Add compute_next_timestep()

library/include/mobilisis/calculate_price.h

@@ -109,6 +109,8 @@ CalcState CALCULATE_LIBRARY_API init_tariff(parking_tariff_t **tariff,
 void CALCULATE_LIBRARY_API free_tariff(parking_tariff_t *tariff);
 int CALCULATE_LIBRARY_API get_zone_nr(int zone = -1);
 
+int CALCULATE_LIBRARY_API compute_next_timestep(parking_tariff_t *tariff, int currentTimeMinutes, int UpDown);
+
 CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(       // deprecated
                                             parking_tariff_t *tariff,
                                             time_t start_parking_time,

library/include/mobilisis/calculator_functions.h

@@ -1,21 +1,13 @@
-#ifndef CALCULATOR_FUNCTIONS_H_INCLUDED
+#pragma once
-#define CALCULATOR_FUNCTIONS_H_INCLUDED
-
 #include <iostream>
-#include <optional>
-
 #include "configuration.h"
 #include "payment_method.h"
-#include "ticket.h"
-#include "tariff_time_range.h"
-
 #include <QDateTime>
 using namespace std;
 
 class Calculator
 {
 public:
-
 	/// <summary>
 	/// Gets duration in seconds from cost
 	/// </summary>
@@ -35,7 +27,7 @@ public:
     /// <param name="end_datetime">Date/time of park end to be conducted in ISO8601 format (e.g. 2022-12-25T08:00:00Z) </param>
 	/// <param name="durationMin">Duration of parking in minutes</param>
 	/// <returns>Returns cost (data type: double)</returns>
-    double GetCostFromDuration(Configuration* cfg, uint8_t vehicle_type, const QDateTime start_datetime, QDateTime & end_datetime, int durationMin, bool nextDay = false, bool prepaid = false);
+    double GetCostFromDuration(Configuration* cfg, uint8_t vehicle_type, const QDateTime start_datetime, QDateTime & end_datetime, double durationMin, bool nextDay = false, bool prepaid = false);
 
     // Daily ticket
     QDateTime GetDailyTicketDuration(Configuration* cfg, const QDateTime start_datetime, uint8_t payment_option, bool carry_over);
@@ -51,33 +43,6 @@ private:
     // For tariff of following structure: only steps, no special days, nonstop.
     uint32_t GetCostFromDuration(Configuration *cfg, QDateTime const &start, quint64 durationMinutes) const;
     uint32_t GetCostFromDuration(Configuration *cfg, QDateTime const &start, QDateTime const &end) const;
-
-    PaymentMethod getPaymentMethodId(Configuration const *cfg);
-    int getMinimalParkingTime(Configuration const *cfg, PaymentMethod methodId);
-    int getMaximalParkingTime(Configuration const *cfg, PaymentMethod methodId);
-
-    Ticket private_GetCostFromDuration(Configuration const* cfg,
-                                       QDateTime const &start,
-                                       QDateTime &end,
-                                       int &durationMinutes,
-                                       bool nextDay = false,
-                                       bool prepaid = false,
-                                       bool overtime = false);
-
-    bool checkDurationMinutes(bool overTime,
-                              int minParkingTime, int maxParkingTime,
-                              int durationMinutes);
-
-    //
     uint32_t GetPriceForTimeStep(Configuration *cfg, int timeStep) const;
     uint32_t GetDurationForPrice(Configuration *cfg, int price) const;
-
-    int findWorkTimeRange(QDateTime const &dt,
-                          QScopedArrayPointer<TariffTimeRange> const &worktime,
-                          size_t size);
-    int findNextWorkTimeRange(QDateTime const &dt,
-                              QScopedArrayPointer<TariffTimeRange> const &worktime,
-                              size_t size);
 };
-
-#endif // CALCULATOR_FUNCTIONS_H_INCLUDED

library/include/mobilisis/payment_method.h

@@ -1,12 +1,10 @@
-#ifndef PAYMENT_METHOD_H_INCLUDED
+#pragma once
-#define PAYMENT_METHOD_H_INCLUDED
 
-enum PaymentMethod {
+enum PaymentMethod
+{
 	Undefined = 0xFF,
 	Progressive = 0x01,
 	Degressive = 0x02,
 	Linear = 0x03,
 	Steps = 0x04
 };
-
-#endif // PAYMENT_METHOD_H_INCLUDED

library/include/mobilisis/tariff_time_range.h

@@ -1,28 +1,17 @@
+// #pragma once
 #ifndef TARIFF_TIME_RANGE_H_INCLUDED
 #define TARIFF_TIME_RANGE_H_INCLUDED
 
-#include <QTime>
+#include <ctime>
 
 /// <summary>
 /// Time range definition
 /// </summary>
 class TariffTimeRange {
-    QTime m_time_from;
-    QTime m_time_until;
-
 public:
-
+	time_t time_from;
-    TariffTimeRange()
+    time_t time_to;
-    : m_time_from(QTime())
+    TariffTimeRange() : time_from(0), time_to(0) {}
-    , m_time_until(QTime()) {}
-
-    void setTimeRange(QTime const& from, QTime const &until) {
-        m_time_from = from;
-        m_time_until = until;
-    }
-
-    QTime const &getTimeFrom() const { return m_time_from; }
-    QTime const &getTimeUntil() const { return m_time_until; }
 };
 
 #endif // TARIFF_TIME_RANGE_H_INCLUDED

library/include/mobilisis/ticket.h

@@ -1,64 +0,0 @@
-#ifndef TICKET_H_INCLUDED
-#define TICKET_H_INCLUDED
-
-#include <tuple>
-#include <vector>
-
-#include <QDebug>
-#include <QDebugStateSaver>
-#include <QStringList>
-#include <QDateTime>
-
-#define NOT_INITIALIZED         (0)
-#define VALID                   (1)
-#define INVALID_FROM_DATETIME   (2)
-#define INVALID_UNTIL_DATETIME  (3)
-#define STATUS_END              (4)
-
-class Ticket {
-    enum {CODE=0, CODE_STR=1, CODE_DESC=3};
-public:
-    using Status = std::tuple<int, char const*, char const*>;
-
-    explicit Ticket();
-    explicit Ticket(QDateTime const &s, QDateTime const &e,
-                    int durationMinutesNetto, int durationMinutesBrutto,
-                    uint32_t price, Status status);
-
-    explicit operator bool() { return std::get<CODE>(m_status) == VALID; }
-    operator QString();
-
-    Status getStatus() const;
-    QDateTime getValidFrom() const;
-    QDateTime getValidUntil() const;
-    uint32_t getPrice() const;
-
-    Status setStatus(Status status);
-    void setValidFrom(QDateTime const &validFrom);
-    void setValidUntil(QDateTime const &validUnil);
-    void setPrice(uint32_t price);
-
-    bool isValid() { return operator bool(); }
-
-    static constexpr const Status s[STATUS_END] = {
-        {NOT_INITIALIZED       , "NOT_INITIALIZED"       , "Ticket not initialized"           },
-        {VALID                 , "VALID"                 , "Ticket is valid"                  },
-        {INVALID_FROM_DATETIME , "INVALID_FROM_DATETIME" , "Ticket has invalid start datetime"},
-        {INVALID_UNTIL_DATETIME, "INVALID_UNTIL_DATETIME", "Ticket has invalid end datetime"  }
-    };
-
-private:
-    Status m_status;
-
-    QDateTime m_validFrom;
-    QDateTime m_validUntil;
-    
-    int m_durationMinutesNetto;
-    int m_durationMinutesBrutto;
-
-    uint32_t m_price;
-};
-    
-QDebug operator<<(QDebug debug, Ticket::Status const &status);
-
-#endif // TICKET_H_INCLUDED

library/include/mobilisis/utilities.h

@@ -8,48 +8,47 @@
 #include "day_of_week.h"
 #include "configuration.h"
 #include "time_range.h"
-#include "payment_method.h"
-
-#include <QDateTime>
 
 using namespace std;
 
-namespace Utilities {
+class Utilities {
+public:
+
 	/// <summary>
 	/// Get day of week from current date (Zeller's Algorithm), starting day is Sunday
 	/// </summary>
 	/// <param name="date"></param>
 	/// <returns></returns>
-	DayOfWeek GetDayOfWeek(struct tm* tm);
+	static DayOfWeek GetDayOfWeek(struct tm* tm);
 
 	/// <summary>
 	/// Date and time parse helper function
 	/// </summary>
 	/// <returns>Returns time (tm) structure</returns>
-	struct tm DateTimeToStructTm(const char* dateTimeStr);
+	static struct tm DateTimeToStructTm(const char* dateTimeStr);
 
 	/// <summary>
 	/// Date parse helper function
 	/// </summary>
 	/// <returns>Returns time (tm) structure</returns>
-	struct tm DateToStructTm(const char* dateStr);
+	static struct tm DateToStructTm(const char* dateStr);
 
 	/// <summary>
 	/// Time parse helper function
 	/// </summary>
 	/// <returns>Returns time (tm) structure</returns>
-	struct tm TimeToStructTm(const char* timeStr, int year, int mon, int mday, int wday);
+	static struct tm TimeToStructTm(const char* timeStr, int year, int mon, int mday, int wday);
 
 	/// <summary>
 	/// Get current local time
 	/// </summary>
 	/// <returns>Returns time_t structure</returns>
-	time_t GetCurrentLocalTime();
+	static time_t GetCurrentLocalTime();
 
 	/// <summary>
 	/// Zeller's algorithm for determining day of week
 	/// </summary>
-	int ZellersAlgorithm(int day, int month, int year);
+	static int ZellersAlgorithm(int day, int month, int year);
 
 	/// <summary>
 	///  Checks if current datetime is in range between start and end month of parking worktime
@@ -57,29 +56,18 @@ namespace Utilities {
 	/// <param name="tariff_cfg"></param>
 	/// <param name="currentDateTime"></param>
 	/// <returns></returns>
-	bool IsYearPeriodActive(Configuration* cfg, struct tm* currentDateTime);
+	static bool IsYearPeriodActive(Configuration* cfg, struct tm* currentDateTime);
-    bool IsYearPeriodActive(Configuration const *cfg, QDateTime const &currentDateTime);
 
 	/// <summary>
 	/// Check permissions
 	/// </summary>
-	bool CheckSpecialDay(Configuration* cfg, const char* currentDateTimeStr, int* specialDayId, double* specialDayPrice);
+	static bool CheckSpecialDay(Configuration* cfg, const char* currentDateTimeStr, int* specialDayId, double* specialDayPrice);
-	bool CheckSpecialDay(Configuration const *cfg,
-						 QDateTime const &currentDateTimeS,
-						 int* specialDayId, uint32_t *specialDayPrice);
 
 	/// <summary>
 	/// Calculates price per unit
 	/// </summary>
 	/// <param name="pra_price"></param>
 	/// <returns></returns>
-	double CalculatePricePerUnit(double pra_price, double durationUnit = -1);
+    static double CalculatePricePerUnit(double pra_price, double durationUnit = -1);
 
-    QTime SpecialDaysWorkTimeFrom(Configuration const *cfg, int specialDayId);
+};
-    QTime SpecialDaysWorkTimeUntil(Configuration const *cfg, int specialDayId);
-    QTime WeekDaysWorkTimeFrom(std::multimap<int, ATBWeekDaysWorktime>::const_iterator itr);
-    QTime WeekDaysWorkTimeUntil(std::multimap<int, ATBWeekDaysWorktime>::const_iterator itr);
-    bool isCarryOverSet(Configuration const *cfg, PaymentMethod paymentMethodId);
-    bool isCarryOverNotSet(Configuration const *cfg, PaymentMethod paymentMethodId);
-    PaymentMethod getPaymentMethodId(Configuration const *cfg);
-}

library/library.pro

@@ -25,8 +25,7 @@ SOURCES += \
     src/utilities.cpp \
     src/configuration.cpp \
     src/tariff_log.cpp \
-    src/calculate_price.cpp \
+    src/calculate_price.cpp
-    src/ticket.cpp
 
 HEADERS += \
 	include/mobilisis/calculator_functions.h \
@@ -67,8 +66,7 @@ HEADERS += \
     include/mobilisis/tariff_payment_rate.h \
     include/mobilisis/tariff_log.h \
     include/mobilisis/calculate_price.h \
-    include/mobilisis/atb_project.h \
+    include/mobilisis/atb_project.h
-    include/mobilisis/ticket.h
 
 OTHER_FILES += src/main.cpp
 

library/src/calculate_price.cpp

@@ -93,6 +93,44 @@ void CALCULATE_LIBRARY_API free_tariff(parking_tariff_t *tariff) {
 }
 
 
+//
+// UpDown 1 -> up; 0 -> down
+int CALCULATE_LIBRARY_API compute_next_timestep(parking_tariff_t *tariff, int currentTimeMinutes, int UpDown)
+{
+    static const QList<int> stepList = calculator.GetTimeSteps(tariff);
+
+    int currentStepIndex = stepList.indexOf(currentTimeMinutes);
+
+    if (currentStepIndex == -1) {
+        qCritical() << "compute_next_timestep() *NO STEP* for currentTimeMinutes (" << currentTimeMinutes << ")";
+        return  currentTimeMinutes;
+    }
+
+    if (UpDown == 1) { // UP
+        if (stepList[currentStepIndex] == stepList.last()) {
+            qCritical() << "compute_next_timestep() *NO NEXT STEP* for currentTimeMinutes (" << currentTimeMinutes << ")";
+            return  currentTimeMinutes;
+        }
+        else {
+            return stepList[currentStepIndex + 1];
+        }
+    }
+    if (UpDown == 0) { // DOWN
+        if (stepList[currentStepIndex] == stepList.first()) {
+            qCritical() << "compute_next_timestep() *NO PREVIOUS STEP* for currentTimeMinutes (" << currentTimeMinutes << ")";
+            return  currentTimeMinutes;
+        }
+        else {
+            return stepList[currentStepIndex - 1];
+        }
+    }
+
+    qCritical() << "compute_next_timestep() *CAN NOT COMPUTE* for currentTimeMinutes (" << currentTimeMinutes << ")";
+    return  currentTimeMinutes;
+}
+
+
+
 // this is currently not used
 CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
         parking_tariff_t *tariff,

library/src/calculator_functions.cpp

@@ -2,14 +2,10 @@
 #include "payment_option.h"
 #include "utilities.h"
 #include "tariff_log.h"
-#include "tariff_time_range.h"
-#include "ticket.h"
 
 #include <sstream>
-#include <algorithm>
 #include <QDateTime>
-#include <QScopedArrayPointer>
+#include <qdebug.h>
-#include <QDebug>
 
 double total_duration_min = 0.0f;
 double total_cost = 0.0f;
@@ -390,314 +386,215 @@ uint32_t Calculator::GetCostFromDuration(Configuration * cfg,
 ///////////////////////////////////////
 
 /// <inheritdoc/>
-double Calculator::GetCostFromDuration(Configuration* cfg,
+double Calculator::GetCostFromDuration(Configuration* cfg, uint8_t payment_option, const QDateTime start_datetime, QDateTime & end_datetime,  double durationMin, bool nextDay, bool prepaid)
-                                       uint8_t payment_option,
+{
-                                       const QDateTime start_datetime,
-                                       QDateTime &end_datetime,
-                                       int durationMinutes,
-                                       bool nextDay,
-                                       bool prepaid) {
     if (cfg->YearPeriod.size() == 0
         && cfg->SpecialDays.size() == 0
         && cfg->SpecialDaysWorktime.size() == 0)
     {
-        end_datetime = start_datetime.addSecs(durationMinutes*60);
+        end_datetime = start_datetime.addSecs(durationMin*60);
         return GetCostFromDuration(cfg, start_datetime, end_datetime);
     }
 
-    QDateTime start = start_datetime;
+    // Get input date
+    QDateTime inputDate = start_datetime;
 
-    Ticket t = private_GetCostFromDuration(cfg, start,
+    // Get day of week
-                                           end_datetime, durationMinutes,
+    int weekdayId = 0;
-                                           nextDay, prepaid);
+    weekdayId = Utilities::ZellersAlgorithm(inputDate.date().day(),inputDate.date().month(),inputDate.date().year());
-    if (t) {
-        qCritical().noquote() << t;
 
-        return t.getPrice();
+    //Get min and max time defined in JSON
+    double minMin = 0;
+    minMin = cfg->PaymentOption.find(payment_option)->second.pop_min_time;
+
+    double maxMin = 0;
+    maxMin = cfg->PaymentOption.find(payment_option)->second.pop_max_time;
+
+    if (minMin < 0) minMin = 0;
+    if (maxMin < 0) maxMin = 0;
+    if (minMin >= maxMin)
+    {
+        LOG_ERROR("Error: min_min cannot be greater or equal to max_min");
+        return 0.0f;
+    }
+    if (maxMin <= minMin)
+    {
+        LOG_ERROR("Error: max_min cannot be lower or equal than min_min");
+        return 0.0f;
     }
 
-    return -1;
+    // Check overtime
-}
+    if (!overtime)
-
+    {
-int Calculator::getMinimalParkingTime(Configuration const *cfg, PaymentMethod methodId) {
+        if (durationMin > maxMin)
-    return std::max((int)cfg->PaymentOption.find(methodId)->second.pop_min_time, 0);
+        {
-}
+            LOG_WARNING("Total duration is greater or equal to max_min");
-
+            return maxMin;
-int Calculator::getMaximalParkingTime(Configuration const *cfg, PaymentMethod methodId) {
-    return std::max((int)cfg->PaymentOption.find(methodId)->second.pop_max_time, 0);
-}
-
-bool Calculator::checkDurationMinutes(bool overtime,
-                                      int minParkingTime,
-                                      int maxParkingTime,
-                                      int durationMinutes) {
-    if (!overtime) {
-        if (durationMinutes > maxParkingTime) {
-            qWarning() << QString("Total duration >= max_min (%1 >= %2)").arg(durationMinutes).arg(maxParkingTime);
-            return false;
         }
-        if (durationMinutes < minParkingTime) {
+
-            qWarning() << QString("Total duration <= minMin (%1 <= %2)").arg(durationMinutes).arg(minParkingTime);
+        if (durationMin < minMin)
-            return false;
+        {
+            LOG_WARNING("Total duration is lower or equal to min_min");
+            return 0.0f;
         }
     }
-    return true;
-}
 
-int Calculator::findWorkTimeRange(QDateTime const &dt,
+    // Get payment method
-                                  QScopedArrayPointer<TariffTimeRange> const &worktime,
+    uint8_t p_method = PaymentMethod::Undefined;
-                                  size_t size) {
+    p_method = payment_option;
-    for (size_t w = 0; w < size; ++w) {
+    LOG_DEBUG("Payment method id: ", (unsigned)p_method);
-        QTime const &worktime_from = worktime[w].getTimeFrom();
-        QTime const &worktime_to = worktime[w].getTimeUntil();
-
-        if ((dt.time() >= worktime_from) && (dt.time() < worktime_to)) {
-            return w;
-        }
-    }
-    return -1;
-}
-
-int Calculator::findNextWorkTimeRange(QDateTime const &dt,
-                                         QScopedArrayPointer<TariffTimeRange> const &worktime,
-                                         size_t size) {
-    int nextWorkTimeRange = -1;
-    for (size_t w = 0; w < size; ++w) {
-        QTime const &worktime_from = worktime[w].getTimeFrom();
-
-        if (dt.time() < worktime_from) {
-            nextWorkTimeRange = w;
-            continue;
-        }
-    }
-    return nextWorkTimeRange;
-}
-
-using namespace Utilities;
-
-Ticket Calculator::private_GetCostFromDuration(Configuration const* cfg,
-                                               QDateTime const &start,
-                                               QDateTime &end,
-                                               int &durationMinutes,
-                                               bool nextDay,
-                                               bool prepaid,
-                                               bool overtime) {
-
-    static const PaymentMethod paymentMethodId = Utilities::getPaymentMethodId(cfg);
-    static const bool carryOverNotSet = isCarryOverNotSet(cfg, paymentMethodId);
-    static int const minParkingTimeMinutes = getMinimalParkingTime(cfg, paymentMethodId);
-    static int const maxParkingTimeMinutes = getMaximalParkingTime(cfg, paymentMethodId);
-
-    static bool const checkMinMaxMinutes = (minParkingTimeMinutes < maxParkingTimeMinutes);
-
-    static const int durationMinutesNetto = durationMinutes;
-
-    if (!checkMinMaxMinutes) {
-        qCritical() << QString(
-            "ERROR: CONDITION minMin < maxMin (%1 < %2) IS NOT VALID")
-                .arg(minParkingTimeMinutes).arg(maxParkingTimeMinutes);
-        return Ticket();
-    }
-
-    if (!checkDurationMinutes(overtime, minParkingTimeMinutes,
-                              maxParkingTimeMinutes, durationMinutes)) {
-        return Ticket();
-    }
-
-    QDateTime inputDate = start;
-
-    int const weekdayId = inputDate.date().dayOfWeek();
-
-    uint32_t price = 0;
-    double durationUnit = 60.0;
 
+    // Check special day
+    double day_price = 0.0f;
     int current_special_day_id = -1;
+    bool is_special_day = Utilities::CheckSpecialDay(cfg, inputDate.toString(Qt::ISODate).toStdString().c_str(), &current_special_day_id, &day_price);
+    LOG_DEBUG("Special day: ", is_special_day);
 
-    // there might be more than 1 worktime ranges per day
+    total_duration_min = durationMin;
-    int const timeRanges = std::max((int)cfg->WeekDaysWorktime.count(weekdayId), 1);
+    LOG_DEBUG("Total min:", total_duration_min);
-    QScopedArrayPointer<TariffTimeRange> worktime(new TariffTimeRange[timeRanges]);
-    int ranges = 0;
 
-    if(Utilities::CheckSpecialDay(cfg, inputDate, &current_special_day_id, &price)) {
+    double price_per_unit = 0.0f;
-        // Set special day price:
+    QTime worktime_from;
-        durationUnit = 60.0;
+    QTime worktime_to;
-        worktime[ranges].setTimeRange(SpecialDaysWorkTimeFrom(cfg, current_special_day_id),
+
-                                      SpecialDaysWorkTimeUntil(cfg, current_special_day_id));
+    if(is_special_day)
-        ranges = 1;
+    {
-    } else {
+        // Set special day price
-        // Set new price for the normal day: do not use a floating-point type
+        price_per_unit = Utilities::CalculatePricePerUnit(day_price);
-        // for the price, rather compute with integers. Only at the very end of
+        worktime_from = QTime::fromString(cfg->SpecialDaysWorktime.find(current_special_day_id)->second.pedwt_time_from.c_str());
-        // the computation the price is divided by durationUnit.
+        worktime_to = QTime::fromString(cfg->SpecialDaysWorktime.find(current_special_day_id)->second.pedwt_time_to.c_str());
-        int pop_id = cfg->PaymentOption.find(paymentMethodId)->second.pop_id;
+    }
-        price = cfg->PaymentRate.find(pop_id)->second.pra_price;
+    else
+    {
+        // Set new price for the normal day
+
+        int pop_id = cfg->PaymentOption.find(payment_option)->second.pop_id;
+        day_price = cfg->PaymentRate.find(pop_id)->second.pra_price;
 
         int durationId = cfg->PaymentRate.find(pop_id)->second.pra_payment_unit_id;
-        durationUnit = cfg->Duration.find(durationId)->second.pun_duration;
+        double durationUnit = cfg->Duration.find(durationId)->second.pun_duration;
+        price_per_unit = Utilities::CalculatePricePerUnit(day_price,durationUnit);
 
         // If no working day found, skip it (recursively call method again)
-        if (cfg->WeekDaysWorktime.count(weekdayId) <= 0) {
+        size_t found = 0;
-            // When no workday found, go to next available day
+        found = cfg->WeekDaysWorktime.count(weekdayId);
-            qDebug() << "No workday found, trying to find next available day";
+
+        // When no workday found, go to next available day
+        if(found <=0)
+        {
+            LOG_DEBUG("- No workday found, trying to find next available day");
             inputDate = inputDate.addDays(1);
-            return private_GetCostFromDuration(cfg, inputDate, end, durationMinutes, true, prepaid, overtime);
+            return floor(GetCostFromDuration(cfg, payment_option, inputDate, end_datetime, durationMin, true, prepaid));
         }
+        worktime_from = QTime::fromString(cfg->WeekDaysWorktime.find(weekdayId)->second.pwd_time_from.c_str());
+        worktime_to = QTime::fromString(cfg->WeekDaysWorktime.find(weekdayId)->second.pwd_time_to.c_str());
+    }
 
-        using WTIterator = std::multimap<int, ATBWeekDaysWorktime>::const_iterator;
+    if (price_per_unit < 0) price_per_unit = 1.0f;
-        std::pair<WTIterator, WTIterator> p = cfg->WeekDaysWorktime.equal_range(weekdayId);
+    LOG_DEBUG("Calculated price per minute: ", price_per_unit);
 
-        for (WTIterator itr = p.first; itr != p.second; ++itr) {
+    if (price_per_unit == 0)
-            worktime[ranges].setTimeRange(WeekDaysWorkTimeFrom(itr),
+    {
-                                          WeekDaysWorkTimeUntil(itr));
+        inputDate = inputDate.addDays(1);
-            ranges += 1;
+        inputDate.setTime(worktime_from);
+        return GetCostFromDuration(cfg, payment_option, inputDate, end_datetime, durationMin, true, prepaid);
+    }
+
+    // If overtime flag is set
+    if (overtime || nextDay)
+    {
+        inputDate.setTime(worktime_from);
+        overtime = false;
+    }
+
+    // Check prepaid
+    if (!prepaid)
+    {
+        if ((inputDate.time() < worktime_from) || (inputDate.time() > worktime_to))
+        {
+            LOG_DEBUG("[STOP] * Ticket is not valid * ");
+            return 0.0f;
+        }
+    }
+    else
+    {
+        LOG_DEBUG("* PREPAID MODE ACTIVE *");
+        if (inputDate.time() < worktime_from)
+        {
+            inputDate.setTime(worktime_from);
+        }
+        else if(inputDate.time() > worktime_to)
+        {
+            LOG_DEBUG(" *** PREPAID *** Current time is past the time range end, searching for next available day");
+            inputDate = inputDate.addDays(1);
+            return GetCostFromDuration(cfg, payment_option, inputDate, end_datetime, durationMin, true, prepaid);
         }
     }
 
-    uint32_t costFromDuration = 0;
+    while(true)
-    QTime const &lastWorktimeTo = worktime[ranges-1].getTimeUntil();
+    {
-    int currentRange = -1;
+        if(total_duration_min <= 0) break;
 
-    if (nextDay) { // this means the function has been called recursively
+        // Check year period
-        currentRange = 0;
+        bool isYearPeriodActive = false;
-        inputDate.setTime(worktime[currentRange].getTimeFrom());
-    } else {
-        // check if inputDate is located inside a valid worktime-range...
-        currentRange = findWorkTimeRange(inputDate, worktime, ranges);
-        if (currentRange == -1) { // no...
-            if (!prepaid) {       // parking is not allowed
-                return Ticket(start, end, durationMinutesNetto, 0,
-                              0, Ticket::s[INVALID_FROM_DATETIME]);
-            }
-            // find the next worktime-range (on the same day), and start from there
-            currentRange = findNextWorkTimeRange(inputDate, worktime, ranges);
-            inputDate.setTime(worktime[currentRange].getTimeFrom());
-        }
-    }
 
-    for (int w = currentRange; w < ranges; ++w) {
+        //// Parse input date
-        if (durationMinutes > 0) {
+        int dayCurrent = inputDate.date().day();
-            QTime const &worktime_from = worktime[w].getTimeFrom();
+        int monthCurrent = inputDate.date().month();
-            QTime const &worktime_to = worktime[w].getTimeUntil();
 
-            qCritical() << "from" << worktime_from;
+        // Current date time
-            qCritical() << "until" << worktime_to;
+        int cdt = (monthCurrent * 100) + dayCurrent;
 
-            //if (w > 0) { // durationMinutes are always meant as netto time and
+        multimap<int, ATBPeriodYear>::iterator year_period_itr;
-            //             // the time between worktime-ranges are free.
+        for (year_period_itr = cfg->YearPeriod.begin(); year_period_itr != cfg->YearPeriod.end(); ++year_period_itr)
-            //    inputDate.setTime(worktime_from);
+        {
-            //}
+            int dStart = year_period_itr->second.pye_start_day;
+            int dEnd = year_period_itr->second.pye_end_day;
 
-            // TODO: hier muss dann der preis hin
+            int mStart = year_period_itr->second.pye_start_month;
-            if (price == 0) {
+            int mEnd = year_period_itr->second.pye_end_month;
-                inputDate = inputDate.addDays(1);
-                inputDate.setTime(worktime_from);
-                Ticket t = private_GetCostFromDuration(
-                                                    cfg, // TODO: erklaerung
-                                                    inputDate,
-                                                    end, durationMinutes,
-                                                    true, prepaid);
-                if (!t.isValid()) {
-                    return t;
-                }
-                costFromDuration += t.getPrice();
-                continue;
-            }
 
-            // If overtime flag is set
+            int start = (mStart * 100) + dStart;
-            // TODO: ueberpruefen, kann man wohl nach oben ziehen
+            int end = (mEnd * 100) + dEnd;
-            //if (overtime || nextDay) {
-            //    inputDate.setTime(worktime_from);
-            //    overtime = false;
-            //}
 
-            qCritical() << "inputDate.time()=" << inputDate.time();
+            if (cdt >= start && cdt <= end) {
-
+                isYearPeriodActive = true;
-            // Check prepaid
+                break;
-            if (!prepaid) {
-                if ((inputDate.time() < worktime_from) || (inputDate.time() > worktime_to)) {
-                    qDebug() << "[STOP] * Ticket is not valid * ";
-                    return Ticket();
-                }
-            } else {
-                qDebug() << "* PREPAID MODE ACTIVE *";
-                if (inputDate.time() < worktime_from) {
-                    inputDate.setTime(worktime_from);
-                //} else if(inputDate.time() > worktime_to) {
-                } else if(inputDate.time() > lastWorktimeTo) {
-                    qDebug() << " *** PREPAID *** Current time is past the time range end, searching for next available day";
-                    // wieso ist hier overtime nicht gesetzt
-                    inputDate = inputDate.addDays(1);
-                    Ticket t = private_GetCostFromDuration(
-                                                cfg, inputDate, end,
-                                                durationMinutes, true, prepaid);
-                    if (!t.isValid()) {
-                        return t;
-                    }
-                    costFromDuration += t.getPrice();
-                    continue;
-                }
-            }
-
-            while(durationMinutes > 0) {
-                // Check for active year period
-                if (!IsYearPeriodActive(cfg, inputDate)) {
-                    return Ticket();
-                }
-
-                qDebug() << "inputDate" << inputDate.toString(Qt::ISODate);
-
-                if(inputDate.time() >= lastWorktimeTo) {
-                    // Go to next day if minutes not spent
-                    if (carryOverNotSet) {
-                        // no carry_over, so stop computation
-                        break;
-                    }
-
-                    qDebug() << "Reached end of worktime, searching for the next working day";
-
-                    inputDate = inputDate.addDays(1);
-                    inputDate.setTime(QTime());
-                    overtime = true;
-                    Ticket t = private_GetCostFromDuration(
-                                                cfg, inputDate, end,
-                                                durationMinutes, true, prepaid, overtime);
-                    if (!t.isValid()) {
-                        return t;
-                    }
-                    costFromDuration += t.getPrice();
-                    break; // stop while, and continue in outer loop
-                } else {
-                    if(inputDate.time() < worktime_to) {
-                        // Increment input date minutes for each monetary unit
-                        inputDate = inputDate.addSecs(60);
-
-                        qDebug() << "inputDate" << inputDate.toString(Qt::ISODate);
-
-                        durationMinutes -= 1;
-                        //costFromDuration += price_per_unit;
-                        costFromDuration += price;
-                    } else break;
-                }
             }
         }
+        if (!isYearPeriodActive)
+        {
+            LOG_DEBUG("Year period is not valid");
+            return 0.0f;
+        }
+
+        int carry_over_status = 0;
+        carry_over_status = cfg->PaymentOption.find(payment_option)->second.pop_carry_over;
+
+        // Go to next day if minutes not spent
+        if(inputDate.time() >= worktime_to)
+        {
+            if (carry_over_status < 1) break;
+
+            LOG_DEBUG("Reached end of worktime, searching for the next working day");
+            inputDate = inputDate.addDays(1);
+            overtime = true;
+            return GetCostFromDuration(cfg, payment_option, inputDate, end_datetime, total_duration_min);
+        }
+
+        // Increment input date minutes for each monetary unit
+        inputDate = inputDate.addSecs(60);
+        total_duration_min -=1;
+        total_cost += price_per_unit;
+
     }
+    qDebug() << "GetCostFromDuration(): Valid until:" << inputDate.toString(Qt::ISODate).toStdString().c_str();
 
+    end_datetime = inputDate;
 
-    if (inputDate >= end) {
+    double ret_val = total_cost;
-        end = inputDate;
+    total_cost = 0.0f;
-    }
+    return ceil(ret_val);
-
-    if (nextDay == false) {
-        qDebug() << "GetCostFromDuration(): Valid until:" << end.toString(Qt::ISODate);
-    }
-
-    return
-        Ticket(start, end,
-               durationMinutesNetto,
-               start.secsTo(end) / 60,
-               nextDay ?
-                   costFromDuration :
-                   llround(Utilities::CalculatePricePerUnit(costFromDuration, durationUnit)),
-               Ticket::s[VALID]);
 }
 
 
@@ -737,22 +634,25 @@ uint32_t Calculator::GetPriceForTimeStep(Configuration *cfg, int timeStep) const
     return 0;
 }
 
+/**
+ * private: read price directly from config file (used with PaymentMethod::Steps)
+ *
+ * return duration in minutes for greatest pra_price < price
+ */
+
 uint32_t Calculator::GetDurationForPrice(Configuration *cfg, int price) const {
     int const pop_id = cfg->getPaymentOptions().pop_id; 
-
     uint32_t duration = 0;
 
     for (auto[itr, rangeEnd] = cfg->PaymentRate.equal_range(pop_id); itr != rangeEnd; ++itr)
     {
         int const durationId = itr->second.pra_payment_unit_id;
         int const pra_price = itr->second.pra_price;
-
         uint32_t const durationUnit = cfg->Duration.find(durationId)->second.pun_duration;
 
-        if (pra_price == price) {
+        if (price == pra_price) {
             return durationUnit;
         }
-
         if (pra_price < price) {
             duration = durationUnit;
         }

library/src/ticket.cpp

@@ -1,88 +0,0 @@
-#include "ticket.h"
-
-Ticket::Ticket() 
-  : m_status(Ticket::s[NOT_INITIALIZED])
-  , m_validFrom()
-  , m_validUntil()
-  , m_durationMinutesNetto(0)
-  , m_durationMinutesBrutto(0)
-  , m_price() {
-
-    qDebug() << *this;
-    qDebug() << m_status;
-}
-
-Ticket::Ticket(QDateTime const &s, QDateTime const &e,
-               int durationMinutesNetto, int durationMinutesBrutto,
-               uint32_t price, Ticket::Status status)
-  : m_status(status)
-  , m_validFrom(s)
-  , m_validUntil(e)
-  , m_durationMinutesNetto(durationMinutesNetto)
-  , m_durationMinutesBrutto(durationMinutesBrutto)
-  , m_price(price) {
-}
-
-
-Ticket::Status Ticket::setStatus(Status status) {
-    Status old = m_status;
-    m_status = status;
-    return old;
-}
-    
-Ticket::Status Ticket::getStatus() const {
-    return m_status;
-}
-    
-void Ticket::setValidFrom(QDateTime const &validFrom) {
-    m_validFrom = validFrom;
-}
-    
-void Ticket::setValidUntil(QDateTime const &validUntil) {
-    m_validUntil = validUntil;
-}
-
-QDateTime Ticket::getValidFrom() const {
-    if (std::get<CODE>(m_status) == VALID) {
-        return m_validFrom;
-    }
-    return QDateTime();
-}
-    
-QDateTime Ticket::getValidUntil() const {
-    if (std::get<CODE>(m_status) == VALID) {
-        return m_validFrom;
-    }
-    return QDateTime();
-}
-
-uint32_t Ticket::getPrice() const {
-    return m_price;
-}
-    
-void Ticket::setPrice(uint32_t price) {
-    m_price = price;
-}
-    
-Ticket::operator QString() {
-    QStringList status;
-    status << QString("**********************");
-    status << QString("Status ............. : %1 (%2)")
-                .arg(std::get<0>(m_status))
-                .arg(std::get<2>(m_status));
-    status << QString("Valid from ......... : %1").arg(m_validFrom.toString(Qt::ISODate));
-    status << QString("Valid until ........ : %1").arg(m_validUntil.toString(Qt::ISODate));
-    status << QString("Duration (netto) ... : %1").arg(m_durationMinutesNetto);
-    status << QString("Duration (brutto)... : %1").arg(m_durationMinutesBrutto);
-    status << QString("Price .............. : %1").arg(m_price);
-    status << QString("**********************");
-
-    return status.join('\n');
-}
-
-QDebug operator<<(QDebug debug, Ticket::Status const &status) {
-    QDebugStateSaver saver(debug);
-    debug << "Ticket-Status: " << std::get<1>(status)
-          << "(" << std::get<2>(status) << ")";
-    return debug;
-}

library/src/utilities.cpp

@@ -1,9 +1,6 @@
 #include "utilities.h"
 #include "tariff_log.h"
 
-#include <QDebug>
-#include <algorithm>
-
 static int protection_counter = 0;
 
 /// <summary>
@@ -196,23 +193,6 @@ bool Utilities::IsYearPeriodActive(Configuration* cfg, struct tm* currentDateTim
 	}
 }
 
-bool Utilities::IsYearPeriodActive(Configuration const *cfg, QDateTime const &dt) {
-    if (std::none_of(cfg->YearPeriod.cbegin(),
-                     cfg->YearPeriod.cend(),
-            [&dt](std::pair<int, ATBPeriodYear> const &year) {
-                QDate const d(2004, // 2004 is a leap year
-                              dt.date().month(),
-                              dt.date().day());
-                QDate const s(2004, year.second.pye_start_month, year.second.pye_start_day);
-                QDate const e(2004, year.second.pye_end_month, year.second.pye_end_day);
-                return (d >= s && d <= e);
-            })) {
-        qCritical() << "NO VALID YEAR PERIOD";
-        return false;
-    }
-    return true;
-}
-
 /// <inheritdoc/>
 bool Utilities::CheckSpecialDay(Configuration* cfg, const char* currentDateTimeStr, int* specialDayId, double* specialDayPrice)
 {
@@ -291,85 +271,3 @@ bool Utilities::CheckSpecialDay(Configuration* cfg, const char* currentDateTimeS
 		return false;
 	}
 }
-
-bool Utilities::CheckSpecialDay(Configuration const *cfg,
-                                QDateTime const &currentDateTime,
-                                int* specialDayId,
-                                uint32_t *specialDayPrice) {
-    *specialDayId = -1;
-    *specialDayPrice = 0;
-
-    std::multimap<int, ATBSpecialDays>::const_iterator spec_days_itr;
-
-    for (spec_days_itr = cfg->SpecialDays.cbegin(); spec_days_itr != cfg->SpecialDays.cend(); ++spec_days_itr) {
-        int repeat_every_year = spec_days_itr->second.ped_year;
-        QDate start = QDate::fromString(spec_days_itr->second.ped_date_start.c_str(), Qt::ISODate);
-        QDate end = QDate::fromString(spec_days_itr->second.ped_date_end.c_str(), Qt::ISODate);
-        if (start.isValid() && end.isValid()) {
-            if ((currentDateTime.date().month() >= start.month()) &&
-                (currentDateTime.date().month() <= end.month())) {
-                if ((currentDateTime.date().day() >= start.day()) &&
-                    (currentDateTime.date().day() <= end.day())) {
-                    if (repeat_every_year <= 0) {
-                        if ((currentDateTime.date().year() != start.year()) ||
-                            (currentDateTime.date().year() != end.year())) {
-                            continue;
-                        }
-                    }
-                    qDebug() << "CheckSpecialDay() => SPECIAL DAY";
-                    *specialDayId = spec_days_itr->second.ped_id;
-                    *specialDayPrice = cfg->SpecialDaysWorktime.find(*specialDayId)->second.pedwt_price;
-                    return true;
-                }
-            }
-        }
-    }
-
-    return false;
-}
-
-QTime Utilities::SpecialDaysWorkTimeFrom(Configuration const *cfg, int specialDayId) {
-    return QTime::fromString(cfg->SpecialDaysWorktime.find(specialDayId)->second.pedwt_time_from.c_str(), Qt::ISODate);
-}
-
-QTime Utilities::SpecialDaysWorkTimeUntil(Configuration const *cfg, int specialDayId) {
-    return QTime::fromString(cfg->SpecialDaysWorktime.find(specialDayId)->second.pedwt_time_to.c_str(), Qt::ISODate);
-}
-
-QTime Utilities::WeekDaysWorkTimeFrom(std::multimap<int, ATBWeekDaysWorktime>::const_iterator itr) {
-    return QTime::fromString(itr->second.pwd_time_from.c_str(), Qt::ISODate);
-}
-
-QTime Utilities::WeekDaysWorkTimeUntil(std::multimap<int, ATBWeekDaysWorktime>::const_iterator itr) {
-    return QTime::fromString(itr->second.pwd_time_to.c_str(), Qt::ISODate);
-}
-
-bool Utilities::isCarryOverSet(Configuration const *cfg, PaymentMethod paymentMethodId) {
-    return !isCarryOverNotSet(cfg, paymentMethodId);
-}
-
-bool Utilities::isCarryOverNotSet(Configuration const *cfg, PaymentMethod paymentMethodId) {
-    return (cfg->PaymentOption.find(paymentMethodId)->second.pop_carry_over < 1);
-}
-
-PaymentMethod Utilities::getPaymentMethodId(Configuration const *cfg) {
-    if (cfg->PaymentOption.size() != 1) {
-        return PaymentMethod::Undefined;
-    }
-
-    std::multimap<int, ATBPaymentOption>::const_iterator it =
-        cfg->PaymentOption.cbegin();
-
-    switch (it->first) {
-    case PaymentMethod::Linear:
-        return PaymentMethod::Linear;
-    case PaymentMethod::Steps:
-        return PaymentMethod::Steps;
-    case PaymentMethod::Degressive:
-        return PaymentMethod::Degressive;
-    case PaymentMethod::Progressive:
-        return PaymentMethod::Progressive;
-    }
-
-    return PaymentMethod::Undefined;
-}

main/main.cpp

@@ -36,7 +36,7 @@ extern "C" char* strptime(const char* s,
 
 int main() {
 
-    std::ifstream input("/tmp/tariff_korneuburg.json");
+    std::ifstream input(QDir::homePath().append("/tariff01.json").toStdString());
     std::stringstream sstr;
     while(input >> sstr.rdbuf());
     std::string json(sstr.str());
@@ -47,15 +47,14 @@ int main() {
     bool isParsed = cfg.ParseJson(&cfg, json.c_str());
     cout << endl;
 
+    char const *startDate = "";
 
     if (isParsed)
     {
-        QDateTime start = QDateTime::fromString("2023-11-27T17:50:00",Qt::ISODate);
+        startDate = "2023-05-10T13:52:18.665Z";
-        //QDateTime start = QDateTime::currentDateTime();
+        std::string duration = calculator.GetDurationFromCost(&cfg, 3, (char *)startDate, 33, false, true);
-        QDateTime end = start.addSecs(120);
+        cout << "---> startDate " << startDate << " _price_ = " << 33
-        uint32_t cost = calculator.GetCostFromDuration(&cfg, 3, start, end, 60);
+             << " Total duration is: " << duration << endl;
-        qCritical() << "cost=" << cost;
-        qCritical() << "end=" << end;
     }
 
     return 0;
@@ -70,7 +69,6 @@ int main() {
     if (init_tariff(&tariff, "/etc/psa_tariff/")) {      
         struct price_t price;
         memset(&price, 0x00, sizeof(price));
-
         QDateTime start = QDateTime::fromString("2023-05-11T07:50:00",Qt::ISODate); //QDateTime::currentDateTime();
         time_t start_parking_time = start.toSecsSinceEpoch() / 60;
         time_t end_parking_time = start_parking_time + 615;

test-files/tariff_korneuburg.json

@@ -1,160 +0,0 @@
-{
-  "Project" :   "Korneuburg",
-  "Version" :   "1.0.0",
-  "Info"    :   "",
-  "Currency": [
-    {
-      "pcu_id": 2,
-      "pcu_sign": "€",
-      "pcu_major": "EUR",
-      "pcu_minor": "",
-      "pcu_active": true
-    }
-  ],
-  "PaymentMethod": [
-    {
-      "pme_id": 1,
-      "pme_label": "progressive"
-    },
-    {
-      "pme_id": 2,
-      "pme_label": "degressive"
-    },
-    {
-      "pme_id": 3,
-      "pme_label": "linear"
-    },
-    {
-      "pme_id": 4,
-      "pme_label": "steps"
-    }
-  ],
-  "PaymentOption": [
-    {
-      "pop_id": 1049,
-      "pop_label": "Zone 1",
-      "pop_payment_method_id": 3,
-      "pop_day_end_time": "00:00:00",
-      "pop_day_night_end_time": "00:00:00",
-      "pop_price_night": 0,
-      "pop_min_time": 30,
-      "pop_max_time": 180,
-      "pop_min_price": 60,
-      "pop_carry_over": 0,
-      "pop_daily_card_price": 0
-    }
-  ],
-  "PaymentRate": [
-    {
-      "pra_payment_option_id": 1049,
-      "pra_payment_unit_id": 1,
-      "pra_price": 10
-    }
-  ],
-  "Duration": [
-    {
-      "pun_id": 1,
-      "pun_label": "5 min",
-      "pun_duration": 5 
-    },
-    {
-      "pun_id": 3,
-      "pun_label": "15 min",
-      "pun_duration": 15
-    },
-    {
-      "pun_id": 4,
-      "pun_label": "1 min",
-      "pun_duration": 1
-    }
-  ],
-  "WeekDaysWorktime": [
-    {
-      "pwd_id": 621,
-      "pwd_period_week_day_id": 36,
-      "pwd_period_day_in_week_id": 1,
-      "pwd_time_from": "08:00:00",
-      "pwd_time_to": "12:00:00"
-    },
-    {
-      "pwd_id": 621,
-      "pwd_period_week_day_id": 36,
-      "pwd_period_day_in_week_id": 1,
-      "pwd_time_from": "14:00:00",
-      "pwd_time_to": "18:00:00"
-    },
-    {
-      "pwd_id": 622,
-      "pwd_period_week_day_id": 36,
-      "pwd_period_day_in_week_id": 2,
-      "pwd_time_from": "08:00:00",
-      "pwd_time_to": "12:00:00"
-    },
-    {
-      "pwd_id": 622,
-      "pwd_period_week_day_id": 36,
-      "pwd_period_day_in_week_id": 2,
-      "pwd_time_from": "14:00:00",
-      "pwd_time_to": "18:00:00"
-    },
-    {
-      "pwd_id": 623,
-      "pwd_period_week_day_id": 36,
-      "pwd_period_day_in_week_id": 3,
-      "pwd_time_from": "08:00:00",
-      "pwd_time_to": "12:00:00"
-    },
-    {
-      "pwd_id": 623,
-      "pwd_period_week_day_id": 36,
-      "pwd_period_day_in_week_id": 3,
-      "pwd_time_from": "14:00:00",
-      "pwd_time_to": "18:00:00"
-    },
-    {
-      "pwd_id": 624,
-      "pwd_period_week_day_id": 36,
-      "pwd_period_day_in_week_id": 4,
-      "pwd_time_from": "08:00:00",
-      "pwd_time_to": "12:00:00"
-    },
-    {
-      "pwd_id": 624,
-      "pwd_period_week_day_id": 36,
-      "pwd_period_day_in_week_id": 4,
-      "pwd_time_from": "14:00:00",
-      "pwd_time_to": "18:00:00"
-    },
-    {
-      "pwd_id": 625,
-      "pwd_period_week_day_id": 36,
-      "pwd_period_day_in_week_id": 5,
-      "pwd_time_from": "08:00:00",
-      "pwd_time_to": "12:00:00"
-    },
-    {
-      "pwd_id": 625,
-      "pwd_period_week_day_id": 36,
-      "pwd_period_day_in_week_id": 5,
-      "pwd_time_from": "14:00:00",
-      "pwd_time_to": "18:00:00"
-    },
-    {
-      "pwd_id": 626,
-      "pwd_period_week_day_id": 36,
-      "pwd_period_day_in_week_id": 6,
-      "pwd_time_from": "08:00:00",
-      "pwd_time_to": "12:00:00"
-    }
-  ],
-  "PeriodYear": [
-    {
-      "pye_id": 8,
-      "pye_label": "Whole year",
-      "pye_start_month": 1,
-      "pye_start_day": 1,
-      "pye_end_month": 12,
-      "pye_end_day": 31
-    }
-  ]
-}