GerhardHoffmann/DCPlugin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Diag: improve E255 handling:

Browse Source 
- allways run through finishDiag() method
 - on finishing diag: only remove elements in previousMachineEventSet if
data is valid
This commit is contained in:
Siegfried Siegert
2025-09-03 13:33:56 +02:00
parent 420ca94f41
commit 26c2120743
2 changed files with 26 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
src/ATBAPP/DeviceControllerDiag.cpp
View File

@@ -113,8 +113,8 @@ void DeviceControllerDiag::private_startDiag()
qCritical() << "DeviceControllerDiag::private_startDiag() interrupted!";
DCMachineEvent E255Event = DCMachineEvent(DeviceController::State::E255);
if (!this->previousMachineEventSet.contains(E255Event)) {
machineEventSet.insert(E255Event);
private_sendDiagEvent(E255Event, DeviceController::Action::SET);
this->private_setDiagEvent(DeviceController::State::E255);
this->private_sendDiagEvent(E255Event, DeviceController::Action::SET);
}
if (this->E255counter > 5) {
this->restartCArun();
@@ -132,9 +132,9 @@ void DeviceControllerDiag::private_startDiag()
* - diag is called again in ModeOOO wokeup()
*/
}
this->diagRequestTimeoutTimer->stop();
this->isRequestRunning = false;
this->flagInterruptDiag = false;
this->private_finishDiag(false);
return;
}
@@ -178,15 +178,16 @@ void DeviceControllerDiag::sys_superviseSystem()
// send
DCMachineEvent E255Event = DCMachineEvent(DeviceController::State::E255);
if (!this->previousMachineEventSet.contains(E255Event)) {
machineEventSet.insert(E255Event);
private_sendDiagEvent(E255Event, DeviceController::Action::SET);
this->private_setDiagEvent(DeviceController::State::E255);
this->private_sendDiagEvent(E255Event, DeviceController::Action::SET);
}
if (this->E255counter > 5) { this->restartCArun(); }
else { this->E255counter++; }
QTimer::singleShot(400, this, &DeviceControllerDiag::diagRequest);
this->diagRequestTimeoutTimer->stop();
this->isRequestRunning = false;
this->flagInterruptDiag = false;
this->private_finishDiag(false);
return;
}
@@ -196,16 +197,14 @@ void DeviceControllerDiag::sys_superviseSystem()
qCritical() << "DeviceControllerDiag::sys_superviseSystem() no valid data!";
hw->dc_autoRequest(true);
DCMachineEvent E255Event = DCMachineEvent(DeviceController::State::M0254);
previousMachineEventSet.insert(E255Event);
private_sendDiagEvent(E255Event, DeviceController::Action::SET);
DCMachineEvent M0254Event = DCMachineEvent(DeviceController::State::M0254);
this->private_setDiagEvent(DeviceController::State::M0254);
this->private_sendDiagEvent(M0254Event, DeviceController::Action::SET);
if (this->E255counter > 5) { this->restartCArun(); }
else { this->E255counter++; }
QTimer::singleShot(400, this, &DeviceControllerDiag::diagRequest);
this->diagRequestTimeoutTimer->stop();
this->isRequestRunning = false;
this->flagInterruptDiag = false;
this->private_finishDiag(false);
return;
}
@@ -477,7 +476,7 @@ void DeviceControllerDiag::sub_componentAssessment()
// finish diag
this->private_finishDiag();
this->private_finishDiag(true);
}
/**
@@ -486,14 +485,20 @@ void DeviceControllerDiag::sub_componentAssessment()
* Single point to finish a diag process:
* -
*/
void DeviceControllerDiag::private_finishDiag()
void DeviceControllerDiag::private_finishDiag(bool dataValid)
{
this->diagRequestTimeoutTimer->stop();
this->isRequestRunning = false;
this->flagInterruptDiag = false;
this->previousMachineEventSet.unite(machineEventSet); // add new elements from machineEventSet
this->previousMachineEventSet.intersect(machineEventSet); // remove elements not in machineEventSet
// add new elements from machineEventSet
this->previousMachineEventSet.unite(machineEventSet);
if (dataValid) {
// remove elements not in machineEventSet
// ... only if data is valid
this->previousMachineEventSet.intersect(machineEventSet);
}
if (this->isDiagBackgroundTask) {
this->isDiagBackgroundTask = false;

2
src/ATBAPP/DeviceControllerDiag.h
View File

@@ -170,7 +170,7 @@ private slots:
void private_setDiagEvent(DeviceController::State result);
void private_sendDiagEvent(DCMachineEvent result, DeviceController::Action action);
void private_finishDiag();
void private_finishDiag(bool dataValid = false);
void sys_superviseSystem();