SiegfriedSiegert/PTU5KAS
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

repos: Make set_remote_url_cmd fail loudly

Browse Source 
No reason to run this with "fail=False" because we won't ignore errors
anyway. The current setting rather leads to the stderr output being
swallowed.

Reported-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
This commit is contained in:
Jan Kiszka 2020-10-13 14:02:34 +02:00
parent b8a6577ece
commit e5701a03a6
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
kas/repos.py
View File

@ -183,16 +183,13 @@ class RepoImpl(Repo):
return retc return retc
# Make sure the remote origin is set to the value # Make sure the remote origin is set to the value
# in the kas file to avoid suprises # in the kas file to avoid surprises
try: try:
(retc, output) = await run_cmd_async( (retc, output) = await run_cmd_async(
self.set_remote_url_cmd(), self.set_remote_url_cmd(),
cwd=self.path, cwd=self.path,
fail=False,
liveupdate=False) liveupdate=False)
if retc != 0: if retc != 0:
logging.info('Changing remote URL to %s failed with error: %s',
self.effective_url, output.strip())
return retc return retc
except NotImplementedError: except NotImplementedError:
logging.warning('Repo implementation does not support changing ' logging.warning('Repo implementation does not support changing '