repos: Make set_remote_url_cmd fail loudly
No reason to run this with "fail=False" because we won't ignore errors anyway. The current setting rather leads to the stderr output being swallowed. Reported-by: Ross Burton <ross.burton@arm.com> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
This commit is contained in:
parent
b8a6577ece
commit
e5701a03a6
@ -183,16 +183,13 @@ class RepoImpl(Repo):
|
||||
return retc
|
||||
|
||||
# Make sure the remote origin is set to the value
|
||||
# in the kas file to avoid suprises
|
||||
# in the kas file to avoid surprises
|
||||
try:
|
||||
(retc, output) = await run_cmd_async(
|
||||
self.set_remote_url_cmd(),
|
||||
cwd=self.path,
|
||||
fail=False,
|
||||
liveupdate=False)
|
||||
if retc != 0:
|
||||
logging.info('Changing remote URL to %s failed with error: %s',
|
||||
self.effective_url, output.strip())
|
||||
return retc
|
||||
except NotImplementedError:
|
||||
logging.warning('Repo implementation does not support changing '
|
||||
|
Loading…
Reference in New Issue
Block a user