From c01a11833f39c430bc20e6a87e4e89461d788bdb Mon Sep 17 00:00:00 2001 From: Jan Kiszka Date: Tue, 30 May 2023 17:29:44 +0200 Subject: [PATCH] repos: Warn if a repo uses legacy refspec We are deprecating its usage but not yet removing it. Warn once per parsed repo and kas run. Signed-off-by: Jan Kiszka --- kas/repos.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/kas/repos.py b/kas/repos.py index 055ee90..ca6bcb1 100644 --- a/kas/repos.py +++ b/kas/repos.py @@ -133,6 +133,8 @@ class Repo: self.commit or self.branch or self.refspec, self.path, self._layers) + __legacy_refspec_warned__ = [] + @staticmethod def factory(name, repo_config, repo_defaults, repo_fallback_path, repo_overrides={}): @@ -177,6 +179,11 @@ class Repo: if refspec is None: commit = repo_overrides.get('refspec', commit) else: + if name not in Repo.__legacy_refspec_warned__: + logging.warning('Using deprecated refspec for repository ' + '"%s". You should migrate to commit/branch.', + name) + Repo.__legacy_refspec_warned__.append(name) if commit is not None or branch is not None: raise RepoRefError('Unsupported mixture of legacy refspec ' 'and commit/branch for repository "{}"'