From b9032ec025b5d2b8b581340e5def23077c16980a Mon Sep 17 00:00:00 2001 From: Claudius Heine Date: Fri, 9 Mar 2018 08:22:51 +0100 Subject: [PATCH] kas/config: Make 'get_repo_dict' private Since 'get_repo_dict' does much more than just querying available repositories, this patch makes it private. The same data is now available via the 'repo_dict' property. This also means that 'get_repos' is now faster, because it accesses cached data, instead of calling 'get_repo_dict' that generates this data. Signed-off-by: Claudius Heine --- kas/config.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/kas/config.py b/kas/config.py index f9917e6..8258dc2 100644 --- a/kas/config.py +++ b/kas/config.py @@ -74,6 +74,7 @@ class Config: self.handler.get_config(repos=repo_paths) self.environ.update(self.get_proxy_config()) + self.repo_dict = self._get_repo_dict() while missing_repo_names: if missing_repo_names == missing_repo_names_old: @@ -83,17 +84,17 @@ class Config: logging.debug('Missing repos for complete config:\n%s', pprint.pformat(missing_repo_names)) - repo_dict = self.get_repo_dict() - missing_repos = [repo_dict[repo_name] + self.repo_dict = self._get_repo_dict() + missing_repos = [self.repo_dict[repo_name] for repo_name in missing_repo_names - if repo_name in repo_dict] + if repo_name in self.repo_dict] repos_fetch(self, missing_repos) for repo in missing_repos: repo.checkout(self) - repo_paths = {r: repo_dict[r].path for r in repo_dict} + repo_paths = {r: self.repo_dict[r].path for r in self.repo_dict} missing_repo_names_old = missing_repo_names (self._config, missing_repo_names) = \ @@ -166,9 +167,9 @@ class Config: """ # pylint: disable=no-self-use - return list(self.get_repo_dict().values()) + return list(self.repo_dict.values()) - def get_repo_dict(self): + def _get_repo_dict(self): """ Returns a dictionary containing the repositories with their name (as it is defined in the config file) as key