SiegfriedSiegert/PTU5KAS
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libcmds: stop creating empty .wgetrc and .netrc

Browse Source 
Having empty files does not add any value. We do have a new HOME so
files from the old HOME are not used anyways. And writing an empty
.wgetrc will not disable the use of /etc/wgetrc. .netrc is supported by
many tools in slightly different ways, but also here if there was a
global config the one from HOME would likely be appended and would not
prevent use of the global one.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
This commit is contained in:
Henning Schild 2022-06-09 16:10:03 +02:00 committed by Jan Kiszka
parent 720aebc79b
commit a8b69f5bd4
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
kas/libcmds.py
View File

@ -167,17 +167,12 @@ class SetupHome(Command):
return 'setup_home' return 'setup_home'
def execute(self, ctx): def execute(self, ctx):
with open(self.tmpdirname + '/.wgetrc', 'w') as fds: if os.environ.get('CI_SERVER_HOST', False) \
fds.write('\n') and os.environ.get('CI_JOB_TOKEN', False):
with open(self.tmpdirname + '/.netrc', 'w') as fds: with open(self.tmpdirname + '/.netrc', 'w') as fds:
# Configure the gitlab CI authentification token
if os.environ.get('CI_SERVER_HOST', False) \
and os.environ.get('CI_JOB_TOKEN', False):
fds.write('machine ' + os.environ['CI_SERVER_HOST'] + '\n' fds.write('machine ' + os.environ['CI_SERVER_HOST'] + '\n'
'login gitlab-ci-token\n' 'login gitlab-ci-token\n'
'password ' + os.environ['CI_JOB_TOKEN'] + '\n') 'password ' + os.environ['CI_JOB_TOKEN'] + '\n')
else:
fds.write('\n')
with open(self.tmpdirname + '/.gitconfig', 'w') as fds: with open(self.tmpdirname + '/.gitconfig', 'w') as fds:
fds.write('[User]\n' fds.write('[User]\n'
'\temail = kas@example.com\n' '\temail = kas@example.com\n'