From 6fcdf85d9af2e089ae3069ea6974a2324490f519 Mon Sep 17 00:00:00 2001 From: Jan Kiszka Date: Fri, 29 Jan 2021 20:51:25 +0100 Subject: [PATCH] release.sh: Address shellcheck remarks No real issues, but let's silence them to catch future ones. One change is a nice simplification in fact. Signed-off-by: Jan Kiszka --- scripts/release.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/release.sh b/scripts/release.sh index 9f1c89b..63b5cc9 100755 --- a/scripts/release.sh +++ b/scripts/release.sh @@ -22,7 +22,7 @@ cat CHANGELOG.md >> newchangelog $EDITOR newchangelog echo -n "All fine, ready to release? [y/N]" -read a +read -r a a=$(echo "$a" | tr '[:upper:]' '[:lower:]') if [ "$a" != "y" ]; then echo "no not happy, let's stop doing the release" @@ -44,7 +44,7 @@ git push --follow-tags python setup.py sdist upload -r pypi authors=$(git shortlog -s "$OLD_VERSION".."$NEW_VERSION" | cut -c8- | paste -s -d, - | sed -e 's/,/, /g') -highlights=$(cat CHANGELOG.md | sed -e "/$OLD_VERSION/,\$d") +highlights=$(sed -e "/$OLD_VERSION/,\$d" CHANGELOG.md) prolog=$PWD/release-email.txt echo \ @@ -62,8 +62,8 @@ https://github.com/siemens/kas/releases/tag/$NEW_VERSION https://github.com/orgs/siemens/packages/container/package/kas%2Fkas https://github.com/orgs/siemens/packages/container/package/kas%2Fkas-isar -"> $prolog +"> "$prolog" -git shortlog $OLD_VERSION..$NEW_VERSION >> $prolog +git shortlog "$OLD_VERSION..$NEW_VERSION" >> "$prolog" thunderbird -compose "subject=[ANNOUNCE] Release $NEW_VERSION,to=kas-devel@googlegroups.com,message=$prolog"