Fixed issues that occured with pylint 1.7.2

When updating the previously used version of pylint 1.6.5 to 1.7.2
some new issues where found.

This patch fixes these issues:

************* Module kas.config
E:402, 0: Bad option value 'redefined-variable-type' (bad-option-value)
************* Module kas.includehandler
E: 33, 0: No name 'version' in module 'distutils' (no-name-in-module)
E: 33, 0: Unable to import 'distutils.version' (import-error)
R:239,12: Unnecessary "else" after "return" (no-else-return)
************* Module kas.libkas
C:214, 7: Do not use `len(SEQUENCE)` as condition value
(len-as-condition)
************* Module kas.repos
R: 54,12: Unnecessary "else" after "return" (no-else-return)

Signed-off-by: Claudius Heine <ch@denx.de>

.pylintrc

@@ -65,7 +65,7 @@ confidence=
 # --enable=similarities". If you want to run only the classes checker, but have
 # no Warning level messages displayed, use"--disable=all --enable=classes
 # --disable=W"
-disable=too-few-public-methods,locally-disabled
+disable=too-few-public-methods,locally-disabled,redefined-variable-type
 
 
 [REPORTS]

kas/config.py

@@ -406,7 +406,6 @@ def load_config(filename, target):
     """
         Return configuration generated from `filename`.
     """
-    # pylint: disable=redefined-variable-type
 
     (_, ext) = os.path.splitext(filename)
     if ext == '.py':

kas/includehandler.py

@@ -30,7 +30,12 @@ import sys
 import collections
 import functools
 import logging
-from distutils.version import StrictVersion
+try:
+    # pylint: disable=no-name-in-module
+    from distutils.version import StrictVersion
+except ImportError as exc:
+    logging.error("Could not import StrictVersion")
+    raise exc
 
 from . import __version__, __compatible_version__
 
@@ -250,15 +255,14 @@ class GlobalIncludes(IncludeHandler):
                     else:
                         dest[key] = upd[key]
                 return dest
-            else:
+            try:
-                try:
+                for k in upd:
-                    for k in upd:
+                    dest[k] = upd[k]
-                        dest[k] = upd[k]
+            except AttributeError:
-                except AttributeError:
+                # this mapping is not a dict
-                    # this mapping is not a dict
+                for k in upd:
-                    for k in upd:
+                    dest[k] = upd[k]
-                        dest[k] = upd[k]
+            return dest
-                return dest
 
         configs, missing_repos = _internal_include_handler(self.top_file)
         config = functools.reduce(_internal_dict_merge,

kas/libkas.py

@@ -220,7 +220,7 @@ def repo_checkout(config, repo):
     (_, output) = run_cmd(['/usr/bin/git', 'diff', '--shortstat'],
                           env=config.environ, cwd=repo.path,
                           fail=False)
-    if len(output):
+    if output:
         logging.warning('Repo %s is dirty. no checkout', repo.name)
         return
 

kas/repos.py

@@ -53,8 +53,7 @@ class Repo:
         if item == 'layers':
             if not self._layers:
                 return [self.path]
-            else:
+            return [self.path + '/' + l for l in self._layers]
-                return [self.path + '/' + l for l in self._layers]
         elif item == 'qualified_name':
             url = urlparse(self.url)
             return ('{url.netloc}{url.path}'