scripts: Remove pylint

pylint has been a great tool to get the initial code base into shape
but since then we mostely false postives. All those warnings needed to
be annonated.

This allong wouldn't be reason enough to remove it. The main problem
is that the pylint version on gitlab is updated in the back and
suddenly we get new warnings which are bogus.

Signed-off-by: Daniel Wagner <daniel.wagner@siemens.com>

.pylintrc

@@ -1,408 +0,0 @@
-[MASTER]
-
-# Specify a configuration file.
-#rcfile=
-
-# Python code to execute, usually for sys.path manipulation such as
-# pygtk.require().
-#init-hook=
-
-# Add files or directories to the blacklist. They should be base names, not
-# paths.
-ignore=CVS
-
-# Add files or directories matching the regex patterns to the blacklist. The
-# regex matches against base names, not paths.
-ignore-patterns=
-
-# Pickle collected data for later comparisons.
-persistent=yes
-
-# List of plugins (as comma separated values of python modules names) to load,
-# usually to register additional checkers.
-load-plugins=
-
-# Use multiple processes to speed up Pylint.
-jobs=1
-
-# Allow loading of arbitrary C extensions. Extensions are imported into the
-# active Python interpreter and may run arbitrary code.
-unsafe-load-any-extension=no
-
-# A comma-separated list of package or module names from where C extensions may
-# be loaded. Extensions are loading into the active Python interpreter and may
-# run arbitrary code
-extension-pkg-whitelist=
-
-# Allow optimization of some AST trees. This will activate a peephole AST
-# optimizer, which will apply various small optimizations. For instance, it can
-# be used to obtain the result of joining multiple strings with the addition
-# operator. Joining a lot of strings can lead to a maximum recursion error in
-# Pylint and this flag can prevent that. It has one side effect, the resulting
-# AST will be different than the one from reality. This option is deprecated
-# and it will be removed in Pylint 2.0.
-optimize-ast=no
-
-
-[MESSAGES CONTROL]
-
-# Only show warnings with the listed confidence levels. Leave empty to show
-# all. Valid levels: HIGH, INFERENCE, INFERENCE_FAILURE, UNDEFINED
-confidence=
-
-# Enable the message, report, category or checker with the given id(s). You can
-# either give multiple identifier separated by comma (,) or put this option
-# multiple time (only on the command line, not in the configuration file where
-# it should appear only once). See also the "--disable" option for examples.
-#enable=
-
-# Disable the message, report, category or checker with the given id(s). You
-# can either give multiple identifiers separated by comma (,) or put this
-# option multiple times (only on the command line, not in the configuration
-# file where it should appear only once).You can also use "--disable=all" to
-# disable everything first and then reenable specific checks. For example, if
-# you want to run only the similarities checker, you can use "--disable=all
-# --enable=similarities". If you want to run only the classes checker, but have
-# no Warning level messages displayed, use"--disable=all --enable=classes
-# --disable=W"
-disable=too-few-public-methods,locally-disabled,redefined-variable-type,too-many-statements,duplicate-code
-
-
-
-[REPORTS]
-
-# Set the output format. Available formats are text, parseable, colorized, msvs
-# (visual studio) and html. You can also give a reporter class, eg
-# mypackage.mymodule.MyReporterClass.
-output-format=text
-
-# Put messages in a separate file for each module / package specified on the
-# command line instead of printing them on stdout. Reports (if any) will be
-# written in a file name "pylint_global.[txt|html]". This option is deprecated
-# and it will be removed in Pylint 2.0.
-files-output=no
-
-# Tells whether to display a full report or only the messages
-reports=yes
-
-# Python expression which should return a note less than 10 (10 is the highest
-# note). You have access to the variables errors warning, statement which
-# respectively contain the number of errors / warnings messages and the total
-# number of statements analyzed. This is used by the global evaluation report
-# (RP0004).
-evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10)
-
-# Template used to display messages. This is a python new-style format string
-# used to format the message information. See doc for all details
-#msg-template=
-
-
-[SIMILARITIES]
-
-# Minimum lines number of a similarity.
-min-similarity-lines=4
-
-# Ignore comments when computing similarities.
-ignore-comments=yes
-
-# Ignore docstrings when computing similarities.
-ignore-docstrings=yes
-
-# Ignore imports when computing similarities.
-ignore-imports=no
-
-
-[MISCELLANEOUS]
-
-# List of note tags to take in consideration, separated by a comma.
-notes=FIXME,XXX,TODO
-
-
-[VARIABLES]
-
-# Tells whether we should check for unused import in __init__ files.
-init-import=no
-
-# A regular expression matching the name of dummy variables (i.e. expectedly
-# not used).
-dummy-variables-rgx=(_+[a-zA-Z0-9]*?$)|dummy
-
-# List of additional names supposed to be defined in builtins. Remember that
-# you should avoid to define new builtins when possible.
-additional-builtins=
-
-# List of strings which can identify a callback function by name. A callback
-# name must start or end with one of those strings.
-callbacks=cb_,_cb
-
-# List of qualified module names which can have objects that can redefine
-# builtins.
-redefining-builtins-modules=six.moves,future.builtins
-
-
-[SPELLING]
-
-# Spelling dictionary name. Available dictionaries: none. To make it working
-# install python-enchant package.
-spelling-dict=
-
-# List of comma separated words that should not be checked.
-spelling-ignore-words=
-
-# A path to a file that contains private dictionary; one word per line.
-spelling-private-dict-file=
-
-# Tells whether to store unknown words to indicated private dictionary in
-# --spelling-private-dict-file option instead of raising a message.
-spelling-store-unknown-words=no
-
-
-[FORMAT]
-
-# Maximum number of characters on a single line.
-max-line-length=100
-
-# Regexp for a line that is allowed to be longer than the limit.
-ignore-long-lines=^\s*(# )?<?https?://\S+>?$
-
-# Allow the body of an if to be on the same line as the test if there is no
-# else.
-single-line-if-stmt=no
-
-# List of optional constructs for which whitespace checking is disabled. `dict-
-# separator` is used to allow tabulation in dicts, etc.: {1  : 1,\n222: 2}.
-# `trailing-comma` allows a space between comma and closing bracket: (a, ).
-# `empty-line` allows space-only lines.
-no-space-check=trailing-comma,dict-separator
-
-# Maximum number of lines in a module
-max-module-lines=1000
-
-# String used as indentation unit. This is usually "    " (4 spaces) or "\t" (1
-# tab).
-indent-string='    '
-
-# Number of spaces of indent required inside a hanging  or continued line.
-indent-after-paren=4
-
-# Expected format of line ending, e.g. empty (any line ending), LF or CRLF.
-expected-line-ending-format=
-
-
-[LOGGING]
-
-# Logging modules to check that the string format arguments are in logging
-# function parameter format
-logging-modules=logging
-
-
-[BASIC]
-
-# Good variable names which should always be accepted, separated by a comma
-good-names=i,j,k,ex,Run,_
-
-# Bad variable names which should always be refused, separated by a comma
-bad-names=foo,bar,baz,toto,tutu,tata
-
-# Colon-delimited sets of names that determine each other's naming style when
-# the name regexes allow several styles.
-name-group=
-
-# Include a hint for the correct naming format with invalid-name
-include-naming-hint=yes
-
-# List of decorators that produce properties, such as abc.abstractproperty. Add
-# to this list to register other decorators that produce valid properties.
-property-classes=abc.abstractproperty
-
-# Regular expression matching correct argument names
-argument-rgx=[a-z_][a-z0-9_]{2,30}$
-
-# Naming hint for argument names
-argument-name-hint=[a-z_][a-z0-9_]{2,30}$
-
-# Regular expression matching correct attribute names
-attr-rgx=[a-z_][a-z0-9_]{2,30}$
-
-# Naming hint for attribute names
-attr-name-hint=[a-z_][a-z0-9_]{2,30}$
-
-# Regular expression matching correct class attribute names
-class-attribute-rgx=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$
-
-# Naming hint for class attribute names
-class-attribute-name-hint=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$
-
-# Regular expression matching correct method names
-method-rgx=[a-z_][a-z0-9_]{2,30}$
-
-# Naming hint for method names
-method-name-hint=[a-z_][a-z0-9_]{2,30}$
-
-# Regular expression matching correct constant names
-const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$
-
-# Naming hint for constant names
-const-name-hint=(([A-Z_][A-Z0-9_]*)|(__.*__))$
-
-# Regular expression matching correct module names
-module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
-
-# Naming hint for module names
-module-name-hint=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
-
-# Regular expression matching correct variable names
-variable-rgx=[a-z_][a-z0-9_]{2,30}$
-
-# Naming hint for variable names
-variable-name-hint=[a-z_][a-z0-9_]{2,30}$
-
-# Regular expression matching correct function names
-function-rgx=[a-z_][a-z0-9_]{2,30}$
-
-# Naming hint for function names
-function-name-hint=[a-z_][a-z0-9_]{2,30}$
-
-# Regular expression matching correct inline iteration names
-inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$
-
-# Naming hint for inline iteration names
-inlinevar-name-hint=[A-Za-z_][A-Za-z0-9_]*$
-
-# Regular expression matching correct class names
-class-rgx=[A-Z_][a-zA-Z0-9]+$
-
-# Naming hint for class names
-class-name-hint=[A-Z_][a-zA-Z0-9]+$
-
-# Regular expression which should only match function or class names that do
-# not require a docstring.
-no-docstring-rgx=^_
-
-# Minimum line length for functions/classes that require docstrings, shorter
-# ones are exempt.
-docstring-min-length=-1
-
-
-[ELIF]
-
-# Maximum number of nested blocks for function / method body
-max-nested-blocks=5
-
-
-[TYPECHECK]
-
-# Tells whether missing members accessed in mixin class should be ignored. A
-# mixin class is detected if its name ends with "mixin" (case insensitive).
-ignore-mixin-members=yes
-
-# List of module names for which member attributes should not be checked
-# (useful for modules/projects where namespaces are manipulated during runtime
-# and thus existing member attributes cannot be deduced by static analysis. It
-# supports qualified module names, as well as Unix pattern matching.
-ignored-modules=
-
-# List of class names for which member attributes should not be checked (useful
-# for classes with dynamically set attributes). This supports the use of
-# qualified names.
-ignored-classes=optparse.Values,thread._local,_thread._local
-
-# List of members which are set dynamically and missed by pylint inference
-# system, and so shouldn't trigger E1101 when accessed. Python regular
-# expressions are accepted.
-generated-members=
-
-# List of decorators that produce context managers, such as
-# contextlib.contextmanager. Add to this list to register other decorators that
-# produce valid context managers.
-contextmanager-decorators=contextlib.contextmanager
-
-
-[DESIGN]
-
-# Maximum number of arguments for function / method
-max-args=5
-
-# Argument names that match this expression will be ignored. Default to name
-# with leading underscore
-ignored-argument-names=_.*
-
-# Maximum number of locals for function / method body
-max-locals=15
-
-# Maximum number of return / yield for function / method body
-max-returns=6
-
-# Maximum number of branch for function / method body
-max-branches=12
-
-# Maximum number of statements in function / method body
-max-statements=50
-
-# Maximum number of parents for a class (see R0901).
-max-parents=7
-
-# Maximum number of attributes for a class (see R0902).
-max-attributes=7
-
-# Minimum number of public methods for a class (see R0903).
-min-public-methods=2
-
-# Maximum number of public methods for a class (see R0904).
-max-public-methods=20
-
-# Maximum number of boolean expressions in a if statement
-max-bool-expr=5
-
-
-[IMPORTS]
-
-# Deprecated modules which should not be used, separated by a comma
-deprecated-modules=optparse
-
-# Create a graph of every (i.e. internal and external) dependencies in the
-# given file (report RP0402 must not be disabled)
-import-graph=
-
-# Create a graph of external dependencies in the given file (report RP0402 must
-# not be disabled)
-ext-import-graph=
-
-# Create a graph of internal dependencies in the given file (report RP0402 must
-# not be disabled)
-int-import-graph=
-
-# Force import order to recognize a module as part of the standard
-# compatibility libraries.
-known-standard-library=
-
-# Force import order to recognize a module as part of a third party library.
-known-third-party=enchant
-
-# Analyse import fallback blocks. This can be used to support both Python 2 and
-# 3 compatible code, which means that the block might have code that exists
-# only in one or another interpreter, leading to false positives when analysed.
-analyse-fallback-blocks=no
-
-
-[CLASSES]
-
-# List of method names used to declare (i.e. assign) instance attributes.
-defining-attr-methods=__init__,__new__,setUp
-
-# List of valid names for the first argument in a class method.
-valid-classmethod-first-arg=cls
-
-# List of valid names for the first argument in a metaclass class method.
-valid-metaclass-classmethod-first-arg=mcs
-
-# List of member names, which should be excluded from the protected access
-# warning.
-exclude-protected=_asdict,_fields,_replace,_source,_make
-
-
-[EXCEPTIONS]
-
-# Exceptions that will emit a warning when being caught. Defaults to
-# "Exception"
-overgeneral-exceptions=Exception

.travis.yml

@@ -14,7 +14,7 @@ install:
   # install kas to have all kas dependencies:
   - pip install .
   # checkcode dependencies:
-  - pip install pylint pycodestyle doc8 Pygments
+  - pip install pycodestyle doc8 Pygments
   # test dependencies:
   - pip install pytest
 

docs/conf.py

@@ -1,7 +1,5 @@
 #!/usr/bin/env python3
 # -*- coding: utf-8 -*-
-# pylint: disable=bad-continuation,missing-docstring,redefined-builtin
-# pylint: disable=invalid-name,wrong-import-position
 #
 # kas documentation build configuration file, created by
 # sphinx-quickstart on Thu Jun 22 11:10:06 2017.

kas/build.py

@@ -72,7 +72,6 @@ class Build:
         """
             Executes the build command of the kas plugin.
         """
-        # pylint: disable=no-self-use
 
         if args.cmd != 'build':
             return False

kas/config.py

@@ -70,7 +70,6 @@ class Config:
         """
             Returns the list of repos.
         """
-        # pylint: disable=no-self-use
 
         # Always keep repo_dict and repos synchronous
         # when calling get_repos

kas/context.py

@@ -44,7 +44,6 @@ except ImportError:
             platform.dist is deprecated and will be removed in python 3.7
             Use the 'distro' package instead.
         """
-        # pylint: disable=deprecated-method
         return platform.dist()[0]
 
 
@@ -55,7 +54,6 @@ def create_global_context():
     """
         Creates global context as singleton.
     """
-    # pylint: disable=global-statement
     global __context__
     __context__ = Context()
     return __context__
@@ -68,7 +66,6 @@ def get_context():
     return __context__
 
 
-# pylint: disable=too-many-instance-attributes
 class Context:
     """
         Implements the kas build context.

kas/includehandler.py

@@ -164,7 +164,6 @@ class IncludeHandler:
             the current file overwrites every include. (evaluation depth first
             and from top to bottom)
             """
-            # pylint: disable=too-many-arguments
 
             missing_repos = []
             configs = []

kas/kas.py

@@ -47,7 +47,6 @@ from . import __version__, __file_version__, __compatible_file_version__
 # Import kas plugins
 # Since they are added by decorators, they don't need to be called,
 # just imported.
-# pylint: disable=unused-import
 from .libkas import kasplugin
 from . import build
 from . import shell
@@ -155,7 +154,6 @@ def main():
     """
         The main function that operates as a wrapper around kas.
     """
-    # pylint: disable=broad-except
 
     try:
         sys.exit(kas(sys.argv[1:]))

kas/libcmds.py

@@ -281,7 +281,6 @@ class SetupReposStep(Command):
 
     def execute(self, ctx):
         """ TODO refactor protected-access """
-        # pylint: disable=protected-access
         if not ctx.missing_repo_names:
             return False
 
@@ -325,7 +324,6 @@ class FinishSetupRepos(Command):
 
     def execute(self, ctx):
         """ TODO refactor protected-access """
-        # pylint: disable=protected-access
         # now fetch everything with complete config and check out layers
         # except if keep_config is set
         if not ctx.keep_config:

kas/libkas.py

@@ -87,11 +87,6 @@ def run_cmd_async(cmd, cwd, env=None, fail=True, liveupdate=True):
     """
         Run a command asynchronously.
     """
-    # pylint: disable=too-many-arguments
-
-    # Disable incorrect warning on asyncio.wait_for,
-    # https://github.com/PyCQA/pylint/issues/996.
-    # pylint: disable=not-an-iterable
 
     env = env or get_context().environ
     cmdstr = ' '.join(cmd)
@@ -136,7 +131,6 @@ def run_cmd(cmd, cwd, env=None, fail=True, liveupdate=True):
     """
         Runs a command synchronously.
     """
-    # pylint: disable=too-many-arguments
 
     loop = asyncio.get_event_loop()
     (ret, output) = loop.run_until_complete(
@@ -164,7 +158,6 @@ def _create_task(routine):
         # for Python < 3.5, avoiding the keyword 'async' introduced in 3.7
         creation_func = getattr(asyncio, 'async')
 
-    # pylint: disable=deprecated-method
     return creation_func(routine)
 
 
@@ -204,7 +197,6 @@ def get_build_environ():
     """
         Creates the build environment variables.
     """
-    # pylint: disable=too-many-locals
     # nasty side effect function: running oe/isar-init-build-env also
     # creates the conf directory
 

kas/repos.py

@@ -41,7 +41,6 @@ class Repo:
 
     def __init__(self, url, path, refspec, layers, patches,
                  disable_operations):
-        # pylint: disable=too-many-arguments
         self.url = url
         self.path = path
         self.refspec = refspec
@@ -51,7 +50,6 @@ class Repo:
         self.operations_disabled = disable_operations
 
     def __getattr__(self, item):
-        # pylint: disable=no-else-return
         if item == 'layers':
             if not self._layers:
                 return [self.path]
@@ -256,7 +254,6 @@ class RepoImpl(Repo):
             (retc, output) = yield from run_cmd_async(cmd,
                                                       cwd=self.path,
                                                       fail=False)
-            # pylint: disable=no-else-return
             if retc:
                 logging.error('Could not apply patch. Please fix repos and '
                               'patches. (patch path: %s, repo: %s, patch '
@@ -274,7 +271,6 @@ class GitRepo(RepoImpl):
     """
         Provides the git functionality for a Repo.
     """
-    # pylint: disable=no-self-use,missing-docstring
 
     def clone_cmd(self, gitsrcdir):
         cmd = ['git', 'clone', '-q', self.url, self.path]
@@ -310,7 +306,6 @@ class MercurialRepo(RepoImpl):
     """
         Provides the hg functionality for a Repo.
     """
-    # pylint: disable=no-self-use,missing-docstring,unused-argument
 
     def clone_cmd(self, gitsrcdir, config):
         return ['hg', 'clone', self.url, self.path]

kas/shell.py

@@ -70,7 +70,6 @@ class Shell:
         """
             Runs this kas plugin
         """
-        # pylint: disable= no-self-use
 
         if args.cmd != 'shell':
             return False

scripts/checkcode.sh

@@ -5,9 +5,6 @@ ERROR=0
 echo "Checking with pycodestyle"
 pycodestyle --ignore=W503,W606 $1/*.py $1/*/*.py || ERROR=$(expr $ERROR + 1)
 
-echo "Checking with pylint"
-pylint $1/*.py $1/*/*.py || ERROR=$(expr $ERROR + 2)
-
 echo "Checking with doc8"
 doc8  $1/docs --ignore-path $1/docs/_build || ERROR=$(expr $ERROR + 4)
 

tests/test_includehandler.py

@@ -20,7 +20,6 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
-# pylint: disable=missing-docstring,no-self-use
 
 import os
 import io