Merge https://git.mimbach49.de/GerhardHoffmann/UpdatePTUDevCtrl into gerhard-development

OnDemandUpdatePTU.pro

@@ -64,20 +64,8 @@ DEFINES += QT_DEPRECATED_WARNINGS
 #           given in ATBUpdateTool.ini can be overwritten on the command-line.
 # 1.3.18:   Bug fixes found during testing.
 # 1.3.19:   Bug fixes found during testing.
+VERSION="1.3.20"
 # 1.3.20:   Bug fixes found during testing.
-# 1.3.21:   Bug fixes found during testing:
-#           Fix directory of ATBUpdateTool.ini to be the working directory of
-#           the application rather than just ".".
-#           Check existance of etc-directory inside customer repository.
-#           Check for valid ISMAS trigger (button) 15x (=90s).
-#           NOTE: if the customer repository is cloned (or repaired and cloned
-#           again), and if the settings always-download-config=true and
-#           always-download-dc=true in the ATBUpdateTool.ini file, the download
-#           the printer-json files and the device controller file, even without
-#           an activated ISMAS trigger (button). The tariff-files are rsynced to
-#           the local filesystem for such clone.
-#           Set new filename for device controller: dc2c.bin.
-VERSION="1.3.22"
 
 # PLANNED TODOS:
 #   1:  Das Repository wird repariert bwz. neu geklont. Unabhaengig vom WAIT.
@@ -108,9 +96,6 @@ VERSION="1.3.22"
 #       Stellung des WAIT-Button. Grund: es koennte sein, dass andernfalls ein
 #       PSA weit hiter anderen steht, und dann ploetzlich einmal alle vorher-
 #       gehenden Aenderungen anzieht, die gar nicht fuer ihn gemeint waren.
-#  10:  Bei einer Neuinstallation (Neuhauser) immer JSON files runterladen,
-#       Tariff-Files syncen (d.h. nur wenn noch kein Repo vorhanden ist), und
-#       zwar auch ohne WAIT-Button.
 
 
 win32 {

commandline_parser.cpp

@@ -87,7 +87,7 @@ void CommandLineParser::configure() {
     m_repositoryUrlOption.setDefaultValue("https://git.mimbach49.de/GerhardHoffmann");
     m_parser.addOption(m_repositoryUrlOption);
 
-    m_iniFileDirectoryOption.setDefaultValue(QCoreApplication::applicationDirPath());
+    m_iniFileDirectoryOption.setDefaultValue(".");
     m_parser.addOption(m_iniFileDirectoryOption);
 
     m_iniFileNameOption.setDefaultValue("ATBUpdateTool.ini");
@@ -117,10 +117,10 @@ void CommandLineParser::configure() {
     m_extendedVersionOption.setDefaultValue("false");
     m_parser.addOption(m_extendedVersionOption);
 
-    m_yoctoVersionOption.setDefaultValue("false");
+    m_yoctoVersionOption .setDefaultValue("false");
     m_parser.addOption(m_yoctoVersionOption);
 
-    m_yoctoInstallStatusOption.setDefaultValue("false");
+    m_yoctoInstallStatusOption .setDefaultValue("false");
     m_parser.addOption(m_yoctoInstallStatusOption);
 }
 
@@ -128,6 +128,7 @@ void CommandLineParser::readSettings() {
     QString const iniFileDir = m_parser.value(m_iniFileDirectoryOption);
     QString const iniFileName = m_parser.value(m_iniFileNameOption);
     m_iniFileName = QDir::cleanPath(iniFileDir + QDir::separator() + iniFileName);
+
     if (!m_iniFileName.isEmpty()) {
         if (QFile(m_iniFileName).exists()) {
             QSettings settings(m_iniFileName, QSettings::IniFormat);

interfaces.h

@@ -2,6 +2,7 @@
 #define INTERFACE_H
 
 #include <QtPlugin>
+#include <QString>
 
 
 
@@ -397,6 +398,8 @@ struct T_bna
 
 };
 
+class hwapi;
+class DownloadThread;
 class hwinf
 {
 
@@ -2273,35 +2276,62 @@ public:
     //                                          countOfBills[1] for 10€   and so on
 
 
+    // download device controller
+    virtual bool dcDownloadRequest(QString const &fileToDownload) const {
+        Q_UNUSED(fileToDownload);
+        return false;
+    }
+    virtual bool dcDownloadRequested() const { return false; }
+    virtual bool dcDownloadResetRequest() const { return false; }
+    virtual bool dcDownloadRequestAck() const { return false; }
+    virtual bool dcDownloadRunning() const { return false; }
+    virtual bool dcDownloadFinished() { return false; }
+
+    virtual bool dcDownloadReportStart() const { return false; }
+    virtual bool dcDownloadReportRunning() const { return true; }
+    virtual bool dcDownloadReportFinished() { return true; }
+
+    virtual bool dcDownloadThreadStart() { return false; }
+    virtual bool dcDownloadThreadRunning() const { return true; }
+    virtual void dcDownloadThreadFinalize(DownloadThread *) {}
+    virtual bool dcDownloadThreadFinished() const { return true; }
+    virtual bool dcDownloadReportThreadStart() { return false; }
+    virtual bool dcDownloadReportThreadRunning() const { return true; }
+    virtual void dcDownloadReportThreadFinalize() {}
+    virtual void dcDownloadReportThreadQuit() {}
+    virtual bool dcDownloadReportThreadFinished() const { return true; }
 
 
-signals:
+    virtual QString dcDownloadFileName() const { return ""; }
-    virtual void hwapi_templatePrintFinished_OK(void) const=0;
+    virtual bool dcDownloadSetRequested(bool requested) {
-    virtual void hwapi_templatePrintFinished_Err(void) const=0;
+       Q_UNUSED(requested); return false;
+    }
+    virtual bool dcDownloadSetRunning(bool running) {
+       Q_UNUSED(running); return false;
+    }
+    virtual bool dcDownloadSetFinished(bool finished) {
+       Q_UNUSED(finished); return false;
+    }
+    virtual void dcDownloadSetTotalBlockNumber(uint16_t totalBlockNumber) {
+       Q_UNUSED(totalBlockNumber);
+    }
+    virtual void dcDownloadSetCurrentBlockNumber(uint16_t currentBlockNumber) {
+       Q_UNUSED(currentBlockNumber);
+    }
+    virtual bool dcDownloadGetRequested() const { return false; }
+    virtual bool dcDownloadGetRunning() const { return false; }
+    virtual bool dcDownloadGetFinished() const { return false; }
+    virtual uint16_t dcDownloadGetTotalBlockNumber() const { return 0; }
+    virtual uint16_t dcDownloadGetCurrentBlockNumber() const { return 0; }
 
-    virtual void hwapi_coinCollectionJustStarted(void) const=0;
+    virtual QObject const *getAPI() { return nullptr; }
-    virtual void hwapi_coinCollectionAborted(void) const=0;
-
-    virtual void hwapi_gotNewCoin(void) const=0;
-    virtual void hwapi_payStopByMax(void) const=0;
-    virtual void hwapi_payStopByPushbutton(void) const=0;
-
-    virtual void hwapi_payStopByEscrow(void) const=0;
-    virtual void hwapi_payStopByError(void) const=0;
-    virtual void hwapi_payStopByTimeout(void) const=0;
-    virtual void hwapi_payCancelled(void) const=0;
-    virtual void hwapi_coinProcessJustStopped(void) const=0;
-
-    virtual void hwapi_doorServiceDoorOpened(void) const=0;
-    virtual void hwapi_doorVaultDoorOpened(void) const=0;
-    virtual void hwapi_doorCoinBoxRemoved(void) const=0;
-    virtual void hwapi_doorCoinBoxInserted(void) const=0;
-    virtual void hwapi_doorCBinAndAllDoorsClosed(void) const=0;
-    virtual void hwapi_doorAllDoorsClosed(void) const=0;
 
+signals:    // for download
+    void hwapi_reportDCDownloadStatus(QString const&) const;
+    void hwapi_reportDCDownloadSuccess(QString const&) const;
+    void hwapi_reportDCDownloadFailure(QString const&) const;
 
     // NOTE: declaring a "pure virtual" "signal" should be an error and thus not valid.
-    /* GH Version, bringt Fehler
     void hwapi_templatePrintFinished_OK() const;
     void hwapi_templatePrintFinished_Err() const;
 
@@ -2324,7 +2354,6 @@ signals:
     void hwapi_doorCoinBoxInserted() const;
     void hwapi_doorCBinAndAllDoorsClosed() const;
     void hwapi_doorAllDoorsClosed() const;
-    */
 };
 
 

mainwindow.cpp

@@ -146,7 +146,7 @@ void MainWindow::onEnableExit() {
 
 void MainWindow::onRestartExitTimer() {
     m_exitTimer->stop();
-    m_exitTimer->start(5 * 1000);
+    m_exitTimer->start(60 * 1000);
 
     scrollDownTextEdit();
     ui->updateStatus->setEnabled(false);
@@ -156,6 +156,15 @@ void MainWindow::onQuit() {
     m_exitTimer->stop();
     int errorCode = 0;
 
+    Update *update = m_worker->update();
+    if (update) {
+        hwinf *hw =  update->hw();
+        if (hw) {
+            hw->dcDownloadReportFinished();
+            hw->dcDownloadFinished();
+        }
+    }
+
     qCritical()
         << QString("ON QUIT: CURRENT STEP %1")
             .arg(m_worker->getSmap()[m_worker->currentStep()]);

plugins/interfaces.h

@@ -2,6 +2,7 @@
 #define INTERFACE_H
 
 #include <QtPlugin>
+#include <QString>
 
 
 
@@ -397,6 +398,8 @@ struct T_bna
 
 };
 
+class hwapi;
+class DownloadThread;
 class hwinf
 {
 
@@ -1834,6 +1837,9 @@ public:
     virtual uint8_t prn_getPrintResult() const {
        return 0;
     }
+    // return:  0: just printing, wait
+    //          1: OK - last print was succesful
+    //          2: error - not printed
 
 
 
@@ -2270,9 +2276,61 @@ public:
     //                                          countOfBills[1] for 10€   and so on
 
 
+    // download device controller
+    virtual bool dcDownloadRequest(QString const &fileToDownload) const {
+        Q_UNUSED(fileToDownload);
+        return false;
+    }
+    virtual bool dcDownloadRequested() const { return false; }
+    virtual bool dcDownloadResetRequest() const { return false; }
+    virtual bool dcDownloadRequestAck() const { return false; }
+    virtual bool dcDownloadRunning() const { return false; }
+    virtual bool dcDownloadFinished() { return false; }
+
+    virtual bool dcDownloadReportStart() const { return false; }
+    virtual bool dcDownloadReportRunning() const { return true; }
+    virtual bool dcDownloadReportFinished() { return true; }
+
+    virtual bool dcDownloadThreadStart() { return false; }
+    virtual bool dcDownloadThreadRunning() const { return true; }
+    virtual void dcDownloadThreadFinalize(DownloadThread *) {}
+    virtual bool dcDownloadThreadFinished() const { return true; }
+    virtual bool dcDownloadReportThreadStart() { return false; }
+    virtual bool dcDownloadReportThreadRunning() const { return true; }
+    virtual void dcDownloadReportThreadFinalize() {}
+    virtual void dcDownloadReportThreadQuit() {}
+    virtual bool dcDownloadReportThreadFinished() const { return true; }
 
 
-signals:
+    virtual QString dcDownloadFileName() const { return ""; }
+    virtual bool dcDownloadSetRequested(bool requested) {
+       Q_UNUSED(requested); return false;
+    }
+    virtual bool dcDownloadSetRunning(bool running) {
+       Q_UNUSED(running); return false;
+    }
+    virtual bool dcDownloadSetFinished(bool finished) {
+       Q_UNUSED(finished); return false;
+    }
+    virtual void dcDownloadSetTotalBlockNumber(uint16_t totalBlockNumber) {
+       Q_UNUSED(totalBlockNumber);
+    }
+    virtual void dcDownloadSetCurrentBlockNumber(uint16_t currentBlockNumber) {
+       Q_UNUSED(currentBlockNumber);
+    }
+    virtual bool dcDownloadGetRequested() const { return false; }
+    virtual bool dcDownloadGetRunning() const { return false; }
+    virtual bool dcDownloadGetFinished() const { return false; }
+    virtual uint16_t dcDownloadGetTotalBlockNumber() const { return 0; }
+    virtual uint16_t dcDownloadGetCurrentBlockNumber() const { return 0; }
+
+    virtual QObject const *getAPI() { return nullptr; }
+
+signals:    // for download
+    void hwapi_reportDCDownloadStatus(QString const&) const;
+    void hwapi_reportDCDownloadSuccess(QString const&) const;
+    void hwapi_reportDCDownloadFailure(QString const&) const;
+
     // NOTE: declaring a "pure virtual" "signal" should be an error and thus not valid.
     void hwapi_templatePrintFinished_OK() const;
     void hwapi_templatePrintFinished_Err() const;

update.cpp

@@ -94,6 +94,7 @@ bool Update::unloadDCPlugin() {
     return false;
 }
 
+class hwapi;
 Update::Update(Worker *worker,
                QString customerRepository,
                QString customerNrStr,
@@ -130,18 +131,44 @@ Update::Update(Worker *worker,
 
     qCritical() << "UPDATE: m_sys_areDCDataValid ..." << m_sys_areDCdataValid;
 
-    //qInfo() << "UPDATE: m_serialInterface    ..." << m_serialInterface;
+    QObject const *obj = m_hw->getAPI();
-    //qInfo() << "UPDATE: m_baudrate           ..." << m_baudrate;
+    // QObject const *obj = (QObject const *)(hw);
-    //qInfo() << "UPDATE: m_customerRepository ..." << m_customerRepository;
+
-    //qInfo() << "UPDATE: m_customerNr ..........." << m_customerNrStr;
+    if (!connect(obj,
-    //qInfo() << "UPDATE: m_branchName ..........." << m_branchName;
+        SIGNAL(hwapi_reportDCDownloadStatus(QString const&)), this,
-    //qInfo() << "UPDATE: m_pluginName ..........." << m_pluginName;
+        SLOT(onReportDCDownloadStatus(QString const &)))) {
-    //qInfo() << "UPDATE: m_workingDirectory ....." << m_workingDir;
+        qCritical() << "ERROR connect() to onReportDCDownloadStatus() failed";
+    }
+    if (!connect(obj,
+        SIGNAL(hwapi_reportDCDownloadSuccess(QString const&)), this,
+        SLOT(onReportDCDownloadSuccess(QString const &)))) {
+        qCritical() << "ERROR connect() to onReportDCDownloadSuccess() failed";
+    }
+    if (!connect(obj,
+        SIGNAL(hwapi_reportDCDownloadFailure(QString const &)), this,
+        SLOT(onReportDCDownloadFailure(QString const &)))) {
+        qCritical() << "ERROR connect() to onReportDCDownloadFailure() failed";
+    }
 }
 
 Update::~Update() {
 }
 
+
+void Update::onReportDCDownloadStatus(QString const &status) {
+    emit m_worker->showStatusMessage("DL", status);
+}
+
+void Update::onReportDCDownloadSuccess(QString const &msg) {
+    qCritical() << "msg" << msg;
+}
+
+void Update::onReportDCDownloadFailure(QString const &errorMsg) {
+    qCritical() << "msg" << errorMsg;
+}
+
+
+
 // br is a index into a table, used for historical reasons.
 bool Update::openSerial(int br, QString baudrate, QString comPort) const {
     qDebug() << "opening serial" << br << baudrate << comPort << "...";
@@ -501,15 +528,57 @@ bool Update::doUpdate(int &displayIndex, QStringList const &filesToWorkOn) {
     }
 
     bool res = false;
+    bool dcDownloadPossible = true;
+
     QList<QString>::const_iterator it;
     for (it = filesToWorkOn.cbegin(); it != filesToWorkOn.cend(); ++it) {
         m_worker->startProgressLoop();
         QString const &fToWorkOn = QDir::cleanPath(m_customerRepository + QDir::separator() + it->trimmed());
-        if (fToWorkOn.contains("dc2c.bin")) {
+        static const QRegularExpression version("^.*dc2c[.][0-9]{1,2}[.][0-9]{1,2}[.]bin.*$");
+        qCritical() << "ABOUT TO START REPORTING THREAD (1)" << fToWorkOn;
+        if (fToWorkOn.contains(version) && dcDownloadPossible) {
+            // download for dc possible only once
+            dcDownloadPossible = false;
+
+            m_hw->dcDownloadRequest(fToWorkOn);  // initiate download process
+
+            // test
+            m_hw->dcDownloadThreadStart();
+
+            if (!m_hw->dcDownloadRunning()) { // may take some time
+                qCritical() << QDateTime::currentDateTime() << __PRETTY_FUNCTION__
+                            << QString("line=%1 DOWNLOAD NOT RUNNING").arg(__LINE__);
+                continue;               // wait for reporting thread to start
+            }
+
+            if (!m_hw->dcDownloadReportThreadStart()) { // may take some time
+                qCritical() << QDateTime::currentDateTime() << __PRETTY_FUNCTION__
+                            << QString("line=%1 REPORT THREAD NOT RUNNING").arg(__LINE__);
+                continue;               // wait for reporting thread to start
+            }
+
+            if (!m_hw->dcDownloadReportRunning()) {     // may take some time
+                qCritical() << QDateTime::currentDateTime() << __PRETTY_FUNCTION__
+                            << QString("line=%1 DOWNLOAD REPORT NOT RUNNING").arg(__LINE__);
+                continue;            // reporting events from download thread
+            }
+
+            if (!m_hw->dcDownloadReportFinished()) {    // may take some time
+                qCritical() << QDateTime::currentDateTime() << __PRETTY_FUNCTION__
+                            << QString("line=%1 DOWNLOAD REPORT THREAD DID NOT FINISH").arg(__LINE__);
+                m_hw->dcDownloadReportThreadQuit();
+                continue;               // wait for download thread to finish
+            }
+
+            qCritical() << QDateTime::currentDateTime() << __PRETTY_FUNCTION__
+                        << QString("line=%1 DOWNLOAD SUCCESS").arg(__LINE__);
+
             bool updateBinaryRes = true;
 
-            // CONSOLE()
 
+
+            // CONSOLE()
+#if 0
             m_hw->dc_autoRequest(false);// default: turn auto-request setting off
             QThread::sleep(1);          // wait to be sure that there are no more
                                         // commands sent to dc-hardware
@@ -538,7 +607,7 @@ bool Update::doUpdate(int &displayIndex, QStringList const &filesToWorkOn) {
                     qInfo() << "dc-firmware-version (NOT UPDATED)" << versions[1];
                 }
             }
-
+#endif
             res = updateBinaryRes;
 
         } else if (fToWorkOn.contains("DC2C_print", Qt::CaseInsensitive)
@@ -595,6 +664,8 @@ bool Update::doUpdate(int &displayIndex, QStringList const &filesToWorkOn) {
             qCritical() << "UNKNOWN JSON FILE NAME" << fToWorkOn;
             res = false;
         }
+        // m_worker->stopProgressLoop();
+        // m_worker->setProgress(100);
 
         if (res == false) {
             break;

update.h

@@ -92,6 +92,9 @@ private slots:
     void readyReadStandardOutput();
     void readyReadStandardError();
     void finished(int exitCode, QProcess::ExitStatus exitStatus);
+    void onReportDCDownloadStatus(QString const &status);
+    void onReportDCDownloadSuccess(QString const &msg);
+    void onReportDCDownloadFailure(QString const &errorMsg);
 
 };
 #endif // UPDATE_H_INCLUDED

worker.cpp

@@ -157,7 +157,14 @@ Worker::Worker(int customerNr,
   , m_updateProcessRunning(true)
   , m_mainWindow(nullptr) /* contains plugin */
   //, m_withoutIsmasDirectPort(true) /* useful for testing */ {
-  , m_withoutIsmasDirectPort(false) /* useful for testing */ {
+  , m_withoutIsmasDirectPort(false) /* useful for testing */
+  // IMPORTANT: allocate m_update here, otherwise the connects() inside of
+  // Update might not work: keep in mind that worker (this) is a thread without
+  // an own event-loop.
+  , m_update(new Update(this,
+                        QDir::cleanPath(m_workingDirectory + QDir::separator() + m_customerNrStr),
+                        m_customerNrStr, m_branchName, m_pluginDir,
+                        m_pluginName, m_workingDirectory)) {
 
     // TODO: turn object into singleton
     instance = this;
@@ -166,9 +173,15 @@ Worker::Worker(int customerNr,
     QDir::setCurrent(m_workingDirectory);
 
     m_apismVersion = getAPISMYoctoVersion();
+
 }
 
 Worker::~Worker() {
+    if (m_update) {
+        qCritical() << "DELETE UPDATE";
+        delete m_update;
+        m_update = nullptr;
+    }
 }
 
 void Worker::displayProgressInMainWindow(int progress) {
@@ -214,12 +227,6 @@ bool Worker::isRepositoryCorrupted() {
             Utils::printCriticalErrorMsg("CORRUPTED CUSTOMER REPOSITORY .GIT DOES NOT EXIST");
             return true;
         }
-        QDir customerRepositoryEtc(QDir::cleanPath(m_customerRepository + QDir::separator() + "etc/"));
-        if (!customerRepositoryEtc.exists()) {
-            // should never happen
-            Utils::printCriticalErrorMsg(QString("CORRUPTED CUSTOMER REPOSITORY %1/etc DOES NOT EXIST").arg(m_customerRepository));
-            return true;
-        }
     }
     return false;
 }
@@ -340,30 +347,21 @@ void Worker::privateUpdate() {
     //
     ////////////////////////////////////////////////////////////////////////////
     m_ismasTriggerActive = false;
-    if (m_clone == false) {
     if ((continueUpdate = updateTriggerSet()) == false) {
-            return;
-        } else {
-            GUI() << (ISMAS() << (CONSOLE() << UPDATE_STEP::CHECK_ISMAS_TRIGGER_SUCCESS));
-            setProgress(_CHECK_ISMAS_TRIGGER_SUCCESS);
-        }
-    } else {
         if (m_initialClone) {
             GUI() << (ISMAS() << (CONSOLE() << UPDATE_STEP::INITIAL_CLONE_WITHOUT_ACTIVE_ISMAS_TRIGGER));
         }
+        return;
+    } else {
+        GUI() << (ISMAS() << (CONSOLE() << UPDATE_STEP::INITIAL_CLONE_WITH_ACTIVE_ISMAS_TRIGGER));
     }
-
-    qCritical() << "**** m_ismasTriggerActive:" << m_ismasTriggerActive;
-    qCritical() << "****              m_clone:" << m_clone;
-
     if (m_ismasTriggerActive == false) {// make it explicit again: only if the
                                         // ismas trigger is active ('WAIT'),
                                         // then proceed
-
+        return;
-        if (m_clone == false) {  // if it is an (initial) clone, then
+    }
-            return;              // run the whole update process:
+    GUI() << (ISMAS() << (CONSOLE() << UPDATE_STEP::CHECK_ISMAS_TRIGGER_SUCCESS));
-        }                        // sync tariff-files, download jsons,
+    setProgress(_CHECK_ISMAS_TRIGGER_SUCCESS);
-    }                            // download device controller
 
 
     ////////////////////////////////////////////////////////////////////////////
@@ -473,8 +471,8 @@ bool Worker::updateTriggerSet() {
     GUI() << (ISMAS() << (CONSOLE() << UPDATE_STEP::CHECK_ISMAS_TRIGGER));
 
     QString triggerValue("NOT CHECKED YET");
-    static constexpr int const repeats = 15;
+
-    for (int repeat = 1; repeat <= repeats; ++repeat) {
+    for (int repeat = 1; repeat <= 100; ++repeat) {
 
         if (repeat > 1) {
             int const startMs = QTime::currentTime().msecsSinceStartOfDay();
@@ -482,12 +480,10 @@ bool Worker::updateTriggerSet() {
             QString const &s = QString("elapsed: %1.%2s").arg(durationMs / 1000).arg(durationMs % 1000);
             CONSOLE(QStringList(func) << s) << UPDATE_STEP::DEBUG;
         } else {
-            QStringList lst = (QStringList(func) << QString("-> REPEAT=%1 (%2)").arg(repeat).arg(repeats-repeat));
+            CONSOLE(QStringList(func) << QString("-> REPEAT=%1").arg(repeat)) << UPDATE_STEP::DEBUG;
-            // GUI(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER;
-            CONSOLE(lst) << UPDATE_STEP::DEBUG;
         }
 
-        if ((repeat % 8) == 0) {
+        if ((repeat % 10) == 0) {
             CONSOLE(QStringList(func) << "RESTART APISM") << UPDATE_STEP::DEBUG;
             Command c("systemctl restart apism");
             if (c.execute("/tmp")) {
@@ -577,7 +573,7 @@ bool Worker::updateTriggerSet() {
                             return m_ismasTriggerActive;
                         } else
                         if (QRegExp("\\s*").exactMatch(triggerValue)) { // check for whitespace
-                            QStringList lst(QString("%1 empty update trigger (%2)").arg(repeat).arg(repeats-repeat));
+                            QStringList lst("empty update trigger");
                             if (m_clone) {
                                 GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_WRONG_VALUE);
                                                     // if the customer repository has just been cloned
@@ -659,7 +655,10 @@ bool Worker::filesToUpdate() {
     // always execute contents of opkg_commands-file
     m_filesToUpdate << "etc/psa_update/opkg_commands";
 
-    if (m_clone && m_alwaysDownloadConfig) {
+    if (m_alwaysDownloadConfig) {
+#if 0
+        QStringList lst(QString("m_alwaysDownloadConfig NOT TESTED"));
+        CONSOLE(lst) << UPDATE_STEP::UPDATE_REPOSITORY;
         // always download all json-config files, even if none of them have been
         // changed in the git repository. useful for first installation.
         QDir dir(QDir::cleanPath(m_customerRepository + QDir::separator() + "etc/psa_config"));
@@ -669,19 +668,24 @@ bool Worker::filesToUpdate() {
                 m_filesToUpdate << jsons;
             }
         }
+#endif
     }
 
-    if (m_clone && m_alwaysDownloadDC) {
+    if (m_alwaysDownloadDC) {
+#if 0
+        QStringList lst(QString("m_alwaysDownloadDC NOT TESTED"));
+        CONSOLE(lst) << UPDATE_STEP::UPDATE_REPOSITORY;
         // always download the last dc-binary, even if not changed in the
         // git repository. useful for first installation.
-        QDir dir(QDir::cleanPath(m_customerRepository + QDir::separator() + "etc/dc"));
+        QDir dir(QDir::cleanPath(m_customerRepository + QDir::separator() + "etc/psa_update"));
         if (dir.exists()) {
-            QStringList dc = dir.entryList(QStringList() << "dc2c.bin", QDir::Files,
+            QStringList dc = dir.entryList(QStringList() << "dc2c*.bin", QDir::Files,
                                            QDir::SortFlag::Time | QDir::SortFlag::Reversed);
             if (!dc.isEmpty()) {
                 m_filesToUpdate << dc.first();
             }
         }
+#endif
     }
 
     if (std::optional<QString> changes = m_gc.gitPull()) {
@@ -714,7 +718,8 @@ bool Worker::computeFilesToDownload() {
             fName.contains("DC2C_cash", Qt::CaseInsensitive)) {
             m_filesToDownload << fName;  // download printer-config-files
         } else {
-            if (fName.contains("dc2c.bin")) {
+            static const QRegularExpression version("^.*dc2c[.][0-9]{1,2}[.][0-9]{1,2}[.]bin.*$");
+            if (fName.contains(version)) {
                 m_filesToDownload << fName; // download device controller
             }
         }
@@ -735,7 +740,7 @@ bool Worker::execOpkgCommands() {
                     if (f.open(QIODevice::ReadOnly)) {
                         QTextStream in(&f);
                         m_opkgCommands.clear();
-                        QStringList opkgErrorLst;
+                        bool executeOpkgCommandFailed = false;
                         while (!in.atEnd()) {
                             QString line = in.readLine();
                             static const QRegularExpression comment("^\\s*#.*$");
@@ -743,7 +748,7 @@ bool Worker::execOpkgCommands() {
                                 // found opkg command
                                 QString opkgCommand = line.trimmed();
                                 if (!executeOpkgCommand(opkgCommand)) {
-                                    opkgErrorLst << opkgCommand;
+                                    executeOpkgCommandFailed = true;
                                 } else {
                                     QString cmd = "\n  " + opkgCommand;
                                     emit appendText(cmd);
@@ -797,15 +802,14 @@ bool Worker::execOpkgCommands() {
                             }
                         }
                         f.close();
-                        if (opkgErrorLst.size() == 0) {
+                        if (!executeOpkgCommandFailed) {
                             if (m_opkgCommands.size() > 0) {
                                 m_displayIndex = 1;
-                                ISMAS() << (GUI() << (CONSOLE() << UPDATE_STEP::EXEC_OPKG_COMMAND_SUCCESS));
+                                GUI() << UPDATE_STEP::EXEC_OPKG_COMMAND_SUCCESS;
                                 setProgress(_EXEC_OPKG_COMMAND_SUCCESS);
                             }
                         } else {
                             m_displayIndex = 1;
-                            ISMAS(opkgErrorLst) << (GUI(opkgErrorLst) << (CONSOLE() << UPDATE_STEP::EXEC_OPKG_COMMAND_FAILURE));
                             GUI() << UPDATE_STEP::EXEC_OPKG_COMMAND_FAILURE;
                             setProgress(_EXEC_OPKG_COMMAND_FAILURE);
                             return false;
@@ -828,15 +832,12 @@ bool Worker::downloadFilesToPSAHardware() {
         if (computeFilesToDownload()) {
             CONSOLE(m_filesToDownload) << UPDATE_STEP::FILES_TO_DOWNLOAD;
 
-            Update update(this,
+            //m_update = new Update(this,
-                          QDir::cleanPath(m_workingDirectory + QDir::separator() + m_customerNrStr),
+            //                      QDir::cleanPath(m_workingDirectory + QDir::separator() + m_customerNrStr),
-                          m_customerNrStr,
+            //                      m_customerNrStr, m_branchName, m_pluginDir,
-                          m_branchName,
+            //                      m_pluginName, m_workingDirectory);
-                          m_pluginDir,
-                          m_pluginName,
-                          m_workingDirectory);
 
-            return update.doUpdate(m_displayIndex, m_filesToDownload);
+            return m_update->doUpdate(m_displayIndex, m_filesToDownload);
         } else {
             CONSOLE(QStringList("NO FILES TO DOWNLOAD TO PSA-HW")) << UPDATE_STEP::DOWNLOAD_FILES_TO_PSA_HARDWARE_FAILURE;
             setProgress(_DOWNLOAD_FILES_TO_PSA_HARDWARE_FAILURE);

worker.h

@@ -557,10 +557,8 @@ private:
         break;
         case UPDATE_STEP::EXEC_OPKG_COMMAND_SUCCESS:
         break;
-        case UPDATE_STEP::EXEC_OPKG_COMMAND_FAILURE: {
+        case UPDATE_STEP::EXEC_OPKG_COMMAND_FAILURE:
-            lst << instance->m_debugMsg;
+        break;
-            Utils::printUpdateStatusMsg(debug, lst);
-        } break;
         case UPDATE_STEP::DOWNLOAD_CONFIG_FILE:
         break;
         case UPDATE_STEP::DOWNLOAD_CONFIG_FILE_SUCCESS:
@@ -1127,9 +1125,6 @@ private:
         break;
         case UPDATE_STEP::CHECK_ISMAS_TRIGGER:
             emit worker->appendText("\n" CHECK_UPDATE_TRIGGER_SET);
-            if (worker->m_guiMsg.size() > 0) {
-                emit worker->showStatusMessage(worker->m_guiMsg);
-            }
         break;
         case UPDATE_STEP::CHECK_ISMAS_TRIGGER_SUCCESS:
         break;