Minor: added comment.

bool m_updateNotNecessary = false;
    QStringList m_ismasTriggerStatusMessage;

OnDemandUpdatePTU.pro

@@ -95,6 +95,10 @@ DEFINES += QT_DEPRECATED_WARNINGS
 # 1.4.0   : Start with version at 1.4.0 (mainly to see a difference with Szeged)
 #           Set hash-value in EVENT-objects. Set location (project), version
 #           and info in send-last-version.
+#           Check the ISMAS update-trigger as very first step.
+#           If the current time is between 0.00 - 4.00 o'clock, then a wrong
+#           trigger-value wil result in an UPDATE_STEP_NOT_NECESSARY.
+#           Move final processing to subclass UpdateProcessRunning.
 VERSION="1.4.0"
 
 # PLANNED TODOS:

commandline_parser.cpp

@@ -128,12 +128,20 @@ void CommandLineParser::readSettings() {
     QString const iniFileDir = m_parser.value(m_iniFileDirectoryOption);
     QString const iniFileName = m_parser.value(m_iniFileNameOption);
     m_iniFileName = QDir::cleanPath(iniFileDir + QDir::separator() + iniFileName);
+
+    qCritical() << __PRETTY_FUNCTION__ << " iniFileDir" << iniFileDir;
+    qCritical() << __PRETTY_FUNCTION__ << "iniFileName" << m_iniFileName;
+
     if (!m_iniFileName.isEmpty()) {
         if (QFile(m_iniFileName).exists()) {
             QSettings settings(m_iniFileName, QSettings::IniFormat);
             QStringList keys = settings.allKeys();
             for (QString const &key: keys) {
                 QVariant v = settings.value(key);
+
+                qCritical() << __PRETTY_FUNCTION__
+                            << key << " -> " << v.toString();
+
                 if (key.contains("repository-url")) {
                     m_repositoryUrl = v.toString();
                 } else
@@ -166,8 +174,14 @@ void CommandLineParser::readSettings() {
                 } else
                 if (key.contains("plugin-name")) {
                     m_plugInName = v.toString();
+                } else {
+                    qCritical() << __PRETTY_FUNCTION__
+                                << key << " -> (UNKNOWN) " << v.toString();
                 }
             }
+        } else {
+            qCritical() << __PRETTY_FUNCTION__ << "iniFileName" << m_iniFileName
+                        << "DOES NOT EXIST";
         }
     }
 }
@@ -238,7 +252,9 @@ bool CommandLineParser::extendedVersion() {
 bool CommandLineParser::alwaysDownloadConfig() {
     if (m_parser.isSet(m_alwaysDownloadConfigOption)) {
         m_alwaysDownloadConfig = m_parser.value(m_alwaysDownloadConfigOption);
+        qCritical() << "m_alwaysDownloadConfigOption IS SET" << m_alwaysDownloadConfig;
     }
+    qCritical() << "m_alwaysDownloadConfig" << m_alwaysDownloadConfig;
     return m_alwaysDownloadConfig == "false" ? false : true;
 }
 

update.cpp

@@ -54,6 +54,10 @@ hwinf *Update::loadDCPlugin(QDir const &plugInDir, QString const &fname) {
                 qCritical() << pluginLoader.errorString();
                 exit(-1);
             }
+
+            qCritical() << "loadDCPlugin() plugin directory:" << plugInDir.absolutePath();
+            qCritical() << "loadDCPlugin() plugin file name:" << pluginLoader.fileName();
+
             if (!pluginLoader.isLoaded()) {
                 qCritical() << pluginLoader.errorString();
                 exit(-2);
@@ -129,7 +133,7 @@ Update::Update(Worker *worker,
         QThread::msleep(500);
     }
 
-    qCritical() << "UPDATE: m_sys_areDCDataValid ..." << m_sys_areDCdataValid;
+    qCritical() << __PRETTY_FUNCTION__ << "m_sys_areDCDataValid ..." << m_sys_areDCdataValid;
 
     //qInfo() << "UPDATE: m_serialInterface    ..." << m_serialInterface;
     //qInfo() << "UPDATE: m_baudrate           ..." << m_baudrate;

worker.cpp

@@ -97,11 +97,13 @@ const QMap<UPDATE_STEP, const char*> Worker::smap (
         INSERT_ELEMENT(UPDATE_STEP::SAVE_LOGS_FAILURE),
         INSERT_ELEMENT(UPDATE_STEP::SEND_LAST_VERSION),
         INSERT_ELEMENT(UPDATE_STEP::UPDATE_SUCCEEDED),
+        INSERT_ELEMENT(UPDATE_STEP::UPDATE_NOT_NECESSARY),
         INSERT_ELEMENT(UPDATE_STEP::UPDATE_FAILED),
         INSERT_ELEMENT(UPDATE_STEP::UPDATE_ACTIVATED),
         INSERT_ELEMENT(UPDATE_STEP::FINISHED),
         INSERT_ELEMENT(UPDATE_STEP::DEBUG),
-        INSERT_ELEMENT(UPDATE_STEP::ERROR)
+        INSERT_ELEMENT(UPDATE_STEP::ERROR),
+        INSERT_ELEMENT(UPDATE_STEP::NONE)
 #undef INSERT_ELEMENT
 });
 
@@ -163,6 +165,8 @@ Worker::Worker(int customerNr,
     // TODO: turn object into singleton
     instance = this;
 
+    m_lastFailedUpdateStep = UPDATE_STEP::NONE;
+
     this->setObjectName("worker-object");
     QDir::setCurrent(m_workingDirectory);
 
@@ -256,6 +260,34 @@ void Worker::privateUpdate() {
 
     QScopedPointer<UpdateProcessRunning> upr(new UpdateProcessRunning(this));
 
+    ////////////////////////////////////////////////////////////////////////////
+    //
+    //                         CHECK UPDATE TRIGGER
+    //
+    ////////////////////////////////////////////////////////////////////////////
+    // NOTE: make sure that nothing is sent to ISMAS during updateTriggerSet
+    ISMAS() << UPDATE_STEP::CHECK_ISMAS_TRIGGER;
+    m_ismasTriggerActive = false;
+    m_updateNotNecessary = false;
+
+    m_ismasTriggerActive = updateTriggerSet();
+    if (m_ismasTriggerActive == false) {
+        if (QDir(m_customerRepository).exists()) { // ignore a possibly corrupted repository
+            m_versionInfo = m_gc.gitShowReason(m_branchName);
+            QDateTime const &current = QDateTime::currentDateTime();
+            if (current.time().hour() < 4) { // update has been triggered within [00:00:00, 00:03:59]
+                m_updateNotNecessary = true;
+                m_ismasTriggerStatusMessage = QStringList(QString("NO UPDATE NECESSARY (%1)").arg(current.toString(Qt::ISODate)));
+                m_lastFailedUpdateStep = UPDATE_STEP::NONE;
+            }
+            // the customer-repository does exist, but the ISMAS-trigger is
+            // *NOT* "WAIT", so STOP the update procedure
+            return;
+        }
+        // in case the customer-repository does not exist, so PROCEED with the
+        // update procedure, even if ISMAS-trigger is not correctly set ("WAIT")
+    }
+
     QDir customerRepository(m_customerRepository);
     QDir customerRepositoryEtc(QDir::cleanPath(m_customerRepository + QDir::separator() + "etc/"));
 
@@ -282,12 +314,12 @@ void Worker::privateUpdate() {
 
     if (isRepositoryCorrupted()) {  // a not-existing repository is not meant
                                     // to be corrupted
-        CONSOLE() << UPDATE_STEP::CHECK_SANITY_FAILURE;
+        CONSOLE() << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_SANITY_FAILURE);
         if ((continueUpdate = repairCorruptedRepository()) == true) {
             m_repairClone = true;
             CONSOLE() << UPDATE_STEP::REPOSITORY_RECOVERED_SUCCESS;
         } else {
-            ISMAS() << (GUI() << (CONSOLE() << UPDATE_STEP::REPOSITORY_RECOVERED_FAILURE));
+            ISMAS() << (GUI() << (CONSOLE() << (m_lastFailedUpdateStep = UPDATE_STEP::REPOSITORY_RECOVERED_FAILURE)));
             return;
         }
     }
@@ -315,7 +347,7 @@ void Worker::privateUpdate() {
             }
 
             if (continueUpdate == false) {
-                GUI() << (ISMAS() << (CONSOLE() << UPDATE_STEP::CLONE_REPOSITORY_FAILURE));
+                GUI() << (ISMAS() << (CONSOLE() << (m_lastFailedUpdateStep = UPDATE_STEP::CLONE_REPOSITORY_FAILURE)));
                 return;
             }
 
@@ -329,7 +361,7 @@ void Worker::privateUpdate() {
 
             CONSOLE() << UPDATE_STEP::CHECK_REPOSITORY;
             if (isRepositoryCorrupted()) {
-                ISMAS() << (GUI() << (CONSOLE() << UPDATE_STEP::CHECK_REPOSITORY_FAILURE));
+                ISMAS() << (GUI() << (CONSOLE() << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_REPOSITORY_FAILURE)));
                 return;
             }
         }
@@ -343,14 +375,8 @@ void Worker::privateUpdate() {
     setProgress(_CHECKOUT_REPOSITORY_SUCCESS);
 
 
-    ////////////////////////////////////////////////////////////////////////////
-    //
-    //                         CHECK UPDATE TRIGGER
-    //
-    ////////////////////////////////////////////////////////////////////////////
-    m_ismasTriggerActive = false;
     if (m_clone == false) {
-        if ((continueUpdate = updateTriggerSet()) == false) {
+        if (m_ismasTriggerActive == false) {
             return;
         } else {
             GUI() << (ISMAS() << (CONSOLE() << UPDATE_STEP::CHECK_ISMAS_TRIGGER_SUCCESS));
@@ -446,28 +472,7 @@ void Worker::privateUpdate() {
     // ISMAS() << (GUI() << (CONSOLE() << UPDATE_STEP::SAVE_LOGS_SUCCESS));
     setProgress(_SAVE_LOGS_SUCCESS);
 
-
-    ////////////////////////////////////////////////////////////////////////////
-    //
-    //                      FINAL MESSAGES (PART 1)
-    //
-    ////////////////////////////////////////////////////////////////////////////
-    ISMAS() << (GUI() << (CONSOLE() << UPDATE_STEP::UPDATE_SUCCEEDED));
-    setProgress(_UPDATE_SUCCEEDED);
-
-    ISMAS() << (GUI() << (CONSOLE() << UPDATE_STEP::UPDATE_ACTIVATED));
-    setProgress(_UPDATE_ACTIVATED);
-
-    ISMAS() << (GUI() << (CONSOLE() << UPDATE_STEP::FINISHED));
-    setProgress(_FINISHED);
-
-
-    ////////////////////////////////////////////////////////////////////////////
-    //
-    //                 FINAL MESSAGES (PART 2): SEND-LAST-VERSION
-    //                 (destructor of struct UpdateProcessRunning)
-    //
-    ////////////////////////////////////////////////////////////////////////////
+    // final messages: see destructor of UpdateProcessRunning subclass
 }
 
 bool Worker::updateTriggerSet() {
@@ -475,11 +480,13 @@ bool Worker::updateTriggerSet() {
     // (WAIT-button) is activated even in case of initial checkout
     static const QString func = "UPDATE-TRIGGER-SET";
 
-    if (m_withoutIsmasDirectPort) { // useful for testing
-        return true;
-    }
+    // if (m_withoutIsmasDirectPort) { // useful for testing
+    //    return true;
+    //}
 
-    GUI() << (ISMAS() << (CONSOLE() << UPDATE_STEP::CHECK_ISMAS_TRIGGER));
+    m_ismasTriggerStatusMessage.clear();
+
+    GUI() << (CONSOLE() << UPDATE_STEP::CHECK_ISMAS_TRIGGER);
 
     QString triggerValue("NOT CHECKED YET");
     static constexpr int const repeats = 15;
@@ -489,10 +496,10 @@ bool Worker::updateTriggerSet() {
             int const startMs = QTime::currentTime().msecsSinceStartOfDay();
             int const durationMs = QTime::currentTime().msecsSinceStartOfDay() - startMs;
             QString const &s = QString("elapsed: %1.%2s").arg(durationMs / 1000).arg(durationMs % 1000);
-            CONSOLE(QStringList(func) << s) << UPDATE_STEP::DEBUG;
+            QStringList lst = (m_ismasTriggerStatusMessage = (QStringList(func) << s));
+            CONSOLE(lst) << UPDATE_STEP::DEBUG;
         } else {
-            QStringList lst = (QStringList(func) << QString("-> REPEAT=%1 (%2)").arg(repeat).arg(repeats-repeat));
-            // GUI(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER;
+            QStringList lst = (m_ismasTriggerStatusMessage = (QStringList(func) << QString("-> REPEAT=%1 (%2)").arg(repeat).arg(repeats-repeat)));
             CONSOLE(lst) << UPDATE_STEP::DEBUG;
         }
 
@@ -501,7 +508,8 @@ bool Worker::updateTriggerSet() {
             Command c("systemctl restart apism");
             if (c.execute("/tmp")) {
                 QThread::sleep(20); // give APISM some time to reconnect
-                CONSOLE(QStringList(func) << "RESTART APISM DONE") << UPDATE_STEP::DEBUG;
+                QStringList lst = (m_ismasTriggerStatusMessage = (QStringList(func) << "RESTART APISM DONE"));
+                CONSOLE(lst) << UPDATE_STEP::DEBUG;
             }
         }
 
@@ -510,31 +518,35 @@ bool Worker::updateTriggerSet() {
                     IsmasClient::APISM::DIRECT_PORT, "#M=APISM#C=REQ_ISMASPARAMETER#J={}")) {
 
             QString const &msg = QString("APISM RESPONSE(%1)=(").arg(repeat) + result.value() + ")";
-            CONSOLE(QStringList(func) << msg) << UPDATE_STEP::DEBUG;
+            QStringList lst = (m_ismasTriggerStatusMessage = (QStringList(func) << msg));
+            CONSOLE(lst) << UPDATE_STEP::DEBUG;
 
             QJsonParseError parseError;
             QJsonDocument document(QJsonDocument::fromJson(result.value().toUtf8(), &parseError));
             if (parseError.error != QJsonParseError::NoError) {
-                QStringList lst(QString("INVALID JSON MSG: PARSING FAILED (json=<START>%1<END> error=[%2] str=[%3] offset=[%4])")
-                                .arg(msg)
-                                .arg(parseError.error)
-                                .arg(parseError.errorString())
-                                .arg(parseError.offset));
-                GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE);
-                break;
+                m_ismasTriggerStatusMessage = QStringList(QString("INVALID JSON MSG: PARSING FAILED (json=<START>%1<END> error=[%2] str=[%3] offset=[%4])")
+                                                .arg(msg)
+                                                .arg(parseError.error)
+                                                .arg(parseError.errorString())
+                                                .arg(parseError.offset));
+                QStringList lst = m_ismasTriggerStatusMessage;
+                GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE));
+                return false;
             }
             if (!document.isObject()) {
-                QStringList lst(QString("not a json-object %1").arg(result.value()));
-                GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE);
-                break;
+                m_ismasTriggerStatusMessage = QStringList(QString("not a json-object %1").arg(result.value()));
+                QStringList lst = m_ismasTriggerStatusMessage;
+                GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE));
+                return false;
             }
 
             QJsonObject obj = document.object();
 
             // always look for an 'error' first
             if (obj.contains("error")) {
-                QStringList lst(obj.value("error").toString());
-                CONSOLE(QStringList(lst)) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE;
+                m_ismasTriggerStatusMessage = QStringList(obj.value("error").toString());
+                QStringList lst = m_ismasTriggerStatusMessage;
+                CONSOLE(QStringList(lst)) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE);
                 QThread::sleep(6);
                 continue;
             }
@@ -549,31 +561,35 @@ bool Worker::updateTriggerSet() {
                         int const customerNr = obj.value("Custom_ID").toInt(-1);
                         int const machineNr = obj.value("Device_ID").toInt(-1);
                         if (customerNr != m_customerNr) {
-                            QStringList lst(QString("CUSTOMER-NR (%1) != LOCAL CUSTOMER-NR (%2)")
-                                            .arg(customerNr).arg(m_customerNr));
-                            GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE);
-                            break;
+                            m_ismasTriggerStatusMessage = QStringList(QString("CUSTOMER-NR (%1) != LOCAL CUSTOMER-NR (%2)")
+                                                            .arg(customerNr).arg(m_customerNr));
+                            QStringList lst = m_ismasTriggerStatusMessage;
+                            GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE));
+                            return false;
                         }
                         if (machineNr != m_machineNr) {
-                            QStringList lst(QString("MACHINE-NR (%1) != LOCAL MACHINE-NR (%2)")
-                                                .arg(machineNr).arg(m_machineNr));
-                            GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE);
-                            break;
+                            m_ismasTriggerStatusMessage = QStringList(QString("MACHINE-NR (%1) != LOCAL MACHINE-NR (%2)")
+                                                            .arg(machineNr).arg(m_machineNr));
+                            QStringList lst = m_ismasTriggerStatusMessage;
+                            GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE));
+                            return false;
                         }
                     } else {
-                        QStringList lst("Dev_ID DOES NOT CONTAIN Custom_ID AND/OR Device_ID");
-                        GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE);
-                        break;
+                        QStringList lst(QString("Dev_ID DOES NOT CONTAIN Custom_ID AND/OR Device_ID (LINE=%1)").arg(__LINE__));
+                        GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE));
+                        return false;
                     }
                 } else {
-                    QStringList lst("Dev_ID KEY NOT A JSON-OBJECT");
-                    GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE);
-                    break;
+                    m_ismasTriggerStatusMessage = QStringList(QString("Dev_ID KEY NOT A JSON-OBJECT (LINE=%1)").arg(__LINE__));
+                    QStringList lst = m_ismasTriggerStatusMessage;
+                    GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE));
+                    return false;
                 }
             } else {
-                QStringList lst("Dev_ID KEY NOT AVAILABLE");
-                GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE);
-                break;
+                m_ismasTriggerStatusMessage = QStringList(QString("Dev_ID KEY NOT AVAILABLE (LINE=%1)").arg(__LINE__));
+                QStringList lst = m_ismasTriggerStatusMessage;
+                GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE));
+                return false;
             }
 
             if (obj.contains("Fileupload")) {
@@ -582,56 +598,68 @@ bool Worker::updateTriggerSet() {
                     obj = v.toObject();
                     if (obj.contains("TRG")) {
                         if ((triggerValue = obj.value("TRG").toString()) == "WAIT") {
+                            m_ismasTriggerStatusMessage = QStringList("ISMAS_UPDATE-TRIGGER SET TO WAIT");
                             m_ismasTriggerActive = true;
                             return m_ismasTriggerActive;
                         } else
                         if (QRegExp("\\s*").exactMatch(triggerValue)) { // check for whitespace
-                            QStringList lst(QString("%1 empty update trigger (%2)").arg(repeat).arg(repeats-repeat));
+                            m_ismasTriggerStatusMessage = QStringList(QString("%1 EMPTY UPDATE TRIGGER (%2)").arg(repeat).arg(repeats-repeat));
+                            QStringList lst = m_ismasTriggerStatusMessage;
                             if (m_clone) {
-                                GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_WRONG_VALUE);
+                                GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_WRONG_VALUE));
                                                     // if the customer repository has just been cloned
-                                break;              // it is OK the ISMAS trigger might not be 'WAIT'
+                                return false;       // it is OK the ISMAS trigger might not be 'WAIT'
                             } else {
-                                GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE);
+                                GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE));
                             }
                             QThread::sleep(6);
                             continue;
                         } else {
-                            // if the download-button once has the wrong value, it will never recover
+                            // if the download-button once has a wrong value, it will never recover
                             if (m_clone) {
-                                GUI() << (CONSOLE() << UPDATE_STEP::CHECK_ISMAS_TRIGGER_WRONG_VALUE);
+                                m_ismasTriggerStatusMessage = QStringList(QString("TRIGGER-VALUE=<%1> NOT 'WAIT'").arg(triggerValue));
+                                QStringList lst = m_ismasTriggerStatusMessage;
+                                GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_WRONG_VALUE));
                             } else {
-                                QStringList lst(QString("TRIGGER-VALUE=<%1> NOT 'WAIT'").arg(triggerValue));
-                                GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE);
+                                m_ismasTriggerStatusMessage = QStringList(QString("TRIGGER-VALUE=<%1> NOT 'WAIT'").arg(triggerValue));
+                                QStringList lst = m_ismasTriggerStatusMessage;
+                                GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE));
                             }
-                            break;
+                            return false;
                         }
                     } else {
-                        QStringList lst("TRG key not available");
-                        GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE);
-                        break;
+                        m_ismasTriggerStatusMessage = QStringList(QString("TRG key not available (LINE=%1)").arg(__LINE__));
+                        QStringList lst = m_ismasTriggerStatusMessage;
+                        GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE));
+                        return false;
                     }
                 } else {
-                    QStringList lst("Fileupload not a json-object");
-                    GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE);
-                    break;
+                    m_ismasTriggerStatusMessage = QStringList(QString("Fileupload not a json-object (LINE=%1)").arg(__LINE__));
+                    QStringList lst = m_ismasTriggerStatusMessage;
+                    GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE));
+                    return false;
                 }
             } else {
-                QStringList lst(QString("Fileupload not available"));
-                GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE);
-                break;
+                m_ismasTriggerStatusMessage = QStringList(QString("Fileupload not available (LINE=%1)").arg(__LINE__));
+                QStringList lst = m_ismasTriggerStatusMessage;
+                GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE));
+                return false;
             }
         } else {
-            QStringList lst = QStringList(QString("no ISMAS response"));
-            GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE);
+            m_ismasTriggerStatusMessage = QStringList(QString("no ISMAS response (LINE=%1)").arg(__LINE__));
+            QStringList lst = m_ismasTriggerStatusMessage;
+            GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE));
             QThread::sleep(6);
+            continue;
         }
     }
 
     if (m_initialClone == false) {
         if (!triggerValue.contains("WAIT", Qt::CaseInsensitive)) {
-            QStringList lst(QString("ISMAS_UPDATE-TRIGGER-NOT-SET-OR-WRONG: VALUE=(") + triggerValue + ")");
-            ISMAS(lst) << (GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE));
+            m_ismasTriggerStatusMessage = QStringList(QString("ISMAS_UPDATE-TRIGGER-NOT-SET-OR-WRONG: VALUE=(") + triggerValue + ")");
+            QStringList lst = m_ismasTriggerStatusMessage;
+            GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECK_ISMAS_TRIGGER_FAILURE));
+            return false;
         }
     }
 
@@ -649,11 +677,11 @@ bool Worker::customerEnvironment() {
             return true;
         } else {
             QStringList lst(QString("CHECKOUT OF " + m_customerRepository + "FAILED"));
-            ISMAS(lst) << (GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECKOUT_BRANCH_FAILURE));
+            ISMAS(lst) << (GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECKOUT_BRANCH_FAILURE)));
         }
     } else {// cannot happen
         QStringList lst(QString(m_customerRepository + " DOES NOT EXIST"));
-        ISMAS(lst) << (GUI(lst) << (CONSOLE(lst) << UPDATE_STEP::CHECKOUT_BRANCH_FAILURE));
+        ISMAS(lst) << (GUI(lst) << (CONSOLE(lst) << (m_lastFailedUpdateStep = UPDATE_STEP::CHECKOUT_BRANCH_FAILURE)));
     }
 
     return false;
@@ -708,7 +736,7 @@ bool Worker::filesToUpdate() {
         GUI(m_filesToUpdate) << (CONSOLE(m_filesToUpdate) << UPDATE_STEP::FILES_TO_UPDATE);
         setProgress(_FILES_TO_UPDATE);
     } else {
-        ISMAS() << (GUI() << (CONSOLE() << UPDATE_STEP::UPDATE_REPOSITORY_FAILURE));
+        ISMAS() << (GUI() << (CONSOLE() << (m_lastFailedUpdateStep = UPDATE_STEP::UPDATE_REPOSITORY_FAILURE)));
         return false;
     }
 
@@ -816,7 +844,7 @@ bool Worker::execOpkgCommands() {
                             }
                         } else {
                             m_displayIndex = 1;
-                            ISMAS(opkgErrorLst) << (GUI(opkgErrorLst) << (CONSOLE() << UPDATE_STEP::EXEC_OPKG_COMMAND_FAILURE));
+                            ISMAS(opkgErrorLst) << (GUI(opkgErrorLst) << (CONSOLE() << (m_lastFailedUpdateStep = UPDATE_STEP::EXEC_OPKG_COMMAND_FAILURE)));
                             GUI() << UPDATE_STEP::EXEC_OPKG_COMMAND_FAILURE;
                             setProgress(_EXEC_OPKG_COMMAND_FAILURE);
                             return false;
@@ -858,7 +886,7 @@ bool Worker::downloadFilesToPSAHardware() {
             }
             return false;
         } else {
-            CONSOLE(QStringList("NO FILES TO DOWNLOAD TO PSA-HW")) << UPDATE_STEP::DOWNLOAD_FILES_TO_PSA_HARDWARE_FAILURE;
+            CONSOLE(QStringList("NO FILES TO DOWNLOAD TO PSA-HW")) << (m_lastFailedUpdateStep = UPDATE_STEP::DOWNLOAD_FILES_TO_PSA_HARDWARE_FAILURE);
             setProgress(_DOWNLOAD_FILES_TO_PSA_HARDWARE_FAILURE);
         }
     }
@@ -946,7 +974,7 @@ bool Worker::syncCustomerRepositoryAndFS() {
             }
         }
     }
-    ISMAS() << (GUI() << (CONSOLE() << UPDATE_STEP::SYNC_CUSTOMER_REPOSITORY_FAILURE));
+    ISMAS() << (GUI() << (CONSOLE() << (m_lastFailedUpdateStep = UPDATE_STEP::SYNC_CUSTOMER_REPOSITORY_FAILURE)));
     setProgress(_SYNC_CUSTOMER_REPOSITORY_FAILURE);
     return false;
 }

worker.h

@@ -33,37 +33,37 @@
 #define _ISMAS_RESET_WAIT   "ISMAS" // reset WAIT-button to "WAIT"
 
 #define _STARTED                                    (1)
-#define _CHECK_SANITY                               (2)
-#define _CHECK_SANITY_FAILURE                       (3)
-#define _CHECK_SANITY_SUCCESS                       (4)
-#define _REPOSITORY_RECOVERED_FAILURE               (5)
-#define _REPOSITORY_RECOVERED_SUCCESS               (6)
-#define _CHECK_REPOSITORY                           (7)
-#define _CHECK_REPOSITORY_FAILURE                   (8)
-#define _CHECK_REPOSITORY_SUCCESS                   (9)
-#define _CLONE_REPOSITORY                           (10)
-#define _CLONE_REPOSITORY_FAILURE                   (11)
-#define _CLONE_REPOSITORY_SUCCESS                   (12)
-#define _CHECKOUT_REPOSITORY                        (13)
-#define _CHECKOUT_REPOSITORY_FAILURE                (14)
-#define _CHECKOUT_REPOSITORY_SUCCESS                (15)
-#define _INITIAL_CLONE_WITHOUT_ACTIVE_ISMAS_TRIGGER (16)
-#define _INITIAL_CLONE_WITH_ACTIVE_ISMAS_TRIGGER    (17)
-#define _CHECK_ISMAS_TRIGGER                        (19)
-#define _CHECK_ISMAS_TRIGGER_WRONG_VALUE            (20)
-#define _CHECK_ISMAS_TRIGGER_SUCCESS                (21)
-#define _CHECK_ISMAS_TRIGGER_FAILURE                (22)
-#define _CHECKOUT_BRANCH                            (23)
-#define _CHECKOUT_BRANCH_FAILURE                    (24)
-#define _CHECKOUT_BRANCH_SUCCESS                    (25)
-#define _UPDATE_REPOSITORY                          (26)
-#define _UPDATE_REPOSITORY_FAILURE                  (28)
-#define _UPDATE_REPOSITORY_SUCCESS                  (29)
-#define _CHECK_FOR_REPOSITORY_CHANGES               (30)
-#define _CHECK_FOR_REPOSITORY_CHANGES_SUCCESS       (36)
-#define _FILES_TO_UPDATE                            (37)
-#define _CHECK_FOR_REPOSITORY_CHANGES_FAILURE       (38)
-#define _FILES_TO_DOWNLOAD                          (39)
+#define _CHECK_ISMAS_TRIGGER                        (2)
+#define _CHECK_SANITY                               (3)
+#define _CHECK_SANITY_FAILURE                       (4)
+#define _CHECK_SANITY_SUCCESS                       (5)
+#define _REPOSITORY_RECOVERED_FAILURE               (6)
+#define _REPOSITORY_RECOVERED_SUCCESS               (7)
+#define _CHECK_REPOSITORY                           (8)
+#define _CHECK_REPOSITORY_FAILURE                   (9)
+#define _CHECK_REPOSITORY_SUCCESS                   (10)
+#define _CLONE_REPOSITORY                           (11)
+#define _CLONE_REPOSITORY_FAILURE                   (12)
+#define _CLONE_REPOSITORY_SUCCESS                   (13)
+#define _CHECKOUT_REPOSITORY                        (14)
+#define _CHECKOUT_REPOSITORY_FAILURE                (15)
+#define _CHECKOUT_REPOSITORY_SUCCESS                (16)
+#define _INITIAL_CLONE_WITHOUT_ACTIVE_ISMAS_TRIGGER (17)
+#define _INITIAL_CLONE_WITH_ACTIVE_ISMAS_TRIGGER    (18)
+#define _CHECK_ISMAS_TRIGGER_WRONG_VALUE            (19)
+#define _CHECK_ISMAS_TRIGGER_SUCCESS                (20)
+#define _CHECK_ISMAS_TRIGGER_FAILURE                (21)
+#define _CHECKOUT_BRANCH                            (22)
+#define _CHECKOUT_BRANCH_FAILURE                    (23)
+#define _CHECKOUT_BRANCH_SUCCESS                    (24)
+#define _UPDATE_REPOSITORY                          (25)
+#define _UPDATE_REPOSITORY_FAILURE                  (26)
+#define _UPDATE_REPOSITORY_SUCCESS                  (27)
+#define _CHECK_FOR_REPOSITORY_CHANGES               (28)
+#define _CHECK_FOR_REPOSITORY_CHANGES_SUCCESS       (29)
+#define _FILES_TO_UPDATE                            (30)
+#define _CHECK_FOR_REPOSITORY_CHANGES_FAILURE       (31)
+#define _FILES_TO_DOWNLOAD                          (32)
 #define _EXEC_OPKG_COMMANDS                         (41)
 #define _EXEC_OPKG_COMMAND_1                        (42)
 #define _EXEC_OPKG_COMMAND_2                        (43)
@@ -82,28 +82,31 @@
 #define _DOWNLOAD_CONFIG_FILE_SUCCESS               (56)
 #define _DOWNLOAD_CONFIG_FILE_FAILURE               (57)
 #define _DOWNLOAD_DEVICE_CONTROLLER                 (65)
-#define _DOWNLOAD_DEVICE_CONTROLLER_SUCCESS         (86)
-#define _DOWNLOAD_DEVICE_CONTROLLER_FAILURE         (87)
-#define _DOWNLOAD_FILES_TO_PSA_HARDWARE_FAILURE     (88)
-#define _DOWNLOAD_FILES_TO_PSA_HARDWARE_SUCCESS     (89)
-#define _SYNC_CUSTOMER_REPOSITORY                   (90)
-#define _SYNC_CUSTOMER_REPOSITORY_FAILURE           (91)
-#define _SYNC_CUSTOMER_REPOSITORY_SUCCESS           (92)
-#define _SAVE_LOGS                                  (93)
-#define _SAVE_LOGS_FAILURE                          (94)
-#define _SAVE_LOGS_SUCCESS                          (95)
-#define _SEND_LAST_VERSION                          (96)
-#define _UPDATE_SUCCEEDED                           (97)
-#define _UPDATE_FAILED                              (98)
-#define _UPDATE_ACTIVATED                           (99)
+#define _DOWNLOAD_DEVICE_CONTROLLER_SUCCESS         (85)
+#define _DOWNLOAD_DEVICE_CONTROLLER_FAILURE         (86)
+#define _DOWNLOAD_FILES_TO_PSA_HARDWARE_FAILURE     (87)
+#define _DOWNLOAD_FILES_TO_PSA_HARDWARE_SUCCESS     (88)
+#define _SYNC_CUSTOMER_REPOSITORY                   (89)
+#define _SYNC_CUSTOMER_REPOSITORY_FAILURE           (90)
+#define _SYNC_CUSTOMER_REPOSITORY_SUCCESS           (91)
+#define _SAVE_LOGS                                  (92)
+#define _SAVE_LOGS_FAILURE                          (93)
+#define _SAVE_LOGS_SUCCESS                          (94)
+#define _SEND_LAST_VERSION                          (95)
+#define _UPDATE_SUCCEEDED                           (96)
+#define _UPDATE_FAILED                              (97)
+#define _UPDATE_ACTIVATED                           (98)
+#define _UPDATE_NOT_NECESSARY                       (99)
 #define _FINISHED                                   (100)
 #define _DEBUG                                      (1000)
 #define _ERROR                                      (1001)
+#define _NONE                                       (1002)
 
-#define _SEND_LAST_VERSION_CORRECTION               (4)
-#define _UPDATE_SUCCEEDED_CORRECTION                (3)
-#define _UPDATE_FAILED_CORRECTION                   (2)
-#define _UPDATE_ACTIVATED_CORRECTION                (1)
+#define _SEND_LAST_VERSION_CORRECTION               (5)
+#define _UPDATE_SUCCEEDED_CORRECTION                (4)
+#define _UPDATE_FAILED_CORRECTION                   (3)
+#define _UPDATE_ACTIVATED_CORRECTION                (2)
+#define _UPDATE_NOT_NECESSARY_CORRECTION            (1)
 
 #define ISMAS_UPDATE_REQUESTS                       (10)
 #define CHECK_UPDATE_TRIGGER_SET                    "Check update trigger ..."
@@ -156,6 +159,8 @@ class Worker : public QThread{
     bool m_initialClone = false;
     bool m_repairClone = false;
     bool m_ismasTriggerActive = false;
+    bool m_updateNotNecessary = false;
+    QStringList m_ismasTriggerStatusMessage;
 
     MainWindow *m_mainWindow;
     bool m_withoutIsmasDirectPort;
@@ -199,6 +204,31 @@ class Worker : public QThread{
         }
 
         virtual ~UpdateProcessRunning() {
+
+            if (m_worker->m_lastFailedUpdateStep == UPDATE_STEP::NONE) {
+                if (m_worker->m_updateNotNecessary) {
+                    // m_ismasTriggerStatusMessage = QStringList(QString("NO UPDATE NECESSARY (%1)").arg(current.toString(Qt::ISODate)));
+                    QStringList lst = m_worker->m_ismasTriggerStatusMessage;
+                    m_worker->GUI(lst) << (m_worker->CONSOLE(lst) << (m_worker->ISMAS(lst) << UPDATE_STEP::UPDATE_NOT_NECESSARY));
+                } else {
+                    m_worker->ISMAS() << (m_worker->GUI() << (m_worker->CONSOLE() << UPDATE_STEP::UPDATE_SUCCEEDED));
+                    m_worker->setProgress(_UPDATE_SUCCEEDED);
+
+                    m_worker->ISMAS() << (m_worker->GUI() << (m_worker->CONSOLE() << UPDATE_STEP::UPDATE_ACTIVATED));
+                    m_worker->setProgress(_UPDATE_ACTIVATED);
+
+                    m_worker->ISMAS() << (m_worker->GUI() << (m_worker->CONSOLE() << UPDATE_STEP::FINISHED));
+                    m_worker->setProgress(_FINISHED);
+                }
+            } else {
+                QStringList lst = m_worker->m_ismasTriggerStatusMessage;
+                UPDATE_STEP last = m_worker->m_lastFailedUpdateStep;
+                if (m_worker->smap.contains(last)) {
+                    lst << QString(" (last failed: %1)").arg(m_worker->smap[last]);
+                }
+                m_worker->GUI(lst) << (m_worker->CONSOLE(lst) << (m_worker->ISMAS(lst) << UPDATE_STEP::UPDATE_FAILED));
+            }
+
             m_worker->ISMAS() << (m_worker->GUI() << (m_worker->CONSOLE()
                               << UPDATE_STEP::SEND_LAST_VERSION));
             m_worker->stopProgressLoop();
@@ -276,10 +306,12 @@ public:
         SEND_LAST_VERSION = _SEND_LAST_VERSION,
         UPDATE_SUCCEEDED = _UPDATE_SUCCEEDED,
         UPDATE_ACTIVATED = _UPDATE_ACTIVATED,
+        UPDATE_NOT_NECESSARY = _UPDATE_NOT_NECESSARY,
         UPDATE_FAILED = _UPDATE_FAILED,
         FINISHED = _FINISHED,
         DEBUG = _DEBUG,
-        ERROR = _ERROR
+        ERROR = _ERROR,
+        NONE = _NONE
     };
 
 private:
@@ -290,6 +322,8 @@ private:
     static Worker *instance;
     QStringList m_opkgCommands;
     Update *m_update = nullptr;
+    hwinf *m_hw = nullptr;
+    UPDATE_STEP m_lastFailedUpdateStep = UPDATE_STEP::NONE;
 
 protected:
     virtual void run();
@@ -347,6 +381,8 @@ public:
     void displayProgressInMainWindow(int progress);
     void startProgressLoop();
     void stopProgressLoop();
+    void setHW(hwinf *hw) { m_hw = hw; }
+    hwinf *getHW() { return m_hw; }
 
     IsmasClient &getIsmasClient() { return m_ismasClient; }
     IsmasClient const &getIsmasClient() const { return m_ismasClient; }
@@ -406,6 +442,8 @@ private:
         QStringList lst = QStringList(smap[step]);
 
         switch (step) {
+        case UPDATE_STEP::NONE: {
+        } break;
         case UPDATE_STEP::STARTED: {
             Utils::printUpdateStatusMsg(
                 debug,
@@ -613,6 +651,10 @@ private:
             lst << instance->m_debugMsg;
             Utils::printUpdateStatusMsg(debug, lst);
         break;
+        case UPDATE_STEP::UPDATE_NOT_NECESSARY:
+            lst << instance->m_debugMsg;
+            Utils::printUpdateStatusMsg(debug, lst);
+        break;
         case UPDATE_STEP::UPDATE_FAILED:
         break;
         case UPDATE_STEP::FINISHED:
@@ -646,6 +688,8 @@ private:
         QStringList lst = QStringList(smap[step]);
 
         switch (step) {
+        case UPDATE_STEP::NONE: {
+        } break;
         case UPDATE_STEP::STARTED: {
             ismasClient.setProgressInPercent(_STARTED);
         } break;
@@ -1059,6 +1103,20 @@ private:
             ismasClient.sendRequestReceiveResponse(
                 IsmasClient::APISM::DB_PORT, ismasUpdateNews);
         } break;
+        case UPDATE_STEP::UPDATE_NOT_NECESSARY: {
+            ismasClient.setProgressInPercent(_UPDATE_NOT_NECESSARY + _UPDATE_NOT_NECESSARY_CORRECTION);
+            QString const &ismasUpdateNews =
+                QString("#M=APISM#C=CMD_EVENT#J=") +
+                    ismasClient.updateNewsToIsmas(
+                        "U0002", // reset WAIT-button to "" (empty string)
+                        ismasClient.getProgressInPercent(),
+                        IsmasClient::RESULT_CODE::SUCCESS,
+                        smap[step],
+                        instance->m_ismasMsg.join(' ').toStdString().c_str(),
+                        instance->m_versionInfo.size() >= 1 ? instance->m_versionInfo.at(0).toUtf8().constData() : "N/A");
+            ismasClient.sendRequestReceiveResponse(
+                IsmasClient::APISM::DB_PORT, ismasUpdateNews);
+        } break;
         case UPDATE_STEP::UPDATE_FAILED: {
             ismasClient.setProgressInPercent(_UPDATE_FAILED);
             QString const &ismasUpdateNews =
@@ -1096,6 +1154,8 @@ private:
         Worker::instance->m_currentStep = step;
 
         switch (step) {
+        case UPDATE_STEP::NONE: {
+        } break;
         case UPDATE_STEP::STARTED:
         break;
         case UPDATE_STEP::CHECK_REPOSITORY:
@@ -1270,6 +1330,8 @@ private:
         break;
         case UPDATE_STEP::UPDATE_ACTIVATED:
         break;
+        case UPDATE_STEP::UPDATE_NOT_NECESSARY:
+        break;
         case UPDATE_STEP::UPDATE_FAILED:
             emit worker->appendText(QString("UPDATE "), UPDATE_STEP_FAIL);
         break;