SO_SNDTIMEO and SO_RCVTIMEO socket options have turned out not to be reliable.

Use select() for detecting timeout on socket (read and write).

ismas/ismas_client.cpp

@@ -137,7 +137,12 @@ IsmasClient::sendRequestReceiveResponse(int port, QString const &request) {
     so_linger.l_onoff = 1;
     so_linger.l_linger = 0;
 
+    int maxfdp1;
+    fd_set rset;
+    fd_set wset;
+
     setsockopt(sockfd, SOL_SOCKET, SO_LINGER, &so_linger, sizeof(so_linger));
+    // no reliable, but does not harm, as we use select() as well
     setsockopt(sockfd, SOL_SOCKET, SO_SNDTIMEO, &tv, sizeof(tv));
     setsockopt(sockfd, SOL_SOCKET, SO_RCVTIMEO, &tv, sizeof(tv));
     int flag = 1;
@@ -151,24 +156,56 @@ IsmasClient::sendRequestReceiveResponse(int port, QString const &request) {
     int loop = 0;
     int bytesWritten = 0;
     while (bytesWritten < bytesToWrite) {
-        int n = ::sendto(sockfd, buf+bytesWritten, bytesToWrite-bytesWritten, 0, NULL, 0);
+        errno = 0;
-        if (n >= 0) {
+        FD_ZERO(&wset);
-            bytesWritten += n;
+        FD_SET(sockfd, &wset);
-        } else {
+        maxfdp1 = sockfd + 1;
-            if (errno == EWOULDBLOCK) {
+        tv.tv_sec = 60;  /* 60 secs timeout for read and write -> APISM cuts the connection after 30s */
-                if (++loop < 10) {
+        tv.tv_usec = 0;
-                    QThread::msleep(500);
+
-                    continue;
+        int const w = select(maxfdp1, NULL, &wset, NULL, &tv);
-                }
+        if (w < 0) { // error
-                printErrorMessage(port, clientIP, clientPort,
-                    QString("WRITE TIMEOUT %1(").arg(loop) + strerror(errno) + ")");
-                ::close(sockfd);
-                return std::nullopt;
-            } else
             if (errno == EINTR) {
                 printErrorMessage(port, clientIP, clientPort,
-                    QString("WRITE INTERRUPTED BY SIGNAL (1) (") + strerror(errno) + ")");
+                    QString("INTERRUPTED BY SIGNAL (1) (") + strerror(errno) + ")");
                 continue;
+            } else {
+                printErrorMessage(port, clientIP, clientPort,
+                        QString("SELECT-ERROR (WRITE) %1(").arg(loop) + strerror(errno) + ")");
+                ::close(sockfd);
+                return std::nullopt;
+            }
+        } else
+        if (w == 0) { // timeout
+            printErrorMessage(port, clientIP, clientPort,
+                    QString("SELECT-TIMEOUT (WRITE) %1(").arg(loop) + strerror(errno) + ")");
+            if (++loop < 10) {
+                QThread::msleep(500);
+                continue;
+            }
+            ::close(sockfd);
+            return std::nullopt;
+        } else
+        if (w > 0) {
+            int n = ::sendto(sockfd, buf+bytesWritten, bytesToWrite-bytesWritten, 0, NULL, 0);
+            if (n >= 0) {
+                bytesWritten += n;
+            } else {
+                if (errno == EWOULDBLOCK) {
+                    if (++loop < 10) {
+                        QThread::msleep(500);
+                        continue;
+                    }
+                    printErrorMessage(port, clientIP, clientPort,
+                        QString("WRITE TIMEOUT %1(").arg(loop) + strerror(errno) + ")");
+                    ::close(sockfd);
+                    return std::nullopt;
+                } else
+                if (errno == EINTR) {
+                    printErrorMessage(port, clientIP, clientPort,
+                        QString("WRITE INTERRUPTED BY SIGNAL (1) (") + strerror(errno) + ")");
+                    continue;
+                }
             }
         }
     }
@@ -188,33 +225,66 @@ IsmasClient::sendRequestReceiveResponse(int port, QString const &request) {
     int bytesRead = 0;
     while (bytesRead < bytesToRead) {
         errno = 0;
-        int n = ::recvfrom(sockfd, buf+bytesRead, bytesToRead-bytesRead,
+        FD_ZERO(&rset);
-                           0, NULL, NULL);
+        FD_SET(sockfd, &rset);
-        if (n > 0) { //
+        maxfdp1 = sockfd + 1;
-            bytesRead += n;
+        tv.tv_sec = 60;  /* 60 secs timeout for read and write */
-        } else
+        tv.tv_usec = 0;
-        if (n == 0) {
+
-            // The return value will be 0 when the peer has performed an orderly shutdown.
+        int const r = select(maxfdp1, &rset, NULL, NULL, &tv);
-            printErrorMessage(port, clientIP, clientPort,
+        if (r < 0) { // error
-                QString("PEER CLOSED CONNECTION (") + strerror(errno) + ")");
-            ::close(sockfd);
-            return std::nullopt;
-        } else
-        if (n < 0) {
-            if (errno == EWOULDBLOCK) {
-                if (++loop < 10) {
-                    QThread::msleep(500);
-                    continue;
-                }
-                printErrorMessage(port, clientIP, clientPort,
-                        QString("READ TIMEOUT %1(").arg(loop) + strerror(errno) + ")");
-                ::close(sockfd);
-                return std::nullopt;
-            }
             if (errno == EINTR) {
                 printErrorMessage(port, clientIP, clientPort,
                     QString("INTERRUPTED BY SIGNAL (2) (") + strerror(errno) + ")");
                 continue;
+            } else {
+                printErrorMessage(port, clientIP, clientPort,
+                        QString("SELECT-ERROR (READ) %1(").arg(loop) + strerror(errno) + ")");
+                ::close(sockfd);
+                return std::nullopt;
+            }
+        } else
+        if (r == 0) { // timeout
+            printErrorMessage(port, clientIP, clientPort,
+                    QString("SELECT-TIMEOUT (READ) %1(").arg(loop) + strerror(errno) + ")");
+            if (++loop < 10) {
+                QThread::msleep(500);
+                continue;
+            }
+            ::close(sockfd);
+            return std::nullopt;
+        } else
+        if (r > 0) {
+            if (FD_ISSET(sockfd, &rset)) {
+                int n = ::recvfrom(sockfd, buf+bytesRead, bytesToRead-bytesRead,
+                                   0, NULL, NULL);
+                if (n > 0) { //
+                    bytesRead += n;
+                } else
+                if (n == 0) {
+                    // The return value will be 0 when the peer has performed an orderly shutdown.
+                    printErrorMessage(port, clientIP, clientPort,
+                        QString("PEER CLOSED CONNECTION (") + strerror(errno) + ")");
+                    ::close(sockfd);
+                    return std::nullopt;
+                } else
+                if (n < 0) {
+                    if (errno == EWOULDBLOCK) { // check just in case
+                        if (++loop < 10) {
+                            QThread::msleep(500);
+                            continue;
+                        }
+                        printErrorMessage(port, clientIP, clientPort,
+                                QString("READ TIMEOUT %1(").arg(loop) + strerror(errno) + ")");
+                        ::close(sockfd);
+                        return std::nullopt;
+                    }
+                    if (errno == EINTR) {
+                        printErrorMessage(port, clientIP, clientPort,
+                            QString("INTERRUPTED BY SIGNAL (2) (") + strerror(errno) + ")");
+                        continue;
+                    }
+                }
             }
         }
 

process/command.cpp

@@ -8,7 +8,8 @@ Command::Command(QString const &command, int start_timeout, int finish_timeout)
     : m_command(command.trimmed())
     , m_commandResult("")
     , m_waitForStartTimeout(start_timeout)
-    , m_waitForFinishTimeout(finish_timeout) {
+    , m_waitForFinishTimeout(finish_timeout)
+    , m_exitCode(-1) {
 }
 
 QString Command::getCommandResult() const {
@@ -62,7 +63,7 @@ bool Command::execute(QString workingDirectory, QStringList args) {
             if (p->waitForFinished(m_waitForFinishTimeout)) {
                 //qDebug() << "PROCESS" << m_command << "FINISHED";
                 if (p->exitStatus() == QProcess::NormalExit) {
-                    if (p->exitCode() == 0) {
+                    if ((m_exitCode = p->exitCode()) == 0) {
                         return true;
                     } else {
                         qCritical() << "EXECUTED" << m_command << "with code" << p->exitCode();

process/command.h

@@ -16,15 +16,17 @@ class Command : public QObject {
     QString m_commandResult;
     int m_waitForStartTimeout;
     int m_waitForFinishTimeout;
-
+    int m_exitCode;
 public:
     explicit Command(QString const &command,
                      int start_timeout = 100000,
                      int finish_timeout = 100000);
 
     QString getCommandResult() const;
+    QString command() const { return m_command; }
 
     bool execute(QString workingDirectory, QStringList args = QStringList());
+    int exitCode() const { return m_exitCode; }
 
 private slots:
     void readyReadStandardOutput();

worker.cpp

@@ -497,12 +497,14 @@ bool Worker::backendConnected() {
     return false;
 }
 
+#define CHECK_UPDATE_TRIGGER_SET "Check update trigger ..."
+
 bool Worker::updateTriggerSet() {
     if (m_withoutIsmasDirectPort) { // useful for testing
         return true;
     }
 
-    emit appendText("\nUpdate trigger set ...");
+    emit appendText("\n" CHECK_UPDATE_TRIGGER_SET);
     QString triggerValue("");
 
     for (int repeat = 0; repeat < 50; ++repeat) {
@@ -518,7 +520,7 @@ bool Worker::updateTriggerSet() {
 
             QString msg = result.value();
 
-            qInfo() << "REPEAT" << repeat << "APISM RESPONSE" << msg;
+            qInfo() << "REPEAT" << repeat << "APISM RESPONSE (" << msg << ")";
 
             QJsonParseError parseError;
             QJsonDocument document(QJsonDocument::fromJson(msg.toUtf8(), &parseError));
@@ -537,7 +539,7 @@ bool Worker::updateTriggerSet() {
                                                       m_updateStatus.m_statusDescription));
                 emit showErrorMessage("check update trigger",
                                       QString("invalid json ") + msg.mid(0, 20));
-                emit replaceLast("Update trigger set ...", UPDATE_STEP_FAIL);
+                emit replaceLast(CHECK_UPDATE_TRIGGER_SET, UPDATE_STEP_FAIL);
                 return false;
             }
             if (!document.isObject()) {
@@ -550,13 +552,25 @@ bool Worker::updateTriggerSet() {
                         m_ismasClient.jsonParseFailed(IsmasClient::RESULT_CODE::INSTALL_ERROR,
                                                       m_updateStatus.m_statusDescription));
                 emit showErrorMessage("check update trigger", QString("not a json object") + msg);
-                emit replaceLast("Update trigger set ...", UPDATE_STEP_FAIL);
+                emit replaceLast(CHECK_UPDATE_TRIGGER_SET, UPDATE_STEP_FAIL);
                 return false;
             }
             progress += 1;
             setProgress(progress);
 
             QJsonObject obj = document.object();
+
+            // always look for an 'error' first
+            if (obj.contains("error")) {
+                progress += 1;
+                setProgress(progress);
+                QString value = obj.value("error").toString();
+                emit showErrorMessage("check update trigger", QString("REPEAT %1 error=<").arg(repeat) + value + ">");
+                qInfo() << "REPEAT" << repeat << "In updateTriggerSet() error=<"
+                        << value << ">";
+                QThread::sleep(6);
+                continue;
+            }
             // sanity check: cust_nr and machine_nr of PSA correct ?
             // note: this check has to be done here, as the cust_nr and the machine_nr
             // of the PSA are sent by ISMAS.
@@ -579,7 +593,7 @@ bool Worker::updateTriggerSet() {
                                     m_ismasClient.sanityCheckFailed(IsmasClient::RESULT_CODE::INSTALL_ERROR,
                                                                     m_updateStatus.m_statusDescription));
                             emit showErrorMessage("check update trigger", m_updateStatus.m_statusDescription);
-                            emit replaceLast("Update trigger set ...", UPDATE_STEP_FAIL);
+                            emit replaceLast(CHECK_UPDATE_TRIGGER_SET, UPDATE_STEP_FAIL);
                             return false;
                         }
                         if (machineNr != m_machineNr) {
@@ -592,7 +606,7 @@ bool Worker::updateTriggerSet() {
                                     m_ismasClient.sanityCheckFailed(IsmasClient::RESULT_CODE::INSTALL_ERROR,
                                                                     m_updateStatus.m_statusDescription));
                             emit showErrorMessage("check update trigger", m_updateStatus.m_statusDescription);
-                            emit replaceLast("Update trigger set ...", UPDATE_STEP_FAIL);
+                            emit replaceLast(CHECK_UPDATE_TRIGGER_SET, UPDATE_STEP_FAIL);
                             return false;
                         }
 
@@ -607,7 +621,7 @@ bool Worker::updateTriggerSet() {
                                 m_ismasClient.sanityCheckFailed(IsmasClient::RESULT_CODE::INSTALL_ERROR,
                                                                 m_updateStatus.m_statusDescription));
                         emit showErrorMessage("check update trigger", m_updateStatus.m_statusDescription);
-                        emit replaceLast("Update trigger set ...", UPDATE_STEP_FAIL);
+                        emit replaceLast(CHECK_UPDATE_TRIGGER_SET, UPDATE_STEP_FAIL);
                         return false;
                     }
                 } else {
@@ -619,7 +633,7 @@ bool Worker::updateTriggerSet() {
                             m_ismasClient.sanityCheckFailed(IsmasClient::RESULT_CODE::INSTALL_ERROR,
                                                             m_updateStatus.m_statusDescription));
                     emit showErrorMessage("check update trigger", m_updateStatus.m_statusDescription);
-                    emit replaceLast("Update trigger set ...", UPDATE_STEP_FAIL);
+                    emit replaceLast(CHECK_UPDATE_TRIGGER_SET, UPDATE_STEP_FAIL);
                     return false;
                 }
             } else {
@@ -631,7 +645,7 @@ bool Worker::updateTriggerSet() {
                         m_ismasClient.sanityCheckFailed(IsmasClient::RESULT_CODE::INSTALL_ERROR,
                                                         m_updateStatus.m_statusDescription));
                 emit showErrorMessage("check update trigger", m_updateStatus.m_statusDescription);
-                emit replaceLast("Update trigger set ...", UPDATE_STEP_FAIL);
+                emit replaceLast(CHECK_UPDATE_TRIGGER_SET, UPDATE_STEP_FAIL);
                 return false;
             }
             progress += 1;
@@ -664,19 +678,28 @@ bool Worker::updateTriggerSet() {
                                 QString("#M=APISM#C=CMD_EVENT#J=") +
                                     m_ismasClient.updateTriggerSet(m_updateStatus.m_statusDescription, ""));
 
-                            emit replaceLast("Update trigger set ...", UPDATE_STEP_OK);
+                            emit replaceLast(CHECK_UPDATE_TRIGGER_SET, UPDATE_STEP_DONE);
                             return true;
+                        } else
+                        if (QRegExp("\\s*").exactMatch(triggerValue)) { // check for whitespace
+                            stopProgressLoop();
+                            int progress = (m_mainWindow->progressValue()/10) + 10;
+                            progress += 1;
+                            setProgress(progress);
+                            emit showErrorMessage("check update trigger", "empty update-trigger");
+                            QThread::sleep(6);
+                            continue;
                         } else {
                             // if the download-button once has the wrong value, it will never recover
                             setProgress(100);
                             m_updateStatus = UpdateStatus(UPDATE_STATUS::ISMAS_WAIT_STATE_CHECK_FAILURE,
-                                             QString("TRIGGER-VALUE ") + triggerValue + " NOT 'WAIT'");
+                                             QString("TRIGGER-VALUE=<") + triggerValue + "> NOT 'WAIT'");
                             IsmasClient::sendRequestReceiveResponse(IsmasClient::APISM::DB_PORT,
                                             QString("#M=APISM#C=CMD_EVENT#J=") +
                                                 m_ismasClient.sanityCheckFailed(IsmasClient::RESULT_CODE::INSTALL_ERROR,
                                                                                 m_updateStatus.m_statusDescription));
                             emit showErrorMessage("check update trigger", m_updateStatus.m_statusDescription);
-                            emit replaceLast("Update trigger set ...", UPDATE_STEP_FAIL);
+                            emit replaceLast(CHECK_UPDATE_TRIGGER_SET, UPDATE_STEP_FAIL);
                             return false;
                         }
                     } else {
@@ -687,7 +710,7 @@ bool Worker::updateTriggerSet() {
                             QString("#M=APISM#C=CMD_EVENT#J=") +
                         m_ismasClient.sanityCheckFailed(IsmasClient::RESULT_CODE::INSTALL_ERROR,
                                                         m_updateStatus.m_statusDescription));
-                        emit replaceLast("Update trigger set ...", UPDATE_STEP_FAIL);
+                        emit replaceLast(CHECK_UPDATE_TRIGGER_SET, UPDATE_STEP_FAIL);
                         emit showErrorMessage("check update trigger", m_updateStatus.m_statusDescription);
                         return false;
                     }
@@ -699,7 +722,7 @@ bool Worker::updateTriggerSet() {
                         QString("#M=APISM#C=CMD_EVENT#J=") +
                     m_ismasClient.sanityCheckFailed(IsmasClient::RESULT_CODE::INSTALL_ERROR,
                                                     m_updateStatus.m_statusDescription));
-                    emit replaceLast("Update trigger set ...", UPDATE_STEP_FAIL);
+                    emit replaceLast(CHECK_UPDATE_TRIGGER_SET, UPDATE_STEP_FAIL);
                     emit showErrorMessage("check update trigger", m_updateStatus.m_statusDescription);
                     return false;
                 }
@@ -711,20 +734,10 @@ bool Worker::updateTriggerSet() {
                     QString("#M=APISM#C=CMD_EVENT#J=") +
                         m_ismasClient.sanityCheckFailed(IsmasClient::RESULT_CODE::INSTALL_ERROR,
                                                         m_updateStatus.m_statusDescription));
-                emit replaceLast("Update trigger set ...", UPDATE_STEP_FAIL);
+                emit replaceLast(CHECK_UPDATE_TRIGGER_SET, UPDATE_STEP_FAIL);
                 emit showErrorMessage("check update trigger", m_updateStatus.m_statusDescription);
                 return false;
             }
-
-            if (obj.contains("error")) {
-                progress += 1;
-                setProgress(progress);
-                QString value = obj.value("error").toString();
-                emit showErrorMessage("check update trigger", QString("REPEAT %1 error=<").arg(repeat) + value + ">");
-                qInfo() << "REPEAT" << repeat << "In updateTriggerSet() error=<"
-                        << value << ">";
-                QThread::sleep(6);
-            }
         } else {
             stopProgressLoop();
             int progress = (m_mainWindow->progressValue()/10) + 10;
@@ -743,7 +756,7 @@ bool Worker::updateTriggerSet() {
         QString("#M=APISM#C=CMD_EVENT#J=") +
             m_ismasClient.errorUpdateTrigger(m_updateStatus.m_statusDescription, ""));
 
-    emit replaceLast("Update trigger set ...", UPDATE_STEP_OK);
+    emit replaceLast(CHECK_UPDATE_TRIGGER_SET, UPDATE_STEP_FAIL);
     return false;
 }
 
@@ -919,10 +932,16 @@ bool Worker::updateFiles(quint8 percent) {
 }
 
 bool Worker::syncCustomerRepositoryAndFS() {
+    // this step is currently needed only for updating tariff-files
     setProgress(0);
     emit appendText("\nSync customer environment with filesystem ...");
     if (QDir(m_customerRepository).exists()) {
         if (QDir::setCurrent(m_customerRepository)) {
+            Command md("bash");
+            if (!md.execute(m_customerRepository,
+                            QStringList() << "-c" << "mkdir -p /etc/psa_config /etc/psa_update /etc/dc /etc/psa_tariff")) {
+                qCritical() << "COULD NOT EXECUTE '" << md.command() << "' exitCode=(" << md.exitCode() << ")";
+            }
             int progress = 10;
             setProgress(progress);
             QString const params("-vv                     "
@@ -953,7 +972,7 @@ bool Worker::syncCustomerRepositoryAndFS() {
                         }
                     } else {
                         Utils::printCriticalErrorMsg(QString("CMD ") + cmd + " FAILED: "
-                                                   + c.getCommandResult());
+                                                   + c.getCommandResult() + QString(" EXIT_CODE=(%1)").arg(c.exitCode()));
                         error = true;
                     }
                 }