Use head -n 1 in gitLastCommit().

Yield thread to give worker thread its share of CPU time.

git/git_client.cpp

@@ -48,8 +48,7 @@ bool GitClient::gitCloneCustomerRepository() {
                 }
             }
         }
-        qCritical() << "ERROR CLONE RESULT HAS WRONG FORMAT. CLONE_RESULT="
-                    << result;
+        Utils::printCriticalErrorMsg(QString("ERROR CLONE RESULT HAS WRONG FORMAT. CLONE_RESULT=") + result);
     }
     return false;
 }
@@ -96,7 +95,7 @@ bool GitClient::gitCheckoutBranch() {
         Command c(gitCommand);
         return c.execute(m_customerRepository); // execute command in customerRepo
     }
-    qCritical() << "ERROR" << m_customerRepository << "DOES NOT EXIST";
+    Utils::printCriticalErrorMsg(QString("ERROR ") + m_customerRepository + " DOES NOT EXIST");
     return false;
 }
 
@@ -108,13 +107,10 @@ bool GitClient::gitCloneAndCheckoutBranch() {
                 return true;
             } else {
                 // TODO
-                // m_worker->terminateUpdateProcess();
             }
         //}
-    } else {
-        // TODO
-        //m_worker->terminateUpdateProcess();
     }
+    Utils::printCriticalErrorMsg(QString("CLONE ") + m_repositoryPath + " AND CHECKOUT FAILED");
     return false;
 }
 
@@ -131,24 +127,37 @@ std::optional<QStringList> GitClient::gitDiff(QString const &commits) {
         Command c(gitCommand);
         if (c.execute(m_customerRepository)) { // execute command in local customerRepo
             QString s = c.getCommandResult().trimmed();
+            Utils::printInfoMsg("GIT DIFF RESULT " + s);
+
             QStringList lines = Update::split(s, '\n');
             QStringList fileNames;
             // each line has the format "etc/psa_config/DC2C_print01.json | 1 +
             // or the format            "etc/psa_config/DC2C_print01.json (new) | 1 +
             // the filenames are relativ to the repository
             for (int i = 0; i < lines.size(); ++i) {
-                // TODO: koennte auch (delete) kommen ?
-                int newIndex = lines.at(i).indexOf("(new)");    // for new files
-                // int goneIndex = lines.at(i).indexOf("(gone)");  // for removed files
+                QString const &line = lines.at(i);
+                int newIndex = line.indexOf("(new");    // for new files
+                int goneIndex = line.indexOf("(gone");  // for removed files
+                int modeIndex = line.indexOf("(mode");
+                int pipeIndex = line.indexOf('|');
                 if (newIndex != -1) {
-                    QString fileName = lines.at(i).mid(0, newIndex).trimmed();
-                    fileNames << fileName;
-                } else {
-                    int pipeIndex = lines.at(i).indexOf('|');
+                    QString file = line.left(newIndex).trimmed();
+                    qInfo() << "FILE (NEW)" << file;
+                    fileNames << file;
+                } else
+                if (modeIndex != -1) {
+                    QString const file = line.left(modeIndex).trimmed();
+                    qInfo() << "FILE (MODE)" << file;
+                    fileNames << file;
+                } else
+                if (goneIndex != -1) {
+                    QString const file = line.left(goneIndex).trimmed();
+                    qCritical() << "FILE (GONE)" << file;
+                } else
                 if (pipeIndex != -1) {
-                        QString fileName = lines.at(i).mid(0, pipeIndex).trimmed();
-                        fileNames << fileName;
-                    }
+                    QString const file = line.left(pipeIndex).trimmed();
+                    qInfo() << "FILE (PIPE)" << file;
+                    fileNames << file;
                 }
             }
             if (!fileNames.isEmpty()) {
@@ -164,8 +173,7 @@ std::optional<QStringList> GitClient::gitDiff(QString const &commits) {
  */
 std::optional<QString> GitClient::gitFetch() {
     if (QDir(m_customerRepository).exists()) {
-
-        qCritical() << "BRANCH NAME" << m_branchName;
+        qInfo() << "BRANCH NAME" << m_branchName;
 
         Command c("git fetch");
         if (c.execute(m_customerRepository)) {
@@ -198,26 +206,29 @@ std::optional<QString> GitClient::gitFetch() {
                                 }
                             } else {
                                 emit m_worker->showErrorMessage("git fetch",
-                                    "regex-match for commits");
+                                    "no regex-match for commits");
+                                Utils::printCriticalErrorMsg("NO REGEX MATCH FOR COMMITS");
                             }
                         }
                     }
                     if (!found) {
                         emit m_worker->showErrorMessage("git fetch",
                             QString("unkown branch name ") + m_branchName);
+                        Utils::printCriticalErrorMsg("UNKNOWN BRANCH NAME " + m_branchName);
                     }
                 } else {
                     emit m_worker->showErrorMessage("git fetch",
                         QString("wrong format for result of 'git fetch' ") + s);
+                    Utils::printCriticalErrorMsg(QString("WRONG FORMAT FOR RESULT OF 'GIT FETCH' ") + s);
                 }
             } else {
-                emit m_worker->showErrorMessage("git fetch",
-                    "empty result for 'git fetch'");
+                emit m_worker->showErrorMessage("git fetch", "empty result for 'git fetch'");
+                Utils::printCriticalErrorMsg("EMPTY RESULT FOR 'GIT FETCH'");
             }
         }
     } else {
-        emit m_worker->showErrorMessage("git fetch",
-            QString("repository ") + m_customerRepository + " does not exist");
+        emit m_worker->showErrorMessage("git fetch", QString("repository ") + m_customerRepository + " does not exist");
+        Utils::printCriticalErrorMsg(QString("REPOSITORY ") + m_customerRepository + " DOES NOT EXIST");
     }
     return std::nullopt;
 }
@@ -238,7 +249,7 @@ bool GitClient::gitPull() {
             qInfo() << "PULLED INTO" << m_customerRepository;
             return true;
         }
-        qCritical() << "PULL INTO" << m_customerRepository << "FAILED";
+        Utils::printCriticalErrorMsg(QString("PULL INTO " + m_customerRepository + " FAILED"));
     }
     return false;
 }
@@ -257,6 +268,7 @@ QString GitClient::gitLastCommit(QString fileName) {
     if (QDir(m_customerRepository).exists()) {
         QString const filePath
             = QDir::cleanPath(m_customerRepository + QDir::separator() + fileName);
+        if (QFile(filePath).exists()) {
             QString const gitCommand = QString("git log %1 | head -n 1").arg(fileName);
             Command c("bash");
             if (c.execute(m_customerRepository, QStringList() << "-c" << gitCommand)) {
@@ -267,6 +279,7 @@ QString GitClient::gitLastCommit(QString fileName) {
                 }
             }
         }
+    }
     return "";
 }
 

ismas/ismas_client.cpp

@@ -148,6 +148,7 @@ IsmasClient::sendRequestReceiveResponse(int port, QString const &request) {
     int const bytesToWrite = strlen(request.toStdString().c_str());
     strncpy(buf, request.toStdString().c_str(), sizeof(buf)-1);
 
+    int loop = 0;
     int bytesWritten = 0;
     while (bytesWritten < bytesToWrite) {
         int n = ::sendto(sockfd, buf+bytesWritten, bytesToWrite-bytesWritten, 0, NULL, 0);
@@ -155,14 +156,18 @@ IsmasClient::sendRequestReceiveResponse(int port, QString const &request) {
             bytesWritten += n;
         } else {
             if (errno == EWOULDBLOCK) {
+                if (++loop < 10) {
+                    QThread::msleep(500);
+                    continue;
+                }
                 printErrorMessage(port, clientIP, clientPort,
-                    QString("TIMEOUT  (") + strerror(errno) + ")");
+                    QString("WRITE TIMEOUT %1(").arg(loop) + strerror(errno) + ")");
                 ::close(sockfd);
                 return std::nullopt;
             } else
             if (errno == EINTR) {
                 printErrorMessage(port, clientIP, clientPort,
-                    QString("INTERRUPTED BY SIGNAL (1) (") + strerror(errno) + ")");
+                    QString("WRITE INTERRUPTED BY SIGNAL (1) (") + strerror(errno) + ")");
                 continue;
             }
         }
@@ -177,6 +182,7 @@ IsmasClient::sendRequestReceiveResponse(int port, QString const &request) {
 
     printInfoMessage(port, clientIP, clientPort, QString("MESSAGE SENT ") + buf);
 
+    loop = 0;
     bzero(buf, sizeof(buf));
     int bytesToRead = sizeof(buf)-1;
     int bytesRead = 0;
@@ -196,8 +202,12 @@ IsmasClient::sendRequestReceiveResponse(int port, QString const &request) {
         } else
         if (n < 0) {
             if (errno == EWOULDBLOCK) {
+                if (++loop < 10) {
+                    QThread::msleep(500);
+                    continue;
+                }
                 printErrorMessage(port, clientIP, clientPort,
-                        QString("TIMEOUT  (") + strerror(errno) + ")");
+                        QString("READ TIMEOUT %1(").arg(loop) + strerror(errno) + ")");
                 ::close(sockfd);
                 return std::nullopt;
             }
@@ -214,8 +224,8 @@ IsmasClient::sendRequestReceiveResponse(int port, QString const &request) {
         if (int idx = response.indexOf("{\"error\":\"ISMAS is offline\"}")) {
             response = response.mid(0, idx);
         } else
-        if (response == "RECORD SAVED") {
-            printInfoMessage(port, clientIP, clientPort, "IGNORED 'RECORD SAVED' RESPONSE");
+        if (response.contains("RECORD")) { // RECORD SAVED or RECORD WRITE ABORTED
+            printInfoMessage(port, clientIP, clientPort, QString("IGNORED '") + response + "' RESPONSE");
             ::close(sockfd);
             return std::nullopt;
         }
@@ -283,6 +293,15 @@ QString IsmasClient::errorBackendNotConnected(QString const &info,
                              version.toStdString().c_str());
 }
 
+QString IsmasClient::errorGitClone(int percent, QString const &info, QString const &version) {
+    return updateNewsToIsmas("U0003",
+                             percent,
+                             RESULT_CODE::INSTALL_ERROR,
+                             "CLONE CUSTOMER REPOSITORY FAILED",
+                             info.toStdString().c_str(),
+                             version.toStdString().c_str());
+}
+
 QString IsmasClient::backendConnected(QString const &info, QString const &version) {
     return updateNewsToIsmas("U0010",
                              m_progressInPercent,
@@ -734,11 +753,21 @@ QString IsmasClient::sanityCheckFailed(int resultCode, QString reason, QString c
                              version.toStdString().c_str());
 }
 
-QString IsmasClient::updateOfPSAFailed(int resultCode, QString reason, QString const &version) {
+QString IsmasClient::jsonParseFailed(int resultCode, QString reason, QString const &version) {
     return updateNewsToIsmas("U0003",
                              m_progressInPercent,
                              resultCode,
-                             "UPDATE ERROR",
+                             "JSON-PARSE-ERROR",
+                             reason.toStdString().c_str(),
+                             version.toStdString().c_str());
+}
+
+QString IsmasClient::updateOfPSAFailed(int resultCode, QString step,
+                                       QString reason, QString const &version) {
+    return updateNewsToIsmas("U0003",
+                             m_progressInPercent,
+                             resultCode,
+                             step.toStdString().c_str(),
                              reason.toStdString().c_str(),
                              version.toStdString().c_str());
 }

ismas/ismas_client.h

@@ -12,6 +12,7 @@ struct PSAInstalled {
         int zone;
         int size;
         QString blob;
+        QString lastCommit;
         QString info;
         QString loadTime;
     } tariff;
@@ -144,6 +145,7 @@ public:
     QString cloneAndCheckoutCustomerRepository(QString const &info, QString const &version = QString());   // clone and checkout customer repository
     QString checkoutBranch(QString const &info, QString const &version = QString());   // checkout branch
     QString errorBackendNotConnected(QString const &info, QString const &version = QString());   // checkout branch
+    QString errorGitClone(int percent, QString const &info, QString const &version = QString());
     QString backendConnected(QString const &info, QString const &version = QString());
     QString updateTriggerSet(QString const &info, QString const &version = QString());
     QString errorUpdateTrigger(QString const &info, QString const &version = QString());
@@ -154,8 +156,9 @@ public:
                                     // and update accepted
     QString updateOfPSASucceeded(QString const &version = QString()); // update process succeeded
     QString updateOfPSAContinues(QString currentStage, QString currentStageInfo, QString const &version = QString());
-    QString updateOfPSAFailed(int resultCode, QString reason, QString const &version = QString());
+    QString updateOfPSAFailed(int resultCode, QString step, QString reason, QString const &version = QString());
     QString sanityCheckFailed(int resultCode, QString reason, QString const &version = QString());
+    QString jsonParseFailed(int resultCode, QString reason, QString const &version = QString());
 
     QString updateOfPSASendVersion(PSAInstalled const &psa);
 

mainwindow.cpp

@@ -32,26 +32,16 @@ MainWindow::MainWindow(Worker *worker, QWidget *parent)
     ui->updateStatus->setText(lst.join('\n'));
     ui->updateStatus->setEnabled(true);
 
-    ui->reserved_1->setVisible(false);
-    ui->reserved_2->setVisible(false);
-    ui->reserved_3->setVisible(false);
-    ui->reserved_4->setVisible(false);
-    ui->reserved_5->setVisible(false);
-    ui->reserved_6->setVisible(false);
-
     m_startTimer = new QTimer(this);
-    connect(m_startTimer, SIGNAL(timeout()), ui->start, SLOT(click()));
+    connect(m_startTimer, SIGNAL(timeout()), m_worker, SLOT(update()));
     m_startTimer->setSingleShot(true);
-    m_startTimer->start(5 * 1000);
+    m_startTimer->start(1000);
 
     m_exitTimer = new QTimer(this);
     connect(m_exitTimer, SIGNAL(timeout()), ui->exit, SLOT(click()));
     m_exitTimer->setSingleShot(true);
     m_exitTimer->start(1800 * 1000);
 
-    connect(m_startTimer, SIGNAL(timeout()), ui->start, SLOT(click()));
-    connect(m_exitTimer, SIGNAL(timeout()), ui->exit, SLOT(click()));
-    connect(ui->start, SIGNAL(clicked()), m_worker, SLOT(update()));
     connect(ui->exit, SIGNAL(clicked()), this, SLOT(onQuit()));
     connect(m_worker, SIGNAL(disableExit()), this, SLOT(onDisableExit()));
     connect(m_worker, SIGNAL(enableExit()), this, SLOT(onEnableExit()));
@@ -97,7 +87,7 @@ void MainWindow::customEvent(QEvent *event) {
                         m_progressValue = progress;
                         ui->updateProgress->setValue(progress/10);
                         QApplication::postEvent(this, new ProgressEvent(this, progress+10));
-                        QThread::msleep(100);
+                        QThread::msleep(500);
                     }
                 }
             }
@@ -120,6 +110,8 @@ void MainWindow::customEvent(QEvent *event) {
             qCritical() << "!!! UNKNOWN SENDER !!!";
         }
     }
+
+    QThread::yieldCurrentThread();
 }
 
 void MainWindow::onStopStartTimer() {
@@ -136,7 +128,7 @@ void MainWindow::onEnableExit() {
 
 void MainWindow::onRestartExitTimer() {
     m_exitTimer->stop();
-    m_exitTimer->start(10 * 1000);
+    m_exitTimer->start(60 * 1000);
 }
 
 void MainWindow::onQuit() {
@@ -147,39 +139,59 @@ void MainWindow::onQuit() {
 
 void MainWindow::onAppendText(QString text, QString suffix) {
     QString editText = ui->updateStatus->toPlainText();
-    if (suffix.size() > 0) {
+    if (!suffix.isNull() && suffix.size() > 0) {
+        qInfo() << "TEXT" << text << "SUFFIX" << suffix;
+        if (suffix == Worker::UPDATE_STEP_SUCCESS || suffix == Worker::UPDATE_STEP_FAIL) {
             editText += QString("\n").leftJustified(m_width-3, '=');
             editText += " ";
+        }
         editText += (QString("\n") + text).leftJustified(m_width - (2 + suffix.size()) ) + suffix;
     } else {
         editText += text.leftJustified(m_width-9);
     }
 
-    QStringList lines = editText.split('\n');
-    for (int i=0; i<lines.size(); ++i) {
-        qDebug() << lines.at(i);
-    } qDebug() << ""; qDebug() << "";
+    Utils::printLineEditInfo(editText.split('\n'));
 
-    ui->updateStatus->setPlainText(editText);
+    ui->updateStatus->setPlainText(editText.trimmed());
     ui->updateStatus->setEnabled(true);
 }
 
 void MainWindow::onReplaceLast(QString text, QString suffix) {
+        qInfo() << "REPL TEXT" << text << "SUFFIX" << suffix;
+
     QString editText = ui->updateStatus->toPlainText();
     QStringList lines = editText.split('\n');
     if (lines.size() > 0) {
         lines.removeLast();
+        if (!suffix.isNull() && suffix.size() > 0 && suffix != "\n") {
             lines += text.leftJustified(m_width-10) + suffix;
+        } else {
+            lines += text.leftJustified(m_width-10);
+        }
     }
 
-    for (int i=0; i<lines.size(); ++i) {
-        qDebug() << lines.at(i);
-    } qDebug() << ""; qDebug() << "";
+    Utils::printLineEditInfo(lines);
 
-    ui->updateStatus->setText(lines.join('\n'));
+    ui->updateStatus->setText(lines.join('\n').trimmed());
     ui->updateStatus->setEnabled(true);
 }
 
 void MainWindow::onShowErrorMessage(QString title, QString text) {
-    QMessageBox::critical(this, title, text, QMessageBox::Ok);
+    text = text.leftJustified(50, ' ');
+    QMessageBox msgBox(QMessageBox::NoIcon, title,
+                       text, QMessageBox::Ok,
+                       nullptr, Qt::FramelessWindowHint);
+    msgBox.setDefaultButton(QMessageBox::Ok);
+    msgBox.defaultButton()->setVisible(false);
+
+    QTimer *t = new QTimer(this);
+    connect(t, SIGNAL(timeout()), msgBox.defaultButton(), SLOT(click()));
+    t->setSingleShot(true);
+    t->start(5 * 1000);
+
+    if(msgBox.exec() == QMessageBox::Ok) {
+      // do something
+    } else {
+      // do something else
+    }
 }

mainwindow.h

@@ -27,7 +27,7 @@ public:
 
 public slots:
     void onAppendText(QString, QString suffix = "");
-    void onReplaceLast(QString, QString);
+    void onReplaceLast(QString, QString suffix = "");
     void onShowErrorMessage(QString, QString);
     void onStopStartTimer();
     void onRestartExitTimer();

mainwindow.ui

@@ -22,114 +22,41 @@
    <widget class="QWidget" name="layoutWidget">
     <property name="geometry">
      <rect>
-      <x>11</x>
-      <y>11</y>
+      <x>10</x>
+      <y>10</y>
       <width>781</width>
       <height>461</height>
      </rect>
     </property>
     <layout class="QGridLayout" name="gridLayout">
-     <item row="2" column="0">
-      <widget class="QPushButton" name="start">
-       <property name="font">
-        <font>
-         <family>Terminus</family>
-        </font>
-       </property>
-       <property name="text">
-        <string>Start</string>
-       </property>
-      </widget>
-     </item>
-     <item row="2" column="1">
+     <item row="3" column="2">
       <widget class="QPushButton" name="exit">
        <property name="text">
         <string>Exit</string>
        </property>
       </widget>
      </item>
-     <item row="2" column="2">
-      <widget class="QPushButton" name="reserved_1">
-       <property name="enabled">
-        <bool>false</bool>
-       </property>
-       <property name="text">
-        <string/>
-       </property>
-      </widget>
-     </item>
-     <item row="2" column="3">
-      <widget class="QPushButton" name="reserved_2">
-       <property name="enabled">
-        <bool>false</bool>
-       </property>
-       <property name="text">
-        <string/>
-       </property>
-      </widget>
-     </item>
-     <item row="2" column="4">
-      <widget class="QPushButton" name="reserved_3">
-       <property name="enabled">
-        <bool>false</bool>
-       </property>
-       <property name="text">
-        <string/>
-       </property>
-      </widget>
-     </item>
-     <item row="2" column="5">
-      <widget class="QPushButton" name="reserved_4">
-       <property name="enabled">
-        <bool>false</bool>
-       </property>
-       <property name="text">
-        <string/>
-       </property>
-      </widget>
-     </item>
-     <item row="2" column="6">
-      <widget class="QPushButton" name="reserved_6">
-       <property name="enabled">
-        <bool>false</bool>
-       </property>
-       <property name="text">
-        <string/>
-       </property>
-      </widget>
-     </item>
-     <item row="2" column="7">
-      <widget class="QPushButton" name="reserved_5">
-       <property name="enabled">
-        <bool>false</bool>
-       </property>
-       <property name="text">
-        <string/>
-       </property>
-      </widget>
-     </item>
-     <item row="0" column="0" colspan="8">
-      <widget class="QTextEdit" name="updateStatus">
-       <property name="enabled">
-        <bool>false</bool>
-       </property>
-       <property name="font">
-        <font>
-         <family>Monospace</family>
-         <pointsize>14</pointsize>
-         <weight>75</weight>
-         <bold>true</bold>
-        </font>
-       </property>
-      </widget>
-     </item>
-     <item row="1" column="0" colspan="8">
+     <item row="3" column="1">
       <widget class="QProgressBar" name="updateProgress">
        <property name="value">
         <number>1</number>
        </property>
       </widget>
      </item>
+     <item row="0" column="0" rowspan="3" colspan="3">
+      <widget class="QTextEdit" name="updateStatus">
+       <property name="enabled">
+        <bool>true</bool>
+       </property>
+       <property name="font">
+        <font>
+         <family>Misc Fixed</family>
+         <pointsize>11</pointsize>
+         <bold>true</bold>
+        </font>
+       </property>
+      </widget>
+     </item>
     </layout>
    </widget>
   </widget>

update.cpp

@@ -8,6 +8,7 @@
 #include <QDebug>
 #include <QTextStream>
 #include <QRegularExpression>
+#include <QRegExp>
 
 //#include <iostream>
 //#include <fstream>
@@ -350,21 +351,25 @@ bool Update::downloadBinaryToDC(QString const &bFile) const {
  10 :   bl_stopBL()     // leave bl and start (the new) application
  */
 bool Update::updateBinary(char const *fileToSendToDC) {
-    qInfo() << "updating device controller binary" << fileToSendToDC;
+    qInfo() << "UPDATING DEVICE CONTROLLER BINARY" << fileToSendToDC;
     QFile fn(fileToSendToDC);
     bool r;
     if ((r = fn.exists()) == true) {
-        QString const linkTarget = fn.symLinkTarget();
-        QFileInfo fi(linkTarget);
-        qInfo() << "      updating binary (size=" << linkTarget << fi.size() << ")";
-        if ((r = updateDC(linkTarget)) == true) {
-            qInfo() << "     updating binary (size=" << linkTarget << fi.size() << ") done";
+        QFileInfo fi(fn);
+        qInfo() << "      UPDATING BINARY" << fi.fileName() << "(size=" << fi.size() << ")";
+        if ((r = updateDC(fileToSendToDC)) == true) {
+            qCritical() << QString(80, '*');
+            qInfo() << "      UPDATING BINARY" << fi.fileName() << "(size=" << fi.size() << ") DONE";
+            qCritical() << QString(80, '*');
         } else {
-            qCritical() << "updating binary (size=" << linkTarget << fi.size() << ")... FAILED";
+            qCritical() << QString(80, '*');
+            qCritical() << "      UPDATING BINARY" << fi.fileName() << "(size=" << fi.size() << ") FAILED";
+            qCritical() << QString(80, '*');
         }
     } else {
-        qCritical() << "symlink" << fileToSendToDC
-                    << "does not exist -> NO UPDATE OF DC FIRMWARE";
+        qCritical() << QString(80, '*');
+        qCritical() << fileToSendToDC << "does not exist -> NO UPDATE OF DC FIRMWARE";
+        qCritical() << QString(80, '*');
     }
     return r;
 }
@@ -514,7 +519,6 @@ void Update::finished(int /*exitCode*/, QProcess::ExitStatus /*exitStatus*/) {
 }
 
 bool Update::doUpdate(int &displayIndex, QStringList const &filesToWorkOn) {
-
     //
     // ACHTUNG !!!
     //
@@ -523,11 +527,6 @@ bool Update::doUpdate(int &displayIndex, QStringList const &filesToWorkOn) {
     bool serialOpened = false;
     bool serialOpen = false;
 
-    if (filesToWorkOn.size() == 0) {
-        qCritical() << "NOTHING TO UPDATE";
-        return true;
-    }
-
     if (!serialOpen) {
         if (!isSerialOpen()) { // open serial only if not already open
             if ((serialOpened = openSerial(baudrateMap.value(m_baudrate), m_baudrate, m_serialInterface)) == false) {
@@ -537,18 +536,23 @@ bool Update::doUpdate(int &displayIndex, QStringList const &filesToWorkOn) {
             }
         }
         serialOpen = true;
-        qCritical() << "SERIAL OPEN" << m_serialInterface << "(BAUDRATE=" << m_baudrate << ")";
+        qInfo() << "SERIAL OPEN" << m_serialInterface << "(BAUDRATE=" << m_baudrate << ")";
     }
 
+    bool res = false;
     QList<QString>::const_iterator it;
     for (it = filesToWorkOn.cbegin(); it != filesToWorkOn.cend(); ++it) {
-        bool res = false;
+        m_worker->startProgressLoop();
         QString fToWorkOn = (*it).trimmed();
+        fToWorkOn = QDir::cleanPath(m_customerRepository + QDir::separator() + fToWorkOn);
 
-        if (fToWorkOn.contains("dc2c", Qt::CaseInsensitive) &&
-            fToWorkOn.endsWith(".bin", Qt::CaseInsensitive)) {
+        static const QRegularExpression version("^.*dc2c[.][0-9][0-9][.][0-9][0-9][.]bin.*$");
+        if (fToWorkOn.contains(version)) {
+
+            qInfo() << QString(80, '*');
+            qInfo() << "DO-UPDATE FILE-TO-WORK-ON" << fToWorkOn;
+            qInfo() << QString(80, '*');
 
-            qDebug() << "sending sw/hw-requests...";
             for (int i=0; i < 3; ++i) { // send explicit reuests to get
                                         // current SW/HW-versions
                 m_hw->request_DC2_SWversion();
@@ -558,12 +562,16 @@ bool Update::doUpdate(int &displayIndex, QStringList const &filesToWorkOn) {
 
             QString const hwVersion = m_hw->dc_getHWversion().toLower();
             QString const fwVersion = m_hw->dc_getSWversion().toLower();
+
             qInfo() << "current dc-hardware-version" << hwVersion;
             qInfo() << "current dc-firmware-version" << fwVersion;
 
             QFile fn(fToWorkOn);
-            QFileInfo linkTarget(fn.symLinkTarget());
-            if (!linkTarget.exists()) { // check for broken link
+            QFileInfo finfo(fn);
+            if (!fn.exists()) { // check for broken link
+                qCritical() << QString(80, '*');
+                qCritical() << "FILE-TO-WORK-ON" << fn << "DOES NOT EXIST";
+                qCritical() << QString(80, '*');
                 res = false;
             } else {
                 if (false) {
@@ -574,13 +582,12 @@ bool Update::doUpdate(int &displayIndex, QStringList const &filesToWorkOn) {
                 } else {
                     res = true;
 
-                    qCritical() << "downloading" << fToWorkOn.trimmed() << "->"
-                                << linkTarget.completeBaseName() << "to DC";
+                    qInfo() << "DOWNLOADING" << finfo.completeBaseName() << "TO DC";
 #if UPDATE_DC == 1
                     m_hw->dc_autoRequest(false);// default: turn auto-request setting off
                     QThread::sleep(1);          // wait to be sure that there are no more
                                                 // commands sent to dc-hardware
-                    qDebug() << "SET AUTO-REQUEST=FALSE";
+                    qInfo() << "SET AUTO-REQUEST=FALSE";
 
                     if ((res = updateBinary(fToWorkOn.toStdString().c_str())) == true) {
                         qCritical() << "downloaded binary" << fToWorkOn;
@@ -591,13 +598,13 @@ bool Update::doUpdate(int &displayIndex, QStringList const &filesToWorkOn) {
                     }
 
                     m_hw->dc_autoRequest(true); // turn auto-request setting on
-                    qDebug() << "SET AUTO-REQUEST=TRUE";
-                    qDebug() << "WAIT 10 SECS TO RECEIVE RESPONSES...";
+                    qInfo() << "SET AUTO-REQUEST=TRUE";
+                    qInfo() << "WAIT 10 SECS TO RECEIVE RESPONSES...";
 
                     QThread::sleep(10); // wait to be sure that responses
                                         // have been received
-                    qCritical() << "updated dc-hardware-version" << m_hw->dc_getHWversion();
-                    qCritical() << "updated dc-firmware-version" << m_hw->dc_getSWversion();
+                    qInfo() << "updated dc-hardware-version" << m_hw->dc_getHWversion();
+                    qInfo() << "updated dc-firmware-version" << m_hw->dc_getSWversion();
 #endif
                 }
             }
@@ -660,10 +667,16 @@ bool Update::doUpdate(int &displayIndex, QStringList const &filesToWorkOn) {
             qCritical() << "UNKNOWN JSON FILE NAME" << fToWorkOn;
             res = false;
         }
+        m_worker->stopProgressLoop();
+        m_worker->setProgress(100);
+
+        if (res == false) {
+            break;
+        }
     } // for (it = openLines.cbegin(); it != openLines.end(); ++it) {
 
     m_hw->dc_autoRequest(true);  // ALWAYS turn autoRequest ON
     qDebug() << "SET AUTO-REQUEST=TRUE";
 
-    return true;
+    return res;
 }

utils.cpp

@@ -1,8 +1,9 @@
 #include "utils.h"
+#include "message_handler.h"
 
 #include <QFile>
 #include <QTextStream>
-
+#include <QDebug>
 
 int Utils::read1stLineOfFile(QString fileName) {
     QFile f(fileName);
@@ -33,3 +34,46 @@ QString Utils::zoneName(quint8 i) {
     }
     return "N/A";
 }
+
+void Utils::printCriticalErrorMsg(QString const &errorMsg) {
+    qCritical() << QString(80, '!');
+    qCritical() << errorMsg;
+    qCritical() << QString(80, '!');
+}
+
+void Utils::printInfoMsg(QString const &infoMsg) {
+    qCritical() << QString(80, '=');
+    qCritical() << infoMsg;
+    qCritical() << QString(80, '=');
+
+}
+
+void Utils::printLineEditInfo(QStringList const &lines) {
+    if (getDebugLevel() == LOG_DEBUG) {
+        for (int i=0; i<lines.size(); ++i) {
+            qInfo() << lines.at(i);
+        } qInfo() << ""; qInfo() << "";
+    }
+}
+
+QString Utils::getTariffLoadTime(QString fileName) {
+    QFileInfo fInfo(fileName);
+    if (fInfo.exists()) {
+        QDateTime lastModifiedTime = fInfo.lastModified();
+        if (lastModifiedTime.isValid()) {
+            return lastModifiedTime.toString(Qt::ISODateWithMs);
+        } else {
+            printCriticalErrorMsg(fileName + " HAS INVALID MODIFIED-TIME");
+            QDateTime birthTime = fInfo.birthTime();
+            if (birthTime.isValid()) {
+                return birthTime.toString(Qt::ISODateWithMs);
+            } else {
+                printCriticalErrorMsg(fileName + " HAS INVALID BIRTH-TIME");
+            }
+        }
+    } else {
+        printCriticalErrorMsg(fileName + " DOES NOT EXIST");
+    }
+    return "N/A";
+}
+

utils.h

@@ -3,11 +3,18 @@
 
 #include <QObject>
 #include <QString>
+#include <QStringList>
 #include <QFile>
+#include <QFileInfo>
+#include <QDateTime>
 
 namespace Utils {
     int read1stLineOfFile(QString fileName);
     QString zoneName(quint8 i);
+    void printCriticalErrorMsg(QString const &errorMsg);
+    void printInfoMsg(QString const &infoMsg);
+    void printLineEditInfo(QStringList const &lines);
+    QString getTariffLoadTime(QString fileName);
 }
 
 #endif // UTILS_H_INCLUDED

worker.h

@@ -32,6 +32,9 @@ enum class UPDATE_STATUS : quint8 {
     ISMAS_WAIT_STATE_CHECK_SUCCESS,
     ISMAS_RESPONSE_RECEIVED,
     BACKEND_CONNECTED,
+    BACKEND_CHECK,
+    BACKEND_CHECK_FAILURE,
+    ISMAS_BACKEND_CHECK_FAILURE,
     BACKEND_NOT_CONNECTED,
     UPDATE_TRIGGER_SET,
     UPDATE_TRIGGER_NOT_SET_OR_WRONG,
@@ -59,6 +62,7 @@ enum class UPDATE_STATUS : quint8 {
     DEVICE_CONTROLLER_UPDATE_SUCCESS,
     JSON_UPDATE,
     JSON_UPDATE_FAILURE,
+    JSON_PARSE_FAILURE,
     JSON_UPDATE_SUCCESS,
     UPDATE_PROCESS_SUCCESS,
     UPDATE_PROCESS_FAILURE,
@@ -67,7 +71,13 @@ enum class UPDATE_STATUS : quint8 {
     ISMAS_UPDATE_INFO_CONFIRM_SUCCESS,
     ISMAS_CURRENT_PSA_STATUS_CONFIRM,
     ISMAS_CURRENT_PSA_STATUS_CONFIRM_FAILURE,
-    ISMAS_CURRENT_PSA_STATUS_CONFIRM_SUCCESS
+    ISMAS_CURRENT_PSA_STATUS_CONFIRM_SUCCESS,
+    ISMAS_SANITY_CHECK_OK,
+    ISMAS_UPDATE_TRIGGER_SET_FAILURE,
+    PSA_UPDATE_FILES_FAILED,
+    GIT_CHECK_FILES_TO_UPDATE_SUCCESS,
+    ISMAS_SEND_LAST_VERSION_FAILED,
+    SAVE_LOG_FILES_FAILED
 };
 
 struct UpdateStatus {
@@ -127,6 +137,7 @@ class Worker : public QObject {
 
     MainWindow *m_mainWindow;
     int m_progressValue;
+    bool m_withoutIsmasDirectPort;
 
     bool executeOpkgCommand(QString opkgCommand);
     QString getOsVersion() const;
@@ -159,6 +170,8 @@ public:
 
     void setMainWindow(MainWindow *mainWindow) { m_mainWindow = mainWindow; }
     void setProgress(int progress);
+    void startProgressLoop();
+    void stopProgressLoop();
 
     IsmasClient &getIsmasClient() { return m_ismasClient; }
     IsmasClient const &getIsmasClient() const { return m_ismasClient; }
@@ -205,8 +218,6 @@ private:
     PSAInstalled getPSAInstalled();
     QString sendCmdSendVersionToIsmas();
     void privateUpdate();
-    void startProgressLoop();
-    void stopProgressLoop();
 };
 
 #endif // WORKER_H_INCLUDED