Fix: copy header files

Recompute pop_max_price using netto-parking-time.
	Search Duration for the time-step with time-step == netto-parking-time,
	then search for the corresponding price in PaymentRate.
	The result is the new pop_max_price.

library/include/mobilisis/atb_time.h

@@ -0,0 +1,59 @@
+#ifndef ATB_TIME_H_INCLUDED
+#define ATB_TIME_H_INCLUDED
+
+#include <QDateTime>
+
+class ATBTime {
+    QDateTime const m_end;
+    mutable QDateTime m_time;
+
+public:
+    explicit ATBTime();
+    explicit ATBTime(int h, int m, int s = 0, int ms = 0);
+    explicit ATBTime(QString const &time);
+
+    int hour() const { return m_time.time().hour(); }
+    int minute() const { return m_time.time().minute(); }
+    int second() const { return m_time.time().second(); }
+    int msec() const { return m_time.time().msec(); }
+
+    int secsTo(QTime t) const { return m_time.time().secsTo(t); }
+    int msecsTo(QTime t) const { return m_time.time().msecsTo(t); }
+
+    bool setHMS(int h, int m, int s, int ms = 0);
+
+    bool isNull() const { return m_time.time().isNull(); }
+    bool isValid() const { return m_time.time().isValid(); }
+
+
+    QTime addMSecs(int ms) const;
+    QTime addMSecs(int ms);
+
+    QTime addSecs(int s) const;
+    QTime addSecs(int s);
+
+    int msecsSinceStartOfDay() const;
+    QString toString(Qt::DateFormat format = Qt::TextDate) const;
+
+
+    static bool isValid(int h, int m, int s, int ms = 0);
+
+    static QTime currentTime() { return QDateTime::currentDateTime().time(); }
+
+    static constexpr QTime fromMSecsSinceStartOfDay(int msecs);
+
+    static QTime fromString(QString const &string, Qt::DateFormat format = Qt::TextDate);
+    static QTime fromString(QString const &string, const QString &format);
+
+    friend bool operator!=(const ATBTime &lhs, const ATBTime &rhs) noexcept;
+    friend bool operator<(const ATBTime &lhs, const ATBTime &rhs) noexcept;
+    friend bool operator<=(const ATBTime &lhs, const ATBTime &rhs) noexcept;
+    friend bool operator<(const ATBTime &lhs, const ATBTime &rhs) noexcept;
+    friend bool operator>(const ATBTime &lhs, const ATBTime &rhs) noexcept;
+    friend bool operator==(const ATBTime &lhs, const ATBTime &rhs) noexcept;
+    friend QDataStream &operator<<(QDataStream &out, ATBTime time);
+    friend QDataStream &operator>>(QDataStream &in, ATBTime &time);
+};
+
+
+#endif // ATB_TIME_H_INCLUDED

library/include/mobilisis/calculate_price.h

@@ -56,6 +56,7 @@ struct CALCULATE_LIBRARY_API CalcState {
     static QString const ABOVE_MAX_PARKING_PRICE;
     static QString const OVERPAID;
     static QString const OUTSIDE_ALLOWED_PARKING_TIME;
+    static QString const SUCCESS_MAXPRICE;
 
     enum class State : uint8_t {
         SUCCESS,
@@ -71,7 +72,8 @@ struct CALCULATE_LIBRARY_API CalcState {
         BELOW_MIN_PARKING_PRICE,
         ABOVE_MAX_PARKING_PRICE,
         OVERPAID,
-        OUTSIDE_ALLOWED_PARKING_TIME
+        OUTSIDE_ALLOWED_PARKING_TIME,
+        SUCCESS_MAXPRICE
     };
 
     State m_status;
@@ -106,6 +108,9 @@ struct CALCULATE_LIBRARY_API CalcState {
         case State::SUCCESS:
             s = CalcState::SUCCESS;
             break;
+        case State::SUCCESS_MAXPRICE:
+            s = CalcState::SUCCESS_MAXPRICE;
+            break;
         case State::ERROR_PARSING_ZONE_NR:
             s = CalcState::ERROR_PARSING_ZONE_NR;
             break;
@@ -158,6 +163,9 @@ struct CALCULATE_LIBRARY_API CalcState {
         case State::SUCCESS:
             s = CalcState::SUCCESS;
             break;
+        case State::SUCCESS_MAXPRICE:
+            s = CalcState::SUCCESS_MAXPRICE;
+            break;
         case State::ERROR_PARSING_ZONE_NR:
             s = CalcState::ERROR_PARSING_ZONE_NR;
             break;
@@ -207,6 +215,9 @@ struct CALCULATE_LIBRARY_API CalcState {
         if (desc == SUCCESS) {
             m_status = State::SUCCESS;
         } else
+        if (desc == SUCCESS_MAXPRICE) {
+            m_status = State::SUCCESS_MAXPRICE;
+        }
         if (desc == ERROR_PARSING_ZONE_NR) {
             m_status = State::ERROR_PARSING_ZONE_NR;
         } else

library/include/mobilisis/calculator_functions.h

@@ -3,6 +3,7 @@
 
 #include <iostream>
 #include <optional>
+#include <utility>
 
 #include "configuration.h"
 #include "calculate_price.h"
@@ -70,7 +71,8 @@ public:
 	/// <param name="start_datetime">Date/time of payment to be conducted in ISO8601 format (e.g. 2022-12-25T08:00:00Z)</param>
 	/// <param name="price"></param>
 	/// <returns>Returns duration in seconds (data type: double)</returns>
-    std::string GetDurationFromCost(Configuration* cfg, uint8_t vehicle_type, char const* start_datetime, double price,
+    std::pair<std::string, QDateTime>
+        GetDurationFromCost(Configuration* cfg, uint8_t vehicle_type, char const* start_datetime, double price,
                             PermitType permitType, bool nextDay = false, bool prepaid = false);
 
 	/// <summary>

library/include/mobilisis/payment_opt.h

@@ -25,6 +25,7 @@ public:
         pop_max_time = 0;
         pop_min_price = 0;
         pop_max_price = 0;
+        pop_max_price_save = 0;
         pop_carry_over = -1;
         pop_carry_over_option_id = -1;
         pop_prepaid_option_id = -1;
@@ -61,6 +62,7 @@ public:
     double pop_max_time;
     double pop_min_price;
     double pop_max_price;
+    double pop_max_price_save;
     int pop_carry_over;
     int pop_carry_over_option_id;
     bool pop_truncate_last_interpolation_step;

library/include/mobilisis/spec_days_worktime.h

@@ -9,4 +9,8 @@ public:
 	std::string pedwt_time_from;
 	std::string pedwt_time_to;
     double pedwt_price;
+    int pedwt_paid; // 00: not paid (i.e. free)
+                    // 01: not paid in winter term, piad in summer term
+                    // 10: paid in winter term, not paid in summer term
+                    // 11: paid in winter and in summer term
 };

library/include/mobilisis/tariff_prepaid.h

@@ -4,6 +4,8 @@
 #include <QTime>
 #include <QString>
 
+#include "atb_time.h"
+
 struct ATBPrepaid {
     int id;
     bool anytime;

library/library.pro

@@ -35,7 +35,8 @@ SOURCES += \
     src/tariff_log.cpp \
     src/calculate_price.cpp \
     src/ticket.cpp \
-    src/tariff_global_defines.cpp
+    src/tariff_global_defines.cpp \
+    src/atb_time.cpp
 
 HEADERS += \
 	include/mobilisis/calculator_functions.h \
@@ -89,7 +90,8 @@ HEADERS += \
     include/mobilisis/tariff_interpolation.h \
     include/mobilisis/tariff_prepaid.h \
     include/mobilisis/tariff_carryover.h \
-    include/mobilisis/tariff_global_defines.h
+    include/mobilisis/tariff_global_defines.h \
+    include/mobilisis/atb_time.h
 
 OTHER_FILES += src/main.cpp \
     ../tariffs/tariff_korneuburg.json \

library/src/atb_time.cpp

@@ -0,0 +1,115 @@
+#include "atb_time.h"
+
+
+ATBTime::ATBTime()
+    : m_end(QDateTime::fromString("1970-01-02T00:00:00", Qt::ISODate))
+    , m_time(QDateTime::fromString("1970-01-01T00:00:00", Qt::ISODate)) {
+}
+
+ATBTime::ATBTime(int h, int m, int s, int ms)
+    : m_end(QDateTime::fromString("1970-01-02T00:00:00", Qt::ISODate))
+    , m_time(QDateTime::fromString("1970-01-01T00:00:00", Qt::ISODate)) {
+
+    QTime t(h, m, s, ms);
+    m_time.setTime(t);
+}
+
+ATBTime::ATBTime(QString const &t)
+    : m_end(QDateTime::fromString("1970-01-02T00:00:00"))
+    , m_time(QDateTime::fromString("1970-01-01T00:00:00")) {
+
+    if (t == "24:00:00") {
+        m_time = m_end;
+    } else {
+        m_time.setTime(QTime::fromString(t, Qt::ISODate));
+    }
+}
+
+
+QTime ATBTime::addMSecs(int ms) const {
+    return m_time.time().addMSecs(ms);
+}
+
+QTime ATBTime::addMSecs(int ms)  {
+    QTime t = m_time.time();
+    t = t.addMSecs(ms);
+    m_time.setTime(t);
+    return t;
+}
+
+QTime ATBTime::addSecs(int s) const {
+    return m_time.time().addSecs(s);
+}
+
+QTime ATBTime::addSecs(int s)  {
+    QTime t = m_time.time();
+    t = t.addSecs(s);
+    m_time.setTime(t);
+    return t;
+}
+
+constexpr QTime ATBTime::fromMSecsSinceStartOfDay(int msecs) {
+    return QTime::fromMSecsSinceStartOfDay(msecs);
+}
+
+QTime ATBTime::fromString(QString const &string, Qt::DateFormat format) {
+    return QTime::fromString(string, format);
+}
+
+QTime ATBTime::fromString(QString const &string, QString const &format) {
+    return QTime::fromString(string, format);
+}
+
+bool ATBTime::isValid(int h, int m, int s, int ms) {
+    return QTime(h, m, s, ms).isValid();
+}
+
+int ATBTime::msecsSinceStartOfDay() const {
+    return m_time.time().msecsSinceStartOfDay();
+}
+
+bool ATBTime::setHMS(int h, int m, int s, int ms) {
+    if (isValid(h, m, s, ms)) {
+        QTime t(h, m, s, ms);
+        m_time.setTime(t);
+        return true;
+    }
+    return false;
+}
+
+QString ATBTime::toString(Qt::DateFormat format) const {
+    return m_time.time().toString(format);
+}
+
+bool operator!=(const ATBTime &lhs, const ATBTime &rhs) noexcept {
+    return lhs.m_time.time() != rhs.m_time.time();
+}
+
+bool operator<=(const ATBTime &lhs, const ATBTime &rhs) noexcept {
+    return lhs.m_time.time() <= rhs.m_time.time();
+
+}
+
+bool operator<(const ATBTime &lhs, const ATBTime &rhs) noexcept {
+    return lhs.m_time.time() < rhs.m_time.time();
+}
+
+bool operator>(const ATBTime &lhs, const ATBTime &rhs) noexcept {
+    return lhs.m_time.time() > rhs.m_time.time();
+}
+
+bool operator==(const ATBTime &lhs, const ATBTime &rhs) noexcept {
+    return lhs.m_time.time() == rhs.m_time.time();
+}
+
+QDataStream &operator<<(QDataStream &out, ATBTime time) {
+    out << time.m_time.time();
+    return out;
+}
+
+QDataStream &operator>>(QDataStream &in, ATBTime &time) {
+    QTime t;
+    in >> t;
+    time.m_time.setTime(t);
+    return in;
+}

library/src/calculate_price.cpp

@@ -26,6 +26,7 @@ QString const CalcState::BELOW_MIN_PARKING_PRICE = "BELOW_MIN_PARKING_PRICE";
 QString const CalcState::ABOVE_MAX_PARKING_PRICE = "ABOVE_MAX_PARKING_PRICE";
 QString const CalcState::OVERPAID = "OVERPAID";
 QString const CalcState::OUTSIDE_ALLOWED_PARKING_TIME = "OUTSIDE_ALLOWED_PARKING_TIME";
+QString const CalcState::SUCCESS_MAXPRICE = "SUCCESS_MAXPRICE";
 
 QList<int> CALCULATE_LIBRARY_API get_time_steps(Configuration *cfg) {
     return Calculator::GetInstance().GetTimeSteps(cfg);
@@ -76,6 +77,7 @@ int CALCULATE_LIBRARY_API get_maximal_parkingtime(Configuration const *cfg,
     if (paymentOptionIndex == -1) {
         paymentOptionIndex = cfg->getPaymentOptionIndex(permitType);
     }
+
     int maxTime = 0;
 
     switch(permitType) {
@@ -682,6 +684,9 @@ CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
         paymentOptionIndex = tariff->getPaymentOptionIndex(permitType.get());
     }
 
+    tariff->getPaymentOptions(paymentOptionIndex).pop_max_price
+        = tariff->getPaymentOptions(paymentOptionIndex).pop_max_price_save;
+
     double minMin = tariff->PaymentOption.find(tariff->getPaymentOptions(paymentOptionIndex).pop_payment_method_id)->second.pop_min_time;
     double maxMin = tariff->PaymentOption.find(tariff->getPaymentOptions(paymentOptionIndex).pop_payment_method_id)->second.pop_max_time;
 
@@ -752,6 +757,9 @@ CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
         paymentOptionIndex = tariff->getPaymentOptionIndex(permitType);
     }
 
+    tariff->getPaymentOptions(paymentOptionIndex).pop_max_price
+        = tariff->getPaymentOptions(paymentOptionIndex).pop_max_price_save;
+
     double minMin = tariff->getPaymentOptions(paymentOptionIndex).pop_min_time;
     double maxMin = tariff->getPaymentOptions(paymentOptionIndex).pop_max_time;
 
@@ -808,8 +816,10 @@ CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
             int pop_prepaid_option_id = tariff->getPaymentOptions(paymentOptionIndex).pop_prepaid_option_id;
 
             std::optional<ATBPeriodYear> yperiod = Utilities::GetYearPeriodActive(tariff, start_parking_time);
+            int period_id = -1;
             if (yperiod.has_value()) {
                 ATBPeriodYear const &period = yperiod.value();
+                period_id = period.pye_id;
                 pop_carry_over_option_id = period.pye_id;
                 pop_prepaid_option_id = period.pye_id;
                 qCritical() << __func__ << ":" << __LINE__ << "re-computed carry-over-id" << pop_carry_over_option_id;
@@ -822,8 +832,39 @@ CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
             qCritical() << __func__ << ":" << __LINE__ << "   carryOverStart" << carryOverStart.toString(Qt::ISODate);
             qCritical() << __func__ << ":" << __LINE__ << "carryOverDuration" << carryOverDuration;
 
-            // handle prepaid option
+
             QDateTime effectiveStartTime(start_parking_time);
+
+            // handle special days
+            int const specialDayId = tariff->specialDayId(start_parking_time);
+            if (specialDayId > 0) { // found special day
+                for (auto[itr, rangeEnd] = tariff->SpecialDaysWorktime.equal_range(specialDayId); itr != rangeEnd; ++itr) {
+                    ATBSpecialDaysWorktime const &wt = itr->second;
+                    switch(period_id) {
+                    case 1: // summer term
+                        if ((wt.pedwt_paid & 1) == 0) {
+                            // does not have to be paid, move to next midnight
+
+                            // better: start of next day (falls kein vorkauf besteht)
+                            effectiveStartTime = effectiveStartTime.addDays(1);
+                            effectiveStartTime.setTime(QTime(0, 0, 0));
+                        }
+                        break;
+                    case 2: // winter term
+                        if ((wt.pedwt_paid & 2) == 0) {
+                            // does not have to be paid, move to next midnight
+
+                            // better: start of next day (falls kein vorkauf besteht)
+                            effectiveStartTime = effectiveStartTime.addDays(1);
+                            effectiveStartTime.setTime(QTime(0, 0, 0));
+                        }
+                        break;
+                    default:;
+                    }
+                }
+            }
+
+            // handle prepaid option
             int const prepaid_option_id = tariff->getPaymentOptions(paymentOptionIndex).pop_prepaid_option_id;
             std::optional<ATBPrepaid> prepaidOption = tariff->getPrepaidType(prepaid_option_id);
             if (prepaidOption.has_value()) {
@@ -844,11 +885,25 @@ CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
                 }
             }
 
+            effectiveStartTime.setTime(QTime(effectiveStartTime.time().hour(),
+                                             effectiveStartTime.time().minute(), 0));
+
             qCritical() << __func__ << ":" << __LINE__ << "effectiveStartTime:" << effectiveStartTime.toString(Qt::ISODate);
 
+            int const carryOver = tariff->getPaymentOptions(paymentOptionIndex).pop_carry_over;
+
+            qCritical() << __func__ << ":" << __LINE__ << "   carryOver flag" << carryOver;
+
+            if (carryOver == 1) {
+                QTime carryOverStart = tariff->TariffCarryOverOptions.find(pop_carry_over_option_id)->second.carryover[weekDay].static_start;
+                int carryOverDuration = tariff->TariffCarryOverOptions.find(pop_carry_over_option_id)->second.carryover[weekDay].duration;
+
+                qCritical() << __func__ << ":" << __LINE__ << "   carryOverStart" << carryOverStart.toString(Qt::ISODate);
+                qCritical() << __func__ << ":" << __LINE__ << "carryOverDuration" << carryOverDuration;
+
                 // handle carry over
                 int minutesUntilCarryOver = effectiveStartTime.time().secsTo(carryOverStart) / 60;
-            if (netto_parking_time > minutesUntilCarryOver) {
+                if ((minutesUntilCarryOver > 0) && (netto_parking_time > minutesUntilCarryOver)) {
                     int const rest = netto_parking_time - minutesUntilCarryOver;
                     QDateTime s(effectiveStartTime);
                     s = s.addSecs(minutesUntilCarryOver * 60);
@@ -878,6 +933,10 @@ CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
                         qCritical() << __func__ << ":" << __LINE__ << "end-parking-time:" << end_parking_time.toString(Qt::ISODate);
                     }
                 }
+            } else {
+                qCritical() << __func__ << ":" << __LINE__ << "NO carryOver configured";
+                end_parking_time = effectiveStartTime.addSecs(netto_parking_time*60);
+            }
 
             end_parking_time.setTime(QTime(end_parking_time.time().hour(),
                                            end_parking_time.time().minute(), 0));
@@ -894,6 +953,8 @@ CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
                     //QTime const &tlimit = wd.getTariffCarryOverSettings().parkingTimeLimit();
                     //end_parking_time.setTime(tlimit);
 
+                    // max_price neu berechnen
+
                     calcState.setDesc(QString("line=%1 endTime=%2: park-time-limit violated").arg(__LINE__)
                                         .arg(end_parking_time.time().toString(Qt::ISODate)));
                     return calcState.set(CalcState::State::ABOVE_MAX_PARKING_TIME);
@@ -970,10 +1031,14 @@ CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
         qCritical() << "           start (cs): " << cs;
         qCritical() << "                price: " << price;
 
-        duration = Calculator::GetInstance().GetDurationFromCost(tariff,
+        std::pair<std::string, QDateTime> p_duration
+                = Calculator::GetInstance().GetDurationFromCost(tariff,
                     tariff->getPaymentOptions(paymentOptionIndex).pop_payment_method_id,
                                               cs.toLocal8Bit().constData(),
-                                                  price, permitType, nextDay, prepaid).c_str();
+                                              price, permitType, nextDay, prepaid);
+        duration = p_duration.first.c_str();
+
+
         QDateTime d = QDateTime::fromString(duration, Qt::ISODate);
         if (!d.isValid()) {
             calcState.setDesc(QString("ticketEndTime=%1").arg(duration));
@@ -1026,6 +1091,10 @@ CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
         if (pop_time_step_config == (int)ATBTimeStepConfig::TimeStepConfig::STATIC) {
             // handle prepaid option
             QDateTime effectiveStartTime(start_parking_time);
+
+            effectiveStartTime.setTime(QTime(effectiveStartTime.time().hour(),
+                                             effectiveStartTime.time().minute(), 0));
+
             int const prepaid_option_id = tariff->getPaymentOptions(paymentOptionIndex).pop_prepaid_option_id;
             std::optional<ATBPrepaid> prepaidOption = tariff->getPrepaidType(prepaid_option_id);
             if (prepaidOption.has_value()) {
@@ -1042,17 +1111,29 @@ CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
                 }
             }
         }
+        QDateTime start(start_parking_time);
+        start.setTime(QTime(start.time().hour(), start.time().minute(), 0));
+        QString cs = start.toString(Qt::ISODate);
 
-        QString cs = start_parking_time.toString(Qt::ISODate);
-        QString endTime = Calculator::GetInstance().GetDurationFromCost(
+        std::pair<std::string, QDateTime> p_endTime
+                = Calculator::GetInstance().GetDurationFromCost(
                     tariff,
                     tariff->getPaymentOptions().pop_payment_method_id,
                     cs.toLocal8Bit().constData(),
-                    price, permitType, nextDay, prepaid).c_str();
+                    price, permitType, nextDay, prepaid);
+
+        QString endTime = p_endTime.first.c_str();
+        ticketEndTime = p_endTime.second;
 
         if (endTime == CalcState::SUCCESS) {
             calcState.setDesc(QString("SUCCESS"));
             calcState.setStatus(endTime);
+            qCritical() << __func__ << ":" << __LINE__ << "SUCCESS";
+        } else
+        if (endTime == CalcState::SUCCESS_MAXPRICE) {
+            calcState.setDesc(QString("SUCCESS_MAXPRICE"));
+            calcState.setStatus(endTime);
+            qCritical() << __func__ << ":" << __LINE__ << "SUCCESS_MAXPRICE";
         } else
         if (endTime == CalcState::ERROR_PARSING_ZONE_NR) {
             calcState.setStatus(endTime);
@@ -1110,8 +1191,14 @@ CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
         } else {
             ticketEndTime = QDateTime::fromString(endTime,Qt::ISODate);
 
+            ticketEndTime.setTime(QTime(ticketEndTime.time().hour(),
+                                        ticketEndTime.time().minute(), 0));
+
+            int netto_parking_time = start_parking_time.secsTo(ticketEndTime) / 60;
+
             qCritical() << __func__ << ":" << __LINE__ << "ticketEndTime:" << ticketEndTime.toString(Qt::ISODate);
             qCritical() << __func__ << ":" << __LINE__ << "step-config:" << pop_time_step_config;
+            qCritical() << __func__ << ":" << __LINE__ << "netto-parking-time" << netto_parking_time;
 
             if (!ticketEndTime.isValid()) {
                 calcState.setDesc(QString("ticketEndTime=%1").arg(endTime));
@@ -1153,10 +1240,25 @@ CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
                 }
 
                 if (carryOverStart.isValid() && carryOverEnd.isValid() && carryOverDuration != -1) {
+
+                    // note: in such a case (direct coins) carry-over has been handled
+                    // already in GetDurationFromCost()
+                    netto_parking_time -= carryOverDuration;
+                    qCritical() << __func__ << ":" << __LINE__ << "netto-parking-time" << netto_parking_time;
+
                     // qCritical() << __func__ << __LINE__ << "ticketEndTime.time():" << ticketEndTime.time().toString(Qt::ISODate);
                     if (ticketEndTime.time() > carryOverStart) {
                         // qCritical() << __func__ << __LINE__ << "ticketEndTime.time():" << ticketEndTime.time().toString(Qt::ISODate);
                         ticketEndTime = ticketEndTime.addSecs(carryOverDuration * 60);
+                    } else
+                    if (ticketEndTime.time() == carryOverStart) {
+                        qCritical() << __func__ << __LINE__ << "ticketEndTime.time():" << ticketEndTime.time().toString(Qt::ISODate);
+                        qCritical() << __func__ << ":" << __LINE__ << "   carryOverStart" << carryOverStart.toString(Qt::ISODate);
+                        ATBPaymentOption const &po = tariff->getPaymentOptions(paymentOptionIndex);
+                        if (po.pop_apply_carry_over_to_ticket_endtime) {
+                            ticketEndTime = ticketEndTime.addSecs(carryOverDuration * 60);
+                            qCritical() << __func__ << __LINE__ << "ticketEndTime.time():" << ticketEndTime.time().toString(Qt::ISODate);
+                        }
                     } else {
                         // qCritical() << __func__ << __LINE__ << "ticketEndTime.time():" << ticketEndTime.time().toString(Qt::ISODate);
                         if (ticketEndTime.time() < carryOverEnd) {
@@ -1169,23 +1271,85 @@ CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
                 }
             }
 
-
-            ticketEndTime.setTime(QTime(ticketEndTime.time().hour(),
-                                        ticketEndTime.time().minute(), 0));
-
             qCritical() << __func__ << ":" << __LINE__ << "ticketEndTime:" << ticketEndTime.toString(Qt::ISODate);
 
             for (auto[itr, rangeEnd] = tariff->WeekDays.equal_range((Qt::DayOfWeek)(ticketEndTime.date().dayOfWeek()));
                  itr != rangeEnd;
                  ++itr) {
                 ATBWeekDay const &wd = itr->second;
-                bool const parkTimeLimitViolated = wd.getTariffCarryOverSettings().parkingTimeLimitExceeded(start_parking_time,
+                bool parkTimeLimitViolated = wd.getTariffCarryOverSettings().parkingTimeLimitExceeded(start_parking_time,
                                                                                                       ticketEndTime,
                                                                                                       paymentOptionIndex);
                 if (parkTimeLimitViolated) {
                     //QTime const &tlimit = wd.getTariffCarryOverSettings().parkingTimeLimit();
                     //ticketEndTime.setTime(tlimit);
 
+                    QList<int> const &stepList = Calculator::GetInstance().GetTimeSteps(tariff, paymentOptionIndex);
+
+                    QDateTime newTicketEndTime = ticketEndTime;
+
+                    qCritical() << __func__ << ":" << __LINE__ << "PARK-TIME VIOLATED";
+
+                    for (int i = stepList.size() - 1; i > 0; --i) {
+                        // qCritical() << __func__ << ":" << __LINE__ << "step[" << i << "]" << stepList.at(i);
+
+                        if (netto_parking_time > 0 && stepList.at(i) <= netto_parking_time) {
+                            int const diff = stepList.at(i-1) - stepList.at(i);
+                            newTicketEndTime = newTicketEndTime.addSecs(diff * 60);
+
+                            // qCritical() << __func__ << ":" << __LINE__ << "new-ticket-end-time" << newTicketEndTime.toString(Qt::ISODate);
+
+                            parkTimeLimitViolated
+                                = wd.getTariffCarryOverSettings()
+                                    .parkingTimeLimitExceeded(start_parking_time, newTicketEndTime, paymentOptionIndex);
+
+                            if (!parkTimeLimitViolated) {
+
+                                qCritical() << __func__ << ":" << __LINE__
+                                            << "PARK-TIME NOT VIOLATED FOR" << newTicketEndTime.toString(Qt::ISODate);
+
+                                int duration = stepList.at(i-1);
+
+                                // qCritical() << __func__ << ":" << __LINE__ << "duration" << duration;
+
+                                std::multimap<int, ATBDuration>::const_iterator it;
+                                for (it = tariff->Duration.cbegin();
+                                     it != tariff->Duration.cend();
+                                     ++it) {
+                                    if (duration == it->second.pun_duration) {
+
+                                        // qCritical() << __func__ << ":" << __LINE__ << "duration" << duration;
+
+                                        ATBPaymentOption &po = tariff->getPaymentOptions(paymentOptionIndex);
+                                        int const pop_id = po.pop_id;
+                                        for (auto[itr, rangeEnd] = tariff->PaymentRate.equal_range(pop_id); itr != rangeEnd; ++itr) {
+                                            int const durationId = itr->second.pra_payment_unit_id;
+
+                                            // qCritical() << __func__ << ":" << __LINE__ << "durationId" << durationId << it->second.pun_id;
+
+                                            // note: for this to work, Duration and PaymentRate must have
+                                            // exactly the same structure
+                                            if (durationId == it->second.pun_id) {
+                                                int const pra_price = itr->second.pra_price;
+                                                po.pop_max_price = pra_price;
+
+                                                qCritical() << __func__ << ":" << __LINE__ << "new max-price" << po.pop_max_price;
+
+                                                // note: ABOVE_MAX_PARKING_TIME would also be possible
+                                                // but here max-parking-time is dynamic. And for
+                                                // this dynamic value, opverpaid is actually correct
+
+                                                calcState.setDesc(CalcState::OVERPAID);
+                                                calcState.setStatus(CalcState::OVERPAID);
+                                                return calcState;
+                                            }
+                                        }
+                                    }
+                                }
+                            }
+                        }
+                    }
+
                     calcState.setDesc(QString("line=%1 endTime=%2: park-time-limit violated").arg(__LINE__)
                                       .arg(ticketEndTime.time().toString(Qt::ISODate)));
                     return calcState.set(CalcState::State::ABOVE_MAX_PARKING_TIME);
@@ -1205,7 +1369,9 @@ CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
         return calcState.set(CalcState::State::INVALID_START_DATE);
     }
 
-    return calcState.set(CalcState::State::SUCCESS);
+    //return calcState.set(CalcState::State::SUCCESS);
+    qCritical() << __func__ << ":" << __LINE__ << "  calcState" << calcState.toString();
+    return calcState;
 }
 
 CalcState CALCULATE_LIBRARY_API compute_duration_for_daily_ticket(parking_tariff_t *tariff,

library/src/calculator_functions.cpp

@@ -118,7 +118,8 @@ QDateTime Calculator::GetDailyTicketDuration(Configuration* cfg, const QDateTime
     return QDateTime();
 }
 /// <inheritdoc/>
-std::string Calculator::GetDurationFromCost(Configuration* cfg,
+std::pair<std::string, QDateTime>
+Calculator::GetDurationFromCost(Configuration* cfg,
                                 uint8_t payment_option,
                                 char const *startDatetimePassed, // given in local time
                                 double cost,
@@ -134,6 +135,9 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
     inputDate.setTime(QTime(inputDate.time().hour(), inputDate.time().minute(), 0));
     static const PaymentMethod paymentMethodId = Utilities::getPaymentMethodId(cfg);
 
+    bool overPaid = false;
+    bool successMaxPrice = false; // max-price and cost match
+
     int paymentOptionIndex = getPaymentOptionIndex(*cfg, inputDate);
     if (paymentOptionIndex == -1) {
         paymentOptionIndex = cfg->getPaymentOptionIndex(QDateTime::fromString(startDatetimePassed, Qt::ISODate));
@@ -162,7 +166,7 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
             // minimal price is set by GetTimeSteps()
             qCritical() << DBG_HEADER << "   provided price (cost):" << cost;
             qCritical() << DBG_HEADER << "configured minimal price:" << cfg->getPaymentOptions(paymentOptionIndex).pop_min_price;
-            return CalcState::BELOW_MIN_PARKING_PRICE.toStdString();
+            return std::make_pair(CalcState::BELOW_MIN_PARKING_PRICE.toStdString(), QDateTime());
         }
 
         if (prepaid == false) {
@@ -225,9 +229,9 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
                             qCritical() << DBG_HEADER << "           minimal parking time (minutes):" << cfg->getPaymentOptions(paymentOptionIndex).pop_min_time;
 
                             if (duration_previous < cfg->getPaymentOptions(paymentOptionIndex).pop_min_time) {
-                                return CalcState::BELOW_MIN_PARKING_TIME.toStdString(); // minimal parking time is set by GetTimeSteps()
+                                return std::make_pair(CalcState::BELOW_MIN_PARKING_TIME.toStdString(), d); // minimal parking time is set by GetTimeSteps()
                             }
-                            return d.toString(Qt::ISODate).toStdString();
+                            return std::make_pair(d.toString(Qt::ISODate).toStdString(), d);
                         }
                     }
 
@@ -240,7 +244,7 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
                         qCritical() << DBG_HEADER << "   provided price (cost):" << cost;
                         qCritical() << DBG_HEADER << "      duration for price:" << durationStr;
 
-                        return durationStr.toStdString();
+                        return std::make_pair(durationStr.toStdString(), d);
                     }
                 }
             }
@@ -254,14 +258,14 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
             // use tariff with structure as for instance Schoenau, Koenigsee:
             // without given YearPeriod, SpecialDays and SpecialDaysWorktime
             inputDate = inputDate.addSecs(GetDurationForPrice(cfg, cost) * 60);
-            return inputDate.toString(Qt::ISODate).toStdString();
+            return std::make_pair(inputDate.toString(Qt::ISODate).toStdString(), inputDate);
         } else {
             if (Utilities::IsYearPeriodActive(cfg, inputDate)) {
                 if (!prepaid) {
                     CalcState cs = isParkingAllowed(cfg, inputDate);
                     if (cs) {
                         inputDate.setTime(cs.getAllowedTimeRange().getTimeUntil());
-                        return inputDate.toString(Qt::ISODate).toStdString();
+                        return std::make_pair(inputDate.toString(Qt::ISODate).toStdString(), inputDate);
                     }
                 }
 
@@ -270,18 +274,25 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
                 int const pop_min_price = cfg->getPaymentOptions(paymentOptionIndex).pop_min_price;
                 int const pop_allow_overpay = cfg->getPaymentOptions(paymentOptionIndex).pop_allow_overpay;
 
+                if (cost == pop_max_price) {
+                    qCritical() << DBG_HEADER << "SUCCESS MAX-PARKING-PRICE" << pop_max_price << ", COST" << cost;
+                    successMaxPrice = true;
+                }
+
                 if (cost > pop_max_price) {
                     qCritical() << DBG_HEADER << "MAX-PARKING-PRICE" << pop_max_price << ", COST" << cost;
                     if (pop_allow_overpay == false) {
-                        return CalcState::OVERPAID.toStdString();
+                        return std::make_pair(CalcState::OVERPAID.toStdString(), QDateTime());
                     }
                     cost = pop_max_price;
+                    overPaid = true;
+                    qCritical() << DBG_HEADER << "OVERPAID, MAX-PARKING-PRICE" << pop_max_price << ", COST" << cost;
                     // return CalcState::OVERPAID.toStdString();
                 }
 
                 if (cost < pop_min_price) {
                     qCritical() << DBG_HEADER << "MIN-PARKING-PRICE" << pop_min_price << ", COST" << cost;
-                    return CalcState::BELOW_MIN_PARKING_PRICE.toStdString();
+                    return std::make_pair(CalcState::BELOW_MIN_PARKING_PRICE.toStdString(), QDateTime());
                 }
 
                 // int const pop_pre_paid = 1;
@@ -366,7 +377,7 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
                     qCritical() << DBG_HEADER
                                 << "ERROR" << inputDate.toString(Qt::ISODate)
                                 << "NOT IN VALID WORKING TIME-RANGE";
-                    return "";
+                    return std::make_pair("", QDateTime());
                 }
 
                 //qCritical() << __func__ << __LINE__;
@@ -391,7 +402,7 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
                     qCritical() << DBG_HEADER
                                 << "ERROR" << inputDate.toString(Qt::ISODate)
                                 << "NOT IN VALID WORKING TIME-RANGE";
-                    return "";
+                    return std::make_pair("", QDateTime());
                 }
 
 #if DEBUG_GET_DURATION_FROM_COST==1
@@ -440,7 +451,13 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
                                 QDateTime d(QDateTime::fromString(s, Qt::ISODate));
                                 d = d.addSecs(duration_previous * 60);
                                 //qCritical() << DBG_HEADER << "XXXXXXXXXXXXXXXXXXXXX" << d;
-                                return d.toString(Qt::ISODate).toStdString();
+                                if (overPaid) {
+                                    return std::make_pair(CalcState::OVERPAID.toStdString(), d);
+                                }
+                                if (successMaxPrice) {
+                                    return std::make_pair(CalcState::SUCCESS_MAXPRICE.toStdString(), d);
+                                }
+                                return std::make_pair(d.toString(Qt::ISODate).toStdString(), d);
                             }
                         } else {
                             durationInSecs = cfg->Duration.find(durationId)->second.pun_duration * 60;
@@ -516,6 +533,16 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
 
                                                 //qCritical() << DBG_HEADER << "NEW INPUT" << inputDate.toString(Qt::ISODate);
 
+                                                int const pop_carry_over = cfg->getPaymentOptions(paymentOptionIndex).pop_carry_over;
+                                                if (pop_carry_over) {
+                                                    int weekDay = inputDate.date().dayOfWeek();
+                                                    int const pop_carry_over_option_id = cfg->getPaymentOptions(paymentOptionIndex).pop_carry_over_option_id;
+                                                    if (pop_carry_over_option_id != -1) {
+                                                        int const carryOverDuration = cfg->TariffCarryOverOptions.find(pop_carry_over_option_id)->second.carryover[weekDay].duration;
+                                                        inputDate = inputDate.addSecs(carryOverDuration * 60);
+                                                    }
+                                                }
+
                                                 inputDate = inputDate.addSecs(durationInSecs);
 #if DEBUG_GET_DURATION_FROM_COST==1
                                                 qCritical() << DBG_HEADER << "TICKET-END" << inputDate.toString(Qt::ISODate);
@@ -551,7 +578,13 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
                             qCritical() << DBG_HEADER << "TICKET-END" << s;
 #endif
 
-                            return s.toStdString();
+                            if (overPaid) {
+                                return std::make_pair(CalcState::OVERPAID.toStdString(), inputDate);
+                            }
+                            if (successMaxPrice) {
+                                return std::make_pair(CalcState::SUCCESS_MAXPRICE.toStdString(), inputDate);
+                            }
+                            return std::make_pair(s.toStdString(), inputDate);
                         } // if ((double)price == cost) {
                         else {
                             //qCritical() << DBG_HEADER;
@@ -561,7 +594,7 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
                     }
                 }
 
-                return "";
+                return std::make_pair("", QDateTime());
             }
         }
     } else
@@ -578,7 +611,7 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
 
         if (cost < minParkingPrice) {
             qCritical() << QString("ERROR: COST < MIN_PARKING_PRICE (%1 < %2)").arg(cost).arg(minParkingPrice);
-            return QDateTime().toString(Qt::ISODate).toStdString();
+            return std::make_pair(QDateTime().toString(Qt::ISODate).toStdString(), QDateTime());
         }
 
         if (cost > maxParkingPrice) {
@@ -617,7 +650,7 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
                 weekdayId = current.date().dayOfWeek();
                 if (weekdayId == weekdayIdLast) {
                     qCritical() << "ERROR: NO VALID WORKDAY-TIMES DEFINED";
-                    return QDateTime().toString(Qt::ISODate).toStdString();
+                    return std::make_pair(QDateTime().toString(Qt::ISODate).toStdString(), QDateTime());
                 }
             }
 
@@ -635,7 +668,13 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
 
             if (current.time() >= to) {
                 if (carryOverNotSet) {
-                    return end_datetime.toString(Qt::ISODate).toStdString();
+                    if (overPaid) {
+                        return std::make_pair(CalcState::OVERPAID.toStdString(), end_datetime);
+                    }
+                    if (successMaxPrice) {
+                        return std::make_pair(CalcState::SUCCESS_MAXPRICE.toStdString(), end_datetime);
+                    }
+                    return std::make_pair(end_datetime.toString(Qt::ISODate).toStdString(), end_datetime);
                 } else {
                     QDateTime const dt = start;
                     start = start.addDays(1);
@@ -682,7 +721,13 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
                                 << "price" << price;
 #endif
                     end_datetime = current;
-                    return end_datetime.toString(Qt::ISODate).toStdString();
+                    if (overPaid) {
+                        return std::make_pair(CalcState::OVERPAID.toStdString(), end_datetime);
+                    }
+                    if (successMaxPrice) {
+                        return std::make_pair(CalcState::SUCCESS_MAXPRICE.toStdString(), end_datetime);
+                    }
+                    return std::make_pair(end_datetime.toString(Qt::ISODate).toStdString(), end_datetime);
                 }
 
                 QTime const &from = QTime::fromString(weekDayWorkTimeRanges[weekDayWorkTimeIndex].pwd_time_from.c_str(), Qt::ISODate);
@@ -777,7 +822,13 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
                                     << "end_datetime" << end_datetime.toString(Qt::ISODate)
                                     << "price" << price;
 #endif
-                        return end_datetime.toString(Qt::ISODate).toStdString();
+                        if (overPaid) {
+                            return std::make_pair(CalcState::OVERPAID.toStdString(), end_datetime);
+                        }
+                        if (successMaxPrice) {
+                            return std::make_pair(CalcState::SUCCESS_MAXPRICE.toStdString(), end_datetime);
+                        }
+                        return std::make_pair(end_datetime.toString(Qt::ISODate).toStdString(), end_datetime);
                     }
                 }
 
@@ -818,7 +869,13 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
                                     << "end_datetime" << end_datetime.toString(Qt::ISODate)
                                     << "price" << price;
 #endif
-                                return end_datetime.toString(Qt::ISODate).toStdString();
+                                if (overPaid) {
+                                    return std::make_pair(CalcState::OVERPAID.toStdString(), end_datetime);
+                                }
+                                if (successMaxPrice) {
+                                    return std::make_pair(CalcState::SUCCESS_MAXPRICE.toStdString(), end_datetime);
+                                }
+                                return std::make_pair(end_datetime.toString(Qt::ISODate).toStdString(), end_datetime);
                             }
 
                             // price has been updated; use next time range
@@ -849,7 +906,13 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
                                     << "price" << price;
 #endif
 
-                        return end_datetime.toString(Qt::ISODate).toStdString();
+                        if (overPaid) {
+                            return std::make_pair(CalcState::OVERPAID.toStdString(), end_datetime);
+                        }
+                        if (successMaxPrice) {
+                            return std::make_pair(CalcState::SUCCESS_MAXPRICE.toStdString(), end_datetime);
+                        }
+                        return std::make_pair(end_datetime.toString(Qt::ISODate).toStdString(), end_datetime);
                     }
 
                     if (moveToNextTimeRange) {
@@ -965,8 +1028,13 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
                                     << "end_datetime" << end_datetime.toString(Qt::ISODate)
                                     << "price" << price;
 #endif
-
-                        return end_datetime.toString(Qt::ISODate).toStdString();
+                        if (overPaid) {
+                            return std::make_pair(CalcState::OVERPAID.toStdString(), end_datetime);
+                        }
+                        if (successMaxPrice) {
+                            return std::make_pair(CalcState::SUCCESS_MAXPRICE.toStdString(), end_datetime);
+                        }
+                        return std::make_pair(end_datetime.toString(Qt::ISODate).toStdString(), end_datetime);
                     }
                 }
 
@@ -979,7 +1047,10 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
                             << "final price" << std::max(price, minParkingPrice);
 #endif
 
-                return end_datetime.toString(Qt::ISODate).toStdString();
+                if (overPaid) {
+                    return std::make_pair(CalcState::OVERPAID.toStdString(), end_datetime);
+                }
+                return std::make_pair(end_datetime.toString(Qt::ISODate).toStdString(), end_datetime);
             } // while (timeRangeIt != cfg->TimeRange.cend()) {
         }
 
@@ -988,7 +1059,7 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
                             << "INVALID END TIME";
 #endif
         end_datetime = QDateTime();
-        return end_datetime.toString(Qt::ISODate).toStdString();
+        return std::make_pair(end_datetime.toString(Qt::ISODate).toStdString(), end_datetime);
     }
 
     Ticket t = private_GetDurationFromCost(cfg, inputDate, cost, prepaid);
@@ -996,7 +1067,7 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg,
     // qCritical().noquote() << t;
 
     // TODO: im fehlerfall
-    return t.getValidUntil().toString(Qt::ISODate).toStdString();
+    return std::make_pair(t.getValidUntil().toString(Qt::ISODate).toStdString(), t.getValidUntil());
 }
 #undef _DEBUG_
 

library/src/configuration.cpp

@@ -1000,6 +1000,7 @@ bool Configuration::ParseJson(Configuration* cfg, const char* json)
                             this->currentPaymentOptions.last().pop_min_time = k->value.GetDouble();
                         } else if (strcmp(inner_obj_name, "pop_max_price") == 0) {
                             this->currentPaymentOptions.last().pop_max_price = k->value.GetDouble();
+                            this->currentPaymentOptions.last().pop_max_price_save = k->value.GetDouble();
                         } else if (strcmp(inner_obj_name, "pop_max_time") == 0) {
                             this->currentPaymentOptions.last().pop_max_time = k->value.GetDouble();
                         } else if (strcmp(inner_obj_name, "pop_min_price") == 0) {
@@ -1110,6 +1111,7 @@ bool Configuration::ParseJson(Configuration* cfg, const char* json)
                         else if (strcmp(inner_obj_name, "pedwt_time_from") == 0) SpecialDaysWorktime.pedwt_time_from = k->value.GetString();
                         else if (strcmp(inner_obj_name, "pedwt_time_to") == 0) SpecialDaysWorktime.pedwt_time_to = k->value.GetString();
                         else if (strcmp(inner_obj_name, "pedwt_price") == 0) SpecialDaysWorktime.pedwt_price = k->value.GetDouble();
+                        else if (strcmp(inner_obj_name, "pedwt_paid") == 0) SpecialDaysWorktime.pedwt_paid = k->value.GetInt();
                         break;
                 /*case MemberType::WeekDaysType:
                         if (strcmp(inner_obj_name, "pdiw_id") == 0) WeekDays.pdiw_id = k->value.GetInt();

main/main.pro

@@ -34,7 +34,11 @@ OTHER_FILES += \
     /opt/ptu5/opt/customer_335/etc/psa_tariff/tariff02.json \
     /opt/ptu5/opt/customer_249/etc/psa_tariff/tariff01.json \
     /opt/ptu5/opt/customer_249/etc/psa_tariff/tariff02.json \
-    /opt/ptu5/opt/customer_249/etc/psa_tariff/tariff03.json
+    /opt/ptu5/opt/customer_249/etc/psa_tariff/tariff03.json \
+    /opt/ptu5/opt/customer_249/etc/psa_tariff/tariff04.json \
+    /opt/ptu5/opt/customer_249/etc/psa_tariff/tariff05.json \
+    /opt/ptu5/opt/customer_249/etc/psa_tariff/tariff06.json \
+    /opt/ptu5/opt/customer_249/etc/psa_tariff/tariff07.json