test case for fuchs/muelbach

Minor: added debug output.

library/include/mobilisis/atb_time.h

@@ -1,58 +0,0 @@
-#ifndef ATB_TIME_H_INCLUDED
-#define ATB_TIME_H_INCLUDED
-
-#include <QDateTime>
-
-class ATBTime {
-    QDateTime const m_end;
-    mutable QDateTime m_time;
-
-public:
-    explicit ATBTime();
-    explicit ATBTime(int h, int m, int s = 0, int ms = 0);
-
-    int hour() const { return m_time.time().hour(); }
-    int minute() const { return m_time.time().minute(); }
-    int second() const { return m_time.time().second(); }
-    int msec() const { return m_time.time().msec(); }
-
-    int secsTo(QTime t) const { return m_time.time().secsTo(t); }
-    int msecsTo(QTime t) const { return m_time.time().msecsTo(t); }
-
-    bool setHMS(int h, int m, int s, int ms = 0);
-
-    bool isNull() const { return m_time.time().isNull(); }
-    bool isValid() const { return m_time.time().isValid(); }
-
-
-    QTime addMSecs(int ms) const;
-    QTime addMSecs(int ms);
-
-    QTime addSecs(int s) const;
-    QTime addSecs(int s);
-
-    int msecsSinceStartOfDay() const;
-    QString toString(Qt::DateFormat format = Qt::TextDate) const;
-
-
-    static bool isValid(int h, int m, int s, int ms = 0);
-
-    static QTime currentTime() { return QDateTime::currentDateTime().time(); }
-
-    static constexpr QTime fromMSecsSinceStartOfDay(int msecs);
-
-    static QTime fromString(QString const &string, Qt::DateFormat format = Qt::TextDate);
-    static QTime fromString(QString const &string, const QString &format);
-
-    friend bool operator!=(const ATBTime &lhs, const ATBTime &rhs) noexcept;
-    friend bool operator<(const ATBTime &lhs, const ATBTime &rhs) noexcept;
-    friend bool operator<=(const ATBTime &lhs, const ATBTime &rhs) noexcept;
-    friend bool operator<(const ATBTime &lhs, const ATBTime &rhs) noexcept;
-    friend bool operator>(const ATBTime &lhs, const ATBTime &rhs) noexcept;
-    friend bool operator==(const ATBTime &lhs, const ATBTime &rhs) noexcept;
-    friend QDataStream &operator<<(QDataStream &out, ATBTime time);
-    friend QDataStream &operator>>(QDataStream &in, ATBTime &time);
-};
-
-
-#endif // ATB_TIME_H_INCLUDED

library/include/mobilisis/calculate_price.h

@@ -56,7 +56,6 @@ struct CALCULATE_LIBRARY_API CalcState {
     static QString const ABOVE_MAX_PARKING_PRICE;
     static QString const OVERPAID;
     static QString const OUTSIDE_ALLOWED_PARKING_TIME;
-    static QString const SUCCESS_MAXPRICE;
 
     enum class State : uint8_t {
         SUCCESS,
@@ -72,8 +71,7 @@ struct CALCULATE_LIBRARY_API CalcState {
         BELOW_MIN_PARKING_PRICE,
         ABOVE_MAX_PARKING_PRICE,
         OVERPAID,
-        OUTSIDE_ALLOWED_PARKING_TIME,
+        OUTSIDE_ALLOWED_PARKING_TIME
-        SUCCESS_MAXPRICE
     };
 
     State m_status;
@@ -108,9 +106,6 @@ struct CALCULATE_LIBRARY_API CalcState {
         case State::SUCCESS:
             s = CalcState::SUCCESS;
             break;
-        case State::SUCCESS_MAXPRICE:
-            s = CalcState::SUCCESS_MAXPRICE;
-            break;
         case State::ERROR_PARSING_ZONE_NR:
             s = CalcState::ERROR_PARSING_ZONE_NR;
             break;
@@ -163,9 +158,6 @@ struct CALCULATE_LIBRARY_API CalcState {
         case State::SUCCESS:
             s = CalcState::SUCCESS;
             break;
-        case State::SUCCESS_MAXPRICE:
-            s = CalcState::SUCCESS_MAXPRICE;
-            break;
         case State::ERROR_PARSING_ZONE_NR:
             s = CalcState::ERROR_PARSING_ZONE_NR;
             break;
@@ -215,9 +207,6 @@ struct CALCULATE_LIBRARY_API CalcState {
         if (desc == SUCCESS) {
             m_status = State::SUCCESS;
         } else
-        if (desc == SUCCESS_MAXPRICE) {
-            m_status = State::SUCCESS_MAXPRICE;
-        }
         if (desc == ERROR_PARSING_ZONE_NR) {
             m_status = State::ERROR_PARSING_ZONE_NR;
         } else

library/include/mobilisis/calculator_functions.h

@@ -3,7 +3,6 @@
 
 #include <iostream>
 #include <optional>
-#include <utility>
 
 #include "configuration.h"
 #include "calculate_price.h"
@@ -28,6 +27,13 @@ class Calculator {
                                             int netto_parking_time,
                                             int paymentOptionIndex);
 
+    int computeBruttoDurationInSecs(Configuration const *cfg,
+                                    QDateTime const &from,
+                                    int durationInSecs, bool maxBrutto = false);
+
+    QDateTime computeBruttoDateTime(Configuration const *cfg,
+                                    QDateTime const &from,
+                                    int durationInSecs, bool maxBrutto = false);
 protected:
     explicit Calculator() = default;
 
@@ -71,9 +77,7 @@ public:
 	/// <param name="start_datetime">Date/time of payment to be conducted in ISO8601 format (e.g. 2022-12-25T08:00:00Z)</param>
 	/// <param name="price"></param>
 	/// <returns>Returns duration in seconds (data type: double)</returns>
-    std::pair<std::string, QDateTime>
+    std::string GetDurationFromCost(Configuration* cfg, uint8_t vehicle_type, char const* start_datetime, double price, PermitType permitType, bool nextDay = false, bool prepaid = false);
-        GetDurationFromCost(Configuration* cfg, uint8_t vehicle_type, char const* start_datetime, double price,
-                            PermitType permitType, bool nextDay = false, bool prepaid = false);
 
 	/// <summary>
 	///  Gets cost from duration in seconds
@@ -81,11 +85,10 @@ public:
 	/// <param name="tariff_cfg">Pointer to configuration</param>
 	/// <param name="vehicle_type">Type of vehicle</param>
 	/// <param name="start_datetime">Date/time of payment to be conducted in ISO8601 format (e.g. 2022-12-25T08:00:00Z) </param>
-    /// <param name="end_datetime">Date/time of park end to be conducted in ISO8601 format (e.g. 2022-12-25T08:00:00Z) </param>
+	/// <param name="end_datetime">Date/time of park end to be conducted in ISO8601 format (e.g. 2022-12-25T08:00:00Z) </param>
 	/// <param name="durationMin">Duration of parking in minutes</param>
 	/// <returns>Returns cost (data type: double)</returns>
-    double GetCostFromDuration(Configuration* cfg, uint8_t vehicle_type, QDateTime &start_datetime, QDateTime & end_datetime, int durationMin,
+    double GetCostFromDuration(Configuration* cfg, uint8_t vehicle_type, QDateTime &start_datetime, QDateTime & end_datetime, int durationMin, PermitType permitType, bool nextDay = false, bool prepaid = false);
-                               PermitType permitType, bool nextDay = false, bool prepaid = false);
 
     // Daily ticket
     QDateTime GetDailyTicketDuration(Configuration* cfg, const QDateTime start_datetime, uint8_t payment_option, bool carry_over);

library/include/mobilisis/configuration.h

@@ -36,7 +36,6 @@
 using namespace std;
 using namespace rapidjson;
 
-
 class Calculator;
 class Configuration
 {
@@ -60,7 +59,7 @@ public:
 	multimap<int, ATBPaymentRate> PaymentRate;
 	SpecialDaysWorktimeType SpecialDaysWorktime;
 	SpecialDaysType SpecialDays;
-    multimap<Qt::DayOfWeek, ATBWeekDay> WeekDays;
+	multimap<int, ATBWeekDays> WeekDays;
 	multimap<int, ATBPeriodYear> YearPeriod;
 	multimap<int, ATBWeekDaysWorktime> WeekDaysWorktime;
 	ATBPaymentOptionType PaymentOption;
@@ -127,15 +126,3 @@ private:
 
 	QVector<ATBPaymentOption> currentPaymentOptions;
 };
-
-bool previousDayHoliday(Configuration const &cfg, QDateTime const &t);
-bool isHoliday(Configuration const &cfg, QDateTime const &t);
-int getPaymentOptionIndex(Configuration const &cfg, QDateTime const& dt = QDateTime::currentDateTime());
-
-ATBWeekDay parseWeekDay(Configuration &cfg,
-                        rapidjson::GenericMemberIterator<false,
-                                                         rapidjson::UTF8<char>,
-                                                         rapidjson::MemoryPoolAllocator<rapidjson::CrtAllocator>> k,
-                        QString const &innerObjName,
-                        Qt::DayOfWeek weekDay,
-                        QString const &weekDayName);

library/include/mobilisis/payment_opt.h

@@ -41,10 +41,7 @@ public:
         pop_use_only_upto_datetime = ""; // deprecated
         pop_use_only_for_duration = 0;   // deprecated
         pop_plus_steps = 1;  // +: jump <x=1> steps forward
-        pop_plus_steps_saved = 1;
         pop_minus_steps = 1; // -: jump <x=1> steps backward
-        pop_allow_overpay = false;
-        pop_apply_carry_over_to_ticket_endtime = false;
     }
 
     int pop_id;
@@ -75,10 +72,7 @@ public:
     bool pop_accumulate_prices;
     bool pop_accumulate_durations;
     int pop_plus_steps;
-    int pop_plus_steps_saved;
     int pop_minus_steps;
-    bool pop_allow_overpay;
-    bool pop_apply_carry_over_to_ticket_endtime;
 
     struct ATBMaxDateTime {
         int direction;

library/include/mobilisis/spec_days_worktime.h

@@ -8,9 +8,5 @@ public:
 	int pedwt_period_exc_day_id;
 	std::string pedwt_time_from;
 	std::string pedwt_time_to;
-    double pedwt_price;
+	double pedwt_price;
-    int pedwt_paid; // 00: not paid (i.e. free)
+};
-                    // 01: not paid in winter term, piad in summer term
-                    // 10: paid in winter term, not paid in summer term
-                    // 11: paid in winter and in summer term
-};

library/include/mobilisis/tariff_carryover.h

@@ -15,19 +15,6 @@ struct ATBCarryOver {
 
     int id;
 
-    explicit ATBCarryOver()
-      : id(-1) {
-
-        for (int i = 0 ; i < 8; ++i) {
-            carryover[i].day = -1;
-            carryover[i].seemless = false;
-            carryover[i].never = false;
-            carryover[i].static_start = QTime(23, 59, 59);
-            carryover[i].static_end = QTime(0, 0, 0);
-            carryover[i].duration = -1;
-        }
-    }
-
     friend QDebug operator<<(QDebug debug, ATBCarryOver const &co) {
         QDebugStateSaver saver(debug);
 
@@ -44,21 +31,21 @@ struct ATBCarryOver {
             << "                day: " << co.carryover[(int)Qt::Tuesday].day << "\n"
             << "       static_start: " << co.carryover[(int)Qt::Tuesday].static_start.toString(Qt::ISODate) << "\n"
             << "         static_end: " << co.carryover[(int)Qt::Tuesday].static_end.toString(Qt::ISODate) << "\n"
-            << "           duration: " << co.carryover[(int)Qt::Tuesday].duration << "\n"
+            << "           duration: " << co.carryover[(int)Qt::Monday].duration << "\n"
             << "            anytime: " << co.carryover[(int)Qt::Tuesday].seemless << "\n"
             << "              never: " << co.carryover[(int)Qt::Tuesday].never << "\n"
             << "        **** Wednesday **** \n"
             << "                day: " << co.carryover[(int)Qt::Wednesday].day << "\n"
             << "       static_start: " << co.carryover[(int)Qt::Wednesday].static_start.toString(Qt::ISODate) << "\n"
             << "         static_end: " << co.carryover[(int)Qt::Wednesday].static_end.toString(Qt::ISODate) << "\n"
-            << "           duration: " << co.carryover[(int)Qt::Wednesday].duration << "\n"
+            << "           duration: " << co.carryover[(int)Qt::Monday].duration << "\n"
             << "            anytime: " << co.carryover[(int)Qt::Wednesday].seemless << "\n"
             << "              never: " << co.carryover[(int)Qt::Wednesday].never << "\n"
             << "        **** Thursday **** \n"
             << "                day: " << co.carryover[(int)Qt::Thursday].day << "\n"
             << "       static_start: " << co.carryover[(int)Qt::Thursday].static_start.toString(Qt::ISODate) << "\n"
             << "         static_end: " << co.carryover[(int)Qt::Thursday].static_end.toString(Qt::ISODate) << "\n"
-            << "           duration: " << co.carryover[(int)Qt::Thursday].duration << "\n"
+            << "           duration: " << co.carryover[(int)Qt::Monday].duration << "\n"
             << "            anytime: " << co.carryover[(int)Qt::Thursday].seemless << "\n"
             << "              never: " << co.carryover[(int)Qt::Thursday].never << "\n"
             << "        **** Friday **** \n"
@@ -71,14 +58,14 @@ struct ATBCarryOver {
             << "                day: " << co.carryover[(int)Qt::Saturday].day << "\n"
             << "       static_start: " << co.carryover[(int)Qt::Saturday].static_start.toString(Qt::ISODate) << "\n"
             << "         static_end: " << co.carryover[(int)Qt::Saturday].static_end.toString(Qt::ISODate) << "\n"
-            << "           duration: " << co.carryover[(int)Qt::Saturday].duration << "\n"
+            << "           duration: " << co.carryover[(int)Qt::Monday].duration << "\n"
             << "            anytime: " << co.carryover[(int)Qt::Saturday].seemless << "\n"
             << "              never: " << co.carryover[(int)Qt::Saturday].never << "\n"
             << "        **** Sunday **** \n"
             << "                day: " << co.carryover[(int)Qt::Sunday].day << "\n"
             << "       static_start: " << co.carryover[(int)Qt::Sunday].static_start.toString(Qt::ISODate) << "\n"
             << "         static_end: " << co.carryover[(int)Qt::Sunday].static_end.toString(Qt::ISODate) << "\n"
-            << "           duration: " << co.carryover[(int)Qt::Sunday].duration << "\n"
+            << "           duration: " << co.carryover[(int)Qt::Monday].duration << "\n"
             << "            anytime: " << co.carryover[(int)Qt::Sunday].seemless << "\n"
             << "              never: " << co.carryover[(int)Qt::Sunday].never << "\n";
 

library/include/mobilisis/tariff_carryover_settings.h

@@ -1,69 +0,0 @@
-#ifndef ATB_TARIFF_CARRYOVER_SETTINGS_H_INCLUDED
-#define ATB_TARIFF_CARRYOVER_SETTINGS_H_INCLUDED
-
-#include <QDebug>
-#include <QDateTime>
-
-#include <functional>
-
-struct ATBTariffCarryOverSettings {
-
-    // parking time limit not violated: return false, otherwise: return true.
-    using ParkingTimeLimitChecker = std::function<bool(ATBTariffCarryOverSettings const&,
-                                                       QDateTime const &startTime,
-                                                       QDateTime const &endTime,
-                                                       int paymentOptionIndex)>;
-
-    int m_duration;
-    QTime m_start;
-    QTime m_end;
-    ParkingTimeLimitChecker m_parkingTimeLimitChecker;
-
-    QTime m_parking_time_limit;
-    QTime m_about_to_exceed_parking_time_limit;
-
-    explicit ATBTariffCarryOverSettings()
-      : m_duration(0)
-      , m_start(QTime())
-      , m_end(QTime())
-      , m_parkingTimeLimitChecker([](ATBTariffCarryOverSettings const&,
-                                  QDateTime const&, QDateTime const&, int) { return false; })
-      , m_parking_time_limit(QTime())
-      , m_about_to_exceed_parking_time_limit(QTime()) {}
-
-    explicit ATBTariffCarryOverSettings(int duration, QTime const &start,
-                                        QTime const &end,
-                                        QTime const &parking_time_limit,
-                                        QTime const &about_to_exceed_parking_time_limit,
-                                        ParkingTimeLimitChecker parkingTimeLimitChecker)
-      : m_duration(duration)
-      , m_start(start)
-      , m_end(end)
-      , m_parkingTimeLimitChecker(std::move(parkingTimeLimitChecker))
-      , m_parking_time_limit(parking_time_limit)
-      , m_about_to_exceed_parking_time_limit(about_to_exceed_parking_time_limit) {
-    }
-
-    bool parkingTimeLimitExceeded(QDateTime const &startTime,
-                                  QDateTime const &endTime,
-                                  int paymentOptionIndex) const {
-        return m_parkingTimeLimitChecker(*this, startTime, endTime, paymentOptionIndex);
-    }
-
-    QTime const &parkingTimeLimit() const { return m_parking_time_limit; }
-    QTime &parkingTimeLimit() { return m_parking_time_limit; }
-
-    friend QDebug operator<<(QDebug debug, ATBTariffCarryOverSettings const &co) {
-        QDebugStateSaver saver(debug);
-
-        debug.nospace()
-            << "                 duration: " << co.m_duration << "\n"
-            << "                    start: " << co.m_start.toString(Qt::ISODate) << "\n"
-            << "                      end: " << co.m_end.toString(Qt::ISODate) << "\n"
-            << "       parking_time_limit: " << co.m_parking_time_limit.toString(Qt::ISODate) << endl;
-
-        return debug;
-    }
-};
-
-#endif // ATB_TARIFF_CARRYOVER_SETTINGS_H_INCLUDED

library/include/mobilisis/tariff_log.h

@@ -14,8 +14,6 @@
 void setDebugLevel(int level);
 int getDebugLevel();
 
-#if 0
-
 static void print() {
     std::cerr << "\n";
     if (getDebugLevel() == DBG_LEVEL_FATAL) {
@@ -77,6 +75,4 @@ static void LOG_FATAL(const Arg1& arg1, const Args&&... args) {
     }
 }
 
-#endif
-
 #endif //  TARIFF_LOG_INCLUDED_H

library/include/mobilisis/tariff_prepaid.h

@@ -5,34 +5,13 @@
 #include <QString>
 
 struct ATBPrepaid {
+    explicit ATBPrepaid() = default;
     int id;
     bool anytime;
     bool never;
     QTime static_start;
     QTime static_end;
 
-    struct week {
-        int day;
-        QTime static_start;
-        QTime static_end;
-        int duration;
-    } prepaid[8];
-
-    explicit ATBPrepaid()
-      : id(-1)
-      , anytime(false)
-      , never(false)
-      , static_start(QTime(23, 59, 59))
-      , static_end(QTime(0, 0, 0)) {
-
-        for (int i = 0 ; i < 8; ++i) {
-            prepaid[i].day = -1;
-            prepaid[i].static_start = QTime(23, 59, 59);
-            prepaid[i].static_end = QTime(0, 0, 0);
-            prepaid[i].duration = -1;
-        }
-    }
-
     friend QDebug operator<<(QDebug debug, ATBPrepaid const &pp) {
         QDebugStateSaver saver(debug);
 
@@ -41,41 +20,7 @@ struct ATBPrepaid {
             << "       static_start: " << pp.static_start.toString(Qt::ISODate) << "\n"
             << "         static_end: " << pp.static_end.toString(Qt::ISODate) << "\n"
             << "            anytime: " << pp.anytime << "\n"
-            << "              never: " << pp.never << "\n"
+            << "              never: " << pp.never << "\n";
-            << "        **** Monday **** \n"
-            << "                day: " << pp.prepaid[(int)Qt::Monday].day << "\n"
-            << "       static_start: " << pp.prepaid[(int)Qt::Monday].static_start.toString(Qt::ISODate) << "\n"
-            << "         static_end: " << pp.prepaid[(int)Qt::Monday].static_end.toString(Qt::ISODate) << "\n"
-            << "           duration: " << pp.prepaid[(int)Qt::Monday].duration << "\n"
-            << "        **** Tuesday **** \n"
-            << "                day: " << pp.prepaid[(int)Qt::Tuesday].day << "\n"
-            << "       static_start: " << pp.prepaid[(int)Qt::Tuesday].static_start.toString(Qt::ISODate) << "\n"
-            << "         static_end: " << pp.prepaid[(int)Qt::Tuesday].static_end.toString(Qt::ISODate) << "\n"
-            << "           duration: " << pp.prepaid[(int)Qt::Tuesday].duration << "\n"
-            << "        **** Wednesday **** \n"
-            << "                day: " << pp.prepaid[(int)Qt::Wednesday].day << "\n"
-            << "       static_start: " << pp.prepaid[(int)Qt::Wednesday].static_start.toString(Qt::ISODate) << "\n"
-            << "         static_end: " << pp.prepaid[(int)Qt::Wednesday].static_end.toString(Qt::ISODate) << "\n"
-            << "           duration: " << pp.prepaid[(int)Qt::Wednesday].duration << "\n"
-            << "        **** Thursday **** \n"
-            << "                day: " << pp.prepaid[(int)Qt::Thursday].day << "\n"
-            << "       static_start: " << pp.prepaid[(int)Qt::Thursday].static_start.toString(Qt::ISODate) << "\n"
-            << "         static_end: " << pp.prepaid[(int)Qt::Thursday].static_end.toString(Qt::ISODate) << "\n"
-            << "           duration: " << pp.prepaid[(int)Qt::Thursday].duration << "\n"
-            << "        **** Friday **** \n"
-            << "                day: " << pp.prepaid[(int)Qt::Friday].day << "\n"
-            << "       static_start: " << pp.prepaid[(int)Qt::Friday].static_start.toString(Qt::ISODate) << "\n"
-            << "         static_end: " << pp.prepaid[(int)Qt::Friday].static_end.toString(Qt::ISODate) << "\n"
-            << "        **** Saturday **** \n"
-            << "                day: " << pp.prepaid[(int)Qt::Saturday].day << "\n"
-            << "       static_start: " << pp.prepaid[(int)Qt::Saturday].static_start.toString(Qt::ISODate) << "\n"
-            << "         static_end: " << pp.prepaid[(int)Qt::Saturday].static_end.toString(Qt::ISODate) << "\n"
-            << "           duration: " << pp.prepaid[(int)Qt::Saturday].duration << "\n"
-            << "        **** Sunday **** \n"
-            << "                day: " << pp.prepaid[(int)Qt::Sunday].day << "\n"
-            << "       static_start: " << pp.prepaid[(int)Qt::Sunday].static_start.toString(Qt::ISODate) << "\n"
-            << "         static_end: " << pp.prepaid[(int)Qt::Sunday].static_end.toString(Qt::ISODate) << "\n"
-            << "           duration: " << pp.prepaid[(int)Qt::Sunday].duration << "\n";
 
         return debug;
     }

library/include/mobilisis/tariff_settings.h

@@ -1,40 +0,0 @@
-#ifndef ATB_TARIFF_SETTINGS_H_INCLUDED
-#define ATB_TARIFF_SETTINGS_H_INCLUDED
-
-#include <QDebug>
-
-struct ATBTariffSettings {
-    int m_max_price;
-    int m_min_price;
-    int m_max_time;
-    int m_min_time;
-
-    explicit ATBTariffSettings()
-      : m_max_price(0)
-      , m_min_price(0)
-      , m_max_time(0)
-      , m_min_time(0) {
-    }
-
-    explicit ATBTariffSettings(int max_price, int min_price, int max_time, int min_time)
-      : m_max_price(max_price)
-      , m_min_price(min_price)
-      , m_max_time(max_time)
-      , m_min_time(min_time) {
-    }
-
-    friend QDebug operator<<(QDebug debug, ATBTariffSettings const &ts) {
-        QDebugStateSaver saver(debug);
-
-        debug.nospace()
-            << "                max_price: " << ts.m_max_price << "\n"
-            << "                min_price: " << ts.m_min_price << "\n"
-            << "                 max_time: " << ts.m_max_time << "\n"
-            << "                 min_time: " << ts.m_min_time << endl;
-
-        return debug;
-    }
-};
-
-
-#endif // ATB_TARIFF_SETTINGS_H_INCLUDED

library/include/mobilisis/weekdays.h

@@ -1,57 +1,10 @@
-#include "tariff_settings.h"
+#pragma once
-#include "tariff_carryover_settings.h"
+#include <string>
 
-#include <QString>
+class ATBWeekDays
-#include <Qt>
+{
-#include <QDate>
+public:
-
+	int pdiw_id;
-struct ATBWeekDay {
+	std::string pdiw_label;
-    enum WeekDayType {USUAL_WEEKDAY=0, HOLIDAY=1};
+	int pdiw_index;
-
+};
-    Qt::DayOfWeek m_id;
-    QString m_name;
-    QDate m_date;
-    WeekDayType m_type;
-    ATBTariffSettings m_tariffSettings;
-    ATBTariffCarryOverSettings m_tariffCarryOverSettings;
-
-    explicit ATBWeekDay()
-        : m_id(Qt::Monday)
-        , m_name("")
-        , m_date(QDate())
-        , m_type(USUAL_WEEKDAY)
-        , m_tariffSettings()
-        , m_tariffCarryOverSettings() {}
-
-    explicit ATBWeekDay(Qt::DayOfWeek id, QString const &name, WeekDayType type,
-                        QDate const &date,
-                        ATBTariffSettings const &tariffSettings,
-                        ATBTariffCarryOverSettings const &tariffCarryOverSettings)
-        : m_id(id)
-        , m_name(name)
-        , m_date(date)
-        , m_type(type)
-        , m_tariffSettings(tariffSettings)
-        , m_tariffCarryOverSettings(tariffCarryOverSettings) {}
-
-    ATBTariffCarryOverSettings &getTariffCarryOverSettings() { return m_tariffCarryOverSettings; }
-    ATBTariffCarryOverSettings const &getTariffCarryOverSettings() const { return m_tariffCarryOverSettings; }
-
-    ATBTariffSettings &getTariffSettings() { return m_tariffSettings; }
-    ATBTariffSettings const &getTariffSettings() const { return m_tariffSettings; }
-
-    friend QDebug operator<<(QDebug debug, ATBWeekDay const &wd) {
-        QDebugStateSaver saver(debug);
-
-        debug.nospace()
-            << "                       id: " << (int)wd.m_id << "\n"
-            << "                     name: " << wd.m_name << "\n"
-            << "                     type: " << (int)wd.m_type << "\n\n"
-            << "          tariff settings: " << "\n"
-                                             << wd.m_tariffSettings << "\n"
-            << "tariff carryover settings: " << "\n"
-                                             << wd.m_tariffCarryOverSettings << endl;
-
-        return debug;
-    }
-};

library/library.pro

@@ -35,8 +35,7 @@ SOURCES += \
     src/tariff_log.cpp \
     src/calculate_price.cpp \
     src/ticket.cpp \
-    src/tariff_global_defines.cpp \
+    src/tariff_global_defines.cpp
-    src/atb_time.cpp
 
 HEADERS += \
 	include/mobilisis/calculator_functions.h \
@@ -90,8 +89,7 @@ HEADERS += \
     include/mobilisis/tariff_interpolation.h \
     include/mobilisis/tariff_prepaid.h \
     include/mobilisis/tariff_carryover.h \
-    include/mobilisis/tariff_global_defines.h \
+    include/mobilisis/tariff_global_defines.h
-    include/mobilisis/atb_time.h
 
 OTHER_FILES += src/main.cpp \
     ../tariffs/tariff_korneuburg.json \

library/src/atb_time.cpp

@@ -1,103 +0,0 @@
-#include "atb_time.h"
-
-
-ATBTime::ATBTime()
-    : m_end(QDateTime::fromString("1970-01-02T00:00:00"))
-    , m_time(QDateTime::fromString("1970-01-01T00:00:00")) {
-}
-
-ATBTime::ATBTime(int h, int m, int s, int ms)
-    : m_end(QDateTime::fromString("1970-01-02T00:00:00"))
-    , m_time(QDateTime::fromString("1970-01-01T00:00:00")) {
-
-    QTime t(h, m, s, ms);
-    m_time.setTime(t);
-}
-
-QTime ATBTime::addMSecs(int ms) const {
-    return m_time.time().addMSecs(ms);
-}
-
-QTime ATBTime::addMSecs(int ms)  {
-    QTime t = m_time.time();
-    t = t.addMSecs(ms);
-    m_time.setTime(t);
-    return t;
-}
-
-QTime ATBTime::addSecs(int s) const {
-    return m_time.time().addSecs(s);
-}
-
-QTime ATBTime::addSecs(int s)  {
-    QTime t = m_time.time();
-    t = t.addSecs(s);
-    m_time.setTime(t);
-    return t;
-}
-
-constexpr QTime ATBTime::fromMSecsSinceStartOfDay(int msecs) {
-    return QTime::fromMSecsSinceStartOfDay(msecs);
-}
-
-QTime ATBTime::fromString(QString const &string, Qt::DateFormat format) {
-    return QTime::fromString(string, format);
-}
-
-QTime ATBTime::fromString(QString const &string, QString const &format) {
-    return QTime::fromString(string, format);
-}
-
-bool ATBTime::isValid(int h, int m, int s, int ms) {
-    return QTime(h, m, s, ms).isValid();
-}
-
-int ATBTime::msecsSinceStartOfDay() const {
-    return m_time.time().msecsSinceStartOfDay();
-}
-
-bool ATBTime::setHMS(int h, int m, int s, int ms) {
-    if (isValid(h, m, s, ms)) {
-        QTime t(h, m, s, ms);
-        m_time.setTime(t);
-        return true;
-    }
-    return false;
-}
-
-QString ATBTime::toString(Qt::DateFormat format) const {
-    return m_time.time().toString(format);
-}
-
-bool operator!=(const ATBTime &lhs, const ATBTime &rhs) noexcept {
-    return lhs.m_time.time() != rhs.m_time.time();
-}
-
-bool operator<=(const ATBTime &lhs, const ATBTime &rhs) noexcept {
-    return lhs.m_time.time() <= rhs.m_time.time();
-
-}
-
-bool operator<(const ATBTime &lhs, const ATBTime &rhs) noexcept {
-    return lhs.m_time.time() < rhs.m_time.time();
-}
-
-bool operator>(const ATBTime &lhs, const ATBTime &rhs) noexcept {
-    return lhs.m_time.time() > rhs.m_time.time();
-}
-
-bool operator==(const ATBTime &lhs, const ATBTime &rhs) noexcept {
-    return lhs.m_time.time() == rhs.m_time.time();
-}
-
-QDataStream &operator<<(QDataStream &out, ATBTime time) {
-    out << time.m_time.time();
-    return out;
-}
-
-QDataStream &operator>>(QDataStream &in, ATBTime &time) {
-    QTime t;
-    in >> t;
-    time.m_time.setTime(t);
-    return in;
-}

library/src/calculate_price.cpp

@@ -26,7 +26,6 @@ QString const CalcState::BELOW_MIN_PARKING_PRICE = "BELOW_MIN_PARKING_PRICE";
 QString const CalcState::ABOVE_MAX_PARKING_PRICE = "ABOVE_MAX_PARKING_PRICE";
 QString const CalcState::OVERPAID = "OVERPAID";
 QString const CalcState::OUTSIDE_ALLOWED_PARKING_TIME = "OUTSIDE_ALLOWED_PARKING_TIME";
-QString const CalcState::SUCCESS_MAXPRICE = "SUCCESS_MAXPRICE";
 
 QList<int> CALCULATE_LIBRARY_API get_time_steps(Configuration *cfg) {
     return Calculator::GetInstance().GetTimeSteps(cfg);
@@ -37,13 +36,11 @@ int CALCULATE_LIBRARY_API get_minimal_parkingtime(Configuration const *cfg,
                                                   int paymentOptionIndex) {
     int minTime = 0;
 
-    paymentOptionIndex = getPaymentOptionIndex(*cfg);
+    qCritical() << __func__ << __LINE__ << "permit" << PermitType(permitType).toString();
-    if (paymentOptionIndex == -1) {
+
-        paymentOptionIndex = cfg->getPaymentOptionIndex(permitType);
+    paymentOptionIndex = cfg->getPaymentOptionIndex(permitType);
-    }
 
     qCritical() << __func__ << __LINE__ << "paymentOptionIndex" << paymentOptionIndex;
-    qCritical() << __func__ << __LINE__ << "permit" << PermitType(permitType).toString();
 
     switch(permitType) {
     case PERMIT_TYPE::SHORT_TERM_PARKING: { // e.g. szeged (customer_281)
@@ -73,10 +70,7 @@ int CALCULATE_LIBRARY_API get_maximal_parkingtime(Configuration const *cfg,
                                                   PERMIT_TYPE permitType,
                                                   int paymentOptionIndex) {
 
-    paymentOptionIndex = getPaymentOptionIndex(*cfg);
+    paymentOptionIndex = cfg->getPaymentOptionIndex(permitType);
-    if (paymentOptionIndex == -1) {
-        paymentOptionIndex = cfg->getPaymentOptionIndex(permitType);
-    }
     int maxTime = 0;
 
     switch(permitType) {
@@ -101,10 +95,7 @@ int CALCULATE_LIBRARY_API get_minimal_parkingprice(Configuration *cfg,
                                                    int paymentOptionIndex,
                                                    QDateTime const &start) {
     int minPrice = -1;
-
+    paymentOptionIndex = cfg->getPaymentOptionIndex(permitType);
-    if ((paymentOptionIndex = getPaymentOptionIndex(*cfg, start)) == -1) {
-        paymentOptionIndex = cfg->getPaymentOptionIndex(permitType);
-    }
 
     int payment_method_id = cfg->getPaymentOptions(paymentOptionIndex).pop_payment_method_id;
 
@@ -331,16 +322,13 @@ int CALCULATE_LIBRARY_API get_maximal_parkingprice(Configuration *cfg,
     int maxPrice = -1;
     static const PaymentMethod paymentMethodId = Utilities::getPaymentMethodId(cfg);
 
-    if ((paymentOptionIndex = getPaymentOptionIndex(*cfg)) == -1) {
+    paymentOptionIndex = cfg->getPaymentOptionIndex(permitType);
-        paymentOptionIndex = cfg->getPaymentOptionIndex(permitType);
-    }
 
     switch(permitType) {
     case PERMIT_TYPE::SHORT_TERM_PARKING: { // e.g. szeged (customer_281)
         if (paymentMethodId == PaymentMethod::Progressive || paymentMethodId == PaymentMethod::Steps) {
-            //maxPrice = Utilities::getMaximalParkingPrice(cfg, paymentMethodId);
+            paymentOptionIndex = cfg->getPaymentOptionIndex(permitType);
-            ATBPaymentOption const &po = cfg->getPaymentOptions(paymentOptionIndex);
+            maxPrice = cfg->getPaymentOptions(paymentOptionIndex).pop_max_price;
-            maxPrice = po.pop_max_price; // maxTime is given in minutes
         } else { // PaymentMethod::Linear -> e.g. szeged
             int const key = cfg->getPaymentOptions(paymentOptionIndex).pop_id;
             int const maxTime = cfg->getPaymentOptions(paymentOptionIndex).pop_max_time; // maxTime is given in minutes
@@ -488,11 +476,7 @@ int CALCULATE_LIBRARY_API compute_next_timestep(parking_tariff_t *tariff, int cu
     //    return currentTimeMinutes;
     //}
 
-    int paymentOptionIndex = getPaymentOptionIndex(*tariff);
+    int const paymentOptionIndex = tariff->getPaymentOptionIndex(permitType);
-    if (paymentOptionIndex == -1) {
-        paymentOptionIndex = tariff->getPaymentOptionIndex(permitType);
-    }
-
     int const &pop_plus_steps = tariff->getPaymentOptions(paymentOptionIndex).pop_plus_steps;
     int const &pop_minus_steps = tariff->getPaymentOptions(paymentOptionIndex).pop_minus_steps;
 
@@ -557,7 +541,7 @@ int CALCULATE_LIBRARY_API compute_next_timestep(parking_tariff_t *tariff, int cu
                 }
             }
             // max. tolerance set to 3 minutes
-            // unsigned const tolerance = std::min(minimalDistance, (unsigned)(3));
+            unsigned const tolerance = std::min(minimalDistance, (unsigned)(3));
             if (j != -1) {
                 stepList[j] = currentTimeMinutes;
             }
@@ -672,16 +656,7 @@ CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
 
     CalcState calcState;
 
-    QDate const d(1970, 1, 1);
+    int const paymentOptionIndex = tariff->getPaymentOptionIndex(permitType.get());
-    QTime const t(0, 0, 0);
-    QDateTime start(d, t, Qt::UTC);
-    start = start.toLocalTime().addSecs(start_parking_time * 60);
-    QDateTime end(start);
-
-    int paymentOptionIndex = getPaymentOptionIndex(*tariff, start);
-    if (paymentOptionIndex == -1) {
-        paymentOptionIndex = tariff->getPaymentOptionIndex(permitType.get());
-    }
 
     double minMin = tariff->PaymentOption.find(tariff->getPaymentOptions(paymentOptionIndex).pop_payment_method_id)->second.pop_min_time;
     double maxMin = tariff->PaymentOption.find(tariff->getPaymentOptions(paymentOptionIndex).pop_payment_method_id)->second.pop_max_time;
@@ -709,11 +684,11 @@ CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
         return calcState.set(CalcState::State::SUCCESS);
     }
 
-    //QDate const d(1970, 1, 1);
+    QDate const d(1970, 1, 1);
-    //QTime const t(0, 0, 0);
+    QTime const t(0, 0, 0);
-    //QDateTime start(d, t, Qt::UTC);
+    QDateTime start(d, t, Qt::UTC);
-    //start = start.toLocalTime().addSecs(start_parking_time * 60);
+    start = start.toLocalTime().addSecs(start_parking_time * 60);
-    //QDateTime end(start);
+    QDateTime end(start);
     if (start.isValid()) {
         double cost = Calculator::GetInstance().GetCostFromDuration(
                     tariff,
@@ -742,30 +717,34 @@ CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
         QDateTime &end_parking_time,
         struct price_t *price,
         PermitType permitType,
-        bool prepaid)
+        bool prepaid) {
-{
     CalcState calcState;
 
     QDateTime start_parking_time(start_parking_time_);
 
-    int paymentOptionIndex = getPaymentOptionIndex(*tariff, start_parking_time);
+    int paymentOptionIndex = tariff->getPaymentOptionIndex(permitType);
-    if (paymentOptionIndex == -1) {
+
-        paymentOptionIndex = tariff->getPaymentOptionIndex(permitType);
+    QList<int> tlist = Calculator::GetInstance().GetTimeSteps(tariff, paymentOptionIndex, start_parking_time);
-    }
+    //Q_UNUSED(tlist);
+    qCritical() << __func__ << __LINE__ << tlist;
 
     double minMin = tariff->getPaymentOptions(paymentOptionIndex).pop_min_time;
     double maxMin = tariff->getPaymentOptions(paymentOptionIndex).pop_max_time;
 
-    // DEBUG
+    // netto_parking_time = minMin;
-    qCritical() << "compute_price_for_parking_ticket() " << endl
+
-                << "          paymentOptionIndex: " << paymentOptionIndex << endl
+    //if (DBG_LEVEL >= DBG_DEBUG) {
-                << "          start_parking_time: " << start_parking_time << endl
+        qCritical() << "compute_price_for_parking_ticket() " << endl
-                << "          netto_parking_time: " << netto_parking_time << endl
+                    << "          paymentOptionIndex: " << paymentOptionIndex << endl
-                << "               start + netto: " << start_parking_time.addSecs(netto_parking_time * 60) << endl
+                    << "          start_parking_time: " << start_parking_time << endl
-                << "                      minMin: " << minMin << endl
+                    << "         start_parking_time_: " << start_parking_time_ << endl
-                << "                      maxMin: " << maxMin
+                    << "          netto_parking_time: " << netto_parking_time << endl
-                << "                     prepaid: " << prepaid
+                    << "               start + netto: " << start_parking_time.addSecs(netto_parking_time * 60) << endl
-                << "                  permitType: " << permitType.toString();
+                    << "                      minMin: " << minMin << endl
+                    << "                      maxMin: " << maxMin << endl
+                    << "                     prepaid: " << prepaid << endl
+                    << "                  permitType: " << permitType.toString();
+    //}
 
     if (netto_parking_time < 0) {
         calcState.setDesc(QString("end=%1, start=%2")
@@ -773,14 +752,17 @@ CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
                                start_parking_time.toString(Qt::ISODate)));
         return calcState.set(CalcState::State::NEGATIVE_PARKING_TIME);
     }
+
     if (netto_parking_time > maxMin) {
         calcState.setDesc(QString("duration=%1, maxMin=%2").arg(netto_parking_time).arg(maxMin));
         return calcState.set(CalcState::State::ABOVE_MAX_PARKING_TIME);
     }
+
     if (netto_parking_time < minMin) {
         calcState.setDesc(QString("duration=%1, minMin=%2").arg(netto_parking_time).arg(minMin));
         return calcState.set(CalcState::State::BELOW_MIN_PARKING_TIME);
     }
+
     if (netto_parking_time == 0) {
         return calcState.set(CalcState::State::SUCCESS);
     }
@@ -798,156 +780,57 @@ CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
                 return calcState;
             }
 
-            QList<int> tlist = Calculator::GetInstance().GetTimeSteps(tariff);
-            Q_UNUSED(tlist);
 
             // compute cost (price)
             cost = Calculator::GetInstance().GetCostFromDuration(tariff, start_parking_time, netto_parking_time, paymentOptionIndex);
 
             int weekDay = start_parking_time.date().dayOfWeek();
             int pop_carry_over_option_id = tariff->getPaymentOptions(paymentOptionIndex).pop_carry_over_option_id;
-            int pop_prepaid_option_id = tariff->getPaymentOptions(paymentOptionIndex).pop_prepaid_option_id;
 
             std::optional<ATBPeriodYear> yperiod = Utilities::GetYearPeriodActive(tariff, start_parking_time);
-            int period_id = -1;
             if (yperiod.has_value()) {
                 ATBPeriodYear const &period = yperiod.value();
-                period_id = period.pye_id;
                 pop_carry_over_option_id = period.pye_id;
-                pop_prepaid_option_id = period.pye_id;
+                //qCritical() << __func__ << __LINE__ << "re-computed carry-over-id" << pop_carry_over_option_id;
-                qCritical() << __func__ << ":" << __LINE__ << "re-computed carry-over-id" << pop_carry_over_option_id;
-                qCritical() << __func__ << ":" << __LINE__ << "   re-computed prepaid-id" << pop_prepaid_option_id;
             }
 
-            QTime carryOverStart = tariff->TariffCarryOverOptions.find(pop_carry_over_option_id)->second.carryover[weekDay].static_start;
+            QTime const carryOverStart = tariff->TariffCarryOverOptions.find(pop_carry_over_option_id)->second.carryover[weekDay].static_start;
-            int carryOverDuration = tariff->TariffCarryOverOptions.find(pop_carry_over_option_id)->second.carryover[weekDay].duration;
+            int const carryOverDuration = tariff->TariffCarryOverOptions.find(pop_carry_over_option_id)->second.carryover[weekDay].duration;
 
-            qCritical() << __func__ << ":" << __LINE__ << "   carryOverStart" << carryOverStart.toString(Qt::ISODate);
+            //qCritical() << __func__ << __LINE__ << "carryOverStart" << carryOverStart.toString(Qt::ISODate);
-            qCritical() << __func__ << ":" << __LINE__ << "carryOverDuration" << carryOverDuration;
+            //qCritical() << __func__ << __LINE__ << "carryOverDuration" << carryOverDuration;
-
-
-            QDateTime effectiveStartTime(start_parking_time);
-
-            // handle special days
-            int const specialDayId = tariff->specialDayId(start_parking_time);
-            if (specialDayId > 0) { // found special day
-                for (auto[itr, rangeEnd] = tariff->SpecialDaysWorktime.equal_range(specialDayId); itr != rangeEnd; ++itr) {
-                    ATBSpecialDaysWorktime const &wt = itr->second;
-                    switch(period_id) {
-                    case 1: // summer term
-                        if ((wt.pedwt_paid & 1) == 0) {
-                            // does not have to be paid, move to next midnight
-
-                            // better: start of next day (falls kein vorkauf besteht)
-                            effectiveStartTime = effectiveStartTime.addDays(1);
-                            effectiveStartTime.setTime(QTime(0, 0, 0));
-                        }
-                        break;
-                    case 2: // winter term
-                        if ((wt.pedwt_paid & 2) == 0) {
-                            // does not have to be paid, move to next midnight
-
-                            // better: start of next day (falls kein vorkauf besteht)
-                            effectiveStartTime = effectiveStartTime.addDays(1);
-                            effectiveStartTime.setTime(QTime(0, 0, 0));
-                        }
-                        break;
-                    default:;
-                    }
-                }
-            }
 
             // handle prepaid option
+            QDateTime effectiveStartTime(start_parking_time);
             int const prepaid_option_id = tariff->getPaymentOptions(paymentOptionIndex).pop_prepaid_option_id;
             std::optional<ATBPrepaid> prepaidOption = tariff->getPrepaidType(prepaid_option_id);
             if (prepaidOption.has_value()) {
                 ATBPrepaid const &p = prepaidOption.value();
                 if (p.never) {
-                    qCritical() << __func__ << ":" << __LINE__ << "prepaid: no";
+                    qCritical() << __func__ << __LINE__ << "prepaid: no";
                 } else {
-                    qCritical() << __func__ << ":" << __LINE__ << "    prepaidStart" << p.prepaid[weekDay].static_start.toString(Qt::ISODate);
+                    if (start_parking_time.time() < p.static_end) {     // static_end: e.g. 08:00:00
-                    qCritical() << __func__ << ":" << __LINE__ << "      prepaidEnd" << p.prepaid[weekDay].static_end.toString(Qt::ISODate);
+                        effectiveStartTime.setTime(p.static_end);
-                    qCritical() << __func__ << ":" << __LINE__ << "prepaid duration" << p.prepaid[weekDay].duration;
-
-                    if (start_parking_time.time() < p.prepaid[weekDay].static_end) {     // static_end: e.g. 08:00:00
-                        effectiveStartTime.setTime(p.prepaid[weekDay].static_end);
                     } else
-                    if (start_parking_time.time() > p.prepaid[weekDay].static_start) {   // static_start: e.g. 22:00:00
+                    if (start_parking_time.time() > p.static_start) {   // static_start: e.g. 22:00:00
-                        effectiveStartTime.setTime(p.prepaid[weekDay].static_start);
+                        effectiveStartTime.setTime(p.static_start);
+                        effectiveStartTime == effectiveStartTime.addSecs(carryOverDuration * 60);
                     }
                 }
             }
 
-            qCritical() << __func__ << ":" << __LINE__ << "effectiveStartTime:" << effectiveStartTime.toString(Qt::ISODate);
+            // handle carry over
-
+            int minutesUntilCarryOver = effectiveStartTime.time().secsTo(carryOverStart) / 60;
-            int const carryOver = tariff->getPaymentOptions(paymentOptionIndex).pop_carry_over;
+            if (netto_parking_time >= minutesUntilCarryOver) {
-
+                int const rest = netto_parking_time - minutesUntilCarryOver;
-            qCritical() << __func__ << ":" << __LINE__ << "   carryOver flag" << carryOver;
+                QDateTime s(effectiveStartTime);
-
+                s = s.addSecs(minutesUntilCarryOver * 60);
-            if (carryOver == 1) {
+                s = s.addSecs(carryOverDuration * 60);
-                QTime carryOverStart = tariff->TariffCarryOverOptions.find(pop_carry_over_option_id)->second.carryover[weekDay].static_start;
+                end_parking_time = s.addSecs(rest * 60);
-                int carryOverDuration = tariff->TariffCarryOverOptions.find(pop_carry_over_option_id)->second.carryover[weekDay].duration;
-
-                qCritical() << __func__ << ":" << __LINE__ << "   carryOverStart" << carryOverStart.toString(Qt::ISODate);
-                qCritical() << __func__ << ":" << __LINE__ << "carryOverDuration" << carryOverDuration;
-
-                // handle carry over
-                int minutesUntilCarryOver = effectiveStartTime.time().secsTo(carryOverStart) / 60;
-                if ((minutesUntilCarryOver > 0) && (netto_parking_time > minutesUntilCarryOver)) {
-                    int const rest = netto_parking_time - minutesUntilCarryOver;
-                    QDateTime s(effectiveStartTime);
-                    s = s.addSecs(minutesUntilCarryOver * 60);
-                    s = s.addSecs(carryOverDuration * 60);
-                    end_parking_time = s.addSecs(rest * 60);
-                } else {
-                    end_parking_time = effectiveStartTime.addSecs(netto_parking_time*60);
-                }
-
-                qCritical() << __func__ << ":" << __LINE__ << "end-parking-time:" << end_parking_time.toString(Qt::ISODate);
-
-                weekDay = end_parking_time.date().dayOfWeek();
-
-                // musste man in einer schleife machen
-                carryOverStart = tariff->TariffCarryOverOptions.find(pop_carry_over_option_id)->second.carryover[weekDay].static_start;
-                carryOverDuration = tariff->TariffCarryOverOptions.find(pop_carry_over_option_id)->second.carryover[weekDay].duration;
-
-                if (end_parking_time.time() > carryOverStart) {
-                    end_parking_time = end_parking_time.addSecs(carryOverDuration * 60);
-                } else
-                if (end_parking_time.time() == carryOverStart) {
-                    qCritical() << __func__ << ":" << __LINE__ << "end-parking-time:" << end_parking_time.toString(Qt::ISODate);
-                    qCritical() << __func__ << ":" << __LINE__ << "   carryOverStart" << carryOverStart.toString(Qt::ISODate);
-                    ATBPaymentOption const &po = tariff->getPaymentOptions(paymentOptionIndex);
-                    if (po.pop_apply_carry_over_to_ticket_endtime) {
-                        end_parking_time = end_parking_time.addSecs(carryOverDuration * 60);
-                        qCritical() << __func__ << ":" << __LINE__ << "end-parking-time:" << end_parking_time.toString(Qt::ISODate);
-                    }
-                }
             } else {
-                qCritical() << __func__ << ":" << __LINE__ << "NO carryOver configured";
                 end_parking_time = effectiveStartTime.addSecs(netto_parking_time*60);
             }
 
-            end_parking_time.setTime(QTime(end_parking_time.time().hour(),
-                                           end_parking_time.time().minute(), 0));
-
-            qCritical() << __func__ << ":" << __LINE__ << "end-parking-time:" << end_parking_time.toString(Qt::ISODate);
-            qCritical() << __func__ << ":" << __LINE__ << "        week-day:" << weekDay;
-
-            for (auto[itr, rangeEnd] = tariff->WeekDays.equal_range((Qt::DayOfWeek)weekDay); itr != rangeEnd; ++itr) {
-                ATBWeekDay const &wd = itr->second;
-                bool const parkTimeLimitViolated = wd.getTariffCarryOverSettings().parkingTimeLimitExceeded(effectiveStartTime,
-                                                                                                            end_parking_time,
-                                                                                                            paymentOptionIndex);
-                if (parkTimeLimitViolated) {
-                    //QTime const &tlimit = wd.getTariffCarryOverSettings().parkingTimeLimit();
-                    //end_parking_time.setTime(tlimit);
-
-                    calcState.setDesc(QString("line=%1 endTime=%2: park-time-limit violated").arg(__LINE__)
-                                        .arg(end_parking_time.time().toString(Qt::ISODate)));
-                    return calcState.set(CalcState::State::ABOVE_MAX_PARKING_TIME);
-                }
-            }
         } else {
             cost = Calculator::GetInstance().GetCostFromDuration(
                         tariff,
@@ -965,8 +848,8 @@ CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
         }
 
         // DEBUG
-        //qCritical() << __LINE__ << "            end_parking_time: " << end_parking_time;
+        // qCritical() << __LINE__ << "            end_parking_time: " << end_parking_time;
-        //qCritical() << __LINE__ << "  -> calculated cost (netto): " << cost;
+        qCritical() << __LINE__ << "  -> calculated cost (netto): " << cost;
 
         price->brutto = price->vat = price->vat_percentage = 0;
         price->units = cost;
@@ -980,6 +863,7 @@ CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
         end_parking_time = end_parking_time.addDays(-1);
         end_parking_time.setTime(QTime(23, 59, 0));
     }
+
     qCritical() << __func__ << __LINE__ << "end_parking_time" << end_parking_time.toString(Qt::ISODate);
 
     return calcState.set(CalcState::State::SUCCESS);
@@ -1000,12 +884,7 @@ CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
         QString cs = start.toString(Qt::ISODate);
 
         bool prepaid = true;
-        int paymentOptionIndex = getPaymentOptionIndex(*tariff, start);
+        int paymentOptionIndex = tariff->getPaymentOptionIndex(permitType);
-        qCritical() << " payment option index: " << paymentOptionIndex;
-        if (paymentOptionIndex == -1) {
-            paymentOptionIndex = tariff->getPaymentOptionIndex(permitType);
-        }
-
         int prepaid_option_id = tariff->getPaymentOptions(paymentOptionIndex).pop_prepaid_option_id;
         if (prepaid_option_id == 2) { // see tariff03.json for 502: 2 means no prepaid-option
             prepaid = false;
@@ -1019,14 +898,10 @@ CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
         qCritical() << "           start (cs): " << cs;
         qCritical() << "                price: " << price;
 
-        std::pair<std::string, QDateTime> p_duration
+        duration = Calculator::GetInstance().GetDurationFromCost(tariff,
-                = Calculator::GetInstance().GetDurationFromCost(tariff,
+                                                  tariff->getPaymentOptions(paymentOptionIndex).pop_payment_method_id,
-                    tariff->getPaymentOptions(paymentOptionIndex).pop_payment_method_id,
+                                                  cs.toLocal8Bit().constData(),
-                                              cs.toLocal8Bit().constData(),
+                                                  price, permitType, nextDay, prepaid).c_str();
-                                              price, permitType, nextDay, prepaid);
-        duration = p_duration.first.c_str();
-
-
         QDateTime d = QDateTime::fromString(duration, Qt::ISODate);
         if (!d.isValid()) {
             calcState.setDesc(QString("ticketEndTime=%1").arg(duration));
@@ -1049,17 +924,8 @@ CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
     CalcState calcState;
 
     bool prepaid = true;
-
+    int paymentOptionIndex = tariff->getPaymentOptionIndex(permitType);
-    int paymentOptionIndex = getPaymentOptionIndex(*tariff, start_parking_time);
-    qCritical() << __func__ << ":" << __LINE__ << "payment option index: " << paymentOptionIndex;
-    if (paymentOptionIndex == -1) {
-        paymentOptionIndex = tariff->getPaymentOptionIndex(permitType);
-    }
-
-    qCritical() << __func__ << ":" << __LINE__ << " payment option index: " << paymentOptionIndex;
-
     int prepaid_option_id = tariff->getPaymentOptions(paymentOptionIndex).pop_prepaid_option_id;
-
     if (prepaid_option_id == 2) {
         prepaid = false;
     }
@@ -1074,39 +940,12 @@ CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
     }
 
     if (start_parking_time.isValid()) {
-
-        int const pop_time_step_config = tariff->getPaymentOptions(paymentOptionIndex).pop_time_step_config;
-        if (pop_time_step_config == (int)ATBTimeStepConfig::TimeStepConfig::STATIC) {
-            // handle prepaid option
-            QDateTime effectiveStartTime(start_parking_time);
-            int const prepaid_option_id = tariff->getPaymentOptions(paymentOptionIndex).pop_prepaid_option_id;
-            std::optional<ATBPrepaid> prepaidOption = tariff->getPrepaidType(prepaid_option_id);
-            if (prepaidOption.has_value()) {
-                ATBPrepaid const &p = prepaidOption.value();
-                if (p.never) {
-                    qCritical() << __func__ << __LINE__ << "prepaid: no";
-                } else {
-                    if (start_parking_time.time() < p.static_end) {     // static_end: e.g. 08:00:00
-                        effectiveStartTime.setTime(p.static_end);
-                    } else
-                    if (start_parking_time.time() > p.static_start) {   // static_start: e.g. 22:00:00
-                        effectiveStartTime.setTime(p.static_start);
-                    }
-                }
-            }
-        }
-
         QString cs = start_parking_time.toString(Qt::ISODate);
-
+        QString endTime = Calculator::GetInstance().GetDurationFromCost(
-        std::pair<std::string, QDateTime> p_endTime
-                = Calculator::GetInstance().GetDurationFromCost(
                     tariff,
                     tariff->getPaymentOptions().pop_payment_method_id,
                     cs.toLocal8Bit().constData(),
-                    price, permitType, nextDay, prepaid);
+                    price, permitType, nextDay, prepaid).c_str();
-
-        QString endTime = p_endTime.first.c_str();
-        ticketEndTime = p_endTime.second;
 
         if (endTime == CalcState::SUCCESS) {
             calcState.setDesc(QString("SUCCESS"));
@@ -1168,105 +1007,20 @@ CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
         } else {
             ticketEndTime = QDateTime::fromString(endTime,Qt::ISODate);
 
-            qCritical() << __func__ << ":" << __LINE__ << "ticketEndTime:" << ticketEndTime.toString(Qt::ISODate);
-            qCritical() << __func__ << ":" << __LINE__ << "step-config:" << pop_time_step_config;
-
             if (!ticketEndTime.isValid()) {
                 calcState.setDesc(QString("ticketEndTime=%1").arg(endTime));
                 return calcState.set(CalcState::State::WRONG_ISO_TIME_FORMAT);
             }
 
-            if (pop_time_step_config == (int)ATBTimeStepConfig::TimeStepConfig::STATIC) {
-                // handle carry over for ticket-end-time
-                qCritical() << __func__ << ":" << __LINE__ << "ticketEndTime:" << ticketEndTime.toString(Qt::ISODate);
-
-                int weekDay = start_parking_time.date().dayOfWeek();
-                int pop_carry_over_option_id = tariff->getPaymentOptions(paymentOptionIndex).pop_carry_over_option_id;
-                qCritical() << __func__ << ":" << __LINE__ << "configured carry-over-id" << pop_carry_over_option_id;
-
-                std::optional<ATBPeriodYear> yperiod = Utilities::GetYearPeriodActive(tariff, start_parking_time);
-                if (yperiod.has_value()) {
-                    ATBPeriodYear const &period = yperiod.value();
-                    pop_carry_over_option_id = period.pye_id;
-                    qCritical() << __func__ << ":" << __LINE__ << "re-computed carry-over-id" << pop_carry_over_option_id;
-                }
-
-                QTime carryOverStart;
-                QTime carryOverEnd;
-                int carryOverDuration = -1;
-
-                // using TariffCarryOverType = std::multimap<int, ATBCarryOver>;
-                std::multimap<int, ATBCarryOver>::const_iterator it;
-                if ((it = tariff->TariffCarryOverOptions.find(pop_carry_over_option_id)) !=
-                    tariff->TariffCarryOverOptions.cend()) {
-                    carryOverStart = it->second.carryover[weekDay].static_start;
-                    carryOverEnd = it->second.carryover[weekDay].static_end;
-                    carryOverDuration = it->second.carryover[weekDay].duration;
-                }
-
-                if (carryOverStart.isValid() && carryOverEnd.isValid()) {
-                    qCritical() << __func__ << ":" << __LINE__ << "carryOverStart" << carryOverStart.toString(Qt::ISODate);
-                    qCritical() << __func__ << ":" << __LINE__ << "carryOverEnd" << carryOverEnd.toString(Qt::ISODate);
-                    qCritical() << __func__ << ":" << __LINE__ << "carryOverDuration" << carryOverDuration;
-                }
-
-                if (carryOverStart.isValid() && carryOverEnd.isValid() && carryOverDuration != -1) {
-                    // qCritical() << __func__ << __LINE__ << "ticketEndTime.time():" << ticketEndTime.time().toString(Qt::ISODate);
-                    if (ticketEndTime.time() > carryOverStart) {
-                        // qCritical() << __func__ << __LINE__ << "ticketEndTime.time():" << ticketEndTime.time().toString(Qt::ISODate);
-                        ticketEndTime = ticketEndTime.addSecs(carryOverDuration * 60);
-                    } else
-                    if (ticketEndTime.time() == carryOverStart) {
-                        qCritical() << __func__ << __LINE__ << "ticketEndTime.time():" << ticketEndTime.time().toString(Qt::ISODate);
-                        qCritical() << __func__ << ":" << __LINE__ << "   carryOverStart" << carryOverStart.toString(Qt::ISODate);
-                        ATBPaymentOption const &po = tariff->getPaymentOptions(paymentOptionIndex);
-                        if (po.pop_apply_carry_over_to_ticket_endtime) {
-                            ticketEndTime = ticketEndTime.addSecs(carryOverDuration * 60);
-                            qCritical() << __func__ << __LINE__ << "ticketEndTime.time():" << ticketEndTime.time().toString(Qt::ISODate);
-                        }
-                    } else {
-                        // qCritical() << __func__ << __LINE__ << "ticketEndTime.time():" << ticketEndTime.time().toString(Qt::ISODate);
-                        if (ticketEndTime.time() < carryOverEnd) {
-                            // qCritical() << __func__ << __LINE__ << "ticketEndTime.time():" << ticketEndTime.time().toString(Qt::ISODate);
-                            ticketEndTime = ticketEndTime.addSecs(carryOverDuration * 60);
-                        }
-                    }
-                } else {
-                    qCritical() << __func__ << ":" << __LINE__ << "WARNING: wrong carry-over-settings";
-                }
-            }
-
-
-            ticketEndTime.setTime(QTime(ticketEndTime.time().hour(),
-                                        ticketEndTime.time().minute(), 0));
-
-            qCritical() << __func__ << ":" << __LINE__ << "ticketEndTime:" << ticketEndTime.toString(Qt::ISODate);
-
-            for (auto[itr, rangeEnd] = tariff->WeekDays.equal_range((Qt::DayOfWeek)(ticketEndTime.date().dayOfWeek()));
-                 itr != rangeEnd;
-                 ++itr) {
-                ATBWeekDay const &wd = itr->second;
-                bool const parkTimeLimitViolated = wd.getTariffCarryOverSettings().parkingTimeLimitExceeded(start_parking_time,
-                                                                                                            ticketEndTime,
-                                                                                                            paymentOptionIndex);
-                if (parkTimeLimitViolated) {
-                    //QTime const &tlimit = wd.getTariffCarryOverSettings().parkingTimeLimit();
-                    //ticketEndTime.setTime(tlimit);
-
-                    calcState.setDesc(QString("line=%1 endTime=%2: park-time-limit violated").arg(__LINE__)
-                                      .arg(ticketEndTime.time().toString(Qt::ISODate)));
-                    return calcState.set(CalcState::State::ABOVE_MAX_PARKING_TIME);
-                }
-            }
-
             if (ticketEndTime.time().hour() == 0 && ticketEndTime.time().minute() == 0) {
                 ticketEndTime = ticketEndTime.addDays(-1);
                 ticketEndTime.setTime(QTime(23, 59, 0));
             }
 
             // DEBUG
-            qCritical() << __func__ << ":" << __LINE__ << "      endTime:" << endTime;
+            qCritical() << "compute_duration_for_parking_ticket(): ";
-            qCritical() << __func__ << ":" << __LINE__ << "ticketEndTime:" << ticketEndTime.toString(Qt::ISODate);
+            qCritical() << "                 endTime: " << endTime;
+            qCritical() << "           ticketEndTime: " << ticketEndTime;
         }
     } else {
         return calcState.set(CalcState::State::INVALID_START_DATE);
@@ -1278,7 +1032,7 @@ CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
 CalcState CALCULATE_LIBRARY_API compute_duration_for_daily_ticket(parking_tariff_t *tariff,
                                                                   QDateTime const &start_parking_time,
                                                                   QDateTime &ticketEndTime,
-                                                                  PermitType /* PermitType */)
+                                                                  PermitType PermitType)
 {
     CalcState calcState;
     if (start_parking_time.isValid()) {

library/src/calculator_functions.cpp

@@ -117,15 +117,125 @@ QDateTime Calculator::GetDailyTicketDuration(Configuration* cfg, const QDateTime
 
     return QDateTime();
 }
+
+int Calculator::computeBruttoDurationInSecs(Configuration const *cfg,
+                                            QDateTime const &start,
+                                            int nettoDurationInSecs,
+                                            bool maxBrutto) {
+    QDateTime from(start);
+    int bruttoDurationInSecs = 0;
+
+    if (DBG_LEVEL >= DBG_DEBUG) {
+        qCritical() << DBG_HEADER << "netto duration in secs" << nettoDurationInSecs;
+    }
+
+    while (nettoDurationInSecs > 0) {
+        int day_in_week_id = from.date().dayOfWeek();
+        int count = cfg->WeekDaysWorktime.count(day_in_week_id);
+
+        if (DBG_LEVEL >= DBG_DEBUG) {
+            qCritical() << DBG_HEADER << "count for " << day_in_week_id << ": " << count;
+        }
+
+        if (count > 0) {
+            for (auto[iter, rEnd] = cfg->WeekDaysWorktime.equal_range(day_in_week_id); iter != rEnd; ++iter) {
+                QTime const &pwd_time_from = QTime::fromString(QString::fromStdString(iter->second.pwd_time_from), Qt::ISODate);
+                QTime const &pwd_time_to = QTime::fromString(QString::fromStdString(iter->second.pwd_time_to), Qt::ISODate);
+                QTime fromTime = from.time();
+
+                if (DBG_LEVEL >= DBG_DEBUG) {
+                    qCritical() << DBG_HEADER;
+                    qCritical() << DBG_HEADER << " wd-from" << pwd_time_from.toString(Qt::ISODate);
+                    qCritical() << DBG_HEADER << "   wd-to" << pwd_time_to.toString(Qt::ISODate);
+                    qCritical() << DBG_HEADER << "fromTime" << fromTime.toString(Qt::ISODate);
+                    qCritical() << DBG_HEADER << "    from" << from.toString(Qt::ISODate);
+                    qCritical() << DBG_HEADER;
+                }
+
+                if (fromTime <= pwd_time_from) {
+                    int secs = fromTime.secsTo(pwd_time_from);
+                    bruttoDurationInSecs += secs;
+                    fromTime = pwd_time_from;
+                    from.setTime(pwd_time_from);
+                }
+
+                if (DBG_LEVEL >= DBG_DEBUG) {
+                    qCritical() << DBG_HEADER << "fromTime" << fromTime.toString(Qt::ISODate);
+                    qCritical() << DBG_HEADER << "    from" << from.toString(Qt::ISODate);
+                    qCritical() << DBG_HEADER << "   netto" << nettoDurationInSecs;
+                    qCritical() << DBG_HEADER << "  brutto" << bruttoDurationInSecs;
+                    qCritical() << DBG_HEADER << " br-date" << start.addSecs(bruttoDurationInSecs);
+                }
+
+                while (fromTime < pwd_time_to && nettoDurationInSecs > 0) {
+                    bruttoDurationInSecs += 60;
+                    nettoDurationInSecs -= 60;
+                    fromTime = fromTime.addSecs(60);
+                    from = from.addSecs(60);
+                }
+
+                if (DBG_LEVEL >= DBG_DEBUG) {
+                    qCritical() << DBG_HEADER;
+                    qCritical() << DBG_HEADER << "   netto" << nettoDurationInSecs;
+                    qCritical() << DBG_HEADER << "  brutto" << bruttoDurationInSecs;
+                    qCritical() << DBG_HEADER << " br-date" << start.addSecs(bruttoDurationInSecs);
+                    qCritical() << DBG_HEADER << "fromTime" << fromTime.toString(Qt::ISODate);
+                    qCritical() << DBG_HEADER << "    from" << from.toString(Qt::ISODate);
+                    qCritical() << DBG_HEADER;
+                }
+
+                if (--count == 0 && fromTime == pwd_time_to) {
+                    // handle rest
+                    QDateTime midnight(from);
+                    midnight = midnight.addDays(1);
+                    midnight.setTime(QTime(0, 0, 0));
+                    int secs =  from.secsTo(midnight);
+                    bruttoDurationInSecs += secs;
+                    from = midnight;
+
+                    if (DBG_LEVEL >= DBG_DEBUG) {
+                        qCritical() << DBG_HEADER;
+                        qCritical() << DBG_HEADER << "   netto" << nettoDurationInSecs;
+                        qCritical() << DBG_HEADER << "  brutto" << bruttoDurationInSecs;
+                        qCritical() << DBG_HEADER << " br-date" << start.addSecs(bruttoDurationInSecs);
+                        qCritical() << DBG_HEADER << "    from" << from.toString(Qt::ISODate);
+                        qCritical() << DBG_HEADER;
+                    }
+                }
+            }
+
+        } else {
+            bruttoDurationInSecs += (24 * 3600);
+            from = from.addDays(1);
+        }
+    }
+
+    if (maxBrutto) {
+        qCritical() << DBG_HEADER << "TODO";
+    }
+
+    if (DBG_LEVEL >= DBG_DEBUG) {
+        qCritical() << DBG_HEADER << " br-date" << start.addSecs(bruttoDurationInSecs);
+    }
+
+    return bruttoDurationInSecs;
+}
+
+QDateTime Calculator::computeBruttoDateTime(Configuration const *cfg,
+                                            QDateTime const &from,
+                                            int durationInSecs,
+                                            bool maxBrutto) {
+    return from.addSecs(computeBruttoDurationInSecs(cfg, from, durationInSecs, maxBrutto));
+}
+
 /// <inheritdoc/>
-std::pair<std::string, QDateTime>
+std::string Calculator::GetDurationFromCost(Configuration* cfg,
-Calculator::GetDurationFromCost(Configuration* cfg,
+                                            uint8_t payment_option,
-                                uint8_t payment_option,
+                                            char const *startDatetimePassed, // given in local time
-                                char const *startDatetimePassed, // given in local time
+                                            double cost,
-                                double cost,
+                                            PermitType permitType,
-                                PermitType /*permitType*/,
+                                            bool nextDay,
-                                bool nextDay,
+                                            bool prepaid)
-                                bool prepaid)
 {
     Q_UNUSED(payment_option);
     Q_UNUSED(nextDay);
@@ -134,16 +244,7 @@ Calculator::GetDurationFromCost(Configuration* cfg,
     QDateTime inputDate = QDateTime::fromString(startDatetimePassed, Qt::ISODate);
     inputDate.setTime(QTime(inputDate.time().hour(), inputDate.time().minute(), 0));
     static const PaymentMethod paymentMethodId = Utilities::getPaymentMethodId(cfg);
-
+    int const paymentOptionIndex = cfg->getPaymentOptionIndex(permitType.get());
-    bool overPaid = false;
-    bool successMaxPrice = false; // max-price and cost match
-
-    int paymentOptionIndex = getPaymentOptionIndex(*cfg, inputDate);
-    if (paymentOptionIndex == -1) {
-        paymentOptionIndex = cfg->getPaymentOptionIndex(QDateTime::fromString(startDatetimePassed, Qt::ISODate));
-    }
-
-    qCritical() << DBG_HEADER << "   option index:" << paymentOptionIndex;
 
     if (DBG_LEVEL >= DBG_DEBUG) {
         qCritical() << DBG_HEADER << "          start:" << inputDate.toString(Qt::ISODate);
@@ -166,7 +267,7 @@ Calculator::GetDurationFromCost(Configuration* cfg,
             // minimal price is set by GetTimeSteps()
             qCritical() << DBG_HEADER << "   provided price (cost):" << cost;
             qCritical() << DBG_HEADER << "configured minimal price:" << cfg->getPaymentOptions(paymentOptionIndex).pop_min_price;
-            return std::make_pair(CalcState::BELOW_MIN_PARKING_PRICE.toStdString(), QDateTime());
+            return CalcState::BELOW_MIN_PARKING_PRICE.toStdString();
         }
 
         if (prepaid == false) {
@@ -191,8 +292,8 @@ Calculator::GetDurationFromCost(Configuration* cfg,
                     price = pra_price;
                 }
 
-                // qCritical() << DBG_HEADER << "  PRICE" << price << "COST" << cost;
+                //qCritical() << DBG_HEADER << "  PRICE" << price << "COST" << cost;
-                // qCritical() << DBG_HEADER << "  duration id" << durationId;
+                //qCritical() << DBG_HEADER << "  duration id" << durationId;
 
                 auto search = cfg->Duration.find(durationId);
                 if (search != cfg->Duration.end()) {
@@ -226,12 +327,12 @@ Calculator::GetDurationFromCost(Configuration* cfg,
 
                             qCritical() << DBG_HEADER << "                    provided price (cost):" << cost;
                             qCritical() << DBG_HEADER << "        computed time for price (minutes):" << duration_previous;
-                            qCritical() << DBG_HEADER << "           minimal parking time (minutes):" << cfg->getPaymentOptions(paymentOptionIndex).pop_min_time;
+                            qCritical() << DBG_HEADER << "configured minimal parking time (minutes):" << cfg->getPaymentOptions(paymentOptionIndex).pop_min_time;
 
                             if (duration_previous < cfg->getPaymentOptions(paymentOptionIndex).pop_min_time) {
-                                return std::make_pair(CalcState::BELOW_MIN_PARKING_TIME.toStdString(), d); // minimal parking time is set by GetTimeSteps()
+                                return CalcState::BELOW_MIN_PARKING_TIME.toStdString(); // minimal parking time is set by GetTimeSteps()
                             }
-                            return std::make_pair(d.toString(Qt::ISODate).toStdString(), d);
+                            return d.toString(Qt::ISODate).toStdString();
                         }
                     }
 
@@ -244,7 +345,7 @@ Calculator::GetDurationFromCost(Configuration* cfg,
                         qCritical() << DBG_HEADER << "   provided price (cost):" << cost;
                         qCritical() << DBG_HEADER << "      duration for price:" << durationStr;
 
-                        return std::make_pair(durationStr.toStdString(), d);
+                        return durationStr.toStdString();
                     }
                 }
             }
@@ -258,41 +359,30 @@ Calculator::GetDurationFromCost(Configuration* cfg,
             // use tariff with structure as for instance Schoenau, Koenigsee:
             // without given YearPeriod, SpecialDays and SpecialDaysWorktime
             inputDate = inputDate.addSecs(GetDurationForPrice(cfg, cost) * 60);
-            return std::make_pair(inputDate.toString(Qt::ISODate).toStdString(), inputDate);
+            return inputDate.toString(Qt::ISODate).toStdString();
         } else {
             if (Utilities::IsYearPeriodActive(cfg, inputDate)) {
                 if (!prepaid) {
                     CalcState cs = isParkingAllowed(cfg, inputDate);
                     if (cs) {
                         inputDate.setTime(cs.getAllowedTimeRange().getTimeUntil());
-                        return std::make_pair(inputDate.toString(Qt::ISODate).toStdString(), inputDate);
+                        return inputDate.toString(Qt::ISODate).toStdString();
                     }
                 }
 
                 int const pop_id = cfg->getPaymentOptions(paymentOptionIndex).pop_id;
                 int const pop_max_price = cfg->getPaymentOptions(paymentOptionIndex).pop_max_price;
                 int const pop_min_price = cfg->getPaymentOptions(paymentOptionIndex).pop_min_price;
-                int const pop_allow_overpay = cfg->getPaymentOptions(paymentOptionIndex).pop_allow_overpay;
-
-                if (cost == pop_max_price) {
-                    qCritical() << DBG_HEADER << "SUCCESS MAX-PARKING-PRICE" << pop_max_price << ", COST" << cost;
-                    successMaxPrice = true;
-                }
 
                 if (cost > pop_max_price) {
-                    qCritical() << DBG_HEADER << "MAX-PARKING-PRICE" << pop_max_price << ", COST" << cost;
-                    if (pop_allow_overpay == false) {
-                        return std::make_pair(CalcState::OVERPAID.toStdString(), QDateTime());
-                    }
                     cost = pop_max_price;
-                    overPaid = true;
+                    qCritical() << DBG_HEADER << "MAX-PARKING-PRICE" << pop_max_price << ", COST" << cost;
-                    qCritical() << DBG_HEADER << "OVERPAID, MAX-PARKING-PRICE" << pop_max_price << ", COST" << cost;
+                    //return CalcState::OVERPAID.toStdString();
-                    // return CalcState::OVERPAID.toStdString();
                 }
 
                 if (cost < pop_min_price) {
                     qCritical() << DBG_HEADER << "MIN-PARKING-PRICE" << pop_min_price << ", COST" << cost;
-                    return std::make_pair(CalcState::BELOW_MIN_PARKING_PRICE.toStdString(), QDateTime());
+                    return CalcState::BELOW_MIN_PARKING_PRICE.toStdString();
                 }
 
                 // int const pop_pre_paid = 1;
@@ -365,8 +455,6 @@ Calculator::GetDurationFromCost(Configuration* cfg,
 #if DEBUG_GET_DURATION_FROM_COST==1
                 qCritical() << DBG_HEADER << "(ADAPTED) INPUT-DATE" << inputDate.toString(Qt::ISODate);
 #endif
-                //qCritical() << __func__ << __LINE__;
-
                 // inputDate is now located in a valid operational-working-range
                 // find this working-time-range
                 int pwd_period_day_in_week_id = inputDate.date().dayOfWeek();
@@ -377,11 +465,9 @@ Calculator::GetDurationFromCost(Configuration* cfg,
                     qCritical() << DBG_HEADER
                                 << "ERROR" << inputDate.toString(Qt::ISODate)
                                 << "NOT IN VALID WORKING TIME-RANGE";
-                    return std::make_pair("", QDateTime());
+                    return "";
                 }
 
-                //qCritical() << __func__ << __LINE__;
-
                 QTime current_working_time_from;
                 QTime current_working_time_to;
 
@@ -402,7 +488,7 @@ Calculator::GetDurationFromCost(Configuration* cfg,
                     qCritical() << DBG_HEADER
                                 << "ERROR" << inputDate.toString(Qt::ISODate)
                                 << "NOT IN VALID WORKING TIME-RANGE";
-                    return std::make_pair("", QDateTime());
+                    return "";
                 }
 
 #if DEBUG_GET_DURATION_FROM_COST==1
@@ -411,12 +497,11 @@ Calculator::GetDurationFromCost(Configuration* cfg,
 #endif
 
                 int const pop_accumulate_prices = cfg->getPaymentOptions(paymentOptionIndex).pop_accumulate_prices;
-                // int const pop_accumulate_durations = cfg->getPaymentOptions(paymentOptionIndex).pop_accumulate_durations;
+                int const pop_accumulate_durations = cfg->getPaymentOptions(paymentOptionIndex).pop_accumulate_durations;
                 int price = 0;
                 int new_price = 0;
                 int durationInSecs = 0;
                 uint32_t duration_previous = 0;
-                // bool found = false;
 
                 for (auto[itr, rangeEnd] = cfg->PaymentRate.equal_range(pop_id); itr != rangeEnd; ++itr) {
                     int const pra_price = itr->second.pra_price;
@@ -439,30 +524,39 @@ Calculator::GetDurationFromCost(Configuration* cfg,
                             uint32_t const durationUnit = cfg->Duration.find(durationId)->second.pun_duration;
 
                             new_price += pra_price;
-                            //qCritical() << "(" << __func__ << ":" << __LINE__ << ")  XXXXXX    price:" << price;
+
-                            //qCritical() << "(" << __func__ << ":" << __LINE__ << ")  YYYYYY    new_price:" << new_price;
+#if DEBUG_GET_DURATION_FROM_COST==1
+                            qCritical() << "(" << __func__ << ":" << __LINE__ << ") pra_price:" << pra_price;
+                            qCritical() << "(" << __func__ << ":" << __LINE__ << ")     price:" << price;
+                            qCritical() << "(" << __func__ << ":" << __LINE__ << ")      cost:" << cost;
+                            qCritical() << "(" << __func__ << ":" << __LINE__ << ") new_price:" << new_price;
+#endif
+
                             if (new_price <= cost) {
-                               duration_previous = durationUnit;
+                                if (pop_accumulate_durations) {
-                               //qCritical() << "(" << __func__ << ":" << __LINE__ << ") ZZZZZZ duration_previous" << duration_previous;
+                                    duration_previous += durationUnit;
+                                } else {
+                                    duration_previous = durationUnit;
+                                }
+                                durationInSecs = duration_previous * 60;
+
+#if DEBUG_GET_DURATION_FROM_COST==1
+                                qCritical() << "(" << __func__ << ":" << __LINE__ << ")      durationUnit" << durationUnit;
+                                qCritical() << "(" << __func__ << ":" << __LINE__ << ") duration_previous" << duration_previous;
+                                qCritical() << "(" << __func__ << ":" << __LINE__ << ")    durationInSecs" << durationInSecs;
+#endif
+
                             } else {
-                               //found = true;
+                                // qCritical() << "(" << __func__ << ":" << __LINE__ << ") duration_previous" << duration_previous;
-                               //qCritical() << "(" << __func__ << ":" << __LINE__ << ") WWWWWW duration_previous" << duration_previous;
                                 QString s = inputDate.toString(Qt::ISODate);
                                 QDateTime d(QDateTime::fromString(s, Qt::ISODate));
                                 d = d.addSecs(duration_previous * 60);
-                                //qCritical() << DBG_HEADER << "XXXXXXXXXXXXXXXXXXXXX" << d;
+                                return d.toString(Qt::ISODate).toStdString();
-                                if (overPaid) {
-                                    return std::make_pair(CalcState::OVERPAID.toStdString(), d);
-                                }
-                                if (successMaxPrice) {
-                                    return std::make_pair(CalcState::SUCCESS_MAXPRICE.toStdString(), d);
-                                }
-                                return std::make_pair(d.toString(Qt::ISODate).toStdString(), d);
                             }
                         } else {
                             durationInSecs = cfg->Duration.find(durationId)->second.pun_duration * 60;
-                            //qCritical() << DBG_HEADER << "DURATION-SECS" << durationInSecs;
+                            qCritical() << DBG_HEADER << "DURATION-SECS" << durationInSecs;
-                            //qCritical() << DBG_HEADER << "DURATION-MINS" << durationInSecs / 60;
+                            qCritical() << DBG_HEADER << "DURATION-MINS" << durationInSecs / 60;
                         }
 
                         if ((double)price == cost) {
@@ -475,25 +569,50 @@ Calculator::GetDurationFromCost(Configuration* cfg,
                             qCritical() << DBG_HEADER << "DURATION IN SECONDS" << durationInSecs;
                             qCritical() << DBG_HEADER << "CURRENT-WORKING-DATE-TIME-TO"
                                                       << current_working_date_time_to.toString(Qt::ISODate);
+                            qCritical() << DBG_HEADER << "    INPUT DATE" << inputDate.toString(Qt::ISODate);
                             qCritical() << DBG_HEADER << "NEW INPUT DATE" << inputDate.addSecs(durationInSecs).toString(Qt::ISODate);
 #endif
-
                             if (inputDate.addSecs(durationInSecs) > current_working_date_time_to) {
+                                int bruttoDurationInSecs = computeBruttoDurationInSecs(cfg, inputDate, durationInSecs);
+//                                qCritical() << DBG_HEADER << "DURATION IN SECONDS  (NETTO)" << durationInSecs;
+//                                qCritical() << DBG_HEADER << "DURATION IN SECONDS (BRUTTO)" << bruttoDurationInSecs;
+
+                                inputDate = inputDate.addSecs(bruttoDurationInSecs);
+#if 0
+                                // durationInSecs is a netto time
+                                // needed is the corresponding brutto-time
+                                int day_in_week_id = inputDate.date().dayOfWeek();
+                                int nettoDurationInSecs = 0;
+
+                                while (nettoDurationInSecs <= durationInSecs) {
+                                    if (cfg->WeekDaysWorktime.count(day_in_week_id) > 0) {
+                                        for (auto[iter, rEnd] = cfg->WeekDaysWorktime.equal_range(day_in_week_id); iter != rEnd; ++iter) {
+                                            QTime pwd_time_from = QTime::fromString(QString::fromStdString(iter->second.pwd_time_from), Qt::ISODate);
+                                            QTime pwd_time_to = QTime::fromString(QString::fromStdString(iter->second.pwd_time_to), Qt::ISODate);
+                                            nettoDurationInSecs += pwd_time_from.secsTo(pwd_time_to);
+                                            if (nettoDurationInSecs > durationInSecs) {
+                                                break;
+                                            }
+                                        }
+                                    }
+                                    day_in_week_id += 1;
+                                    if (day_in_week_id > (int)Qt::Sunday) {
+                                        day_in_week_id = Qt::Monday;
+                                    }
+                                }
+                                qCritical() << DBG_HEADER;
+
                                 QTime next_working_time_from;
                                 if (cfg->getPaymentOptions(paymentOptionIndex).pop_carry_over != 0) {
-#if DEBUG_GET_DURATION_FROM_COST==1
                                     qCritical() << DBG_HEADER << "CARRY-OVER SET";
-#endif
                                     // check for next working-time-range on same day
                                     int day_in_week_id = inputDate.date().dayOfWeek();
                                     for (auto[iter, rEnd] = cfg->WeekDaysWorktime.equal_range(day_in_week_id); iter != rEnd; ++iter) {
                                         QTime pwd_time_from = QTime::fromString(QString::fromStdString(iter->second.pwd_time_from), Qt::ISODate);
                                         if (pwd_time_from > current_working_time_to) {
                                             next_working_time_from = pwd_time_from;
-#if DEBUG_GET_DURATION_FROM_COST==1
                                             qCritical() << DBG_HEADER << "NEXT-WORKING-TIME-FROM"
                                                         << next_working_time_from.toString(Qt::ISODate);
-#endif
                                             break;
                                         }
                                     }
@@ -510,33 +629,33 @@ Calculator::GetDurationFromCost(Configuration* cfg,
                                                     QTime pwd_time_from = QTime::fromString(QString::fromStdString(iter->second.pwd_time_from), Qt::ISODate);
                                                     if (next_working_time_from < pwd_time_from) {
                                                         next_working_time_from = pwd_time_from;
+                                                        qCritical() << DBG_HEADER << "           day in week" << day_in_week_id;
                                                         qCritical() << DBG_HEADER << "next working time from" << next_working_time_from.toString(Qt::ISODate);
                                                         break;
                                                     }
                                                 }
 
-                                                //qCritical() << DBG_HEADER << "DAYS" << days;
+                                                qCritical() << DBG_HEADER << "DAYS" << days;
-                                                //qCritical() << DBG_HEADER << "DURATION-SECS" << durationInSecs;
+                                                qCritical() << DBG_HEADER << "DURATION-SECS" << durationInSecs;
-                                                //qCritical() << DBG_HEADER << "DURATION-MINS" << durationInSecs / 60;
+                                                qCritical() << DBG_HEADER << "DURATION-MINS" << durationInSecs / 60;
 
                                                 QDateTime upper = inputDate.addDays(days);
                                                 upper.setTime(next_working_time_from);
 
-                                                //qCritical() << DBG_HEADER << "UPPER" << upper.toString(Qt::ISODate);
+                                                qCritical() << DBG_HEADER << "UPPER" << upper.toString(Qt::ISODate);
 
                                                 QDateTime lower = inputDate;
                                                 lower.setTime(current_working_time_to);
 
-                                                //qCritical() << DBG_HEADER << "LOWER" << lower.toString(Qt::ISODate);
+                                                qCritical() << DBG_HEADER << "LOWER" << lower.toString(Qt::ISODate);
 
                                                 // inputDate = inputDate.addSecs(lower.secsTo(upper));
 
                                                 //qCritical() << DBG_HEADER << "NEW INPUT" << inputDate.toString(Qt::ISODate);
 
-                                                inputDate = inputDate.addSecs(durationInSecs);
+                                                // durationInSecs is a netto-parking-time
-#if DEBUG_GET_DURATION_FROM_COST==1
+                                                inputDate = inputDate.addSecs(durationInSecs + lower.secsTo(upper));
                                                 qCritical() << DBG_HEADER << "TICKET-END" << inputDate.toString(Qt::ISODate);
-#endif
                                                 break;
                                             }
                                         } // for (int days = 1; days < 8; ++days) {
@@ -548,43 +667,32 @@ Calculator::GetDurationFromCost(Configuration* cfg,
                                         lower.setTime(current_working_time_to);
 
                                         inputDate = inputDate.addSecs(lower.secsTo(upper) + durationInSecs);
-#if DEBUG_GET_DURATION_FROM_COST==1
+                                        //qCritical() << DBG_HEADER << "TICKET-END" << inputDate.toString(Qt::ISODate);
-                                        qCritical() << DBG_HEADER << "TICKET-END" << inputDate.toString(Qt::ISODate);
-#endif
                                     }
                                 }
-                            } else {
-                                inputDate = inputDate.addSecs(duration.pun_duration * 60);
-
-#if DEBUG_GET_DURATION_FROM_COST==1
-                                qCritical() << DBG_HEADER << "INPUT-DATE" << inputDate.toString(Qt::ISODate);
 #endif
-
+                            } else { // if (inputDate.addSecs(durationInSecs) > current_working_date_time_to) {
+                                if (pop_accumulate_durations) {
+                                    inputDate = inputDate.addSecs(durationInSecs);
+                                } else {
+                                    inputDate = inputDate.addSecs(duration.pun_duration * 60);
+                                }
+                                // qCritical() << DBG_HEADER << "INPUT-DATE" << inputDate.toString(Qt::ISODate);
                             }
 
                             QString const &s = inputDate.toString(Qt::ISODate);
-
+                            // qCritical() << DBG_HEADER << "TICKET-END" << s;
-#if DEBUG_GET_DURATION_FROM_COST==1
+                            return s.toStdString();
-                            qCritical() << DBG_HEADER << "TICKET-END" << s;
-#endif
-
-                            if (overPaid) {
-                                return std::make_pair(CalcState::OVERPAID.toStdString(), inputDate);
-                            }
-                            if (successMaxPrice) {
-                                return std::make_pair(CalcState::SUCCESS_MAXPRICE.toStdString(), inputDate);
-                            }
-                            return std::make_pair(s.toStdString(), inputDate);
                         } // if ((double)price == cost) {
                         else {
-                            //qCritical() << DBG_HEADER;
+                            // qCritical() << DBG_HEADER;
                         }
                     } else {
-                        //qCritical() << __func__ << __LINE__;
+                        // qCritical() << DBG_HEADER;
                     }
                 }
-
+                // qCritical() << DBG_HEADER;
-                return std::make_pair("", QDateTime());
+                return "";
             }
         }
     } else
@@ -601,7 +709,7 @@ Calculator::GetDurationFromCost(Configuration* cfg,
 
         if (cost < minParkingPrice) {
             qCritical() << QString("ERROR: COST < MIN_PARKING_PRICE (%1 < %2)").arg(cost).arg(minParkingPrice);
-            return std::make_pair(QDateTime().toString(Qt::ISODate).toStdString(), QDateTime());
+            return QDateTime().toString(Qt::ISODate).toStdString();
         }
 
         if (cost > maxParkingPrice) {
@@ -640,7 +748,7 @@ Calculator::GetDurationFromCost(Configuration* cfg,
                 weekdayId = current.date().dayOfWeek();
                 if (weekdayId == weekdayIdLast) {
                     qCritical() << "ERROR: NO VALID WORKDAY-TIMES DEFINED";
-                    return std::make_pair(QDateTime().toString(Qt::ISODate).toStdString(), QDateTime());
+                    return QDateTime().toString(Qt::ISODate).toStdString();
                 }
             }
 
@@ -658,13 +766,7 @@ Calculator::GetDurationFromCost(Configuration* cfg,
 
             if (current.time() >= to) {
                 if (carryOverNotSet) {
-                    if (overPaid) {
+                    return end_datetime.toString(Qt::ISODate).toStdString();
-                        return std::make_pair(CalcState::OVERPAID.toStdString(), end_datetime);
-                    }
-                    if (successMaxPrice) {
-                        return std::make_pair(CalcState::SUCCESS_MAXPRICE.toStdString(), end_datetime);
-                    }
-                    return std::make_pair(end_datetime.toString(Qt::ISODate).toStdString(), end_datetime);
                 } else {
                     QDateTime const dt = start;
                     start = start.addDays(1);
@@ -711,13 +813,7 @@ Calculator::GetDurationFromCost(Configuration* cfg,
                                 << "price" << price;
 #endif
                     end_datetime = current;
-                    if (overPaid) {
+                    return end_datetime.toString(Qt::ISODate).toStdString();
-                        return std::make_pair(CalcState::OVERPAID.toStdString(), end_datetime);
-                    }
-                    if (successMaxPrice) {
-                        return std::make_pair(CalcState::SUCCESS_MAXPRICE.toStdString(), end_datetime);
-                    }
-                    return std::make_pair(end_datetime.toString(Qt::ISODate).toStdString(), end_datetime);
                 }
 
                 QTime const &from = QTime::fromString(weekDayWorkTimeRanges[weekDayWorkTimeIndex].pwd_time_from.c_str(), Qt::ISODate);
@@ -812,13 +908,7 @@ Calculator::GetDurationFromCost(Configuration* cfg,
                                     << "end_datetime" << end_datetime.toString(Qt::ISODate)
                                     << "price" << price;
 #endif
-                        if (overPaid) {
+                        return end_datetime.toString(Qt::ISODate).toStdString();
-                            return std::make_pair(CalcState::OVERPAID.toStdString(), end_datetime);
-                        }
-                        if (successMaxPrice) {
-                            return std::make_pair(CalcState::SUCCESS_MAXPRICE.toStdString(), end_datetime);
-                        }
-                        return std::make_pair(end_datetime.toString(Qt::ISODate).toStdString(), end_datetime);
                     }
                 }
 
@@ -859,13 +949,7 @@ Calculator::GetDurationFromCost(Configuration* cfg,
                                     << "end_datetime" << end_datetime.toString(Qt::ISODate)
                                     << "price" << price;
 #endif
-                                if (overPaid) {
+                                return end_datetime.toString(Qt::ISODate).toStdString();
-                                    return std::make_pair(CalcState::OVERPAID.toStdString(), end_datetime);
-                                }
-                                if (successMaxPrice) {
-                                    return std::make_pair(CalcState::SUCCESS_MAXPRICE.toStdString(), end_datetime);
-                                }
-                                return std::make_pair(end_datetime.toString(Qt::ISODate).toStdString(), end_datetime);
                             }
 
                             // price has been updated; use next time range
@@ -896,13 +980,7 @@ Calculator::GetDurationFromCost(Configuration* cfg,
                                     << "price" << price;
 #endif
 
-                        if (overPaid) {
+                        return end_datetime.toString(Qt::ISODate).toStdString();
-                            return std::make_pair(CalcState::OVERPAID.toStdString(), end_datetime);
-                        }
-                        if (successMaxPrice) {
-                            return std::make_pair(CalcState::SUCCESS_MAXPRICE.toStdString(), end_datetime);
-                        }
-                        return std::make_pair(end_datetime.toString(Qt::ISODate).toStdString(), end_datetime);
                     }
 
                     if (moveToNextTimeRange) {
@@ -1018,13 +1096,8 @@ Calculator::GetDurationFromCost(Configuration* cfg,
                                     << "end_datetime" << end_datetime.toString(Qt::ISODate)
                                     << "price" << price;
 #endif
-                        if (overPaid) {
+
-                            return std::make_pair(CalcState::OVERPAID.toStdString(), end_datetime);
+                        return end_datetime.toString(Qt::ISODate).toStdString();
-                        }
-                        if (successMaxPrice) {
-                            return std::make_pair(CalcState::SUCCESS_MAXPRICE.toStdString(), end_datetime);
-                        }
-                        return std::make_pair(end_datetime.toString(Qt::ISODate).toStdString(), end_datetime);
                     }
                 }
 
@@ -1037,10 +1110,7 @@ Calculator::GetDurationFromCost(Configuration* cfg,
                             << "final price" << std::max(price, minParkingPrice);
 #endif
 
-                if (overPaid) {
+                return end_datetime.toString(Qt::ISODate).toStdString();
-                    return std::make_pair(CalcState::OVERPAID.toStdString(), end_datetime);
-                }
-                return std::make_pair(end_datetime.toString(Qt::ISODate).toStdString(), end_datetime);
             } // while (timeRangeIt != cfg->TimeRange.cend()) {
         }
 
@@ -1049,7 +1119,7 @@ Calculator::GetDurationFromCost(Configuration* cfg,
                             << "INVALID END TIME";
 #endif
         end_datetime = QDateTime();
-        return std::make_pair(end_datetime.toString(Qt::ISODate).toStdString(), end_datetime);
+        return end_datetime.toString(Qt::ISODate).toStdString();
     }
 
     Ticket t = private_GetDurationFromCost(cfg, inputDate, cost, prepaid);
@@ -1057,7 +1127,7 @@ Calculator::GetDurationFromCost(Configuration* cfg,
     // qCritical().noquote() << t;
 
     // TODO: im fehlerfall
-    return std::make_pair(t.getValidUntil().toString(Qt::ISODate).toStdString(), t.getValidUntil());
+    return t.getValidUntil().toString(Qt::ISODate).toStdString();
 }
 #undef _DEBUG_
 
@@ -1089,14 +1159,17 @@ uint32_t Calculator::GetCostFromDuration(Configuration * cfg,
                                          int paymentOptionIndex) const {
     static const PaymentMethod paymentMethodId = Utilities::getPaymentMethodId(cfg);
 
-    //qCritical() << __func__ << __LINE__ << "paymentOptionIndex" << paymentOptionIndex;
+    // qCritical() << __func__ << __LINE__ << "paymentOptionIndex" << paymentOptionIndex;
 
     if (paymentMethodId == PaymentMethod::Steps ||
         paymentMethodId == PaymentMethod::Degressive) {
         int const timeStepInMinutes = start.secsTo(end) / 60;
         QList<int> tlist = Calculator::GetInstance().GetTimeSteps(cfg, paymentOptionIndex, start);
-        qCritical() << DBG_HEADER << "timeStepList" << timeStepInMinutes << tlist;
+        Q_UNUSED(tlist);
-        qCritical() << DBG_HEADER << "timeStepInMinutes" << timeStepInMinutes << start.toString(Qt::ISODate);
+        //qCritical() << DBG_HEADER << "       start" << start.toString(Qt::ISODate);
+        //qCritical() << DBG_HEADER << "         end" << end.toString(Qt::ISODate);
+        //qCritical() << DBG_HEADER << "timeStepList" << timeStepInMinutes << tlist;
+        //qCritical() << DBG_HEADER << "timeStepInMinutes" << timeStepInMinutes << start.toString(Qt::ISODate);
 
         return GetPriceForTimeStep(cfg, timeStepInMinutes, paymentOptionIndex);
     }
@@ -1384,8 +1457,8 @@ CalcState Calculator::isParkingAllowed(Configuration const *cfg,
                                        int netto_parking_time,
                                        int paymentOptionIndex) {
 
-    qCritical() << DBG_HEADER << "CHECK IF PARKING IS ALLOWED AT"
+    //qCritical() << DBG_HEADER << "CHECK IF PARKING IS ALLOWED AT"
-                << start.toString(Qt::ISODate) << "...";
+    //            << start.toString(Qt::ISODate) << "...";
 
     CalcState cs;
 
@@ -1487,10 +1560,7 @@ double Calculator::GetCostFromDuration(Configuration* cfg,
     Q_UNUSED(payment_option);
     Q_UNUSED(nextDay);
 
-    int paymentOptionIndex = getPaymentOptionIndex(*cfg, start_datetime);
+    int const paymentOptionIndex = cfg->getPaymentOptionIndex(permitType.get());
-    if (paymentOptionIndex == -1) {
-        paymentOptionIndex = cfg->getPaymentOptionIndex(permitType.get());
-    }
     static const PaymentMethod paymentMethodId = Utilities::getPaymentMethodId(cfg);
     if (paymentMethodId == PaymentMethod::Steps) {
         if (tariffIs24_7(cfg)) {
@@ -2606,16 +2676,18 @@ QList<int> &Calculator::GetTimeSteps(Configuration *cfg, int paymentOptionIndex,
                             }
                         }
                     } else { // if (carryOverTimeRangeFrom == QTime(0, 0, 0)) {
-                        //if (DBG_LEVEL >= DBG_DEBUG) {
+                        if (DBG_LEVEL >= DBG_DEBUG) {
                             qCritical() << "(" << __func__ << ":" << __LINE__ << ")        carry over time range from:" << carryOverTimeRangeFrom.toString(Qt::ISODate);
                             qCritical() << "(" << __func__ << ":" << __LINE__ << ")          carry over time range to:" << carryOverTimeRangeTo.toString(Qt::ISODate);
-                        //}
+                        }
 
                         m_timeSteps[paymentOptionIndex].clear();
 
                         std::optional<QDateTime> prepaidStart = cfg->prepaidStart(start, pop_prepaid_option_id);
                         // TODO: zusaetzlicher faktor falls vorkauf-option zieht
                         if (prepaidStart) {
+                            //qCritical() << "(" << __func__ << ":" << __LINE__ << ")                       start:" << start.toString(Qt::ISODate);
+                            //qCritical() << "(" << __func__ << ":" << __LINE__ << ")         prepaid start value:" << prepaidStart.value().toString(Qt::ISODate);
                             start = prepaidStart.value();
                             if (DBG_LEVEL >= DBG_DEBUG) {
                                 qCritical() << "(" << __func__ << ":" << __LINE__ << ")         prepaid adapted start:" << start.toString(Qt::ISODate);
@@ -2636,13 +2708,15 @@ QList<int> &Calculator::GetTimeSteps(Configuration *cfg, int paymentOptionIndex,
                             qCritical() << "(" << __func__ << ":" << __LINE__ << ") TODO";
                         }
 
+                        // qCritical() << "(" << __func__ << ":" << __LINE__ << ")                       start:" << start.toString(Qt::ISODate);
+
                         // int const start_time = start.time().hour() * 60 + start.time().minute();
                         QDateTime nextTimeStep = start;
                         int runtimeInMinutes = 0;
 
                         // qCritical() << "(" << __func__ << ":" << __LINE__ << ")            runtime in minutes (1):" << runtimeInMinutes;
 
-                        // int const pop_truncate_last_interpolation_step = cfg->getPaymentOptions(paymentOptionIndex).pop_truncate_last_interpolation_step;
+                        int const pop_truncate_last_interpolation_step = cfg->getPaymentOptions(paymentOptionIndex).pop_truncate_last_interpolation_step;
 
                         // TODO: auslagern
                         for (auto[itr, rangeEnd] = cfg->PaymentRate.equal_range(pop_id); itr != rangeEnd; ++itr) {
@@ -2661,13 +2735,13 @@ QList<int> &Calculator::GetTimeSteps(Configuration *cfg, int paymentOptionIndex,
                         for (auto[itr, rangeEnd] = cfg->PaymentRate.equal_range(pop_id); itr != rangeEnd; ++itr) {
                             int const durationId = itr->second.pra_payment_unit_id;
 
-                            //qCritical() << "(" << __func__ << ":" << __LINE__ << ")  durationId" << durationId;
+                            // qCritical() << "(" << __func__ << ":" << __LINE__ << ")  durationId" << durationId;
                             // int const price = itr->second.pra_price;
 
                             auto search = cfg->Duration.find(durationId);
                             if (search != cfg->Duration.end()) {
                                 ATBDuration duration = search->second;
-                                // ATBDuration &previous = search->second;
+                                ATBDuration &previous = search->second;
 
                                 if (duration.pun_interpolation_id == -1) {
 
@@ -2678,14 +2752,15 @@ QList<int> &Calculator::GetTimeSteps(Configuration *cfg, int paymentOptionIndex,
                                     break;
                                 }
 
-                                //qCritical() << "(" << __func__ << ":" << __LINE__ << ")            runtime in minutes:" << runtimeInMinutes;
+                                // qCritical() << "(" << __func__ << ":" << __LINE__ << ")            runtime in minutes:" << runtimeInMinutes;
 
                                 std::optional<ATBInterpolation> ipolCheck = cfg->getInterpolationType(duration.pun_interpolation_id);
                                 if (ipolCheck) {
                                     ATBInterpolation interpolation = ipolCheck.value();
 
                                     if (duration.pun_interpolation_id == (int)ATBInterpolation::DYNAMIC_ABSTRACT_TIMEPOINT_AND_STATIC_PRICE) {
-                                        qCritical() << "(" << __func__ << ":" << __LINE__ << ")  HIER NICHT";
+                                        //qCritical() << "(" << __func__ << ":" << __LINE__ << ")     payment option id:" << pop_id;
+                                        //qCritical() << "(" << __func__ << ":" << __LINE__ << ")  pun_intnerpolation_id:" << duration.pun_interpolation_id;
 
                                         interpolation.dynamic_start = start.time();
                                         interpolation.dynamic_start.setHMS(start.time().hour(), start.time().minute(), 0);
@@ -2697,12 +2772,13 @@ QList<int> &Calculator::GetTimeSteps(Configuration *cfg, int paymentOptionIndex,
                                         // qCritical() << "(" << __func__ << ":" << __LINE__ << ")         interpolation dynamic end:" << interpolationEnd.toString(Qt::ISODate);
                                         // qCritical() << "(" << __func__ << ":" << __LINE__ << ")    interpolation dynamic end time:" << end_time;
 
-                                        // int pop_min_time = cfg->getPaymentOptions(paymentOptionIndex).pop_min_time;
+                                        int pop_min_time = cfg->getPaymentOptions(paymentOptionIndex).pop_min_time;
+                                        bool pop_accumulate_durations = cfg->getPaymentOptions(paymentOptionIndex).pop_accumulate_durations;
 
                                         runtimeInMinutes += duration.pun_duration;
                                         nextTimeStep = start.addSecs(runtimeInMinutes * 60);
 
-                                        //qCritical() << "(" << __func__ << ":" << __LINE__ << ")            runtime in minutes (1):" << runtimeInMinutes;
+                                        // qCritical() << "(" << __func__ << ":" << __LINE__ << ")            runtime in minutes (1):" << runtimeInMinutes;
 
                                         if (nextTimeStep.time() > carryOverStart) {
                                             int const backTime = carryOverStart.secsTo(nextTimeStep.time()) / 60;
@@ -2727,19 +2803,22 @@ QList<int> &Calculator::GetTimeSteps(Configuration *cfg, int paymentOptionIndex,
                                                 //}
                                             } else {
                                                 m_timeSteps[paymentOptionIndex] << runtimeInMinutes;
+                                                //qCritical() << "(" << __func__ << ":" << __LINE__ << ")   :" <<  m_timeSteps[paymentOptionIndex];
                                             }
                                         }
 
-                                        duration.pun_duration = runtimeInMinutes;
+                                        if (pop_accumulate_durations == false) {
-
+                                            duration.pun_duration = runtimeInMinutes;
-                                        //qCritical() << "(" << __func__ << ":" << __LINE__ << ")            pun_id:" << duration.pun_id;
+                                            qCritical() << "(" << __func__ << ":" << __LINE__ << ")            pun_id:" << duration.pun_id;
-                                        //qCritical() << "(" << __func__ << ":" << __LINE__ << ")      pun_duration:" << duration.pun_duration;
+                                            qCritical() << "(" << __func__ << ":" << __LINE__ << ")      pun_duration:" << duration.pun_duration;
-
+                                            search->second = duration;
-                                        search->second = duration;
+                                        }
                                     } else
                                     if (duration.pun_interpolation_id == (int)ATBInterpolation::NO_INTERPOLATION) {
+                                        qCritical() << "(" << __func__ << ":" << __LINE__ << ")" ;
 
                                         //qCritical() << "(" << __func__ << ":" << __LINE__ << ")                            pun_id:" << duration.pun_id;
+                                        //qCritical() << "(" << __func__ << ":" << __LINE__ << ")              paymentOptionIndex:" << paymentOptionIndex;
                                         //qCritical() << "(" << __func__ << ":" << __LINE__ << ")                      pun duration:" << duration.pun_duration;
                                         //qCritical() << "(" << __func__ << ":" << __LINE__ << ")                    next time step:" << nextTimeStep.toString(Qt::ISODate);
                                         //qCritical() << "(" << __func__ << ":" << __LINE__ << ")            runtime in minutes (2):" << runtimeInMinutes;
@@ -2752,6 +2831,7 @@ QList<int> &Calculator::GetTimeSteps(Configuration *cfg, int paymentOptionIndex,
                                                     m_timeSteps[paymentOptionIndex] << duration.pun_duration;
                                                     search->second = duration;
                                                     cfg->getPaymentOptions(paymentOptionIndex).pop_min_time = runtimeInMinutes;
+                                                    qCritical() << "(" << __func__ << ":" << __LINE__ << ")       pop_min_time" << cfg->getPaymentOptions(paymentOptionIndex).pop_min_time;
                                                     continue;
                                                 }
                                             }
@@ -2774,7 +2854,7 @@ QList<int> &Calculator::GetTimeSteps(Configuration *cfg, int paymentOptionIndex,
                                         //qCritical() << "(" << __func__ << ":" << __LINE__ << ")            runtime in minutes:" << runtimeInMinutes;
 
                                         QDateTime s = start.addSecs(runtimeInMinutes * 60);
-                                        // int const minutes = s.time().secsTo(carryOverStart) / 60;
+                                        int const minutes = s.time().secsTo(carryOverStart) / 60;
 
 #if 0
                                         if (minutes > 0) {
@@ -2827,8 +2907,7 @@ QList<int> &Calculator::GetTimeSteps(Configuration *cfg, int paymentOptionIndex,
                                         // duration.pun_duration = runtimeInMinutes - carryOverDuration;
                                         m_timeSteps[paymentOptionIndex] << duration.pun_duration;
                                         search->second = duration;
-                                    } else {
+                                    } else { // if (duration.pun_interpolation_id == (int)ATBInterpolation::NO_INTERPOLATION) {
-                                        qCritical() << "(" << __func__ << ":" << __LINE__ << ")  HIER NICHT";
                                         cfg->Duration.erase(search);
                                     }
                                 }
@@ -2862,7 +2941,7 @@ QList<int> &Calculator::GetTimeSteps(Configuration *cfg, int paymentOptionIndex,
         }
     }
 
-    qCritical() << "(" << __func__ << ":" << __LINE__ << ")                   NEW timeSteps:" << m_timeSteps;
+    // qCritical() << "(" << __func__ << ":" << __LINE__ << ")                   NEW timeSteps:" << m_timeSteps;
 
     if (DBG_LEVEL >= DBG_DEBUG) {
         qCritical() << "(" << __func__ << ":" << __LINE__ << ")                   NEW timeSteps:" << m_timeSteps;
@@ -2895,9 +2974,13 @@ uint32_t Calculator::GetPriceForTimeStep(Configuration *cfg, int timeStep, int p
     uint32_t price = 0;
     int pun_duration = 0;
 
-    qCritical() << "(" << __func__ << ":" << __LINE__ << ") paymentOptionIndex" << paymentOptionIndex;
+    if (DBG_LEVEL >= DBG_DEBUG) {
-    //qCritical() << "(" << __func__ << ":" << __LINE__ << ") timeStep" << timeStep;
+        qCritical() << "(" << __func__ << ":" << __LINE__ << ") paymentOptionIndex" << paymentOptionIndex;
-    //qCritical() << "(" << __func__ << ":" << __LINE__ << ") pop_id" << pop_id;
+        qCritical() << "(" << __func__ << ":" << __LINE__ << ") timeStep" << timeStep;
+        qCritical() << "(" << __func__ << ":" << __LINE__ << ") pop_id" << pop_id;
+        qCritical() << "(" << __func__ << ":" << __LINE__ << ") pop_accumulate_prices" << pop_accumulate_prices;
+        qCritical() << "(" << __func__ << ":" << __LINE__ << ") pop_accumulate_durations" << pop_accumulate_durations;
+    }
 
     for (auto[itr, rangeEnd] = cfg->PaymentRate.equal_range(pop_id); itr != rangeEnd; ++itr)
     {
@@ -2922,6 +3005,7 @@ uint32_t Calculator::GetPriceForTimeStep(Configuration *cfg, int timeStep, int p
         }
 
         if (DBG_LEVEL >= DBG_DEBUG) {
+            qCritical() << "(" << __func__ << ":" << __LINE__ << ")";
             qCritical() << "(" << __func__ << ":" << __LINE__ << ") price" << price;
             qCritical() << "(" << __func__ << ":" << __LINE__ << ") pun_id" << pun_id;
             qCritical() << "(" << __func__ << ":" << __LINE__ << ") pun_unit_id" << payment_unit_id;
@@ -2930,7 +3014,7 @@ uint32_t Calculator::GetPriceForTimeStep(Configuration *cfg, int timeStep, int p
         }
 
         if (timeStep == pun_duration) {
-            qCritical() << "(" << __func__ << ":" << __LINE__ << ") return price" << price;
+            //qCritical() << "(" << __func__ << ":" << __LINE__ << ") return price" << price;
             return price;
         }
     }
@@ -2942,7 +3026,9 @@ uint32_t Calculator::GetDurationForPrice(Configuration *cfg, int price) const {
     int const pop_id = cfg->getPaymentOptions().pop_id;
     int const pop_accumulate_prices = cfg->getPaymentOptions().pop_accumulate_prices;
 
-    //qCritical() << "(" << __func__ << ":" << __LINE__ << ") accumulate prices" << pop_accumulate_prices;
+    qCritical() << "(" << __func__ << ":" << __LINE__ << ") accumulate prices" << pop_accumulate_prices;
+    qCritical() << "(" << __func__ << ":" << __LINE__ << ")            pop_id" << pop_id;
+    qCritical() << "(" << __func__ << ":" << __LINE__ << ")             price" << price;
 
     int new_price = 0;
     uint32_t duration = 0;

library/src/configuration.cpp

@@ -8,8 +8,6 @@
 #include "tariff_global_defines.h"
 #include "tariff_carryover.h"
 #include "tariff_global_defines.h"
-#include "tariff_settings.h"
-#include "tariff_carryover_settings.h"
 
 #include <QString>
 #include <QDebug>
@@ -23,13 +21,7 @@ MemberType Configuration::IdentifyJsonMember(const char* member_name)
     if (strcmp(member_name, "PaymentRate") == 0) return MemberType::PaymentRateType;
     if (strcmp(member_name, "PaymentOption") == 0) return MemberType::PaymentOptionType;
     if (strcmp(member_name, "Duration") == 0) return MemberType::DurationType;
-    if (strcmp(member_name, "Monday") == 0) return MemberType::WeekDaysType;
+    //if (strcmp(member_name, "WeekDays") == 0) return MemberType::WeekDaysType;
-    if (strcmp(member_name, "Tuesday") == 0) return MemberType::WeekDaysType;
-    if (strcmp(member_name, "Wednesday") == 0) return MemberType::WeekDaysType;
-    if (strcmp(member_name, "Thursday") == 0) return MemberType::WeekDaysType;
-    if (strcmp(member_name, "Friday") == 0) return MemberType::WeekDaysType;
-    if (strcmp(member_name, "Saturday") == 0) return MemberType::WeekDaysType;
-    if (strcmp(member_name, "Sunday") == 0) return MemberType::WeekDaysType;
     if (strcmp(member_name, "WeekDaysWorktime") == 0) return MemberType::WeekDaysWorkTimeType;
     if (strcmp(member_name, "SpecialDaysWorktime") == 0) return MemberType::SpecialDaysWorktimeType;
     if (strcmp(member_name, "SpecialDays") == 0) return MemberType::SpecialDaysType;
@@ -46,298 +38,6 @@ MemberType Configuration::IdentifyJsonMember(const char* member_name)
     else return MemberType::UnknownType;
 }
 
-ATBWeekDay parseWeekDay(Configuration &cfg,
-                        rapidjson::GenericMemberIterator<false,
-                                                         rapidjson::UTF8<char>,
-                                                         rapidjson::MemoryPoolAllocator<rapidjson::CrtAllocator>> k,
-                        QString const &innerObjName,
-                        Qt::DayOfWeek weekDay,
-                        QString const &weekDayName) {
-    int max_price = 0;
-    int min_price = 0;
-    int min_time = 0;
-    int max_time = 0;
-    int duration = 0;
-    ATBWeekDay WeekDay;
-    QTime start, end, parking_time_limit, about_to_exceed_limit;
-    ATBTariffCarryOverSettings::ParkingTimeLimitChecker parkTimeLimitChecker;
-    if (innerObjName == QString("week_day_default")) {
-        if (k->value.IsObject()) {
-            auto obj = k->value.GetObject();
-            for (auto m = obj.MemberBegin(); m != obj.MemberEnd(); ++m) {
-                QString const &name = m->name.GetString();
-                if (name == "week_day_type") {
-                    //
-                } else
-                if (name == "tariff_settings") {
-                    if (m->value.IsObject()) {
-                        auto obj = m->value.GetObject();
-                        for (auto n = obj.MemberBegin(); n != obj.MemberEnd(); ++n) {
-                            QString const &name = QString::fromStdString(n->name.GetString());
-                            if (name == "min_time") {
-                                if (n->value.IsInt()) { min_time = n->value.GetInt(); }
-                            } else if (name == "max_time") {
-                                if (n->value.IsInt()) { max_time = n->value.GetInt(); }
-                            } else if (name == "min_price") {
-                                if (n->value.IsInt()) { min_price = n->value.GetInt(); }
-                            } else if (name == "max_price") {
-                                if (n->value.IsInt()) { max_price = n->value.GetInt(); }
-                            }
-                        }
-                    }
-                } else
-                if (name == "carry_over_settings") {
-                    if (m->value.IsObject()) {
-                        auto obj = m->value.GetObject();
-                        for (auto n = obj.MemberBegin(); n != obj.MemberEnd(); ++n) {
-                            QString const &name = QString::fromStdString(n->name.GetString());
-                            if (name == "duration") {
-                                if (n->value.IsInt()) {
-                                    duration = n->value.GetInt();
-                                }
-                            } else
-                            if (name == "start") {
-                                if (n->value.IsString()) {
-                                    start = QTime::fromString(QString::fromStdString(n->value.GetString()), Qt::ISODate);
-                                }
-                            } else
-                            if (name == "end") {
-                                if (n->value.IsString()) {
-                                    end = QTime::fromString(QString::fromStdString(n->value.GetString()), Qt::ISODate);
-                                }
-                            } else
-                            if (name == "parking_time_limit") {
-                                if (n->value.IsObject()) {
-                                    auto o = n->value.GetObject();
-                                    for (auto l = o.MemberBegin(); l != o.MemberEnd(); ++l) {
-                                        if (l->name.IsString()) {
-                                            QString const &member = QString::fromStdString(l->name.GetString());
-                                            if (member == "prev_day_sunday?") {
-                                                if (l->value.IsArray()) {
-                                                    auto limits = l->value.GetArray();
-                                                    if (limits.Size() >= 2) {
-                                                        about_to_exceed_limit = QTime::fromString(QString::fromStdString(limits[0].GetString()), Qt::ISODate);
-                                                        parking_time_limit = QTime::fromString(QString::fromStdString(limits[1].GetString()), Qt::ISODate);
-                                                    }
-                                                    parkTimeLimitChecker = [&cfg, weekDay, weekDayName](ATBTariffCarryOverSettings const& cs,
-                                                                                                        QDateTime const &startTime,
-                                                                                                        QDateTime const &endTime,
-                                                                                                        int paymentOptionIndex) {
-                                                        if (startTime.date() < endTime.date()) { // start end end on different days
-                                                            if (endTime.date().dayOfWeek() == (int)weekDay) {
-                                                                if (endTime.time() > cs.m_parking_time_limit) {
-                                                                    qCritical() << __func__ << ":" << __LINE__
-                                                                                << QString("ERROR time limit for end-time violated: [%1, %2 end-time=%3], but time-limit=%4")
-                                                                                        .arg(weekDayName)
-                                                                                        .arg(endTime.date().toString(Qt::ISODate))
-                                                                                        .arg(endTime.time().toString(Qt::ISODate))
-                                                                                        .arg(cs.m_parking_time_limit.toString(Qt::ISODate));
-                                                                    return true;
-                                                                }
-                                                                if (endTime.time() >= cs.m_about_to_exceed_parking_time_limit) {
-                                                                    cfg.getPaymentOptions(paymentOptionIndex).pop_plus_steps = 1;
-                                                                } else {
-                                                                    cfg.getPaymentOptions(paymentOptionIndex).pop_plus_steps =
-                                                                        cfg.getPaymentOptions(paymentOptionIndex).pop_plus_steps_saved;
-                                                                }
-                                                            }
-                                                        }
-                                                        return false;
-                                                    };
-                                                }
-                                            } else
-                                            if (member == "prev_day_holiday?") {
-                                                if (l->value.IsArray()) {
-                                                    auto limits = l->value.GetArray();
-                                                    if (limits.Size() >= 2) {
-                                                        about_to_exceed_limit = QTime::fromString(QString::fromStdString(limits[0].GetString()), Qt::ISODate);
-                                                        parking_time_limit = QTime::fromString(QString::fromStdString(limits[1].GetString()), Qt::ISODate);
-                                                    }
-                                                    parkTimeLimitChecker = [&cfg, weekDayName](ATBTariffCarryOverSettings const& cs,
-                                                                                               QDateTime const &startTime,
-                                                                                               QDateTime const &endTime,
-                                                                                               int paymentOptionIndex) {
-                                                        if (startTime.date() < endTime.date()) { // start end end on different days
-                                                            if (previousDayHoliday(cfg, endTime)) {
-                                                                if (endTime.time() > cs.m_parking_time_limit) {
-                                                                    qCritical() << __func__ << ":" << __LINE__
-                                                                                << QString("ERROR time limit for end-time violated: [%1, %2, end-time=%3], but time-limit=%4")
-                                                                                        .arg(weekDayName)
-                                                                                        .arg(endTime.date().toString(Qt::ISODate))
-                                                                                        .arg(endTime.time().toString(Qt::ISODate))
-                                                                                        .arg(cs.m_parking_time_limit.toString(Qt::ISODate));
-                                                                    return true;
-                                                                }
-                                                                if (endTime.time() >= cs.m_about_to_exceed_parking_time_limit) {
-                                                                    cfg.getPaymentOptions(paymentOptionIndex).pop_plus_steps = 1;
-                                                                } else {
-                                                                    cfg.getPaymentOptions(paymentOptionIndex).pop_plus_steps =
-                                                                        cfg.getPaymentOptions(paymentOptionIndex).pop_plus_steps_saved;
-                                                                }
-                                                            }
-                                                        }
-                                                        return false;
-                                                    };
-                                                }
-                                            }
-                                        }
-                                    }
-                                }
-                            }
-                        }
-                    }
-                }
-            }
-            ATBTariffSettings ts(max_price, min_price, max_time, min_time);
-            ATBTariffCarryOverSettings cs(duration, start, end, parking_time_limit, about_to_exceed_limit,
-                                          parkTimeLimitChecker);
-            WeekDay = ATBWeekDay(weekDay, weekDayName, ATBWeekDay::USUAL_WEEKDAY, QDate(), ts, cs);
-
-        } // if (k->value.IsObject()) {
-    } else {
-        QDate date(QDate::fromString(innerObjName, Qt::ISODate));
-        if (date.isValid()) {
-            if (k->value.IsObject()) {
-                auto obj = k->value.GetObject();
-                for (auto m = obj.MemberBegin(); m != obj.MemberEnd(); ++m) {
-                    QString const &name = m->name.GetString();
-                    if (name == "week_day_type") {
-                        // TODO
-                    } else
-                    if (name == "tariff_settings") {
-                        if (m->value.IsObject()) {
-                            auto obj = m->value.GetObject();
-                            for (auto n = obj.MemberBegin(); n != obj.MemberEnd(); ++n) {
-                                QString const &name = QString::fromStdString(n->name.GetString());
-                                if (name == "min_time") {
-                                    if (n->value.IsInt()) { min_time = n->value.GetInt(); }
-                                } else if (name == "max_time") {
-                                    if (n->value.IsInt()) { max_time = n->value.GetInt(); }
-                                } else if (name == "min_price") {
-                                    if (n->value.IsInt()) { min_price = n->value.GetInt(); }
-                                } else if (name == "max_price") {
-                                    if (n->value.IsInt()) { max_price = n->value.GetInt(); }
-                                }
-                            }
-                        }
-                    } else
-                    if (name == "carry_over_settings") {
-                        if (m->value.IsObject()) {
-                            auto obj = m->value.GetObject();
-                            for (auto n = obj.MemberBegin(); n != obj.MemberEnd(); ++n) {
-                                QString const &name = QString::fromStdString(n->name.GetString());
-                                if (name == "duration") {
-                                    if (n->value.IsInt()) {
-                                        duration = n->value.GetInt();
-                                    }
-                                } else
-                                if (name == "start") {
-                                    if (n->value.IsString()) {
-                                        start = QTime::fromString(QString::fromStdString(n->value.GetString()), Qt::ISODate);
-                                    }
-                                } else
-                                if (name == "end") {
-                                    if (n->value.IsString()) {
-                                        end = QTime::fromString(QString::fromStdString(n->value.GetString()), Qt::ISODate);
-                                    }
-                                } else
-                                if (name == "parking_time_limit") {
-                                    if (n->value.IsObject()) {
-                                        auto o = n->value.GetObject();
-                                        for (auto l = o.MemberBegin(); l != o.MemberEnd(); ++l) {
-                                            if (l->name.IsString()) {
-                                                QString const &member = QString::fromStdString(l->name.GetString());
-                                                if (member == "default") {
-                                                    if (l->value.IsArray()) {
-                                                        auto limits = l->value.GetArray();
-                                                        if (limits.Size() >= 2) {
-                                                            about_to_exceed_limit = QTime::fromString(QString::fromStdString(limits[0].GetString()), Qt::ISODate);
-                                                            parking_time_limit = QTime::fromString(QString::fromStdString(limits[1].GetString()), Qt::ISODate);
-                                                        }
-                                                    }
-
-                                                    parkTimeLimitChecker = [&cfg, weekDay](ATBTariffCarryOverSettings const& cs,
-                                                                                           QDateTime const &startTime,
-                                                                                           QDateTime const &endTime,
-                                                                                           int paymentOptionIndex) {
-                                                        if (startTime.date() < endTime.date()) { // start end end on different days
-                                                            if (endTime.date().dayOfWeek() == (int)weekDay) {
-                                                                if (endTime.time() > cs.m_parking_time_limit) {
-                                                                    qCritical() << __func__ << ":" << __LINE__
-                                                                                << QString("ERROR time limit for end-time violated: end-time=%1, but time-limit=%2")
-                                                                                        .arg(endTime.time().toString(Qt::ISODate))
-                                                                                        .arg(cs.m_parking_time_limit.toString(Qt::ISODate));
-                                                                    return true;
-                                                                }
-                                                                if (endTime.time() >= cs.m_about_to_exceed_parking_time_limit) {
-                                                                    cfg.getPaymentOptions(paymentOptionIndex).pop_plus_steps = 1;
-                                                                } else {
-                                                                    cfg.getPaymentOptions(paymentOptionIndex).pop_plus_steps =
-                                                                        cfg.getPaymentOptions(paymentOptionIndex).pop_plus_steps_saved;
-                                                                }
-                                                            }
-                                                        }
-                                                        return false;
-                                                    };
-                                                } else
-                                                if (member == "prev_day_holiday?") {
-                                                    if (l->value.IsArray()) {
-                                                        auto limits = l->value.GetArray();
-                                                        if (limits.Size() >= 2) {
-                                                            about_to_exceed_limit = QTime::fromString(QString::fromStdString(limits[0].GetString()), Qt::ISODate);
-                                                            parking_time_limit = QTime::fromString(QString::fromStdString(limits[1].GetString()), Qt::ISODate);
-                                                        }
-                                                    }
-                                                    parkTimeLimitChecker = [&cfg](ATBTariffCarryOverSettings const& cs,
-                                                                                  QDateTime const &startTime,
-                                                                                  QDateTime const &endTime,
-                                                                                  int paymentOptionIndex) {
-                                                        if (startTime.date() < endTime.date()) { // start end end on different days
-                                                            if (previousDayHoliday(cfg, endTime)) {
-                                                                if (endTime.time() > cs.m_parking_time_limit) {
-                                                                    qCritical() << __func__ << ":" << __LINE__
-                                                                                << QString("ERROR time limit for end-time violated: end-time=%1, but time-limit=%2")
-                                                                                        .arg(endTime.time().toString(Qt::ISODate))
-                                                                                        .arg(cs.m_parking_time_limit.toString(Qt::ISODate));
-                                                                    return true;
-                                                                }
-                                                                if (endTime.time() >= cs.m_about_to_exceed_parking_time_limit) {
-                                                                    cfg.getPaymentOptions(paymentOptionIndex).pop_plus_steps = 1;
-                                                                } else {
-                                                                    cfg.getPaymentOptions(paymentOptionIndex).pop_plus_steps =
-                                                                        cfg.getPaymentOptions(paymentOptionIndex).pop_plus_steps_saved;
-                                                                }
-                                                            }
-                                                        }
-                                                        return false;
-                                                    };
-                                                }
-                                            }
-                                        }
-                                    }
-                                }
-                            }
-                        }
-                    }
-                }
-                ATBTariffSettings ts(max_price, min_price, max_time, min_time);
-                ATBTariffCarryOverSettings cs(duration, start, end, parking_time_limit,
-                                              about_to_exceed_limit, parkTimeLimitChecker);
-                WeekDay = ATBWeekDay(weekDay, weekDayName, ATBWeekDay::HOLIDAY, date, ts, cs);
-
-            } else {// if (k->value.IsObject()) {
-                qCritical() << __func__ << ":" << __LINE__ << "ERROR: no object";
-            }
-
-        } else {
-            qCritical() << __func__ << __LINE__
-                        << "ERROR: invalid date for" << weekDayName << "," << innerObjName;
-        }
-    }
-
-    return WeekDay;
-}
-
 /// <inheritdoc/>
 bool Configuration::ParseJson(Configuration* cfg, const char* json)
 {
@@ -396,7 +96,7 @@ bool Configuration::ParseJson(Configuration* cfg, const char* json)
             ATBPaymentRate PaymentRate;
             ATBSpecialDaysWorktime SpecialDaysWorktime;
             ATBSpecialDays SpecialDays;
-            //ATBWeekDay WeekDay;
+            ATBWeekDays  WeekDays;
             ATBWeekDaysWorktime  WeekDaysWorktime;
             ATBPeriodYear YearPeriod;
             ATBDailyTicket DailyTicket;
@@ -412,29 +112,29 @@ bool Configuration::ParseJson(Configuration* cfg, const char* json)
             MemberType mb_type = MemberType::UnknownType;
             this->currentPaymentOptions.clear();
 
-            // Get all JSON object members
+                // Get all JSON object members
-            // This code should run only once (to load JSON variables into memory)
+                // This code should run only once (to load JSON variables into memory)
-            for (auto i = document.MemberBegin(); i != document.MemberEnd(); i++)
+                for (auto i = document.MemberBegin(); i != document.MemberEnd(); i++)
-            {
+                {
-                // Get name of all general members of JSON, don't print name if NULL
+                        // Get name of all general members of JSON, don't print name if NULL
-                const char* mb_name = i->name.GetString();
+                        const char* mb_name = i->name.GetString();
-                if (mb_name == NULL) continue;
+            if (mb_name == NULL) continue;
 
-                if (document[mb_name].IsString()) {
+            if (document[mb_name].IsString()) {
-                    QString const _mb_name(mb_name);
+                QString const _mb_name(mb_name);
-                    if (_mb_name.startsWith("Project", Qt::CaseInsensitive)) {
+                if (_mb_name.startsWith("Project", Qt::CaseInsensitive)) {
-                        cfg->project.project = document[mb_name].GetString();
+                    cfg->project.project = document[mb_name].GetString();
-                        continue;
+                    continue;
-                     }
+                 }
-                    if (_mb_name.startsWith("Version", Qt::CaseInsensitive)) {
+                if (_mb_name.startsWith("Version", Qt::CaseInsensitive)) {
-                        cfg->project.version = document[mb_name].GetString();
+                    cfg->project.version = document[mb_name].GetString();
-                        continue;
+                    continue;
-                    }
-                    if (_mb_name.startsWith("Info", Qt::CaseInsensitive)) {
-                        cfg->project.info = document[mb_name].GetString();
-                        continue;
-                    }
                 }
+                if (_mb_name.startsWith("Info", Qt::CaseInsensitive)) {
+                    cfg->project.info = document[mb_name].GetString();
+                    continue;
+                }
+            }
 
             // ... everything else should be an array
             if (!document[mb_name].IsArray()) {
@@ -471,36 +171,6 @@ bool Configuration::ParseJson(Configuration* cfg, const char* json)
                     {
                     case MemberType::UnknownType:
                         break;
-                    case MemberType::WeekDaysType: {
-                        ATBWeekDay WeekDay;
-                        if (QString(mb_name) == "Monday") {
-                            WeekDay = parseWeekDay(*cfg, k, inner_obj_name, Qt::Monday, mb_name);
-                        } else
-                        if (QString(mb_name) == "Tuesday") {
-                            WeekDay = parseWeekDay(*cfg, k, inner_obj_name, Qt::Tuesday, mb_name);
-                        } else
-                        if (QString(mb_name) == "Wednesday") {
-                            WeekDay = parseWeekDay(*cfg, k, inner_obj_name, Qt::Wednesday, mb_name);
-                        } else
-                        if (QString(mb_name) == "Thursday") {
-                            WeekDay = parseWeekDay(*cfg, k, inner_obj_name, Qt::Thursday, mb_name);
-                        } else
-                        if (QString(mb_name) == "Friday") {
-                            WeekDay = parseWeekDay(*cfg, k, inner_obj_name, Qt::Friday, mb_name);
-                        } else
-                        if (QString(mb_name) == "Saturday") {
-                            WeekDay = parseWeekDay(*cfg, k, inner_obj_name, Qt::Saturday, mb_name);
-                        } else
-                        if (QString(mb_name) == "Sunday") {
-                            WeekDay = parseWeekDay(*cfg, k, inner_obj_name, Qt::Sunday, mb_name);
-                        } else {
-                            qCritical() << "ERROR: unknown week day" << mb_name;
-                        }
-
-                        cfg->WeekDays.insert(pair<Qt::DayOfWeek, ATBWeekDay>(WeekDay.m_id, WeekDay));
-                        // qCritical() << WeekDay;
-
-                    } break;
                     case MemberType::CarryOverType: {
                         if (QString(inner_obj_name) == QString("carry_over_id")) {
                             if (k->value.IsInt()) {
@@ -591,49 +261,6 @@ bool Configuration::ParseJson(Configuration* cfg, const char* json)
                                 QTime const &t = QTime::fromString(k->value.GetString(), Qt::ISODate);
                                 TariffPrepaidOption.static_end = t;
                             }
-                        } else
-                        if (QString(inner_obj_name) == QString("prepaid_week")) {
-                            if (k->value.IsArray()) {
-                                auto days = k->value.GetArray();
-                                for (rapidjson::SizeType j=0; j < days.Size(); ++j) {
-                                    if (days[j].IsObject()) {
-                                        auto weekday = days[j].GetObject();
-                                        for (auto w = weekday.MemberBegin(); w != weekday.MemberEnd(); ++w) {
-                                            int day = j+1; // 8 entries
-
-                                            TariffPrepaidOption.prepaid[day].day = 0;
-
-                                            QString member(QString::fromStdString(w->name.GetString()));
-                                            if (member == "prepaid_day") {
-                                                if (w->value.IsInt()) {
-                                                    rapidjson::SizeType const d = w->value.GetInt();
-                                                    if (d != (j+1)) {
-                                                        qCritical() << "ERROR: misconfigured jsonfile" << d << "!=" << (j+1);
-                                                    }
-                                                    TariffPrepaidOption.prepaid[day].day = day;
-                                                }
-                                            } else
-                                            if (member == "prepaid_duration") {
-                                                if (w->value.IsInt()) {
-                                                    TariffPrepaidOption.prepaid[day].duration = w->value.GetInt();
-                                                }
-                                            } else
-                                            if (member == "prepaid_static_start") {
-                                                if (w->value.IsString()) {
-                                                    QTime const &t = QTime::fromString(w->value.GetString(), Qt::ISODate);
-                                                    TariffPrepaidOption.prepaid[day].static_start = t;
-                                                }
-                                            } else
-                                            if (member == "prepaid_static_end") {
-                                                if (w->value.IsString()) {
-                                                    QTime const &t = QTime::fromString(w->value.GetString(), Qt::ISODate);
-                                                    TariffPrepaidOption.prepaid[day].static_end = t;
-                                                }
-                                            }
-                                        }
-                                    }
-                                }
-                            }
                         }
                     } break;
                     case MemberType::InterpolationType: {
@@ -974,20 +601,11 @@ bool Configuration::ParseJson(Configuration* cfg, const char* json)
                         } else if (strcmp(inner_obj_name, "pop_plus_steps") == 0) {
                             if (k->value.IsInt()) {
                                 this->currentPaymentOptions.last().pop_plus_steps = k->value.GetInt();
-                                this->currentPaymentOptions.last().pop_plus_steps_saved = k->value.GetInt();
                             }
                         } else if (strcmp(inner_obj_name, "pop_minus_steps") == 0) {
                             if (k->value.IsInt()) {
                                 this->currentPaymentOptions.last().pop_minus_steps = k->value.GetInt();
                             }
-                        } else if (strcmp(inner_obj_name, "pop_allow_overpay") == 0) {
-                            if (k->value.IsBool()) {
-                                this->currentPaymentOptions.last().pop_allow_overpay = k->value.GetBool();
-                            }
-                        } else if (strcmp(inner_obj_name, "pop_apply_carry_over_to_ticket_endtime") == 0) {
-                            if (k->value.IsBool()) {
-                                this->currentPaymentOptions.last().pop_apply_carry_over_to_ticket_endtime = k->value.GetBool();
-                            }
                         } else if (strcmp(inner_obj_name, "pop_payment_method_id") == 0) {
                             this->currentPaymentOptions.last().pop_payment_method_id = k->value.GetInt();
                         } else if (strcmp(inner_obj_name, "pop_day_end_time") == 0) {
@@ -1110,7 +728,6 @@ bool Configuration::ParseJson(Configuration* cfg, const char* json)
                         else if (strcmp(inner_obj_name, "pedwt_time_from") == 0) SpecialDaysWorktime.pedwt_time_from = k->value.GetString();
                         else if (strcmp(inner_obj_name, "pedwt_time_to") == 0) SpecialDaysWorktime.pedwt_time_to = k->value.GetString();
                         else if (strcmp(inner_obj_name, "pedwt_price") == 0) SpecialDaysWorktime.pedwt_price = k->value.GetDouble();
-                        else if (strcmp(inner_obj_name, "pedwt_paid") == 0) SpecialDaysWorktime.pedwt_paid = k->value.GetInt();
                         break;
                 /*case MemberType::WeekDaysType:
                         if (strcmp(inner_obj_name, "pdiw_id") == 0) WeekDays.pdiw_id = k->value.GetInt();
@@ -1153,11 +770,6 @@ bool Configuration::ParseJson(Configuration* cfg, const char* json)
                 switch (mb_type) {
                 case MemberType::UnknownType:
                     break;
-                case MemberType::WeekDaysType:
-                    // qCritical() << "INSERT" << (int)WeekDay.m_id << WeekDay.m_date.toString(Qt::ISODate);
-                    // cfg->WeekDays.insert(pair<Qt::DayOfWeek, ATBWeekDay>(WeekDay.m_id, WeekDay));
-                    // qCritical() << WeekDay;
-                    break;
                 case MemberType::PaymentMethodType:
                     cfg->PaymentMethod.insert(pair<int, ATBPaymentMethod>(PaymentMethod.pme_id, PaymentMethod));
                     break;
@@ -1478,6 +1090,7 @@ bool Configuration::isDayIncludedAsSpecialDay(uint64_t businessHours, QDateTime
 
     if (isSpecialDay(dt)) {
         bool const &r = ((businessHours & BusinessHours::OFFICIAL_HOLIDAY) == BusinessHours::OFFICIAL_HOLIDAY);
+        qCritical() << "XXXXXXXXXXXXXXXXXX r" << r << businessHours;
         return r;
     }
 
@@ -1567,6 +1180,7 @@ int Configuration::getPaymentOptionIndex(PERMIT_TYPE permitType) const {
     std::optional<QVector<ATBPaymentOption>> paymentOptions = getPaymentOptionsForAllKeys();
     if (paymentOptions) {
 
+
         QVector<ATBPaymentOption> const vec = paymentOptions.value();
         PermitType const p(permitType);
 
@@ -1580,73 +1194,6 @@ int Configuration::getPaymentOptionIndex(PERMIT_TYPE permitType) const {
     return 0;
 }
 
-int getPaymentOptionIndex(Configuration const &cfg, QDateTime const &dt) {
-
-    int const numOptions = cfg.getAllPaymentOptions().size();
-
-    // qCritical() << __func__ << ":" << __LINE__ << "numOptions" << numOptions;
-
-    for (int opt=0; opt < numOptions; ++opt) {
-        uint64_t const pop_business_hours = cfg.getPaymentOptions(opt).pop_business_hours;
-
-        if (pop_business_hours == 0) { // 0 == 24/7
-            return opt;
-        }
-
-        // QDateTime const dt = QDateTime::currentDateTime();
-        int const dayOfWeek = dt.date().dayOfWeek();
-
-        // qCritical() << __func__ << ":" << __LINE__ << "dayOfWeek" << dayOfWeek;
-
-        if (isHoliday(cfg, dt)) {
-            if (pop_business_hours & BusinessHours::OFFICIAL_HOLIDAY) {
-                return opt;
-            }
-        } else {
-            switch (dayOfWeek) {
-            case (int)Qt::Monday: {
-                if (pop_business_hours & BusinessHours::MON) {
-                    return opt;
-                }
-            } break;
-            case (int)Qt::Tuesday: {
-                if (pop_business_hours & BusinessHours::TUE) {
-                    return opt;
-                }
-            } break;
-            case (int)Qt::Wednesday: {
-                if (pop_business_hours & BusinessHours::WED) {
-                    return opt;
-                }
-            } break;
-            case (int)Qt::Thursday: {
-                if (pop_business_hours & BusinessHours::THU) {
-                    return opt;
-                }
-            } break;
-            case (int)Qt::Friday: {
-                if (pop_business_hours & BusinessHours::FRI) {
-                    return opt;
-                }
-            } break;
-            case (int)Qt::Saturday: {
-                if (pop_business_hours & BusinessHours::SAT) {
-                    return opt;
-                }
-            } break;
-            case (int)Qt::Sunday: {
-                if (pop_business_hours & BusinessHours::SUN) {
-        qCritical() << __func__ << ":" << __LINE__ << "opt" << opt;
-                    return opt;
-                }
-            } break;
-            }
-        }
-    }
-
-    return -1;
-}
-
 std::optional<QVector<ATBTariffProduct>>
 Configuration::getTariffProductForProductId(PermitType permitType) const {
     QString permitTypeName(permitType);
@@ -1713,7 +1260,7 @@ std::optional<QDateTime> Configuration::prepaidStart(QDateTime const &start, int
     std::optional<QDateTime> value;
     QDateTime s = start;
 
-    qCritical() << "(" << __func__ << ":" << __LINE__ << ")         prepaid option id:" << prepaid_option_id;
+    // qCritical() << "(" << __func__ << ":" << __LINE__ << ")         prepaid option id:" << prepaid_option_id;
 
     std::optional<ATBPrepaid> prepaid_option = getPrepaidType(prepaid_option_id);
     if (prepaid_option.has_value()) {
@@ -1901,43 +1448,3 @@ Configuration::getWeekDayWorkTime(QTime const &time, Qt::DayOfWeek dayOfWeek) {
 
     return value;
 }
-
-bool isHoliday(Configuration const &cfg, QDateTime const &t) {
-    int const weekDay = t.date().dayOfWeek();
-
-    for (auto[iter, rEnd] = cfg.WeekDays.equal_range(static_cast<Qt::DayOfWeek>(weekDay));
-         iter != rEnd;
-         ++iter) {
-
-        if (iter->second.m_type == ATBWeekDay::WeekDayType::HOLIDAY) {
-            QDate const &d = iter->second.m_date;
-            if (!d.isNull() && d.isValid()) {
-                if (t.date() == d) {
-                    return true;
-                }
-            }
-        }
-    }
-    return false;
-}
-
-bool previousDayHoliday(Configuration const &cfg, QDateTime const &t) {
-    int const weekDay = t.date().dayOfWeek();
-    int const previousWeekDay = (weekDay == static_cast<int>(Qt::Monday)) ?
-                static_cast<int>(Qt::Sunday) : (weekDay - 1);
-
-    for (auto[iter, rEnd] = cfg.WeekDays.equal_range(static_cast<Qt::DayOfWeek>(previousWeekDay));
-         iter != rEnd;
-         ++iter) {
-
-        if (iter->second.m_type == ATBWeekDay::WeekDayType::HOLIDAY) {
-            QDate const &d = iter->second.m_date;
-            if (!d.isNull() && d.isValid()) {
-                if (t.addDays(-1).date() == d) {
-                    return true;
-                }
-            }
-        }
-    }
-    return false;
-}

library/src/utilities.cpp

@@ -207,13 +207,7 @@ bool Utilities::IsYearPeriodActive(Configuration const *cfg, QDateTime const &dt
                               dt.date().day());
                 QDate const s(2004, year.second.pye_start_month, year.second.pye_start_day);
                 QDate const e(2004, year.second.pye_end_month, year.second.pye_end_day);
-                //qCritical() << __func__ << __LINE__ << "    d" << d.toString(Qt::ISODate);
+                return (d >= s && d <= e);
-                //qCritical() << __func__ << __LINE__ << "start" << s.toString(Qt::ISODate);
-                //qCritical() << __func__ << __LINE__ << "  end" << e.toString(Qt::ISODate);
-                if (s <= e) {
-                    return (d >= s && d <= e);
-                }
-                return (d >= s || d <= e);
             })) {
         qCritical() << "NO VALID YEAR PERIOD";
         return false;

main/main.cpp

@@ -43,7 +43,7 @@ extern "C" char* strptime(const char* s,
 #define NEUHAUSER_LINSINGER_MASCHINENBAU        (0)
 #define NEUHAUSER_NORDISCHES_AUSBILDUNGSZENTRUM (0)
 #define NEUHAUSER_BILEXA_GALTUER                (0)
-#define BAD_NEUENAHR_AHRWEILER                  (1)
+#define BAD_NEUENAHR_AHRWEILER                  (0)
 #define NEUHAUSER_CHRISTOPH_REISEN              (0)
 #define NEUHAUSER_PERNEGG_AN_DER_MUR            (0)
 #define NEUHAUSER_STOCKERAU                     (0)
@@ -52,6 +52,7 @@ extern "C" char* strptime(const char* s,
 #define SCHNALS_LEITER_KIRCHL                   (0)
 #define SCHNALS_STAUMAUER                       (SCHNALS_LEITER_KIRCHL)
 #define VALSER_ALM                              (0)
+#define FUCHS_MUEHLBACH                         (1)
 
 #if NEUHAUSER_KIRCHDORF==1
 static bool test_neuhauser_kirchdorf(int step, double cost) {
@@ -339,20 +340,20 @@ int main() {
     cout << endl;
 
     if (isParsed) {
-        //pop_min_time = get_minimal_parkingtime(&cfg);
+        pop_min_time = get_minimal_parkingtime(&cfg);
-        //pop_max_time = get_maximal_parkingtime(&cfg);
+        pop_max_time = get_maximal_parkingtime(&cfg);
-        //pop_min_price = get_minimal_parkingprice(&cfg);
+        pop_min_price = get_minimal_parkingprice(&cfg);
-        //pop_max_price = get_maximal_parkingprice(&cfg);
+        pop_max_price = get_maximal_parkingprice(&cfg);
-        //pop_daily_card_price = cfg.getPaymentOptions().pop_daily_card_price;
+        pop_daily_card_price = cfg.getPaymentOptions().pop_daily_card_price;
 
-        //qCritical() << "        pop_min_time: " << pop_min_time;
+        qCritical() << "        pop_min_time: " << pop_min_time;
-        //qCritical() << "        pop_max_time: " << pop_max_time;
+        qCritical() << "        pop_max_time: " << pop_max_time;
-        //qCritical() << "       pop_min_price: " << pop_min_price;
+        qCritical() << "       pop_min_price: " << pop_min_price;
-        //qCritical() << "       pop_max_price: " << pop_max_price;
+        qCritical() << "       pop_max_price: " << pop_max_price;
 
 
-        //QList<int> timeSteps = Calculator::GetInstance().GetTimeSteps(&cfg);
+        QList<int> timeSteps = Calculator::GetInstance().GetTimeSteps(&cfg);
-        //qCritical() << "TimeSteps" << timeSteps;
+        qCritical() << "TimeSteps" << timeSteps;
 
         // return 0;
 
@@ -363,7 +364,8 @@ int main() {
 
         // for (int day = Qt::Monday; day <= Qt::Sunday; ++day) {
         for (int day = Qt::Monday; day <= Qt::Monday; ++day) {
-            QDateTime s(QDate(2024, 8, 19 + day), QTime()); // 20: (whit) monday,..., 26: sunday
+            QDateTime s(QDate(2024, 7, 29 + day), QTime()); // 20: (whit) monday,..., 26: sunday
+            QDateTime end;
 
             switch (day) {
             case (int)Qt::Monday:
@@ -389,30 +391,6 @@ int main() {
                 break;
             }
 
-            QDateTime start(s);
-            start.setTime(QTime(21, 30, 0));
-
-            QDateTime end;
-            int netto_parking_time = 14 * 60;
-            struct price_t costs;
-            PermitType pt(PERMIT_TYPE::SHORT_TERM_PARKING);
-
-            double cost = 150;
-
-            //cs = compute_price_for_parking_ticket(&cfg, start, netto_parking_time,
-            //                                      end, &costs, pt);
-
-
-
-            //qCritical() << "start" << start.toString(Qt::ISODate) << "< cost" << costs.netto
-            //            << "> end" << end.toString(Qt::ISODate);
-
-            cs = compute_duration_for_parking_ticket(&cfg, start, cost, end, PermitType(PERMIT_TYPE::SHORT_TERM_PARKING));
-                        qCritical() << "start" << start.toString(Qt::ISODate) << "< cost" << cost
-                                    << "> end" << end.toString(Qt::ISODate);
-            //}
-
-            exit(0);
 
             /*
             CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
@@ -598,8 +576,8 @@ int main() {
     int pop_max_price;
     int pop_daily_card_price;
 
-    //input.open("/home/linux/customer_505/etc/psa_tariff/tariff01.json");
+    input.open("/home/linux/customer_505/etc/psa_tariff/tariff01.json");
-    input.open("/opt/ptu5/opt/customer_505/etc/psa_tariff/tariff01.json");
+    //input.open("/opt/ptu5/opt/customer_505/etc/psa_tariff/tariff01.json");
 
     std::stringstream sstr;
     while(input >> sstr.rdbuf());
@@ -611,10 +589,13 @@ int main() {
     cout << endl;
 
     if (isParsed) {
-        pop_min_time = get_minimal_parkingtime(&cfg);
+        //PermitType permitType(PERMIT_TYPE::SHORT_TERM_PARKING);
-        pop_max_time = get_maximal_parkingtime(&cfg);
+        PermitType permitType(PERMIT_TYPE::DAY_TICKET_PKW);
-        pop_min_price = get_minimal_parkingprice(&cfg);
+
-        pop_max_price = get_maximal_parkingprice(&cfg);
+        pop_min_time = get_minimal_parkingtime(&cfg, permitType);
+        pop_max_time = get_maximal_parkingtime(&cfg, permitType);
+        pop_min_price = get_minimal_parkingprice(&cfg, permitType);
+        pop_max_price = get_maximal_parkingprice(&cfg, permitType);
         pop_daily_card_price = cfg.getPaymentOptions().pop_daily_card_price;
 
         qCritical() << "        pop_min_time: " << pop_min_time;
@@ -672,10 +653,10 @@ int main() {
             }
 
             //for (int minutes = 0; minutes < 1440; ++minutes) {
-            for (int minutes = 1020; minutes <= 1020; minutes += 1) {
+            for (int minutes = 480; minutes <= 480; minutes += 1) {
                 QDateTime start = s.addSecs(minutes * 60);
 
-                qCritical() << "start" << start.toString(Qt::ISODate);
+                // qCritical() << "start" << start.toString(Qt::ISODate);
 
                 QDateTime effectiveStart = start;
 
@@ -692,8 +673,136 @@ int main() {
                 }
 
 #if 0
-                PermitType permitType(PERMIT_TYPE::SHORT_TERM_PARKING);
+                for (int i = 700; i <= 1400; i += 700) {
-                for (int i = 200; i <= 200; i += 10) {
+                    cost = i;
+
+                    if ((cs = compute_duration_for_parking_ticket(&cfg, start, cost, end, permitType))) {      // return value
+                    }
+
+                    if (!cs) {
+                        qCritical() << "ERROR CalcState" << cs.toString() << endl;
+                    } else {
+//                        qCritical() << cs.toString();
+                    }
+
+                    //qCritical() << "start" << start.toString(Qt::ISODate) << "< cost" << cost
+                    //            << "> end" << end.toString(Qt::ISODate);
+
+                }
+#else
+
+                start = QDateTime::currentDateTime();
+                //start.setTime(QTime(9, 57, 0));
+
+                for (int netto_parking_time = 60; netto_parking_time <= 60; netto_parking_time += 60) {
+
+                    QDateTime end;
+                    struct price_t price;
+                    cs = compute_price_for_parking_ticket(&cfg, start, netto_parking_time, end, &price, permitType, true);
+
+                    qCritical() << "start" << start.toString(Qt::ISODate) << "end" << end.toString(Qt::ISODate)
+                                << "price" << price.netto;
+                }
+#endif
+            }
+        }
+    }
+#endif
+
+#if FUCHS_MUEHLBACH==1
+    std::ifstream input;
+    int pop_min_time;
+    int pop_max_time;
+    int pop_min_price;
+    int pop_max_price;
+    int pop_daily_card_price;
+
+    input.open("/home/linux/customer_504/etc/psa_tariff/tariff01.json");
+    //input.open("/opt/ptu5/opt/customer_505/etc/psa_tariff/tariff01.json");
+
+    std::stringstream sstr;
+    while(input >> sstr.rdbuf());
+    std::string json(sstr.str());
+
+    Configuration cfg;
+
+    bool isParsed = cfg.ParseJson(&cfg, json.c_str());
+    cout << endl;
+
+    if (isParsed) {
+        PermitType permitType(PERMIT_TYPE::SHORT_TERM_PARKING);
+
+        //pop_min_time = get_minimal_parkingtime(&cfg, permitType);
+        //pop_max_time = get_maximal_parkingtime(&cfg, permitType);
+        //pop_min_price = get_minimal_parkingprice(&cfg, permitType);
+        //pop_max_price = get_maximal_parkingprice(&cfg, permitType);
+        //pop_daily_card_price = cfg.getPaymentOptions().pop_daily_card_price;
+
+        //qCritical() << "        pop_min_time: " << pop_min_time;
+        //qCritical() << "        pop_max_time: " << pop_max_time;
+        //qCritical() << "       pop_min_price: " << pop_min_price;
+        //qCritical() << "       pop_max_price: " << pop_max_price;
+
+        CalcState cs;
+        double cost;
+        int durationInMinutes = 0;
+        int offsetInMinutes = 0;
+
+        // for (int day = Qt::Monday; day <= Qt::Sunday; ++day) {
+        for (int day = Qt::Wednesday; day <= Qt::Wednesday; ++day) {
+            QDateTime s(QDate(2024, 8, 11 + day), QTime(0, 0, 0));
+            QDateTime end;
+
+            switch (day) {
+            case (int)Qt::Monday:
+                qCritical() << "Monday";
+                break;
+            case (int)Qt::Tuesday:
+                qCritical() << "Tuesday";
+                break;
+            case (int)Qt::Wednesday:
+                qCritical() << "Wednesday";
+                break;
+            case (int)Qt::Thursday:
+                qCritical() << "Thursday";
+                break;
+            case (int)Qt::Friday:
+                qCritical() << "Friday";
+                break;
+            case (int)Qt::Saturday:
+                qCritical() << "Saturday";
+                break;
+            case (int)Qt::Sunday:
+                qCritical() << "Sunday";
+                break;
+            }
+
+            //for (int minutes = 0; minutes < 1440; ++minutes) {
+            for (int minutes = 491; minutes <= 491; minutes += 1) {
+                QDateTime start = s.addSecs(minutes * 60);
+
+                //qCritical() << "start" << start.toString(Qt::ISODate);
+
+                QDateTime effectiveStart = start;
+
+                // hier sollte man auch testen was passiert, falls man ausserhalb
+                // der verkaufsdaten steht
+                if (start.time() < QTime(7, 0, 0)) {
+                    effectiveStart.setTime(QTime(7, 0, 0));
+                } else
+                if (start.time() <= QTime(20, 0, 0)) {
+                    effectiveStart = start;
+                } else {
+                    effectiveStart = start.addDays(1);
+                    effectiveStart.setTime(QTime(7, 0, 0)); // next day
+                }
+
+#if 0
+                qCritical() << "";
+                qCritical() << "compute_duration_for_parking_ticket";
+                qCritical() << "===================================";
+
+                for (int i = 0; i <= 600; i += 10) {
                     cost = i;
 
                     if ((cs = compute_duration_for_parking_ticket(&cfg, start, cost, end, permitType))) {      // return value
@@ -710,33 +819,14 @@ int main() {
 
                 }
 #else
-                for (int i = 700; i <= 1400; i += 700) {
+                qCritical() << "";
-                //for (int i = 2100; i <= 2100; i += 10) {
+                qCritical() << "compute_price_for_parking_ticket";
-                    cost = i;
+                qCritical() << "================================";
-
-                    if ((cs = compute_duration_for_parking_ticket(&cfg, start, cost, end, PermitType(PERMIT_TYPE::SHORT_TERM_PARKING_PKW)))) {      // return value
-                    }
-
-                    if (!cs) {
-                        qCritical() << "ERROR CalcState" << cs.toString() << endl;
-                    } else {
-//                        qCritical() << cs.toString();
-                    }
-
-                    qCritical() << "start" << start.toString(Qt::ISODate) << "< cost" << cost
-                                << "> end" << end.toString(Qt::ISODate);
-                }
-#endif
-#if 0
-
-                start = QDateTime::currentDateTime();
-                start.setTime(QTime(9, 57, 0));
-
-                for (int i = 66; i <= 66; i += 6) {
 
+                for (int netto_parking_time = 180; netto_parking_time <= (180 + 720*3); netto_parking_time += 720) {
                     QDateTime end;
                     struct price_t price;
-                    cs = compute_price_for_parking_ticket(&cfg, start, i, end, &price);
+                    cs = compute_price_for_parking_ticket(&cfg, start, netto_parking_time, end, &price, permitType, true);
 
                     qCritical() << "start" << start.toString(Qt::ISODate) << "end" << end.toString(Qt::ISODate)
                                 << "price" << price.netto;
@@ -1380,7 +1470,7 @@ int main() {
     int pop_carry_over;
     int pop_carry_over_time_range_id;
 
-    for (int zone=2; zone < 3; ++zone) {
+    for (int zone=1; zone < 2; ++zone) {
     //for (int t=6; t < 7; t+=20) {
         switch (zone) {
         case 1: {
@@ -1389,7 +1479,6 @@ int main() {
             //pop_max_time = 6*60;
         } break;
         case 2: {
-            qCritical() << "        ZONE 2: KURZZEIT 1";
             // kuzzeit-1-tarif
             input.open("/opt/ptu5/opt/customer_249/etc/psa_tariff/tariff02.json");
             //pop_max_time = 5*60;
@@ -1432,7 +1521,6 @@ int main() {
         cout << endl;
 
         if (isParsed) {
-
             // test library functions
 
             if (zone == 1) {
@@ -1459,10 +1547,10 @@ int main() {
                 static QList<int> const timeSteps = Calculator::GetInstance().GetTimeSteps(&cfg);
                 qCritical() << "TimeSteps" << timeSteps;
 
-                //if (stepsConfigured != timeSteps) {
+                if (stepsConfigured != timeSteps) {
-                //    qCritical() << "TIME-STEPS SHOULD BE" << stepsConfigured;
+                    qCritical() << "TIME-STEPS SHOULD BE" << stepsConfigured;
-                //    return -1;
+                    return -1;
-                //}
+                }
 
                 QDateTime start = QDateTime::currentDateTime();
 
@@ -1470,8 +1558,7 @@ int main() {
                 double price1 = 0;
                 double price2 = 0;
 
-                //for (int m=0; m < 1440; ++m) {
+                for (int m=0; m < 1440; ++m) {
-                for (int m=480; m < 481; ++m) {
                     start.setTime(QTime(0, 0, 0));
                     start = start.addSecs(m*60);
 
@@ -1488,7 +1575,7 @@ int main() {
                     //}
 
                     CalcState cs;
-#if 1
+
                     for (int i = 0, j=timeSteps.size() ; i < timeSteps.size(); --j, ++i) {
                         QDateTime end = start.addSecs(timeSteps.at(i)*60);
 
@@ -1523,21 +1610,6 @@ int main() {
                         //                                                                     cost[i], false, true);
                         //qCritical() << "duration" << duration.c_str();
                     }
-#else
-
-                    double cost = 80;
-                    qCritical() << "START" << start.toString(Qt::ISODate) << "cost" << cost;
-                    QDateTime end;
-
-                    cs = compute_duration_for_parking_ticket(&cfg, start, cost, end,
-                                                             PermitType(PERMIT_TYPE::SHORT_TERM_PARKING));
-                        qCritical() << __LINE__ << cs.toString()
-                                    << "START" << start.toString(Qt::ISODate)
-                                    << "<duration" << start.secsTo(end) / 60
-                                    << "cost" << cost
-                                    << "> end" << end.toString(Qt::ISODate);
-                    //}
-#endif
                 }
             } // zone == 1
             if (zone == 2) {
@@ -1575,19 +1647,18 @@ int main() {
                 bool fail;
                 QDateTime start;
 
-                for (int i=1; i < 2; ++i) {
+                for (int i=0; i < 4; ++i) {
                     switch (i) {
                     case 0:
                         start = QDateTime(QDate(2024, 5, 1), QTime(16, 0, 0)); // holiday
                         fail = false;
                     break;
                     case 1:
-                        //start = QDateTime(QDate(2024, 10, 3), QTime(17, 0, 0)); // sunday
+                        start = QDateTime(QDate(2024, 4, 21), QTime(16, 0, 0)); // sunday
-                        start = QDateTime(QDate(2024, 9, 8), QTime(16, 2, 0)); // sunday
                         fail = false;
                     break;
                     case 2:
-                        start = QDateTime(QDate(2024, 4, 22), QTime(17, 30, 0)); // monday
+                        start = QDateTime(QDate(2024, 4, 22), QTime(8, 0, 0)); // monday
                         fail = false;
                     break;
                     case 3:
@@ -1611,52 +1682,18 @@ int main() {
 
                         QList<int>::const_iterator step;
                         for (step = timeSteps.cbegin(); step != timeSteps.cend(); ++step) {
-                            //qCritical() << __LINE__
-                            //            << "START" << start.toString(Qt::ISODate)
-                            //            << "<duration" << *step;
-
-                            // if (*step != 180)
-                            // continue;
-
 
                             double cost = 0;
                             CalcState cs;
 
-                            QDateTime s(start);
+                            if ((cs = compute_price_for_parking_ticket(&cfg, start, *step, end, &price, PermitType(PERMIT_TYPE::SHORT_TERM_PARKING)))) {
-
-                            qCritical() << __LINE__
-                                        << "START" << start.toString(Qt::ISODate)
-                                        << "<duration" << *step;
-
-#if 1
-                            if ((cs = compute_price_for_parking_ticket(&cfg, s, *step, end, &price,
-                                                                       PermitType(PERMIT_TYPE::SHORT_TERM_PARKING)))) {
                                 cost = price.netto;
-                                qCritical() << __LINE__
+                                qCritical() << "step" << *step << ": cost" << cost;
-                                            << "START" << start.toString(Qt::ISODate)
-                                            << "<duration" << *step
-                                            << "cost" << cost
-                                            << "> end" << end.toString(Qt::ISODate);
                             } else {
                                 if (fail == false) {
                                     qCritical() << "<<<ERROR>>> cs =" << QString(cs);
                                 }
                             }
-#else
-                            cost = 200;
-                            qCritical() << "START" << start.toString(Qt::ISODate) << "cost" << cost;
-
-                            cs = compute_duration_for_parking_ticket(&cfg, start, cost, end,
-                                                                         PermitType(PERMIT_TYPE::SHORT_TERM_PARKING));
-                                qCritical() << __LINE__ << cs.toString()
-                                            << "START" << start.toString(Qt::ISODate)
-                                            << "<duration" << start.secsTo(end) / 60
-                                            << "cost" << cost
-                                            << "> end" << end.toString(Qt::ISODate);
-                            break;
-                            //}
-#endif
-
                         }
                     } else {
                         qCritical() << "ERROR paymentOptionIndex =" << paymentOptionIndex;

main/main.pro

@@ -30,15 +30,9 @@ SOURCES += main.cpp
 # HEADERS +=
 
 OTHER_FILES += \
-    /opt/ptu5/opt/customer_335/etc/psa_tariff/tariff01.json \
+    /opt/ptu5/opt/customer_502/etc/psa_tariff/tariff01.json \
-    /opt/ptu5/opt/customer_335/etc/psa_tariff/tariff02.json \
+    /opt/ptu5/opt/customer_502/etc/psa_tariff/tariff02.json \
-    /opt/ptu5/opt/customer_249/etc/psa_tariff/tariff01.json \
+    /opt/ptu5/opt/customer_502/etc/psa_tariff/tariff03.json
-    /opt/ptu5/opt/customer_249/etc/psa_tariff/tariff02.json \
-    /opt/ptu5/opt/customer_249/etc/psa_tariff/tariff03.json \
-    /opt/ptu5/opt/customer_249/etc/psa_tariff/tariff04.json \
-    /opt/ptu5/opt/customer_249/etc/psa_tariff/tariff05.json \
-    /opt/ptu5/opt/customer_249/etc/psa_tariff/tariff06.json \
-    /opt/ptu5/opt/customer_249/etc/psa_tariff/tariff07.json