Use fprintf instead of printf.

compute_duration_for_parking_ticket() using QDateTime parameters.
Added new error code WRONG_ISO_TIME_FORMAT.

library/include/mobilisis/calculate_price.h

@@ -4,6 +4,9 @@
 #include <time.h>
 #include <inttypes.h>
 
+#include <QString>
+#include <QDateTime>
+
 #ifdef WIN32
 #ifdef CALCULATE_LIBRARY_EXPORTS
 #define CALCULATE_LIBRARY_API __declspec(dllexport)
@@ -18,9 +21,9 @@ class Configuration;
 
 typedef Configuration parking_tariff_t;
 
-#ifdef __cplusplus
-extern "C" {
-#endif
+//#ifdef __cplusplus
+//extern "C" {
+//#endif
 
 struct CALCULATE_LIBRARY_API price_t {
     uint32_t units;
@@ -30,16 +33,107 @@ struct CALCULATE_LIBRARY_API price_t {
     double vat;
 };
 
-bool CALCULATE_LIBRARY_API init_tariff(parking_tariff_t **tariff, char const *config_file);
-void CALCULATE_LIBRARY_API free_tariff(parking_tariff_t *tariff);
-int CALCULATE_LIBRARY_API get_zone_nr();
+struct CALCULATE_LIBRARY_API CalcState {
+    enum class State : uint8_t {
+        SUCCESS,
+        ERROR_PARSING_ZONE_NR,
+        ERROR_LOADING_TARIFF,
+        ERROR_PARSING_TARIFF,
+        NEGATIVE_PARING_TIME,
+        INVALID_START_DATE,
+        WRONG_PARAM_VALUES,
+        WRONG_ISO_TIME_FORMAT,
+        ABOVE_MAX_PARKING_TIME,
+        BELOW_MIN_PARKING_TIME,
+        BELOW_MIN_PARKING_PRICE,
+        OVERPAID
+    };
 
-bool CALCULATE_LIBRARY_API compute_price_for_parking_ticket(parking_tariff_t *tariff,
+    State m_status;
+    QString m_desc;
+
+    explicit CalcState() : m_status(State::SUCCESS), m_desc("") {}
+
+    explicit operator bool() const noexcept {
+        return (m_status == State::SUCCESS);
+    }
+
+    explicit operator QString () const noexcept {
+        QString s;
+        switch (m_status) {
+        case State::SUCCESS:
+            s = "SUCCESS";
+            break;
+        case State::ERROR_PARSING_ZONE_NR:
+            s = "ERROR_PARSING_ZONE_NR";
+            break;
+        case State::ERROR_LOADING_TARIFF:
+            s = "ERROR_LOADING_TARIFF";
+            break;
+        case State::ERROR_PARSING_TARIFF:
+            s = "ERROR_PARSING_TARIFF";
+            break;
+        case State::NEGATIVE_PARING_TIME:
+            s = "NEGATIVE_PARKING_TIME";
+            break;
+        case State::ABOVE_MAX_PARKING_TIME:
+            s = "ABOVE_MAX_PARKING_TIME";
+            break;
+        case State::WRONG_PARAM_VALUES:
+            s = "WRONG_PARAM_VALUES";
+            break;
+        case State::BELOW_MIN_PARKING_TIME:
+            s = "BELOW_MIN_PARKING_TIME";
+            break;
+        case State::BELOW_MIN_PARKING_PRICE:
+            s = "BELOW_MIN_PARKING_PRICE";
+            break;
+        case State::OVERPAID:
+            s = "OVERPAID";
+            break;
+        case State::INVALID_START_DATE:
+            s = "INVALID_START_DATE";
+            break;
+        case State::WRONG_ISO_TIME_FORMAT:
+            s = "WRONG_ISO_TIME_FORMAT";
+        }
+        return s + ":" + m_desc;
+    }
+
+    CalcState &set(State s) { m_status = s; return *this; }
+    CalcState &setDesc(QString s) { m_desc = s; return *this; }
+};
+
+CalcState CALCULATE_LIBRARY_API init_tariff(parking_tariff_t **tariff,
+                                            char const *config_file);
+void CALCULATE_LIBRARY_API free_tariff(parking_tariff_t *tariff);
+int CALCULATE_LIBRARY_API get_zone_nr(int zone = -1);
+
+CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
+                                            parking_tariff_t *tariff,
                                             time_t start_parking_time,
                                             time_t end_parking_time,
                                             struct price_t *price);
-#ifdef __cplusplus
-} // extern "C"
-#endif
+
+CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
+                                            parking_tariff_t *tariff,
+                                            QDateTime const &start_parking_time,
+                                            QDateTime const &end_parking_time,
+                                            struct price_t *price);
+
+CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
+                                            parking_tariff_t *tariff,
+                                            time_t start_parking_time,
+                                            double cost,
+                                            QString &duration);
+
+CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
+                                            parking_tariff_t *tariff,
+                                            QDateTime const &start_parking_time,
+                                            double cost,
+                                            QDateTime &ticketEndTime);
+//#ifdef __cplusplus
+//} // extern "C"
+//#endif
 
 #endif // CALCULATE_PRICE_H

library/src/calculate_price.cpp

@@ -10,25 +10,31 @@
 
 static Calculator calculator;
 
-int CALCULATE_LIBRARY_API get_zone_nr() {
+int CALCULATE_LIBRARY_API get_zone_nr(int zone)
+{
+    if(zone > -1) return zone;
+    else
+  {
         QFile zone("/etc/zone_nr");
         if (zone.exists()) {
             QFileInfo finfo(zone);
             if (finfo.size() <= 4) { // decimal 000\n
                 if (zone.open(QIODevice::ReadOnly | QIODevice::Text)) {
-
                     QTextStream in(&zone);
                     return in.readLine(100).toInt();
-
                 }
             }
         }
         return -1;
+   }
 }
 
-bool CALCULATE_LIBRARY_API init_tariff(parking_tariff_t **tariff, char const *config_file) {
+CalcState CALCULATE_LIBRARY_API init_tariff(parking_tariff_t **tariff, char const *config_file) {
     *tariff = new Configuration();
 
+    CalcState calcState;
+#if __linux__
+
     int const zone = get_zone_nr();
 
     // DEBUG
@@ -36,7 +42,9 @@ bool CALCULATE_LIBRARY_API init_tariff(parking_tariff_t **tariff, char const *co
     qCritical() << "      ... zone = " << zone;
 
     if (zone <= 0) {
-        return false;
+        delete *tariff;
+        *tariff = nullptr;
+        return calcState.set(CalcState::State::ERROR_PARSING_ZONE_NR);
     }
 
     QString confFile(config_file);
@@ -48,42 +56,75 @@ bool CALCULATE_LIBRARY_API init_tariff(parking_tariff_t **tariff, char const *co
     memset(buffer, 0x00, sizeof(buffer));
     snprintf(buffer, sizeof(buffer)-1, "tariff%02d.json", zone);
     confFile += buffer;
+#else // windows
+    QString confFile(config_file);
+#endif
 
     // DEBUG
     qCritical() << "      ... confFile = " << confFile;
 
     QFile fname(confFile);
-    if (fname.exists()) {
-
-        // DEBUG
-        qCritical() << "      ... confFile exists";
-
-        if (fname.open(QIODevice::ReadOnly | QIODevice::Text)) {
-
+    if (fname.exists() &&
+        fname.open(QIODevice::ReadOnly | QIODevice::Text)) {
         // DEBUG
         qCritical() << "      ... confFile is open";
 
         QString json = fname.readAll();
-            return (*tariff)->ParseJson(*tariff, json.toStdString().c_str());
+        if (! (*tariff)->ParseJson(*tariff, json.toStdString().c_str())) {
+            delete *tariff;
+            *tariff = nullptr;
+            return calcState.set(CalcState::State::ERROR_PARSING_TARIFF);
         }
+    } else {
+        delete *tariff;
+        *tariff = nullptr;
+        return calcState.set(CalcState::State::ERROR_LOADING_TARIFF);
     }
 
-    qCritical() << "init_tariff: Parsing tariff config (" << confFile << ") failed!";
+    qCritical() << "init_tariff: Parsing tariff config (" << confFile << ")";
 
-    return false;
+    return calcState;
 }
 
 void CALCULATE_LIBRARY_API free_tariff(parking_tariff_t *tariff) {
+    if (tariff != nullptr) {
         delete tariff;
+    }
 }
 
-bool CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
+CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
                                     parking_tariff_t *tariff,
                                     time_t start_parking_time, // in minutes
                                     time_t end_parking_time,   // in minutes
                                     struct price_t *price) {
+    CalcState calcState;
+    double minMin = tariff->PaymentOption.find(PaymentOption::Option1)->second.pop_min_time;
+    double maxMin = tariff->PaymentOption.find(PaymentOption::Option1)->second.pop_max_time;
+
+    if (minMin < 0 || maxMin < 0 || maxMin < minMin) {
+        calcState.setDesc(QString("minMin=%1, maxMin=%2").arg(minMin).arg(maxMin));
+        return calcState.set(CalcState::State::WRONG_PARAM_VALUES);
+    }
+
     int const duration = end_parking_time - start_parking_time;
-    if (duration > 0) {
+    if (duration < 0) {
+        calcState.setDesc(QString("end=%1, start=%2")
+                            .arg(end_parking_time, start_parking_time));
+        return calcState.set(CalcState::State::NEGATIVE_PARING_TIME);
+    }
+    if (duration > maxMin) {
+        calcState.setDesc(QString("duration=%1, maxMin=%2").arg(duration).arg(maxMin));
+        return calcState.set(CalcState::State::ABOVE_MAX_PARKING_TIME);
+    }
+    if (duration < minMin) {
+        calcState.setDesc(QString("duration=%1, minMin=%2").arg(duration).arg(minMin));
+        return calcState.set(CalcState::State::BELOW_MIN_PARKING_TIME);
+    }
+    if (duration == 0) {
+        memset(price, 0x00, sizeof(*price));
+        return calcState.set(CalcState::State::SUCCESS);
+    }
+
     QDate const d(1970, 1, 1);
     QTime const t(0, 0, 0);
     QDateTime start(d, t, Qt::UTC);
@@ -94,16 +135,142 @@ bool CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
                         tariff, PaymentOption::Option1,
                         cs.toLocal8Bit().constData(),
                         duration, false, true);
+        double minCost = tariff->PaymentOption.find(PaymentOption::Option1)->second.pop_min_price;
+        if (cost < minCost) {
+            calcState.setDesc(QString("minCost=%1, cost=%2").arg(minCost).arg(cost));
+            return calcState.set(CalcState::State::BELOW_MIN_PARKING_PRICE);
+        }
         price->units = cost;
         price->netto = cost;
-            return true;
+    } else {
+        return calcState.set(CalcState::State::INVALID_START_DATE);
+    }
+
+    return calcState.set(CalcState::State::SUCCESS);
+}
+
+CalcState CALCULATE_LIBRARY_API compute_price_for_parking_ticket(
+                                            parking_tariff_t *tariff,
+                                            QDateTime const &start_parking_time,
+                                            QDateTime const &end_parking_time,
+                                            struct price_t *price) {
+    CalcState calcState;
+    double minMin = tariff->PaymentOption.find(PaymentOption::Option1)->second.pop_min_time;
+    double maxMin = tariff->PaymentOption.find(PaymentOption::Option1)->second.pop_max_time;
+
+    // DEBUG
+    qCritical() << "compute_price_for_parking_ticket() " << endl
+                << "          start_parking_time: " << start_parking_time << endl
+                << "            end_parking_time: " << end_parking_time   << endl
+                << "                      minMin: " << minMin << endl
+                << "                      maxMin: " << maxMin;
+
+
+    int const duration = (end_parking_time.toSecsSinceEpoch() -
+                          start_parking_time.toSecsSinceEpoch()) / 60;
+
+    if (duration < 0) {
+        calcState.setDesc(QString("end=%1, start=%2")
+                            .arg(end_parking_time.toString(Qt::ISODate),
+                                 start_parking_time.toString(Qt::ISODate)));
+        return calcState.set(CalcState::State::NEGATIVE_PARING_TIME);
+    }
+    if (duration > maxMin) {
+        calcState.setDesc(QString("duration=%1, maxMin=%2").arg(duration, maxMin));
+        return calcState.set(CalcState::State::ABOVE_MAX_PARKING_TIME);
+    }
+    if (duration < minMin) {
+        calcState.setDesc(QString("duration=%1, minMin=%2").arg(duration, minMin));
+        return calcState.set(CalcState::State::BELOW_MIN_PARKING_TIME);
     }
-    } else
     if (duration == 0) {
         memset(price, 0x00, sizeof(*price));
-        return true;
+        return calcState.set(CalcState::State::SUCCESS);
     }
-    qCritical() << "ERROR start_parking_time (" << start_parking_time << ") <"
-                << "end_parking_time (" << end_parking_time << ")";
-    return false;
+
+    if (start_parking_time.isValid()) {
+        QString cs = start_parking_time.toString(Qt::ISODate);
+        double cost = calculator.GetCostFromDuration(
+                        tariff, PaymentOption::Option1,
+                        cs.toLocal8Bit().constData(),
+                        duration, false, true);
+        double minCost = tariff->PaymentOption.find(PaymentOption::Option1)->second.pop_min_price;
+        if (cost < minCost) {
+            calcState.setDesc(QString("minCost=%1, cost=%2").arg(minCost, cost));
+            return calcState.set(CalcState::State::BELOW_MIN_PARKING_PRICE);
+        }
+
+        // DEBUG
+        qCritical() << "               -> calculated cost (price->netto) =  " << cost;
+
+        price->units = cost;
+        price->netto = cost;
+    } else {
+        return calcState.set(CalcState::State::INVALID_START_DATE);
+    }
+
+    return calcState.set(CalcState::State::SUCCESS);
+}
+
+CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
+                                            parking_tariff_t *tariff,
+                                            time_t start_parking_time,
+                                            double price,
+                                            QString &duration) {
+    CalcState calcState;
+    QDate const d(1970, 1, 1);
+    QTime const t(0, 0, 0);
+    QDateTime start(d, t, Qt::UTC);
+    start = start.toLocalTime().addSecs(start_parking_time * 60);
+    if (start.isValid()) {
+        QString cs = start.toString(Qt::ISODate);
+
+        // DEBUG
+        qCritical() << "compute_duration_for_parking_ticket(): ";
+        qCritical() << "      start (cs): " << cs;
+        qCritical() << "           price: " << price;
+
+        duration = calculator.GetDurationFromCost(tariff, PaymentOption::Option1,
+                                                  cs.toLocal8Bit().constData(),
+                                                  price, false, true).c_str();
+        QDateTime d = QDateTime::fromString(duration);
+        if (!d.isValid()) {
+            calcState.setDesc(QString("ticketEndTime=%1").arg(duration));
+            return calcState.set(CalcState::State::WRONG_ISO_TIME_FORMAT);
+        }
+    } else {
+        return calcState.set(CalcState::State::INVALID_START_DATE);
+    }
+
+    return calcState.set(CalcState::State::SUCCESS);
+}
+
+CalcState CALCULATE_LIBRARY_API compute_duration_for_parking_ticket(
+                                            parking_tariff_t *tariff,
+                                            QDateTime const &start_parking_time,
+                                            double price,
+                                            QDateTime &ticketEndTime) {
+    CalcState calcState;
+    if (start_parking_time.isValid()) {
+        QString cs = start_parking_time.toString(Qt::ISODate);
+        QString endTime = calculator.GetDurationFromCost(
+                                        tariff, PaymentOption::Option1,
+                                        cs.toLocal8Bit().constData(),
+                                        price, false, true).c_str();
+        ticketEndTime = QDateTime::fromString(endTime,Qt::ISODate);
+
+        // DEBUG
+        qCritical() << "compute_duration_for_parking_ticket(): ";
+        qCritical() << "                 endTime: " << endTime;
+        qCritical() << "           ticketEndTime: " << ticketEndTime;
+
+        if (!ticketEndTime.isValid()) {
+            calcState.setDesc(QString("ticketEndTime=%1").arg(endTime));
+            return calcState.set(CalcState::State::WRONG_ISO_TIME_FORMAT);
+        }
+    } else {
+        return calcState.set(CalcState::State::INVALID_START_DATE);
+    }
+
+    return calcState.set(CalcState::State::SUCCESS);
 }

library/src/calculator_functions.cpp

@@ -4,13 +4,28 @@
 #include "tariff_log.h"
 
 #include <sstream>
+#include <QDateTime>
+#include <qdebug.h>
 
 double total_duration_min = 0.0f;
 double total_cost = 0.0f;
 bool overtime = false;
 
+#ifdef _WIN32
+    inline struct tm* localtime_r(const time_t *clock, struct tm* result){
+    if(!clock || !result) return NULL;
+    memcpy(result,localtime(clock),sizeof(*result));
+    return result;
+    }
+#endif
+
 /// <inheritdoc/>
-std::string Calculator::GetDurationFromCost(Configuration* cfg, uint8_t payment_option, char const* start_datetime, double price, bool nextDay, bool prepaid)
+std::string Calculator::GetDurationFromCost(Configuration* cfg,
+                                            uint8_t payment_option,
+                                            char const* start_datetime, // given in local time
+                                            double price,
+                                            bool nextDay,
+                                            bool prepaid)
 {
 	// Get current date time from input
 	struct tm current_datetime = Utilities::DateTimeToStructTm(start_datetime);
@@ -266,11 +281,38 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg, uint8_t payment_
 	cout << "Total minutes: " << (int)ret_val << endl;
     if (ret_val <= 0) return "PARKING NOT ALLOWED";
 
-	struct tm valid_until_datetime = *localtime(&valid_until_datetime_t);
-	LOG_DEBUG("Ticket is valid until ", asctime(&valid_until_datetime));
+#ifdef __linux__
+    #if !defined(_SVID_SOURCE) && !defined(_XOPEN_SOURCE)
+        // needed for timezone-correction
+        #error "!defined(_SVID_SOURCE) && !defined(_XOPEN_SOURCE)"
+    #else
+        // timezone correction: localtime() needs argument in UTC-timezone
+        // The global variable 'timezone' is set by tzset(), see
+        // https://linux.die.net/man/3/tzset, so I change of the timezone will
+        // also change the value of the variable 'timezone'.
+        valid_until_datetime_t += timezone;
+    #endif
+#else // windows, only for testing
+    static const long timezone = -3600;
+    valid_until_datetime_t += timezone;
+#endif
+
+    struct tm valid_until_datetime;
+    memset(&valid_until_datetime, 0x00, sizeof(valid_until_datetime));
+
+    if (!localtime_r(&valid_until_datetime_t, &valid_until_datetime)) {
+        return "LOCALTIME_R() ERROR";
+    }
+
+    // return in ISO-format: "%Y-%m-%dT%H:%M:%S"
+    char buf[128];
+    memset(buf, 0x00, sizeof(buf));
+    strftime(buf, sizeof(buf)-1, "%Y-%m-%dT%H:%M:%S", &valid_until_datetime);
+
+    LOG_DEBUG("Ticket is valid until ", buf);
 
 	total_duration_min = 0.0f;
-	return asctime(&valid_until_datetime);
+    return std::string(buf);
 }
 
 ///////////////////////////////////////
@@ -278,41 +320,40 @@ std::string Calculator::GetDurationFromCost(Configuration* cfg, uint8_t payment_
 /// <inheritdoc/>
 double Calculator::GetCostFromDuration(Configuration* cfg, uint8_t payment_option, const char* start_datetime, double durationMin, bool nextDay, bool prepaid)
 {
-	// Get current date time from input
-	struct tm current_datetime = Utilities::DateTimeToStructTm(start_datetime);
-	time_t current_datetime_t;
+    // Get input date
+    QDateTime inputDate = QDateTime::fromString(start_datetime,Qt::ISODate);
 
     // Get day of week
-	DayOfWeek weekdayId = DayOfWeek::UndefinedDay;
-	weekdayId = Utilities::GetDayOfWeek(&current_datetime);
-	LOG_DEBUG("*** Input date is: ", start_datetime, " [weekday id = ", weekdayId, "]");
+    int weekdayId = 0;
+    weekdayId = Utilities::ZellersAlgorithm(inputDate.date().day(),inputDate.date().month(),inputDate.date().year());
 
+    //Get min and max time defined in JSON
     double minMin = 0;
     minMin = cfg->PaymentOption.find(payment_option)->second.pop_min_time;
-	if (minMin < 0) minMin = 0;
 
     double maxMin = 0;
     maxMin = cfg->PaymentOption.find(payment_option)->second.pop_max_time;
-	if (maxMin <= 0) maxMin = 60;
 
+    if (minMin < 0) minMin = 0;
+    if (maxMin < 0) maxMin = 0;
     if (minMin >= maxMin)
     {
         LOG_ERROR("Error: min_min cannot be greater or equal to max_min");
         return 0.0f;
     }
-
     if (maxMin <= minMin)
     {
         LOG_ERROR("Error: max_min cannot be lower or equal than min_min");
         return 0.0f;
     }
 
+    // Check overtime
     if (!overtime)
     {
         if (durationMin > maxMin)
         {
             LOG_WARNING("Total duration is greater or equal to max_min");
-			return 0.0f;
+            return maxMin;
         }
 
         if (durationMin < minMin)
@@ -322,29 +363,30 @@ double Calculator::GetCostFromDuration(Configuration* cfg, uint8_t payment_optio
         }
     }
 
+    // Get payment method
     uint8_t p_method = PaymentMethod::Undefined;
     p_method = payment_option;
     LOG_DEBUG("Payment method id: ", (unsigned)p_method);
 
+    // Check special day
     double day_price = 0.0f;
     int current_special_day_id = -1;
-	bool is_special_day = Utilities::CheckSpecialDay(cfg, start_datetime, &current_special_day_id, &day_price);
+    bool is_special_day = Utilities::CheckSpecialDay(cfg, inputDate.toString(Qt::ISODate).toStdString().c_str(), &current_special_day_id, &day_price);
     LOG_DEBUG("Special day: ", is_special_day);
 
     total_duration_min = durationMin;
     LOG_DEBUG("Total min:", total_duration_min);
 
     double price_per_unit = 0.0f;
+    QTime worktime_from;
+    QTime worktime_to;
 
-	string worktime_from = "";
-	string worktime_to = "";
-
-	if (is_special_day)
+    if(is_special_day)
     {
         // Set special day price
         price_per_unit = Utilities::CalculatePricePerUnit(day_price);
-		worktime_from = cfg->SpecialDaysWorktime.find(current_special_day_id)->second.pedwt_time_from;
-		worktime_to = cfg->SpecialDaysWorktime.find(current_special_day_id)->second.pedwt_time_to;
+        worktime_from = QTime::fromString(cfg->SpecialDaysWorktime.find(current_special_day_id)->second.pedwt_time_from.c_str());
+        worktime_to = QTime::fromString(cfg->SpecialDaysWorktime.find(current_special_day_id)->second.pedwt_time_to.c_str());
     }
     else
     {
@@ -356,67 +398,38 @@ double Calculator::GetCostFromDuration(Configuration* cfg, uint8_t payment_optio
         size_t found = 0;
         found = cfg->WeekDaysWorktime.count(weekdayId);
 
-		if (found <= 0)
+        // When no workday found, go to next available day
+        if(found <=0)
         {
             LOG_DEBUG("- No workday found, trying to find next available day");
-			current_datetime_t = mktime(&current_datetime);
-			current_datetime_t += 86400;
-			current_datetime = *localtime(&current_datetime_t);
-
-			char buffer_datetime[80];
-			strftime(buffer_datetime, 80, "%Y-%m-%dT%H:%M:%S", &current_datetime);
-
-			//Make new datetime string and call function again recursively
-			start_datetime = buffer_datetime;
-            return floor(GetCostFromDuration(cfg, payment_option, start_datetime, durationMin, true, prepaid));
+            inputDate = inputDate.addDays(1);
+            return floor(GetCostFromDuration(cfg, payment_option, inputDate.toString(Qt::ISODate).toStdString().c_str(), durationMin, true, prepaid));
         }
-
-		worktime_from = cfg->WeekDaysWorktime.find(weekdayId)->second.pwd_time_from;
-		worktime_to = cfg->WeekDaysWorktime.find(weekdayId)->second.pwd_time_to;
+        worktime_from = QTime::fromString(cfg->WeekDaysWorktime.find(weekdayId)->second.pwd_time_from.c_str());
+        worktime_to = QTime::fromString(cfg->WeekDaysWorktime.find(weekdayId)->second.pwd_time_to.c_str());
     }
 
     if (price_per_unit < 0) price_per_unit = 1.0f;
     LOG_DEBUG("Calculated price per minute: ", price_per_unit);
 
-	LOG_DEBUG("Worktime from: ", worktime_from);
-	LOG_DEBUG("Worktime to: ", worktime_to);
-
-	struct tm from_tm;
-	struct tm to_tm;
-
-	from_tm = Utilities::TimeToStructTm(worktime_from.c_str(), current_datetime.tm_year, current_datetime.tm_mon, current_datetime.tm_mday, current_datetime.tm_wday);
-	from_tm.tm_year = current_datetime.tm_year;
-	from_tm.tm_mon = current_datetime.tm_mon;
-	from_tm.tm_wday = current_datetime.tm_wday;
-	from_tm.tm_mday = current_datetime.tm_mday;
-
-	to_tm = Utilities::TimeToStructTm(worktime_to.c_str(), current_datetime.tm_year, current_datetime.tm_mon, current_datetime.tm_mday, current_datetime.tm_wday);
-	to_tm.tm_year = current_datetime.tm_year;
-	to_tm.tm_mon = current_datetime.tm_mon;
-	to_tm.tm_wday = current_datetime.tm_wday;
-	to_tm.tm_mday = current_datetime.tm_mday;
-
-	// Convert tm structures to time_t
-	current_datetime_t = mktime(&current_datetime);
-
-	time_t from_datetime_t = mktime(&from_tm);
-	time_t to_datetime_t = mktime(&to_tm);
+    if (price_per_unit == 0)
+    {
+        inputDate = inputDate.addDays(1);
+        inputDate.setTime(worktime_from);
+        return GetCostFromDuration(cfg, payment_option, inputDate.toString(Qt::ISODate).toStdString().c_str(), durationMin, true, prepaid);
+    }
 
     // If overtime flag is set
     if (overtime || nextDay)
     {
-		current_datetime.tm_hour = from_tm.tm_hour;
-		current_datetime.tm_min = from_tm.tm_min;
-		current_datetime.tm_sec = from_tm.tm_sec;
-		current_datetime_t = mktime(&current_datetime);
-		LOG_DEBUG(" *** New input date set according to worktime: ", asctime(&current_datetime));
+        inputDate.setTime(worktime_from);
         overtime = false;
     }
 
-	// Validate ticket
+    // Check prepaid
     if (!prepaid)
     {
-		if ((current_datetime_t < from_datetime_t) || (current_datetime_t > to_datetime_t))
+        if ((inputDate.time() < worktime_from) || (inputDate.time() > worktime_to))
         {
             LOG_DEBUG("[STOP] * Ticket is not valid * ");
             return 0.0f;
@@ -425,89 +438,76 @@ double Calculator::GetCostFromDuration(Configuration* cfg, uint8_t payment_optio
     else
     {
         LOG_DEBUG("* PREPAID MODE ACTIVE *");
-
-		if (current_datetime_t < from_datetime_t)
+        if (inputDate.time() < worktime_from)
         {
-			current_datetime.tm_hour = from_tm.tm_hour;
-			current_datetime.tm_min = from_tm.tm_min;
-			current_datetime.tm_sec = from_tm.tm_sec;
-			current_datetime_t = mktime(&current_datetime);
-			LOG_DEBUG(" *** PREPAID *** Current time is before the time range start, adjusting time to: ", asctime(&current_datetime));
+            inputDate.setTime(worktime_from);
         }
-		else if (current_datetime_t > to_datetime_t)
+        else if(inputDate.time() > worktime_to)
         {
             LOG_DEBUG(" *** PREPAID *** Current time is past the time range end, searching for next available day");
-			current_datetime_t = mktime(&current_datetime);
-			current_datetime_t += 86400;
-			current_datetime = *localtime(&current_datetime_t);
-
-			char buffer_datetime[80];
-			strftime(buffer_datetime, 80, "%Y-%m-%dT%H:%M:%S", &current_datetime);
-
-			//Make new datetime string and call function again recursively
-			start_datetime = buffer_datetime;
-			return floor(GetCostFromDuration(cfg, payment_option, start_datetime, durationMin, true, prepaid));
+            inputDate = inputDate.addDays(1);
+            return GetCostFromDuration(cfg, payment_option, inputDate.toString(Qt::ISODate).toStdString().c_str(), durationMin, true, prepaid);
         }
     }
 
-	while (true)
+    while(true)
     {
-		if (!Utilities::IsYearPeriodActive(cfg, &current_datetime))
+        if(total_duration_min <= 0) break;
+
+        // Check year period
+        bool isYearPeriodActive = false;
+
+        //// Parse input date
+        int dayCurrent = inputDate.date().day();
+        int monthCurrent = inputDate.date().month();
+
+        // Current date time
+        int cdt = (monthCurrent * 100) + dayCurrent;
+
+        multimap<int, ATBPeriodYear>::iterator year_period_itr;
+        for (year_period_itr = cfg->YearPeriod.begin(); year_period_itr != cfg->YearPeriod.end(); ++year_period_itr)
+        {
+            int dStart = year_period_itr->second.pye_start_day;
+            int dEnd = year_period_itr->second.pye_end_day;
+
+            int mStart = year_period_itr->second.pye_start_month;
+            int mEnd = year_period_itr->second.pye_end_month;
+
+            int start = (mStart * 100) + dStart;
+            int end = (mEnd * 100) + dEnd;
+
+            if (cdt >= start && cdt <= end) {
+                isYearPeriodActive = true;
+                break;
+            }
+        }
+        if (!isYearPeriodActive)
         {
             LOG_DEBUG("Year period is not valid");
             return 0.0f;
         }
 
-		// Decrement by 1 minute
-		current_datetime_t = mktime(&current_datetime);
-		current_datetime_t += 60;
-		current_datetime = *localtime(&current_datetime_t);
-
-		total_duration_min -= 1.0f;
-		total_cost += price_per_unit;
-
-		// If no minutes left (e.g. spent all of the money before reaching end of worktime)
-		if (total_duration_min <= 0)
-		{
-			//total_duration_min -= 1.0f;
-			LOG_DEBUG("No minutes left ");
-			break;
-		}
-		else
-		{
-			// If minutes has left but the end of worktime has been reached (go to next day)
-			if (current_datetime_t >= to_datetime_t)
+        // Go to next day if minutes not spent
+        if(inputDate.time() >= worktime_to)
         {
             int carry_over_status = 0;
             carry_over_status = cfg->PaymentOption.find(payment_option)->second.pop_carry_over;
-				total_duration_min += 1.0f;
-				total_cost -= price_per_unit;
-
-				LOG_DEBUG("Carry over status: ", carry_over_status);
             if (carry_over_status < 1) break;
 
-				LOG_DEBUG("Reached end of worktime");
-				LOG_DEBUG("Trying to find next available day, min left = ", total_duration_min);
-				current_datetime_t = mktime(&current_datetime);
-				current_datetime_t += 86400;
-				current_datetime = *localtime(&current_datetime_t);
-
-				char buffer_datetime[80];
-				strftime(buffer_datetime, 80, "%Y-%m-%dT%H:%M:%S", &current_datetime);
-
-				// Make new datetime string and call function again recursively
-				start_datetime = buffer_datetime;
+            LOG_DEBUG("Reached end of worktime, searching for the next working day");
+            inputDate = inputDate.addDays(1);
             overtime = true;
-				return floor(GetCostFromDuration(cfg, payment_option, start_datetime, total_duration_min));
-			}
-		}
+            return GetCostFromDuration(cfg, payment_option, inputDate.toString(Qt::ISODate).toStdString().c_str(), total_duration_min);
         }
 
-	time_t valid_until_datetime_t = current_datetime_t;
-	struct tm valid_until_datetime = *localtime(&valid_until_datetime_t);
-	LOG_DEBUG("Ticket is valid until ", asctime(&valid_until_datetime));
+        // Increment input date minutes for each monetary unit
+        inputDate = inputDate.addSecs(60);
+        total_duration_min -=1;
+        total_cost += price_per_unit;
 
+    }
+    qDebug() << "Valid until:" << inputDate.toString(Qt::ISODate).toStdString().c_str();
     double ret_val = total_cost;
     total_cost = 0.0f;
-	return floor(ret_val);
+    return ceil(ret_val);
 }

library/src/configuration.cpp

@@ -23,12 +23,12 @@ bool Configuration::ParseJson(Configuration* cfg, const char* json)
 	{
 		if (cfg == nullptr)
 		{
-			printf("TariffConfiguration pointer not set\n");
+            fprintf(stderr, "TariffConfiguration pointer not set\n");
 			return false;
 		}
 		if (json == NULL)
 		{
-			printf("%s", "Input JSON string is NULL\n");
+            fprintf(stderr, "%s", "Input JSON string is NULL\n");
 			return false;
 		}
 
@@ -40,17 +40,17 @@ bool Configuration::ParseJson(Configuration* cfg, const char* json)
 		ParseErrorCode err = document.GetParseError();
 		if (err != 0)
 		{
-			printf("%s %d (%s)\n", "Unable to parse JSON, error code:", err, GetParseError_En(err));
+            fprintf(stderr, "%s %d (%s)\n", "Unable to parse JSON, error code:", err, GetParseError_En(err));
 			return false;
 		}
 
 		// Validate JSON, check if it's a JSON object
-		printf("%s", "JSON parsing has been successful\n");
+        fprintf(stderr, "%s", "JSON parsing has been successful\n");
 		if (!document.IsObject()) {
-			printf("%s", "Error: not a (valid) JSON object\n");
+            fprintf(stderr, "%s", "Error: not a (valid) JSON object\n");
 			return false;
 		}
-		printf("%s", "Valid JSON object identified\n");
+        fprintf(stderr, "%s", "Valid JSON object identified\n");
 
 		// Validate JSON, check configuration members
 		if (!document.HasMember("Currency")
@@ -65,7 +65,7 @@ bool Configuration::ParseJson(Configuration* cfg, const char* json)
 			printf("%s", "Error: not a valid configuration JSON\n");
 			return false;
 		}
-		printf("%s", "Valid JSON configuration identified\n");
+        fprintf(stderr, "%s", "Valid JSON configuration identified\n");
 
 		ATBCurrency Currency;
 		ATBDuration Duration;
@@ -115,7 +115,7 @@ bool Configuration::ParseJson(Configuration* cfg, const char* json)
 					const char* inner_obj_name = k->name.GetString();
 					if (inner_obj_name == NULL)
 					{
-						printf("Inner object name is NULL\n");
+                        fprintf(stderr, "Inner object name is NULL\n");
 						continue;
 					}
 
@@ -240,7 +240,7 @@ bool Configuration::ParseJson(Configuration* cfg, const char* json)
 		return true;
 	}
 	catch (...) {
-		printf("%s\n", "General exception has occurred while parsing JSON\n");
+        fprintf(stderr, "%s\n", "General exception has occurred while parsing JSON\n");
 		return false;
 	}
 }

library/src/utilities.cpp

@@ -33,7 +33,7 @@ time_t Utilities::GetCurrentLocalTime()
 		memset(&tm_curr_time, '\0', sizeof(struct tm));
 
 		tm_curr_time = *localtime(&curr_time);
-		curr_time = mktime(&tm_curr_time) - timezone;
+        curr_time = mktime(&tm_curr_time); //- timezone;
 		return curr_time;
 	}
 	catch (...)

main/main.cpp

@@ -31,12 +31,12 @@ extern "C" char* strptime(const char* s,
 int main() {
 
     parking_tariff_t *tariff = 0;
-    if (init_tariff(&tariff, "/etc/psa_tariff/")) {
+    if (init_tariff(&tariff, "C:\\Users\\MROD\\Documents\\QtCreator\\build-MOBILISIS-Calculator-Desktop_Qt_5_12_12_MSVC2017_32bit-Debug\\main\\etc\\psa_tariff\\zone1.json")) {
         struct price_t price;
         memset(&price, 0x00, sizeof(price));
-        QDateTime start = QDateTime::currentDateTime();
+        QDateTime start = QDateTime::fromString("2023-05-11T07:50:00",Qt::ISODate); //QDateTime::currentDateTime();
         time_t start_parking_time = start.toSecsSinceEpoch() / 60;
-        time_t end_parking_time = start_parking_time + 60;
+        time_t end_parking_time = start_parking_time + 1230;
 
         if (compute_price_for_parking_ticket(tariff,
                                              start_parking_time,
@@ -45,69 +45,76 @@ int main() {
             qDebug() << "price=" << price.netto;
         }
 
-        // tests
-        struct tm now;
-        memset(&now, 0, sizeof(now));
+//        QString duration;
+//        if(compute_duration_for_parking_ticket(tariff,start_parking_time,3090,duration))
+//        {
+//            qDebug() << "duration=" << duration;
+//        }
 
-        // 3.Jan 2023 -> Tuesday
-        strptime("2023-01-03T14:00:00", "%Y-%m-%dT%H:%M:%S", &now);
-        for (int i = 0; i < 600; ++i) {
-            start_parking_time = mktime(&now);
-            end_parking_time = start_parking_time + 240; // duration == 240
+//        // tests
+//        struct tm now;
+//        memset(&now, 0, sizeof(now));
 
-            if (compute_price_for_parking_ticket(tariff,
-                                                 start_parking_time,
-                                                 end_parking_time,
-                                                 &price)) {
-                int const zone = get_zone_nr();
-                switch (zone) {
-                case 1:
-                    assert(price.netto == 879);    // expected value: 880
-                    break;
-                case 2:
-                    /* fall through */
-                case 3:
-                    assert(price.netto == 1920);
-                    break;
-                }
-            }
-            time_t t = start_parking_time + 60;
-            now = *localtime(&t);
-        }
-        //
-        // test May 1st 2023
-        //
-        memset(&now, 0, sizeof(now));
-        strptime("2023-04-30T06:00:00", "%Y-%m-%dT%H:%M:%S", &now);
-        now.tm_hour -= 1; // for ctime
-        for (int i=0; i<6*24; ++i) {
-            int const duration = 120;
-            time_t t = mktime(&now);
-            start_parking_time = t / 60;
-            end_parking_time = start_parking_time + duration;
+//        // 3.Jan 2023 -> Tuesday
+//        strptime("2023-01-03T14:00:00", "%Y-%m-%dT%H:%M:%S", &now);
+//        for (int i = 0; i < 600; ++i) {
+//            start_parking_time = mktime(&now);
+//            end_parking_time = start_parking_time + 240; // duration == 240
 
-            if (compute_price_for_parking_ticket(tariff,
-                                                 start_parking_time,
-                                                 end_parking_time,
-                                                 &price)) {
-                int const zone = get_zone_nr();
-                switch (zone) {
-                case 1:
-                    qDebug() << i << zone << ctime(&t) << price.netto << " FT";
-                    assert(price.netto == 440);
-                    break;
-                case 2:
-                    /* fall through */
-                case 3:
-                    qDebug() << i << zone << ctime(&t) << price.netto << " FT";
-                    assert(price.netto == 960);
-                    break;
-                }
-            }
+//            if (compute_price_for_parking_ticket(tariff,
+//                                                 start_parking_time,
+//                                                 end_parking_time,
+//                                                 &price)) {
+//                int const zone = get_zone_nr(1);
+//                switch (zone) {
+//                case 1:
+//                    assert(price.netto == 879);    // expected value: 880
+//                    break;
+//                case 2:
+//                    /* fall through */
+//                case 3:
+//                    assert(price.netto == 1920);
+//                    break;
+//                }
+//            }
+//            time_t t = start_parking_time + 60;
+//            now = *localtime(&t);
+//        }
+//        //
+//        // test May 1st 2023
+//        //
+//        memset(&now, 0, sizeof(now));
+//        strptime("2023-04-30T06:00:00", "%Y-%m-%dT%H:%M:%S", &now);
+//        now.tm_hour -= 1; // for ctime
+//        // for (int i=0; i<6*24; ++i) {
+//        for (int i=0; i<1; ++i) {
+//            int const duration = 120;
+//            time_t t = mktime(&now);
+//            start_parking_time = t / 60;
+//            end_parking_time = start_parking_time + duration;
 
-            t = (start_parking_time + 60)*60;
-            now = *localtime(&t);
-        }
+//            if (compute_price_for_parking_ticket(tariff,
+//                                                 start_parking_time,
+//                                                 end_parking_time,
+//                                                 &price)) {
+//                int const zone = get_zone_nr();
+//                switch (zone) {
+//                case 1:
+//                    qDebug() << i << zone << ctime(&t) << price.netto << " FT";
+//                    assert(price.netto == 440);
+//                    break;
+//                case 2:
+//                    /* fall through */
+//                case 3:
+//                    qDebug() << i << zone << ctime(&t) << price.netto << " FT";
+//                    assert(price.netto == 960);
+//                    break;
+//                }
+//            }
+
+//            t = (start_parking_time + 60)*60;
+//            now = *localtime(&t);
+//        }
 
         free_tariff(tariff);
     }