loadRecDataFromFrame():

When reading next message, check readCount + 1 == writeCount. If not, there
	must be something wrong: ignore this message and set readCount <- writeCount.

include/com.h

@@ -33,9 +33,7 @@ class T_com : public QObject        //,  public QPlainTextEdit
 //    QSerialPort *CatSerial = nullptr;
     QSerialPort *CatSerial;
 
-    QVector<uint16_t> readCmds;     // list of active commands sent to DC
-
-
+    uint32_t writeCount = 0;
 
     //char oeffneSerialPort();
     char open_Serial_Port();
@@ -66,8 +64,7 @@ public:
     bool readFromSerial(QByteArray &data, uint16_t &sendLength);
         // retval: true: data available
 
-    QVector<uint16_t> &getReadCmds() { return readCmds; }
-    QVector<uint16_t> const &getReadCmds() const { return readCmds; }
+    uint32_t getWriteCount() { return writeCount; }
 
 /*
     uint8_t getAllPortPins(void);

include/datIf.h

@@ -169,6 +169,7 @@ class T_datif : public QObject
     uint8_t selectedSlaveAddr;
 
     bool waitForTestResponse = false;
+    uint32_t readCount = 0;
 
 private slots:
     char datif_cycleSend();

src/com.cpp

@@ -1,5 +1,6 @@
 #include "com.h"
 #include <QDebug>
+#include <QDateTime>
 //#include "controlBus.h"
 
 //////////////////////////////////////////////////////////////////////////////////
@@ -24,67 +25,48 @@ void T_com::writeToSerial(const QByteArray &data, uint16_t sendLength)
     // logic: exactly one command is sent to DC. no other command can be sent
     // until the respond has been read from the serial line.
 
-    static int errorCnt = 0;
-
-    if (readCmds.size() == 0) { // no other read command active: ok
-        if (CatSerial->isOpen())
-        {
-            if (CatSerial->error() != QSerialPort::NoError) {
-                qCritical() << __func__ << "" << __LINE__ << "ERROR on serial line" << CatSerial->errorString();
-                CatSerial->clearError();
-                qCritical() << __func__ << "" << __LINE__ << "cleared error on serial line";
-            }
-
-            if (!CatSerial->atEnd()) {
-                qCritical() << QString("ERROR %1 bytes available on serial line before write").arg(CatSerial->bytesAvailable());
-                qCritical() << CatSerial->readAll().toHex(':');
-                CatSerial->clear();
-                qCritical() << __func__ << "" << __LINE__ << "read all data from serial line";
-            }
-
-            QByteArray buffer(data);
-
-            int bytesToWrite = buffer.size();
-            while (bytesToWrite > 0 && !buffer.isEmpty()) {
-                int bytesWritten = CatSerial->write(buffer);
-                if (bytesWritten != -1) {
-                    bytesToWrite -= bytesWritten;
-                    buffer = buffer.right(bytesWritten);
-                } else {
-                    qCritical() << __func__ << ":" << __LINE__
-                                << QString("ERROR %1 for sending %2").arg(CatSerial->errorString()).arg(data.toHex(':').constData());
-                    CatSerial->clearError();
-                    qCritical() << __func__ << ":" << __LINE__ << "cleared error on serial line. returning ...";
-                    return;
-                }
-            }
-
-            // save last command sent.
-            readCmds.append(data.constData()[2]); // 2: index of the last command
-
-        } else {
-            qCritical() << __func__ << ":" << __LINE__
-                        << "ERROR sending" << data.toHex(':') << "port is not open";
+    if (CatSerial->isOpen()) {
+        if (CatSerial->error() != QSerialPort::NoError) {
+            qCritical() << __func__ << "" << __LINE__ << "ERROR on serial line" << CatSerial->errorString();
+            CatSerial->clearError();
+            qCritical() << __func__ << "" << __LINE__ << "cleared error on serial line";
         }
-    } else {
-        qCritical() << __func__ << "" << __LINE__ << errorCnt << "ERROR about to send cmd" << QString("0x%1").arg((unsigned char)data.constData()[2], 0, 16);
-        qCritical() << __func__ << "" << __LINE__ << errorCnt << "ERROR detected active read cmds" << readCmds;
-        if (CatSerial->isOpen()) {
-            int availableBytes = CatSerial->bytesAvailable();
-            qCritical() << __func__ << "" << __LINE__ << "ERROR available bytes" << availableBytes;
-            if (availableBytes == 0) {
-                errorCnt += 1;
-                if (errorCnt > 20) {
-                    readCmds.clear();
-                    errorCnt = 0;
-                }
+
+        if (!CatSerial->atEnd()) {
+            qCritical() << QString("ERROR %1 bytes available on serial line before write").arg(CatSerial->bytesAvailable());
+            qCritical() << CatSerial->readAll().toHex(':');
+            CatSerial->clear();
+            qCritical() << __func__ << "" << __LINE__ << "read all data from serial line";
+        }
+
+        CatSerial->clear();
+
+        QByteArray buffer(data);
+        int bytesToWrite = buffer.size();
+        while (bytesToWrite > 0 && !buffer.isEmpty()) {
+            int bytesWritten = CatSerial->write(buffer);
+            if (bytesWritten != -1) {
+                bytesToWrite -= bytesWritten;
+                buffer = buffer.right(bytesWritten);
             } else {
-                errorCnt = 0;
+                qCritical() << __func__ << ":" << __LINE__
+                            << QString("ERROR %1 for sending %2").arg(CatSerial->errorString()).arg(data.toHex(':').constData());
+                CatSerial->clearError();
+                qCritical() << __func__ << ":" << __LINE__ << "cleared error on serial line. returning ...";
+                return;
             }
-        } else {
-            qCritical() << __func__ << ":" << __LINE__
-                        << "ERROR sending" << data.toHex(':') << "port is not open";
         }
+
+        CatSerial->flush();
+        writeCount += 1;
+
+        // only for debugging
+        // qCritical() << __func__ << ":" << __LINE__ << QDateTime::currentDateTime().time().toString(Qt::ISODateWithMs)
+        //            << "write cmd" << (unsigned int)data.constData()[2];
+
+    } else {
+        qCritical() << __func__ << ":" << __LINE__
+                    << "ERROR sending" << data.toHex(':') << "port is not open";
     }
 }
 
@@ -141,6 +123,7 @@ T_com::T_com(QObject *parent) : QObject(parent)
     ChkConnectTimer->setSingleShot(false);
     ChkConnectTimer->start(100);     // in ms
     com_want2read=0;
+    writeCount = 0;
 }
 
 

src/datIf.cpp

@@ -11,6 +11,7 @@ History:
 #include "controlBus.h"
 #include "storeINdata.h"
 #include <QDebug>
+#include <QDateTime>
 #include <datei.h>
 #include <QDir>
 
@@ -125,6 +126,7 @@ T_datif::T_datif(QObject *parent) : QObject(parent)
     datif_pNextCmd=0;
     datif_sendSlowCmd=0;
 
+    readCount = 0;
 }
 
 void T_datif::resetChain(void)
@@ -549,50 +551,25 @@ char T_datif::loadRecDataFromFrame()
     gpi_storeRecPayLoad(RdDleng, receivedData); //  save for host (user of hwapi)
 
     if (myDCIF && myDCIF->getSerialPort()) {
-        QVector<uint16_t> &readCmds = myDCIF->getSerialPort()->getReadCmds();
-
-        if (readCmds.size() == 1) { // there can be only one command been sent to the DC
-            // the command number active at the moment must be the same as the saved one
-            if (readSource == myDCIF->getReadSource() && readSource == readCmds[0]) {
-                // maybe we have sent a explicit request for a test-response
-                if (waitForTestResponse) {
-                    qCritical() << __func__ << ":" << __LINE__ << "turn on auto-request";
-                    if (readCmds[0] == CMD2DC_TestSerial) {
-                        if (QString(QByteArray((char const *)receivedData, RdDleng)) == "< SlaveResponse") {
-                            waitForTestResponse = false;
-                            qCritical() << __func__ << ":" << __LINE__ << "turn on auto-request";
-                            ((hwapi *)parent())->dc_autoRequest(true); // return autorequest to true
-                        } else {
-                            qCritical() << __func__ << ":" << __LINE__ << "ERROR received wrong test-response"
-                                        << QString(QByteArray((char const *)receivedData, RdDleng));
-                        }
-                    }
-                } else {
-                    // usual handling of response
-                    // qCritical() << __func__ << ":" << __LINE__ << ":" << readSource << myDCIF->getReadSource() << readCmds[0];
-                    // qCritical() << __func__ << ":" << __LINE__ << ":" << QByteArray((char const *)receivedData, RdDleng).toHex(':');
-                }
-                readCmds.clear();
-            } else { // error
-                qCritical() << __func__ << ":" << __LINE__ << ": ERROR " << readSource << myDCIF->getReadSource() << readCmds[0];
-                qCritical() << __func__ << ":" << __LINE__ << ": ERROR length" << RdDleng << QString(", ignore data for cmd 0x%1").arg(readCmds[0], 0, 16)
+        uint32_t writeCount = myDCIF->getSerialPort()->getWriteCount();
+        if ((readCount + 1) == writeCount) { // there can be only one command sent to the DC
+            readCount = writeCount;
+            if (readSource != myDCIF->getReadSource()) {
+                qCritical() << __func__ << ":" << __LINE__ << ": ERROR length" << RdDleng << ", ignore data"
                             << QByteArray((char const *)receivedData, RdDleng).toHex(':');
-                readCmds.clear();
+                qCritical() << __func__ << ":" << __LINE__ << "would be interpretated as" << readSource << myDCIF->getReadSource();
                 return 0;
+            } else {
+                // only for debugging
+                // qCritical() << __func__ << ":" << __LINE__ << QDateTime::currentDateTime().time().toString(Qt::ISODateWithMs) << readSource << myDCIF->getReadSource();
             }
         } else {
-            // error: read commands has not size 1 as it should be: turn off
-            // auto requests and send explicit request for test-response:
-            // once this response has been received, turn on the autmatic requests
-            // again.
-            readCmds.clear();
-            if (parent()) {
-                qCritical() << __func__ << ":" << __LINE__ << "ERROR turn off auto-request";
-                qCritical() << __func__ << ":" << __LINE__ << "ERROR send request for test-response";
-                waitForTestResponse = true;
-                ((hwapi *)parent())->dc_autoRequest(false);
-                ((hwapi *)parent())->dc_requTestResponse();
-            }
+            qCritical() << __func__ << ":" << __LINE__ << QString(": ERROR readCount + 1 != writeCount: %1 != %2").arg(readCount + 1).arg(writeCount);
+            qCritical() << __func__ << ":" << __LINE__ << ": ERROR length" << RdDleng << ", ignore data"
+                        << QByteArray((char const *)receivedData, RdDleng).toHex(':');
+            qCritical() << __func__ << ":" << __LINE__ << "would be interpretated as" << readSource << myDCIF->getReadSource();
+
+            readCount = writeCount;
             return 0;
         }
     }