13 changed files with 76 additions and 333 deletions
--- a/ATBUpdateTool.ini
+++ b/ATBUpdateTool.ini
@ -1,5 +1,5 @@
 [REPOSITORY_URL]
-repository-url="gitea@ptu-config.atb-comm.de:ATB/"
+repository-url="https://ptu-config.atb-comm.de/ATB"

 [DIRECTORIES]
 plugin-directory="/usr/lib/"
--- a/UpdatePTUDevCtrl/UpdatePTUDevCtrl.pro
+++ b/UpdatePTUDevCtrl/UpdatePTUDevCtrl.pro
@ -133,22 +133,7 @@ DEFINES += QT_DEPRECATED_WARNINGS
 #           In case there is an automatic update (00:00-04:00) use M0100 instead
 #           of U0002.
 # 1.4.10  : Fix: for the time being, never set the autoRequest-flag to false.
-# 1.4.11  : Fix: remove hard-coded path to git-repos of gitea in mimbach. Read
-#           from ATBUpdateTool.ini the url for the gitrepositories.
-# 1.5.0   : Use ptu-config.atb-comm.de (given in ini-file) as new server for
-#           customer repositories.
-#           Fix: allow empty lines in opkg_commands.
-# 1.5.1   : Fix: do not use cleanPath() on a url-address.
-# 1.5.2   : Remove .ipk and .gz files in /var/cache/opkg.
-# 1.5.3   : Build customer_(id) name without right justification.
-# 1.5.4   : Try to run opkg-commands even under some error conditions (failure
-#           of customerEnvironment(), filesToUpdate() or
-#           syncCustomerRepositoryAndFS().
-# 1.5.5   : Call into binary ptuPackageVersion to get installed package
-#           versions.
-# 1.5.6   : Show additional update progress info in status bar.
-# 1.5.7   : Add support for dynamic portrait / landscape.
-VERSION="1.5.7"
+VERSION="1.4.10"
 # PLANNED TODOS:
 #   1:  Das Repository wird repariert bwz. neu geklont. Unabhaengig vom WAIT.
 #   2:  Wenn der WAIT-Button aktiv ist, dann wird ein Repository repariert (neu
--- a/UpdatePTUDevCtrl/git/git_client.cpp
+++ b/UpdatePTUDevCtrl/git/git_client.cpp
@ -9,15 +9,14 @@
 #include <QStringList>


-GitClient::GitClient(QString const &customerRepositoryPath,
-                     QString const &customerNrStr,
+GitClient::GitClient(QString const &customerNrStr,
                     QString const &customerRepository,
                     QString const &workingDirectory,
                     QString const &branchName,
                     QObject *parent)
  : QObject(parent)
  , m_worker(qobject_cast<Worker *>(parent))
-  , m_repositoryPath(customerRepositoryPath)
+  , m_repositoryPath(QString("https://git.mimbach49.de/GerhardHoffmann/%1.git").arg(customerNrStr))
  , m_customerNr(customerNrStr)
  , m_workingDirectory(workingDirectory)
  , m_branchName(branchName)
@ -393,45 +392,6 @@ std::optional<QString> GitClient::gitPull() {
    if (QDir(m_customerRepository).exists()) {
        qInfo() << "BRANCH NAME" << m_branchName;

-#if 0
-        IMPORTANT COMMENT:
-
-        If remote host keys are changed, then
-
-        export GIT_SSH_COMMAND="ssh -i /opt/app/tools/atbupdate/.keys/id_ed25519_ptuConfig"
-        git pull
-
-        leads to the following warning/error message:
-
-        @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
-        @    WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED!     @
-        @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
-        IT IS POSSIBLE THAT SOMEONE IS DOING SOMETHING NASTY!
-        Someone could be eavesdropping on you right now (man-in-the-middle attack)!
-        It is also possible that a host key has just been changed.
-        The fingerprint for the ECDSA key sent by the remote host is
-        SHA256:vOD5jF2hglGktqLhK9ABxfEjwEgIK68/v9erdT05NDQ.
-        Please contact your system administrator.
-        Add correct host key in /home/root/.ssh/known_hosts to get rid of this message.
-        Offending ECDSA key in /home/root/.ssh/known_hosts:1
-        Password authentication is disabled to avoid man-in-the-middle attacks.
-        Keyboard-interactive authentication is disabled to avoid man-in-the-middle attacks.
-        Agent forwarding is disabled to avoid man-in-the-middle attacks.
-        X11 forwarding is disabled to avoid man-in-the-middle attacks.
-        Already up to date.
-
-        This first part is from ssh itself. Only the last line is the git message.
-
-        Here an output of running ATBUpdateTool with a corrupted known-hosts-file:
-
-        ...
-        Oct 23 14:18:18 ATB_PTU5 ATBUpdateTool[2696]: ( branchExistsRemotely : 310 ) branch "zg1/zone1" EXISTS REMOTELY. ( "@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@\r\n@    WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED!     @\r\n@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@\r\nIT IS POSSIBLE THAT SOMEONE IS DOING SOMETHING NASTY!\r\nSomeone could be eavesdropping on you right now (man-in-the-middle attack)!\r\nIt is also possible that a host key has just been changed.\r\nThe fingerprint for the ECDSA key sent by the remote host is\nSHA256:vOD5jF2hglGktqLhK9ABxfEjwEgIK68/v9erdT05NDQ.\r\nPlease contact your system administrator.\r\nAdd correct host key in /home/root/.ssh/known_hosts to get rid of this message.\r\nOffending ECDSA key in /home/root/.ssh/known_hosts:1\r\nPassword authentication is disabled to avoid man-in-the-middle attacks.\r\nKeyboard-interactive authentication is disabled to avoid man-in-the-middle attacks.\r\nAgent forwarding is disabled to avoid man-in-the-middle attacks.\r\nX11 forwarding is disabled to avoid man-in-the-middle attacks.\r\nbd4e8da4780b1a7d6be3d3ce8419f43ccf7e706f\trefs/heads/zg1/zone1" )
-        Oct 23 14:18:18 ATB_PTU5 ATBUpdateTool[2696]: EXECUTED "git branch -l" "(runtime 16ms)" with code 0 IN "/opt/app/tools/atbupdate/customer_336"
-        Oct 23 14:18:18 ATB_PTU5 ATBUpdateTool[2696]: "UPDATE_STEP::PULL_NEW_BRANCH"
-        Oct 23 14:18:18 ATB_PTU5 ATBUpdateTool[2696]: "BRANCH-NAME zg1/zone1 CONTAINED IN RESULT master\n* zg1/zone1" .....
-
-        The download continues.
-#endif
        Command c("git pull");
        if (c.execute(m_customerRepository)) {
            QString const s = c.getCommandResult().trimmed();
--- a/UpdatePTUDevCtrl/git/git_client.h
+++ b/UpdatePTUDevCtrl/git/git_client.h
@ -22,8 +22,7 @@ class GitClient : public QObject {
    bool copyGitConfigFromMaster();

  public:
-    explicit GitClient(QString const &customerRepositoryUrl,
-                       QString const &customerNrStr,
+    explicit GitClient(QString const &customerNrStr,
                       QString const &repositoryPath,
                       QString const &workingDirectory = QCoreApplication::applicationDirPath(),
                       QString const &branchName = "master",
--- a/UpdatePTUDevCtrl/ismas/ismas_client.cpp
+++ b/UpdatePTUDevCtrl/ismas/ismas_client.cpp
@ -690,8 +690,7 @@ QString IsmasClient::updateOfPSASendVersion(PSAInstalled const &psa) {
                "\"libTCP_ZVT_CCPlugin.so\" : {"
                    "\"VERSION\" : \"%s\""
                "}"
-            "},"
-             "\"PTU-PACKAGE-VERSIONS\" : %s"
+            "}"
        "}",
        psa.versionInfo.reason.toStdString().c_str(),
        psa.versionInfo.created.toStdString().c_str(),
@ -802,11 +801,9 @@ QString IsmasClient::updateOfPSASendVersion(PSAInstalled const &psa) {
        psa.pluginVersion.mobilisisCalculatePriceConfigUi.toStdString().c_str(),
        psa.pluginVersion.prmCalculatePrice.toStdString().c_str(),
        psa.pluginVersion.prmCalculatePriceConfigUi.toStdString().c_str(),
-        psa.pluginVersion.tcpZVT.toStdString().c_str(),
+        psa.pluginVersion.tcpZVT.toStdString().c_str());

-        psa.ptuPackageVersion.toStdString().c_str());
-
-        qInfo() << buf;
+    qInfo() << buf;

    return buf;
 }
--- a/UpdatePTUDevCtrl/ismas/ismas_client.h
+++ b/UpdatePTUDevCtrl/ismas/ismas_client.h
@ -77,8 +77,6 @@ struct PSAInstalled {

    DC2C print[32];

-    QString ptuPackageVersion;
-
    explicit PSAInstalled() {
        tariff.name = "N/A";
        tariff.version = "N/A";
--- a/UpdatePTUDevCtrl/main.cpp
+++ b/UpdatePTUDevCtrl/main.cpp
@ -50,11 +50,9 @@
 // argv[1]: file to send to dc
 int main(int argc, char *argv[]) {
    QByteArray const value = qgetenv("LC_ALL");
-    if (value.isEmpty() || value != "C") {
+    if (value != "C") {
        qputenv("LC_ALL", "C");
    }
-
-
    // qputenv("XDG_RUNTIME_DIR", "/var/run/user/0");

    openlog("ATB-UPDATE", LOG_PERROR | LOG_PID | LOG_CONS, LOG_USER);
@ -74,38 +72,6 @@ int main(int argc, char *argv[]) {
    parser.readSettings();

    QString repositoryUrl = parser.repositoryUrl();
-
-    if (repositoryUrl.endsWith('/')) {
-        repositoryUrl.chop(1);
-    }
-
-    QString gitSSHCommand("");
-
-    if (repositoryUrl.contains("ptu-config.atb-comm.de")) {
-        QByteArray const v = qgetenv("GIT_SSH_COMMAND");
-        if (v.isEmpty()) {
-            QString sshKeyFile("/opt/app/tools/atbupdate/.keys/id_ed25519_ptuConfig");
-            if (QFileInfo(sshKeyFile).exists()) {
-                gitSSHCommand = "ssh -i /opt/app/tools/atbupdate/.keys/id_ed25519_ptuConfig";
-                if (!qputenv("GIT_SSH_COMMAND", QByteArray(gitSSHCommand.toStdString().c_str()))) {
-                    qCritical() << "ERROR: GIT_SSH_COMMAND not put into env. Exiting...";
-                    return -1;
-                }
-            } else {
-                qCritical() << "ERROR ssh-key-file" << sshKeyFile << "does not exists. Exiting...";
-                return -1;
-            }
-        } else {
-            gitSSHCommand = QString(v.toStdString().c_str());
-            qCritical() << "WARNING GIT_SSH_COMMAND already set in enviroment:"
-                        << gitSSHCommand;
-            if (gitSSHCommand != "ssh -i /opt/app/tools/atbupdate/.keys/id_ed25519_ptuConfig") {
-                qCritical() << "ERROR" << gitSSHCommand << "wrong. Exiting...";
-                return -1;
-            }
-        }
-    }
-
    QString plugInDir = parser.plugInDir();
    QString plugInName = parser.plugInName();
    QString workingDir = parser.workingDir();
@ -128,9 +94,6 @@ int main(int argc, char *argv[]) {

    qInfo() << "pwd ......................" << rtPath;
    qInfo() << "repositoryUrl ............" << repositoryUrl;
-    if (!gitSSHCommand.isEmpty()) {
-        qInfo() << "GIT_SSH_COMMAND .........." << gitSSHCommand;
-    }
    qInfo() << "plugInDir ................" << plugInDir;
    qInfo() << "plugInName ..............." << plugInName;
    qInfo() << "workingDir ..............." << workingDir;
--- a/UpdatePTUDevCtrl/mainwindow.cpp
+++ b/UpdatePTUDevCtrl/mainwindow.cpp
@ -12,9 +12,6 @@
 #include <QScrollBar>
 #include <QEvent>

-#include <QScreen>
-
-

 MainWindow::MainWindow(Worker *worker, QWidget *parent)
    : QMainWindow(parent)
@ -33,7 +30,6 @@ MainWindow::MainWindow(Worker *worker, QWidget *parent)
    this->statusBar()->setFont(f);

    ui->setupUi(this);
-    checkOrientation();

    ui->updateProgress->setRange(0, 100);
    ui->updateProgress->reset();
@ -63,24 +59,6 @@ MainWindow::MainWindow(Worker *worker, QWidget *parent)
    m_exitTimer->setSingleShot(true);
    m_exitTimer->start(1800 * 1000);

-    m_statusTimer = new QTimer(this);
-    if (m_statusTimer) {
-        connect(m_statusTimer, &QTimer::timeout, [this]() {
-            static QString p(".");
-            QTime const &t = QDateTime::currentDateTime().time();
-            QString s = t.toString(Qt::ISODate);
-            s += ": Update might take several minutes " + p;
-            if (p.length() >= 5) {
-                p = ".";
-            } else {
-                p += ".";
-            }
-            this->statusBar()->showMessage(s);
-        });
-        m_statusTimer->setSingleShot(false);
-        m_statusTimer->start(1000);
-    }
-
    connect(ui->exit, SIGNAL(clicked()),this,SLOT(onQuit()));
    connect(m_worker, SIGNAL(disableExit()),this,SLOT(onDisableExit()));
    connect(m_worker, SIGNAL(enableExit()),this,SLOT(onEnableExit()));
@ -98,60 +76,9 @@ MainWindow::MainWindow(Worker *worker, QWidget *parent)
 MainWindow::~MainWindow() {
    delete m_startTimer;
    delete m_exitTimer;
-    delete m_statusTimer;
    delete ui;
 }

-
-// ----------------------------- Ui::LAYOUT setting -------------------------------------
-
-void MainWindow::checkOrientation()
-{
-    QScreen *screen = QGuiApplication::primaryScreen();
-    Qt::ScreenOrientation orientation = screen->orientation();
-
-    switch (orientation) {
-    case Qt::PrimaryOrientation:
-        this->setLandscapeLayout();
-        break;
-    case Qt::LandscapeOrientation:
-        this->setLandscapeLayout();
-        break;
-    case Qt::PortraitOrientation:
-        this->setPortraitLayout();
-        break;
-    case Qt::InvertedLandscapeOrientation:
-        this->setLandscapeLayout();
-        break;
-    case Qt::InvertedPortraitOrientation:
-        this->setPortraitLayout();
-        break;
-    }
-
-    this->currentOrientation = orientation;
-}
-
-
-
-void MainWindow::setPortraitLayout()
-{
-    // Adjust layout for portrait mode (480x800)
-    this->setFixedSize(480, 800);
-    ui->centralwidget->setFixedSize(480, 800);
-}
-
-void MainWindow::setLandscapeLayout()
-{
-    // Adjust layout for landscape mode (800x480)
-    this->setFixedSize(800, 480);
-    ui->centralwidget->setFixedSize(800, 480);
-}
-
-
-
-
-
-
 void MainWindow::customEvent(QEvent *event) {
    if (event->type() == ProgressEvent::type()) {
        ProgressEvent *pevent = (ProgressEvent *)event;
--- a/UpdatePTUDevCtrl/mainwindow.h
+++ b/UpdatePTUDevCtrl/mainwindow.h
@ -66,12 +66,6 @@ private:
    void onShowMessage(QString, QString);

    Ui::MainWindow *ui;
-    void checkOrientation();
-    void setPortraitLayout();
-    void setLandscapeLayout();
-    Qt::ScreenOrientation currentOrientation;
-
-
    Worker *m_worker;
    int const m_width;
    QTimer *m_startTimer;
@ -79,6 +73,5 @@ private:
    bool m_progressRunning;
    //int m_progressValue;
    UpdateDcEvent::UpdateStep m_updateStep;
-    QTimer *m_statusTimer;
 };
 #endif // MAINWINDOW_H
--- a/UpdatePTUDevCtrl/mainwindow.ui
+++ b/UpdatePTUDevCtrl/mainwindow.ui
@ -10,12 +10,6 @@
    <height>480</height>
   </rect>
  </property>
-  <property name="minimumSize">
-   <size>
-    <width>480</width>
-    <height>480</height>
-   </size>
-  </property>
  <property name="font">
   <font>
    <family>Source Code Pro</family>
@ -25,47 +19,55 @@
   <string>MainWindow</string>
  </property>
  <widget class="QWidget" name="centralwidget">
-   <layout class="QVBoxLayout" name="verticalLayout">
-    <item>
-     <layout class="QGridLayout" name="gridLayout">
-      <item row="3" column="2">
-       <widget class="QPushButton" name="exit">
-        <property name="text">
-         <string>Exit</string>
-        </property>
-       </widget>
-      </item>
-      <item row="3" column="1">
-       <widget class="QProgressBar" name="updateProgress">
-        <property name="value">
-         <number>1</number>
-        </property>
-       </widget>
-      </item>
-      <item row="0" column="0" rowspan="3" colspan="3">
-       <widget class="QTextEdit" name="updateStatus">
-        <property name="enabled">
-         <bool>true</bool>
-        </property>
-        <property name="font">
-         <font>
-          <family>Misc Fixed</family>
-          <pointsize>11</pointsize>
-          <weight>75</weight>
-          <bold>true</bold>
-         </font>
-        </property>
-        <property name="verticalScrollBarPolicy">
-         <enum>Qt::ScrollBarAsNeeded</enum>
-        </property>
-        <property name="horizontalScrollBarPolicy">
-         <enum>Qt::ScrollBarAsNeeded</enum>
-        </property>
-       </widget>
-      </item>
-     </layout>
-    </item>
-   </layout>
+   <widget class="QWidget" name="layoutWidget">
+    <property name="geometry">
+     <rect>
+      <x>10</x>
+      <y>10</y>
+      <width>781</width>
+      <height>441</height>
+     </rect>
+    </property>
+    <layout class="QGridLayout" name="gridLayout">
+     <item row="3" column="2">
+      <widget class="QPushButton" name="exit">
+       <property name="text">
+        <string>Exit</string>
+       </property>
+      </widget>
+     </item>
+     <item row="3" column="1">
+      <widget class="QProgressBar" name="updateProgress">
+       <property name="value">
+        <number>1</number>
+       </property>
+      </widget>
+     </item>
+     <item row="0" column="0" rowspan="3" colspan="3">
+      <widget class="QTextEdit" name="updateStatus">
+       <property name="enabled">
+        <bool>true</bool>
+       </property>
+       <property name="font">
+        <font>
+         <family>Misc Fixed</family>
+         <pointsize>11</pointsize>
+         <bold>true</bold>
+        </font>
+       </property>
+       <property name="verticalScrollBarPolicy">
+        <enum>Qt::ScrollBarAsNeeded</enum>
+       </property>
+       <property name="horizontalScrollBarPolicy">
+        <enum>Qt::ScrollBarAsNeeded</enum>
+       </property>
+       <property name="sizeAdjustPolicy">
+        <enum>QAbstractScrollArea::AdjustToContents</enum>
+       </property>
+      </widget>
+     </item>
+    </layout>
+   </widget>
  </widget>
 </widget>
 <resources/>
--- a/UpdatePTUDevCtrl/utils.cpp
+++ b/UpdatePTUDevCtrl/utils.cpp
@ -110,19 +110,19 @@ QString Utils::getTariffInfo(QString fileName) {
 }

 QString Utils::zoneName(quint8 i) {
-    //static constexpr char const *zName[] = {
-    //    "",
-    //    "purple",
-    //    "blue",
-    //    "yellow",
-    //    "green",
-    //    "yellow (mars)",
-    //    "green (mars)"
-    //};
-    //if (i < (sizeof(zName)/sizeof(char const *))) {
-    //    return zName[i];
-    //}
-    return "---";
+    static constexpr char const *zName[] = {
+        "",
+        "purple",
+        "blue",
+        "yellow",
+        "green",
+        "yellow (mars)",
+        "green (mars)"
+    };
+    if (i < (sizeof(zName)/sizeof(char const *))) {
+        return zName[i];
+    }
+    return "N/A";
 }

 void Utils::printCriticalErrorMsg(QString const &errorMsg, bool upper, bool lower) {
--- a/UpdatePTUDevCtrl/worker.cpp
+++ b/UpdatePTUDevCtrl/worker.cpp
@ -18,7 +18,6 @@
 #include <Qt>
 #include <QScopedPointer>
 #include <QRegularExpression>
-#include <QJsonArray>

 #include "message_handler.h"
 #include <DeviceController/interfaces.h>
@ -142,7 +141,7 @@ Worker::Worker(int customerNr,
               char const *serialInterface,
               char const *baudrate)
  : m_customerNr(customerNr)
-  , m_customerNrStr(QString("customer_") + QString::number(m_customerNr))
+  , m_customerNrStr(QString("customer_") + QString::number(m_customerNr).rightJustified(3, '0'))
  , m_machineNr(machineNr)
  , m_zoneNr(zoneNr)
  , m_pluginDir(pluginDir)
@ -158,7 +157,7 @@ Worker::Worker(int customerNr,
  , m_parent(parent)
  , m_serialInterface(serialInterface)
  , m_baudrate(baudrate)
-  , m_gc(m_customerRepositoryPath, m_customerNrStr, m_customerRepository, m_workingDirectory, m_branchName, this)
+  , m_gc(m_customerNrStr, m_customerRepository, m_workingDirectory, m_branchName, this)
  , m_versionInfo(QStringList())
  , m_osVersion(getOsVersion())
  , m_atbqtVersion(getATBQTVersion())
@ -457,14 +456,6 @@ void Worker::privateUpdate() {
    //
    ////////////////////////////////////////////////////////////////////////////
    if ((continueUpdate = customerEnvironment()) == false) {
-        // even if something goes wrong creating the environment, try to execute
-        // opkg_commands
-        if (QDir(m_customerRepository).exists()) {
-            // always execute contents of opkg_commands-file
-            m_filesToUpdate.clear();
-            m_filesToUpdate << "etc/psa_update/opkg_commands";
-            execOpkgCommands();
-        }
        return;
    }
    m_versionInfo = m_gc.gitShowReason(m_branchName);
@ -479,14 +470,6 @@ void Worker::privateUpdate() {
    //
    ////////////////////////////////////////////////////////////////////////////
    if ((continueUpdate = filesToUpdate()) == false) {
-        // even if something goes wrong in filesToUpdate, try to execute
-        // opkg_commands
-        if (QDir(m_customerRepository).exists()) {
-            // always execute contents of opkg_commands-file
-            m_filesToUpdate.clear();
-            m_filesToUpdate << "etc/psa_update/opkg_commands";
-            execOpkgCommands();
-        }
        return;
    }
    m_versionInfo = m_gc.gitShowReason(m_branchName);
@ -500,14 +483,6 @@ void Worker::privateUpdate() {
    //
    ////////////////////////////////////////////////////////////////////////////
    if ((continueUpdate = syncCustomerRepositoryAndFS()) == false) {
-        // even if something goes wrong with rsync, try to execute
-        // opkg_commands
-        if (QDir(m_customerRepository).exists()) {
-            // always execute contents of opkg_commands-file
-            m_filesToUpdate.clear();
-            m_filesToUpdate << "etc/psa_update/opkg_commands";
-            execOpkgCommands();
-        }
        return;
    }
    lst = QStringList(QString(smap[UPDATE_STEP::SYNC_CUSTOMER_REPOSITORY_SUCCESS]));
@ -889,24 +864,7 @@ bool Worker::computeFilesToDownload() {
    return (m_filesToDownload.size() > 0);
 }

-
-bool Worker::cleanUpOpkgCache() {
-    bool removedFiles = true;
-    QDir dir("/var/cache/opkg");
-    if (dir.exists()) {
-        dir.setNameFilters(QStringList() << ".gz" << ".ipk");
-        dir.setFilter(QDir::Files);
-        foreach(QString dirFile, dir.entryList()) {
-            removedFiles &= dir.remove(dirFile);
-        }
-    }
-    return removedFiles;
-}
-
 bool Worker::execOpkgCommands() {
-    if (!cleanUpOpkgCache()) {
-        CONSOLE() << "INFO: some cached opkg files not removed";
-    }
    for (int i = 0; i < m_filesToUpdate.size(); ++i) {
        QString const fName = m_filesToUpdate.at(i);
        if (fName.contains("opkg_commands", Qt::CaseInsensitive)) {
@ -922,12 +880,10 @@ bool Worker::execOpkgCommands() {
                        while (!in.atEnd()) {
                            QString line = in.readLine();
                            // TODO: "^\\s*[#]{0,}$" : empty line or comment line starting with #
-                            static const QRegularExpression comment("^\\s*[#].*$");
-                            static const QRegularExpression emptyLine("^\\s*$");
-                            if (line.indexOf(emptyLine, 0) == -1 &&
-                                line.indexOf(comment, 0) == -1) {
+                            static const QRegularExpression comment("^\\s*#.*$");
+                            if (line.indexOf(comment, 0) == -1) {
+                                // found opkg command
                                QString opkgCommand = line.trimmed();
-                                qCritical() << "Found opkg-command" << opkgCommand;
                                if (!executeOpkgCommand(opkgCommand)) {
                                    opkgErrorLst << opkgCommand;
                                } else {
@ -1462,41 +1418,5 @@ PSAInstalled Worker::getPSAInstalled() {
        }
    }

-    psaInstalled.ptuPackageVersion = "{}";
-    if (QFile::exists("/usr/bin/ptuPackageVersions")) {
-        Command c("/usr/bin/ptuPackageVersions -i -o json");
-        if (c.execute(m_workingDirectory)) {
-            QString r = c.getCommandResult();
-            // ptuPackageVersions returns a json-array
-            QJsonArray const &ja = QJsonDocument::fromJson(r.remove(QRegExp("\\n")).toUtf8()).array();
-            if (!ja.empty()) {
-                // transform the array into an object, containing the objects
-                // of the array (christian needs it this way)
-                QJsonObject o;
-                foreach (QJsonValue const &value, ja) {
-                    if (value.isObject()) {
-                        QJsonObject obj = value.toObject();
-                        QStringList keys = obj.keys();
-                        if (!keys.isEmpty()) {
-                            QString const &k = obj.keys().first();
-                            QJsonValue const &v = obj.value(k);
-                            o.insert(k, v);
-                        }
-                    }
-                }
-
-                psaInstalled.ptuPackageVersion =
-                    QJsonDocument(o).toJson(QJsonDocument::Compact);
-
-            } else {
-                qCritical() << __func__ << ":" << __LINE__
-                            << "ERROR array return by ptuPackageVersions empty";
-            }
-        } else {
-            qCritical() << __func__ << ":" << __LINE__
-                        << "ERROR executing ptuPackageVersions";
-        }
-    }
-
    return psaInstalled;
 }
--- a/UpdatePTUDevCtrl/worker.h
+++ b/UpdatePTUDevCtrl/worker.h
@ -193,7 +193,6 @@ class Worker : public QThread{
    QString m_apismVersion;

    bool executeOpkgCommand(QString opkgCommand);
-    bool cleanUpOpkgCache();
    QString getOsVersion() const;
    QString getATBQTVersion() const;
    QString getATBUpdateToolVersion() const;